[{"id":1776516,"web_url":"http://patchwork.ozlabs.org/comment/1776516/","msgid":"<5774e18d-7370-9c00-6f40-2ab558c28679@canonical.com>","list_archive_url":null,"date":"2017-09-27T18:09:19","subject":"NACK: [pull] [SRU][Zesty]PCI: Add pci_mmap_resource_range() and use\n\tit for ARM64","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 20.09.2017 16:20, Manoj Iyer wrote:\n> Please review and consider this pull request for Zesty to address bug\n> https://launchpad.net/bugs/1712580 where without this patch uio device binding\n> inside VM would fail with errors. This patch was requested by Qualcomm for their\n> QDF2400 system. The test kernel is available at \n> https://launchpad.net/~centriq-team/+archive/ubuntu/lp1712580/ and was tested by\n> me on QDF2400 system. The patches touch PCI subsystem on all architecures and\n> PCI drivers, I have regression tested it on AMD64 and PPC64EL systems and posted\n> those results to the bug report. \n> \n> The following changes since commit 6b7134e0ebc3750d3cbae0fec2ad9e032264b836:\n> \n>   UBUNTU: Ubuntu-4.10.0-33.37 (2017-08-11 11:41:50 +0200)\n> \n> are available in the git repository at:!\n> \n>   git+ssh://git.launchpad.net/~centriq-team/+git/linux-sru:lp1712580 \n> \n> for you to fetch changes up to d08ceb5769af1059d87e9df000cecfa743c81a85:\n> \n>   PCI: Add pci_mmap_resource_range() and use it for ARM64 (2017-08-24 11:28:13\n> -0500)\n> \n> ----------------------------------------------------------------\n> David Woodhouse (4):\n>       PCI: Move multiple declarations of pci_mmap_page_range() to \n>       PCI: Use BAR index in sysfs attr->private instead of resource pointer\n>       PCI: Add BAR index argument to pci_mmap_page_range()\n>       PCI: Add pci_mmap_resource_range() and use it for ARM64\n> \n>  Documentation/filesystems/sysfs-pci.txt | 10 ++--\n> &n! bsp;arch/ arm/include/asm/pci.h              |  2 -\n>  arch/arm/kernel/bios32.c                |  3 +-\n>  arch/arm64/include/asm/pci.h            |  2 +\n>  arch/cris/arch-v32/drivers/pci/bios.c   |  3 +-\n>  arch/cris/include/asm/pci.h             |  3 --\n>  arch/ia64/include/asm/pci.h             |  4 +-\n>  arch/ia64/pci/pci.c                     |  3 +-\n>  arch/microblaze/include/asm/pci.h       |  3 --\n>  arch/microblaze/pci/pci-common.c        |  2 +-\n>  arch/mips/include/asm/pci.h             |  3 --\n>  arch/mips/pci/pci.c !   &n bsp;                 |  3 +-\n>  arch/mn10300/include/asm/pci.h          |  3 --\n>  arch/mn10300/unit-asb2305/pci-asb2305.c |  3 +-\n>  arch/parisc/include/asm/pci.h           |  3 --\n>  arch/parisc/kernel/pci.c                |  3 +-\n>  arch/powerpc/include/asm/pci.h          |  3 --\n>  arch/powerpc/kernel/pci-common.c        |  3 +-\n>  arch/sh/drivers/pci/pci.c               |  3 +-\n>  arch/sh/include/asm/pci.h               |  3 +-\n>  arch/sparc/include/asm/pci_64.h         |  4 --\n>  arch/sparc/kernel/pci.c         !   &n bsp;     |  6 +--\n>  arch/unicore32/include/asm/pci.h        |  2 -\n>  arch/unicore32/kernel/pci.c             |  3 +-\n>  arch/x86/include/asm/pci.h              |  5 +-\n>  arch/x86/pci/i386.c                     |  3 +-\n>  arch/xtensa/include/asm/pci.h           |  4 --\n>  arch/xtensa/kernel/pci.c                |  3 +-\n>  drivers/pci/Makefile                    |  2 +-\n>  drivers/pci/mmap.c                      | 95 +++++++++++++++++++++++++++++++++\n>  drivers/pci/pci-sysfs.c          ! ;       | 52 ++++++------------\n>  drivers/pci/pci.h                       |  4 +-\n>  drivers/pci/proc.c                      |  2 +-\n>  include/linux/pci.h                     | 23 ++++++++\n>  34 files changed, 177 insertions(+), 96 deletions(-)\n>  create mode 100644 drivers/pci/mmap.c\n> \n> \n> \nThese changes are spreading across all arches, touching a central subsystem. If\nthis really needs to be fixed in the Zesty kernel, there should be a more\nminimalistic approach. Otherwise I would say this will be fixed once the Artful\nkernel becomes the current HWE kernel.\n\n-Stefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2Qng46lNz9sPt;\n\tThu, 28 Sep 2017 04:09:27 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dxGlv-0007Vp-1a; Wed, 27 Sep 2017 18:09:23 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dxGlt-0007RP-F3\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:09:21 +0000","from rrcs-69-193-151-51.nyc.biz.rr.com ([69.193.151.51]\n\thelo=[10.155.52.21]) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dxGlt-0005s4-5P\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:09:21 +0000"],"Subject":"NACK: [pull] [SRU][Zesty]PCI: Add pci_mmap_resource_range() and use\n\tit for ARM64","To":"kernel-team@lists.ubuntu.com","References":"<1505938815.6965.3@smtp.canonical.com>","From":"Stefan Bader ","Message-ID":"<5774e18d-7370-9c00-6f40-2ab558c28679@canonical.com>","Date":"Wed, 27 Sep 2017 14:09:19 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505938815.6965.3@smtp.canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1914083730938228831==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]