[{"id":1772830,"web_url":"http://patchwork.ozlabs.org/comment/1772830/","msgid":"<20170921151744.000054d0@huawei.com>","list_archive_url":null,"date":"2017-09-21T14:17:44","subject":"Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE","submitter":{"id":71988,"url":"http://patchwork.ozlabs.org/api/people/71988/","name":"Jonathan Cameron","email":"Jonathan.Cameron@huawei.com"},"content":"On Wed, 20 Sep 2017 20:59:56 +0200\nWolfram Sang wrote:\n\n> Signed-off-by: Wolfram Sang \n\nMakes sense as do the other drivers.\n\nFeel free to add\n\nReviewed-by: Jonathan Cameron \n\nto all of them (though they hardly took a lot of reviewing given how simple\nthe patches were :)\n\n> ---\n> drivers/i2c/i2c-dev.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c\n> index 6f638bbc922db4..bbc7aadb4c899d 100644\n> --- a/drivers/i2c/i2c-dev.c\n> +++ b/drivers/i2c/i2c-dev.c\n> @@ -280,6 +280,8 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client,\n> \t\t\tres = PTR_ERR(rdwr_pa[i].buf);\n> \t\t\tbreak;\n> \t\t}\n> +\t\t/* memdup_user allocates with GFP_KERNEL, so DMA is ok */\n> +\t\trdwr_pa[i].flags |= I2C_M_DMA_SAFE;\n> \n> \t\t/*\n> \t\t * If the message length is received from the slave (similar","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xydxs2nS1z9t4B\n\tfor ;\n\tFri, 22 Sep 2017 00:18:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751787AbdIUOSG (ORCPT );\n\tThu, 21 Sep 2017 10:18:06 -0400","from szxga05-in.huawei.com ([45.249.212.191]:6536 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751675AbdIUOSF (ORCPT\n\t); Thu, 21 Sep 2017 10:18:05 -0400","from 172.30.72.58 (EHLO DGGEMS410-HUB.china.huawei.com)\n\t([172.30.72.58])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DHT67341; Thu, 21 Sep 2017 22:17:57 +0800 (CST)","from localhost (10.206.48.115) by DGGEMS410-HUB.china.huawei.com\n\t(10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.301.0;\n\tThu, 21 Sep 2017 22:17:54 +0800"],"Date":"Thu, 21 Sep 2017 15:17:44 +0100","From":"Jonathan Cameron ","To":"Wolfram Sang ","CC":", ,\n\t, ,\n\t, ,\n\t","Subject":"Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE","Message-ID":"<20170921151744.000054d0@huawei.com>","In-Reply-To":"<20170920185956.13874-7-wsa+renesas@sang-engineering.com>","References":"<20170920185956.13874-1-wsa+renesas@sang-engineering.com>\n\t<20170920185956.13874-7-wsa+renesas@sang-engineering.com>","Organization":"Huawei","X-Mailer":"Claws Mail 3.15.0 (GTK+ 2.24.31; x86_64-w64-mingw32)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.206.48.115]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020205.59C3CA17.00C9, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"f5cbe839c172e71a517e9372dd9b2a83","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1772838,"web_url":"http://patchwork.ozlabs.org/comment/1772838/","msgid":"<20170921142313.ghshkvl7o26gkfyp@ninjato>","list_archive_url":null,"date":"2017-09-21T14:23:13","subject":"Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Thu, Sep 21, 2017 at 03:17:44PM +0100, Jonathan Cameron wrote:\n> On Wed, 20 Sep 2017 20:59:56 +0200\n> Wolfram Sang wrote:\n> \n> > Signed-off-by: Wolfram Sang \n> \n> Makes sense as do the other drivers.\n> \n> Feel free to add\n> \n> Reviewed-by: Jonathan Cameron \n> \n> to all of them (though they hardly took a lot of reviewing given how simple\n> the patches were :)\n\nWell, bugs can slip in everywhere, so thanks for the review!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyf3V0d61z9s06\n\tfor ;\n\tFri, 22 Sep 2017 00:23:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751675AbdIUOXQ (ORCPT );\n\tThu, 21 Sep 2017 10:23:16 -0400","from sauhun.de ([88.99.104.3]:41943 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751387AbdIUOXP (ORCPT );\n\tThu, 21 Sep 2017 10:23:15 -0400","from localhost (p54B33566.dip0.t-ipconnect.de [84.179.53.102])\n\tby pokefinder.org (Postfix) with ESMTPSA id 711F12C503E;\n\tThu, 21 Sep 2017 16:23:13 +0200 (CEST)"],"Date":"Thu, 21 Sep 2017 16:23:13 +0200","From":"Wolfram Sang ","To":"Jonathan Cameron ","Cc":"Wolfram Sang ,\n\tlinux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-renesas-soc@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-input@vger.kernel.org, linux-media@vger.kernel.org,\n\tdri-devel@lists.freedesktop.org","Subject":"Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE","Message-ID":"<20170921142313.ghshkvl7o26gkfyp@ninjato>","References":"<20170920185956.13874-1-wsa+renesas@sang-engineering.com>\n\t<20170920185956.13874-7-wsa+renesas@sang-engineering.com>\n\t<20170921151744.000054d0@huawei.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"qdfqet27rre5b7op\"","Content-Disposition":"inline","In-Reply-To":"<20170921151744.000054d0@huawei.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]