[{"id":1772498,"web_url":"http://patchwork.ozlabs.org/comment/1772498/","msgid":"<20170921074023.tafqgvdhu7vm7y7k@flea>","list_archive_url":null,"date":"2017-09-21T07:40:23","subject":"Re: [U-Boot] [PATCH v5 1/4] sunxi: change the DE1 video option to\n\tCONFIG_VIDEO_SUNXI","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi,\n\nOn Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote:\n> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the same\n> name as the \"Enable legacy video support\" option in\n> drivers/video/Kconfig.\n> \n> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by\n> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h\n> when CONFIG_VIDEO is selected before this change. Now CONFIG_VIDEO_SUNXI\n> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig and\n> config headers are all converted to use CONFIG_VIDEO_SUNXI.\n> \n> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n\nThe patch is fine, but you also seem to imply that it's an issue. It's\nnot, you can very well define in Kconfig the same symbol in two\ndifferent places, and Kconfig will merge the two by itself.\n\n> ---\n>  arch/arm/mach-sunxi/Kconfig    | 29 +++++++++++++++--------------\n>  include/configs/sunxi-common.h |  6 ++----\n>  scripts/config_whitelist.txt   |  1 -\n>  3 files changed, 17 insertions(+), 19 deletions(-)\n> \n> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig\n> index 2309f59999..3c29fc61f7 100644\n> --- a/arch/arm/mach-sunxi/Kconfig\n> +++ b/arch/arm/mach-sunxi/Kconfig\n> @@ -606,7 +606,7 @@ config AXP_GPIO\n>  \t---help---\n>  \tSay Y here to enable support for the gpio pins of the axp PMIC ICs.\n>  \n> -config VIDEO\n> +config VIDEO_SUNXI\n>  \tbool \"Enable graphical uboot console on HDMI, LCD or VGA\"\n>  \tdepends on !MACH_SUN8I_A83T\n>  \tdepends on !MACH_SUNXI_H3_H5\n> @@ -614,6 +614,7 @@ config VIDEO\n>  \tdepends on !MACH_SUN8I_V3S\n>  \tdepends on !MACH_SUN9I\n>  \tdepends on !MACH_SUN50I\n> +\tselect VIDEO\n>  \tdefault y\n\nWhich means that this was just adding depends on and default to the\nexisting CONFIG_VIDEO in drivers/video/Kconfig.\n\nMaxime","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyT6y3TYVz9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 17:40:42 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 33431C21F55; Thu, 21 Sep 2017 07:40:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 67637C21EA5;\n\tThu, 21 Sep 2017 07:40:36 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7CA26C21EA5; Thu, 21 Sep 2017 07:40:34 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby lists.denx.de (Postfix) with ESMTP id 2BEE0C21E23\n\tfor <u-boot@lists.denx.de>; Thu, 21 Sep 2017 07:40:34 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 438E720960; Thu, 21 Sep 2017 09:40:33 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 15C7520810;\n\tThu, 21 Sep 2017 09:40:23 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Thu, 21 Sep 2017 09:40:23 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"Icenowy Zheng <icenowy@aosc.io>","Message-ID":"<20170921074023.tafqgvdhu7vm7y7k@flea>","References":"<20170920161822.64503-1-icenowy@aosc.io>\n\t<20170920161822.64503-2-icenowy@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<20170920161822.64503-2-icenowy@aosc.io>","User-Agent":"NeoMutt/20170914 (1.9.0)","Cc":"u-boot@lists.denx.de, Jernej Skrabec <jernej.skrabec@siol.net>,\n\tJagan Teki <jagan@openedev.com>, linux-sunxi@googlegroups.com","Subject":"Re: [U-Boot] [PATCH v5 1/4] sunxi: change the DE1 video option to\n\tCONFIG_VIDEO_SUNXI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============3852853904842984564==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1772504,"web_url":"http://patchwork.ozlabs.org/comment/1772504/","msgid":"<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>","list_archive_url":null,"date":"2017-09-21T07:48:20","subject":"Re: [U-Boot] [PATCH v5 1/4] sunxi: change the DE1 video option to\n\tCONFIG_VIDEO_SUNXI","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:\n>Hi,\n>\n>On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote:\n>> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the\n>same\n>> name as the \"Enable legacy video support\" option in\n>> drivers/video/Kconfig.\n>> \n>> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by\n>> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h\n>> when CONFIG_VIDEO is selected before this change. Now\n>CONFIG_VIDEO_SUNXI\n>> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig\n>and\n>> config headers are all converted to use CONFIG_VIDEO_SUNXI.\n>> \n>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n>\n>The patch is fine, but you also seem to imply that it's an issue. It's\n>not, you can very well define in Kconfig the same symbol in two\n>different places, and Kconfig will merge the two by itself.\n\nSo I can drop this patch and simply add \"imply\nVIDEO_DT_SIMPLEFB\" in the VIDEO option at sunxi\nKconfig?\n\n>\n>> ---\n>>  arch/arm/mach-sunxi/Kconfig    | 29 +++++++++++++++--------------\n>>  include/configs/sunxi-common.h |  6 ++----\n>>  scripts/config_whitelist.txt   |  1 -\n>>  3 files changed, 17 insertions(+), 19 deletions(-)\n>> \n>> diff --git a/arch/arm/mach-sunxi/Kconfig\n>b/arch/arm/mach-sunxi/Kconfig\n>> index 2309f59999..3c29fc61f7 100644\n>> --- a/arch/arm/mach-sunxi/Kconfig\n>> +++ b/arch/arm/mach-sunxi/Kconfig\n>> @@ -606,7 +606,7 @@ config AXP_GPIO\n>>  \t---help---\n>>  \tSay Y here to enable support for the gpio pins of the axp PMIC ICs.\n>>  \n>> -config VIDEO\n>> +config VIDEO_SUNXI\n>>  \tbool \"Enable graphical uboot console on HDMI, LCD or VGA\"\n>>  \tdepends on !MACH_SUN8I_A83T\n>>  \tdepends on !MACH_SUNXI_H3_H5\n>> @@ -614,6 +614,7 @@ config VIDEO\n>>  \tdepends on !MACH_SUN8I_V3S\n>>  \tdepends on !MACH_SUN9I\n>>  \tdepends on !MACH_SUN50I\n>> +\tselect VIDEO\n>>  \tdefault y\n>\n>Which means that this was just adding depends on and default to the\n>existing CONFIG_VIDEO in drivers/video/Kconfig.\n>\n>Maxime","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyTJK58nyz9sNw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 17:48:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 47ED0C21F77; Thu, 21 Sep 2017 07:48:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F1435C21EA5;\n\tThu, 21 Sep 2017 07:48:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A9016C21EA5; Thu, 21 Sep 2017 07:48:42 +0000 (UTC)","from burlywood.ash.relay.mailchannels.net\n\t(burlywood.ash.relay.mailchannels.net [23.83.222.26])\n\tby lists.denx.de (Postfix) with ESMTPS id 2D777C21DC4\n\tfor <u-boot@lists.denx.de>; Thu, 21 Sep 2017 07:48:40 +0000 (UTC)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 8D88D7C974C;\n\tThu, 21 Sep 2017 07:48:36 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.138.121])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id E4AFD7C8988;\n\tThu, 21 Sep 2017 07:48:35 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.62.11])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Thu, 21 Sep 2017 07:48:36 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id E678A47BA4;\n\tThu, 21 Sep 2017 07:48:31 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Stretch-Spill":"2455be6f4515285a_1505980116436_2617865184","X-MC-Loop-Signature":"1505980116436:1240957705","X-MC-Ingress-Time":"1505980116436","Date":"Thu, 21 Sep 2017 15:48:20 +0800","In-Reply-To":"<20170921074023.tafqgvdhu7vm7y7k@flea>","References":"<20170920161822.64503-1-icenowy@aosc.io>\n\t<20170920161822.64503-2-icenowy@aosc.io>\n\t<20170921074023.tafqgvdhu7vm7y7k@flea>","MIME-Version":"1.0","To":"Maxime Ripard <maxime.ripard@free-electrons.com>","From":"Icenowy Zheng <icenowy@aosc.io>","Message-ID":"<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>","Cc":"u-boot@lists.denx.de, Jernej Skrabec <jernej.skrabec@siol.net>,\n\tJagan Teki <jagan@openedev.com>, linux-sunxi@googlegroups.com","Subject":"Re: [U-Boot] [PATCH v5 1/4] sunxi: change the DE1 video option to\n\tCONFIG_VIDEO_SUNXI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1773121,"web_url":"http://patchwork.ozlabs.org/comment/1773121/","msgid":"<20170921191849.jxxn6o2pl2dtpmz3@flea>","list_archive_url":null,"date":"2017-09-21T19:18:49","subject":"Re: [U-Boot] [PATCH v5 1/4] sunxi: change the DE1 video option to\n\tCONFIG_VIDEO_SUNXI","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 21, 2017 at 07:48:20AM +0000, Icenowy Zheng wrote:\n> \n> \n> 于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:\n> >Hi,\n> >\n> >On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote:\n> >> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the\n> >same\n> >> name as the \"Enable legacy video support\" option in\n> >> drivers/video/Kconfig.\n> >> \n> >> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by\n> >> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h\n> >> when CONFIG_VIDEO is selected before this change. Now\n> >CONFIG_VIDEO_SUNXI\n> >> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig\n> >and\n> >> config headers are all converted to use CONFIG_VIDEO_SUNXI.\n> >> \n> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n> >\n> >The patch is fine, but you also seem to imply that it's an issue. It's\n> >not, you can very well define in Kconfig the same symbol in two\n> >different places, and Kconfig will merge the two by itself.\n> \n> So I can drop this patch and simply add \"imply VIDEO_DT_SIMPLEFB\" in\n> the VIDEO option at sunxi Kconfig?\n\nI don't see anything wrong with this patch, there's no need to change it.\n\nMaxime","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyqfk4qpFz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 07:35:58 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BB065C21E3C; Thu, 21 Sep 2017 19:18:53 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D4DA9C21C29;\n\tThu, 21 Sep 2017 19:18:50 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1E59AC21C29; Thu, 21 Sep 2017 19:18:50 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby lists.denx.de (Postfix) with ESMTP id C7D1AC21C26\n\tfor <u-boot@lists.denx.de>; Thu, 21 Sep 2017 19:18:49 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid CAC4F20983; Thu, 21 Sep 2017 21:18:48 +0200 (CEST)","from localhost (LFbn-TOU-1-209-191.w86-201.abo.wanadoo.fr\n\t[86.201.56.191])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id A063020981;\n\tThu, 21 Sep 2017 21:18:48 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Thu, 21 Sep 2017 21:18:49 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"Icenowy Zheng <icenowy@aosc.io>","Message-ID":"<20170921191849.jxxn6o2pl2dtpmz3@flea>","References":"<20170920161822.64503-1-icenowy@aosc.io>\n\t<20170920161822.64503-2-icenowy@aosc.io>\n\t<20170921074023.tafqgvdhu7vm7y7k@flea>\n\t<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>","User-Agent":"NeoMutt/20170914 (1.9.0)","Cc":"u-boot@lists.denx.de, Jernej Skrabec <jernej.skrabec@siol.net>,\n\tJagan Teki <jagan@openedev.com>, linux-sunxi@googlegroups.com","Subject":"Re: [U-Boot] [PATCH v5 1/4] sunxi: change the DE1 video option to\n\tCONFIG_VIDEO_SUNXI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============5254682442881988317==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1773296,"web_url":"http://patchwork.ozlabs.org/comment/1773296/","msgid":"<61398876edfdc696ae88b34faa4cdcd6@aosc.io>","list_archive_url":null,"date":"2017-09-22T06:41:40","subject":"Re: [U-Boot] [linux-sunxi] Re: [PATCH v5 1/4] sunxi: change the DE1\n\tvideo option to CONFIG_VIDEO_SUNXI","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-22 03:18，Maxime Ripard 写道：\n> On Thu, Sep 21, 2017 at 07:48:20AM +0000, Icenowy Zheng wrote:\n>> \n>> \n>> 于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard \n>> <maxime.ripard@free-electrons.com> 写到:\n>> >Hi,\n>> >\n>> >On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote:\n>> >> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the\n>> >same\n>> >> name as the \"Enable legacy video support\" option in\n>> >> drivers/video/Kconfig.\n>> >>\n>> >> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by\n>> >> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h\n>> >> when CONFIG_VIDEO is selected before this change. Now\n>> >CONFIG_VIDEO_SUNXI\n>> >> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig\n>> >and\n>> >> config headers are all converted to use CONFIG_VIDEO_SUNXI.\n>> >>\n>> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n>> >\n>> >The patch is fine, but you also seem to imply that it's an issue. It's\n>> >not, you can very well define in Kconfig the same symbol in two\n>> >different places, and Kconfig will merge the two by itself.\n>> \n>> So I can drop this patch and simply add \"imply VIDEO_DT_SIMPLEFB\" in\n>> the VIDEO option at sunxi Kconfig?\n> \n> I don't see anything wrong with this patch, there's no need to change \n> it.\n\nSo this patchset can be applied if no further rejections?\n\n> \n> Maxime\n> \n> --\n> Maxime Ripard, Free Electrons\n> Embedded Linux and Kernel engineering\n> http://free-electrons.com","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz3ml1Vh3z9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 16:41:59 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C66ACC21E5B; Fri, 22 Sep 2017 06:41:54 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 09B10C21C29;\n\tFri, 22 Sep 2017 06:41:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 727A6C21C29; Fri, 22 Sep 2017 06:41:50 +0000 (UTC)","from nov-007-i543.relay.mailchannels.net\n\t(nov-007-i543.relay.mailchannels.net [46.232.183.97])\n\tby lists.denx.de (Postfix) with ESMTPS id A74D9C21C26\n\tfor <u-boot@lists.denx.de>; Fri, 22 Sep 2017 06:41:47 +0000 (UTC)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 40C3D10806A;\n\tFri, 22 Sep 2017 06:41:44 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.127.236])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 8AB9A108E6C;\n\tFri, 22 Sep 2017 06:41:43 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.62.11])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Fri, 22 Sep 2017 06:41:44 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id A9F5947843;\n\tFri, 22 Sep 2017 06:41:40 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Lonely-Unite":"1e54016a74b6ce34_1506062504082_770480317","X-MC-Loop-Signature":"1506062504082:2754136942","X-MC-Ingress-Time":"1506062504082","MIME-Version":"1.0","Date":"Fri, 22 Sep 2017 14:41:40 +0800","From":"icenowy@aosc.io","To":"maxime.ripard@free-electrons.com","In-Reply-To":"<20170921191849.jxxn6o2pl2dtpmz3@flea>","References":"<20170920161822.64503-1-icenowy@aosc.io>\n\t<20170920161822.64503-2-icenowy@aosc.io>\n\t<20170921074023.tafqgvdhu7vm7y7k@flea>\n\t<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>\n\t<20170921191849.jxxn6o2pl2dtpmz3@flea>","Message-ID":"<61398876edfdc696ae88b34faa4cdcd6@aosc.io>","X-Sender":"icenowy@aosc.io","Cc":"u-boot@lists.denx.de, Jernej Skrabec <jernej.skrabec@siol.net>,\n\tJagan Teki <jagan@openedev.com>, linux-sunxi@googlegroups.com","Subject":"Re: [U-Boot] [linux-sunxi] Re: [PATCH v5 1/4] sunxi: change the DE1\n\tvideo option to CONFIG_VIDEO_SUNXI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1773523,"web_url":"http://patchwork.ozlabs.org/comment/1773523/","msgid":"<20170922115715.xgpk4hngml3sc3s3@flea.lan>","list_archive_url":null,"date":"2017-09-22T11:57:15","subject":"Re: [U-Boot] [linux-sunxi] Re: [PATCH v5 1/4] sunxi: change the DE1\n\tvideo option to CONFIG_VIDEO_SUNXI","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Fri, Sep 22, 2017 at 06:41:40AM +0000, icenowy@aosc.io wrote:\n> 在 2017-09-22 03:18，Maxime Ripard 写道：\n> > On Thu, Sep 21, 2017 at 07:48:20AM +0000, Icenowy Zheng wrote:\n> > > \n> > > \n> > > 于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard\n> > > <maxime.ripard@free-electrons.com> 写到:\n> > > >Hi,\n> > > >\n> > > >On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote:\n> > > >> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the\n> > > >same\n> > > >> name as the \"Enable legacy video support\" option in\n> > > >> drivers/video/Kconfig.\n> > > >>\n> > > >> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by\n> > > >> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h\n> > > >> when CONFIG_VIDEO is selected before this change. Now\n> > > >CONFIG_VIDEO_SUNXI\n> > > >> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig\n> > > >and\n> > > >> config headers are all converted to use CONFIG_VIDEO_SUNXI.\n> > > >>\n> > > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n> > > >\n> > > >The patch is fine, but you also seem to imply that it's an issue. It's\n> > > >not, you can very well define in Kconfig the same symbol in two\n> > > >different places, and Kconfig will merge the two by itself.\n> > > \n> > > So I can drop this patch and simply add \"imply VIDEO_DT_SIMPLEFB\" in\n> > > the VIDEO option at sunxi Kconfig?\n> > \n> > I don't see anything wrong with this patch, there's no need to change\n> > it.\n> \n> So this patchset can be applied if no further rejections?\n\nYes, I'm just waiting for some feedback from the video people.\n\nMaxime","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzBn33kByz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Sep 2017 21:57:43 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3CB57C21F04; Fri, 22 Sep 2017 11:57:33 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 98521C21E0E;\n\tFri, 22 Sep 2017 11:57:30 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E1A7AC21E0E; Fri, 22 Sep 2017 11:57:29 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby lists.denx.de (Postfix) with ESMTP id D7A65C21D56\n\tfor <u-boot@lists.denx.de>; Fri, 22 Sep 2017 11:57:28 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 8109720861; Fri, 22 Sep 2017 13:57:25 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 53BFD20861;\n\tFri, 22 Sep 2017 13:57:15 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Fri, 22 Sep 2017 13:57:15 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"icenowy@aosc.io","Message-ID":"<20170922115715.xgpk4hngml3sc3s3@flea.lan>","References":"<20170920161822.64503-1-icenowy@aosc.io>\n\t<20170920161822.64503-2-icenowy@aosc.io>\n\t<20170921074023.tafqgvdhu7vm7y7k@flea>\n\t<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>\n\t<20170921191849.jxxn6o2pl2dtpmz3@flea>\n\t<61398876edfdc696ae88b34faa4cdcd6@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<61398876edfdc696ae88b34faa4cdcd6@aosc.io>","User-Agent":"NeoMutt/20170914 (1.9.0)","Cc":"u-boot@lists.denx.de, Jernej Skrabec <jernej.skrabec@siol.net>,\n\tJagan Teki <jagan@openedev.com>, linux-sunxi@googlegroups.com","Subject":"Re: [U-Boot] [linux-sunxi] Re: [PATCH v5 1/4] sunxi: change the DE1\n\tvideo option to CONFIG_VIDEO_SUNXI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============8150450621017994528==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1773671,"web_url":"http://patchwork.ozlabs.org/comment/1773671/","msgid":"<d34cecee3c5e083a4f32e6d77ee9fda6@aosc.io>","list_archive_url":null,"date":"2017-09-22T14:25:42","subject":"Re: [U-Boot] [linux-sunxi] Re: [PATCH v5 1/4] sunxi: change the DE1\n\tvideo option to CONFIG_VIDEO_SUNXI","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-22 19:57，Maxime Ripard 写道：\n> On Fri, Sep 22, 2017 at 06:41:40AM +0000, icenowy@aosc.io wrote:\n>> 在 2017-09-22 03:18，Maxime Ripard 写道：\n>> > On Thu, Sep 21, 2017 at 07:48:20AM +0000, Icenowy Zheng wrote:\n>> > >\n>> > >\n>> > > 于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard\n>> > > <maxime.ripard@free-electrons.com> 写到:\n>> > > >Hi,\n>> > > >\n>> > > >On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote:\n>> > > >> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the\n>> > > >same\n>> > > >> name as the \"Enable legacy video support\" option in\n>> > > >> drivers/video/Kconfig.\n>> > > >>\n>> > > >> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by\n>> > > >> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h\n>> > > >> when CONFIG_VIDEO is selected before this change. Now\n>> > > >CONFIG_VIDEO_SUNXI\n>> > > >> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig\n>> > > >and\n>> > > >> config headers are all converted to use CONFIG_VIDEO_SUNXI.\n>> > > >>\n>> > > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n>> > > >\n>> > > >The patch is fine, but you also seem to imply that it's an issue. It's\n>> > > >not, you can very well define in Kconfig the same symbol in two\n>> > > >different places, and Kconfig will merge the two by itself.\n>> > >\n>> > > So I can drop this patch and simply add \"imply VIDEO_DT_SIMPLEFB\" in\n>> > > the VIDEO option at sunxi Kconfig?\n>> >\n>> > I don't see anything wrong with this patch, there's no need to change\n>> > it.\n>> \n>> So this patchset can be applied if no further rejections?\n> \n> Yes, I'm just waiting for some feedback from the video people.\n\nI didn't To: or Cc: them...\n\nBut I think U-Boot has Patchwork, right?\n\n> \n> Maxime\n> \n> --\n> Maxime Ripard, Free Electrons\n> Embedded Linux and Kernel engineering\n> http://free-electrons.com","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzGJr6YPrz9t3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 00:37:00 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 30A0EC220F2; Fri, 22 Sep 2017 14:34:04 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 85DA5C220FC;\n\tFri, 22 Sep 2017 14:33:55 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C04B4C220C5; Fri, 22 Sep 2017 14:25:52 +0000 (UTC)","from nov-007-i623.relay.mailchannels.net\n\t(nov-007-i623.relay.mailchannels.net [46.232.183.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 3A210C220A6\n\tfor <u-boot@lists.denx.de>; Fri, 22 Sep 2017 14:25:49 +0000 (UTC)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id D7CC1129829;\n\tFri, 22 Sep 2017 14:25:46 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.136.222])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 36B0D12969A;\n\tFri, 22 Sep 2017 14:25:46 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.67.103])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Fri, 22 Sep 2017 14:25:46 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 07D2847843;\n\tFri, 22 Sep 2017 14:25:43 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H4,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Suffer-Print":"6c10d1577078a6ad_1506090346709_2762631412","X-MC-Loop-Signature":"1506090346708:4216747450","X-MC-Ingress-Time":"1506090346708","MIME-Version":"1.0","Date":"Fri, 22 Sep 2017 22:25:42 +0800","From":"icenowy@aosc.io","To":"maxime.ripard@free-electrons.com","In-Reply-To":"<20170922115715.xgpk4hngml3sc3s3@flea.lan>","References":"<20170920161822.64503-1-icenowy@aosc.io>\n\t<20170920161822.64503-2-icenowy@aosc.io>\n\t<20170921074023.tafqgvdhu7vm7y7k@flea>\n\t<64A1752C-47AA-4447-B715-77A62478D1A7@aosc.io>\n\t<20170921191849.jxxn6o2pl2dtpmz3@flea>\n\t<61398876edfdc696ae88b34faa4cdcd6@aosc.io>\n\t<20170922115715.xgpk4hngml3sc3s3@flea.lan>","Message-ID":"<d34cecee3c5e083a4f32e6d77ee9fda6@aosc.io>","X-Sender":"icenowy@aosc.io","Cc":"u-boot@lists.denx.de, Jernej Skrabec <jernej.skrabec@siol.net>,\n\tJagan Teki <jagan@openedev.com>, linux-sunxi@googlegroups.com","Subject":"Re: [U-Boot] [linux-sunxi] Re: [PATCH v5 1/4] sunxi: change the DE1\n\tvideo option to CONFIG_VIDEO_SUNXI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]