[{"id":1772256,"web_url":"http://patchwork.ozlabs.org/comment/1772256/","msgid":"<59C2DCAD.3090309@iogearbox.net>","list_archive_url":null,"date":"2017-09-20T21:25:01","subject":"Re: [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when\n\tcross-compiling","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/20/2017 06:11 PM, Joel Fernandes wrote:\n> BPF samples fail to build when cross-compiling for ARM64 because of incorrect\n> pt_regs param selection. This is because clang defines __x86_64__ and\n> bpf_headers thinks we're building for x86. Since clang is building for the BPF\n> target, it shouldn't make assumptions about what target the BPF program is\n> going to run on. To fix this, lets pass ARCH so the header knows which target\n> the BPF program is being compiled for and can use the correct pt_regs code.\n>\n> Acked-by: Alexei Starovoitov \n> Signed-off-by: Joel Fernandes \n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyCVf4SbMz9sBd\n\tfor ;\n\tThu, 21 Sep 2017 07:26:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751903AbdITVZF (ORCPT );\n\tWed, 20 Sep 2017 17:25:05 -0400","from www62.your-server.de ([213.133.104.62]:45439 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751387AbdITVZD (ORCPT\n\t); Wed, 20 Sep 2017 17:25:03 -0400","from [85.7.161.218] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dumUP-0000AM-SB; Wed, 20 Sep 2017 23:25:01 +0200"],"Message-ID":"<59C2DCAD.3090309@iogearbox.net>","Date":"Wed, 20 Sep 2017 23:25:01 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Joel Fernandes , linux-kernel@vger.kernel.org","CC":"netdev@vger.kernel.org, alison@she-devel.com, juri.lelli@arm.com,\n\tfengc@google.com, davem@davemloft.net, ast@kernel.org,\n\tkernel-team@android.com","Subject":"Re: [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when\n\tcross-compiling","References":"<20170920161159.25747-1-joelaf@google.com>\n\t<20170920161159.25747-3-joelaf@google.com>","In-Reply-To":"<20170920161159.25747-3-joelaf@google.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23857/Wed Sep 20 18:44:07 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]