[{"id":1773077,"web_url":"http://patchwork.ozlabs.org/comment/1773077/","msgid":"<20170921192258.4a4fekbtmqwbjdwd@ubuntu-xps13>","list_archive_url":null,"date":"2017-09-21T19:22:58","subject":"ACK / APPLIED[artful]: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix\n\tvlun resize failure in the shrink path","submitter":{"id":6957,"url":"http://patchwork.ozlabs.org/api/people/6957/","name":"Seth Forshee","email":"seth.forshee@canonical.com"},"content":"On Wed, Sep 20, 2017 at 11:47:50AM -0400, Joseph Salisbury wrote:\n> From: Uma Krishnan \n> \n> BugLink: http://bugs.launchpad.net/bugs/1713575\n> \n> The ioctl DK_CAPI_VLUN_RESIZE can fail if the allocated vlun size is\n> reduced from almost maximum capacity and then increased again.\n> \n> The shrink_lxt() routine is currently using the SISL_ASTATUS_MASK to\n> mask the higher 48 bits of the lxt entry. This is unnecessary and\n> incorrect as it uses a mask designed for the asynchronous interrupt\n> status register. When the 4 port support was added to cxlflash, the\n> SISL_ASTATUS_MASK was updated to reflect the status bits for all 4\n> ports. This change indirectly affected the shrink_lxt() code path.\n> \n> To extract the base, simply shift the bits without masking.\n> \n> Fixes: 565180723294 (\"scsi: cxlflash: SISlite updates to support 4 ports\")\n> Signed-off-by: Uma Krishnan \n> Signed-off-by: Martin K. Petersen \n> (cherry picked from commit 07a191f762a7b8d0db13c38036380927116e29bb)\n> Signed-off-by: Joseph Salisbury \n\nClean cherry pick, positive testing.\n\nAcked-by: Seth Forshee \n\nApplied to artful/master-next, thanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xymlX6PS7z9t4B;\n\tFri, 22 Sep 2017 05:24:56 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dv73w-0007Js-LR; Thu, 21 Sep 2017 19:23:04 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dv73t-0007IE-R7\n\tfor kernel-team@lists.ubuntu.com; Thu, 21 Sep 2017 19:23:01 +0000","from mail-it0-f71.google.com ([209.85.214.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dv73t-0000us-Gt\n\tfor kernel-team@lists.ubuntu.com; Thu, 21 Sep 2017 19:23:01 +0000","by mail-it0-f71.google.com with SMTP id c195so11619694itb.5\n\tfor ;\n\tThu, 21 Sep 2017 12:23:01 -0700 (PDT)","from localhost ([2605:a601:aae:1b20:30dd:a670:de40:d9eb])\n\tby smtp.gmail.com with ESMTPSA id\n\tg12sm1346776itg.6.2017.09.21.12.22.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Sep 2017 12:22:59 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=HiBwLPvczHqZVV6w6UPhJBqyq/TbW6ckpyz957t2Hac=;\n\tb=qJkpLsvC82yvMF1GaG1OXiVa7woINyHVFMxO0a4dvPX+O9YZpPlcNq95za+7MWNGZK\n\t1SqwV7h2Sp/0kmu1KRWlo6LVc99tyc96apEf9CozQnF/jS18yVaFEKnkVbs1rdY8cAWr\n\t+4Gw3GVD+6ARjio6cIMCti0fKHSptdRvj7mMAivkJVjhuzslOlz1HxXvXz1LBE/7cWdW\n\tvaV8WbqstqHpLuz78j1Q+Fz48Z0k6Rpt9RvUIp/uFqo2uG44pi0UjAN9KKepM06avgz6\n\tpz/4Iiwg7C0fFTaknrs8Ys5bJj64QHlqj9pmDwDzonOEPDuzm+av2G1/HXm9akxz63Vk\n\tftmw==","X-Gm-Message-State":"AHPjjUgCgHOn0yk2iA+dTB/tVDZXjQvOdX2DMgAbYNddO+227Zm9wVuE\n\tFbBLW70Ku22GA/RIzuVgJNsekFGViLpOFxJhQVGr0gDib0Jm2DYFb16IDTCZkZYmBWnpjInu/nT\n\tADEgjvGr2chxt5FdLPb4ttT0AgkS8KiwYtuZjssWNwg==","X-Received":["by 10.107.18.100 with SMTP id a97mr4217513ioj.41.1506021780523; \n\tThu, 21 Sep 2017 12:23:00 -0700 (PDT)","by 10.107.18.100 with SMTP id a97mr4217497ioj.41.1506021780289; \n\tThu, 21 Sep 2017 12:23:00 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QC0MGeCowu6e+Om15EucS5XpGsAzmY5Yd2+BBoVWPrRTyKOmFR4Hobn5syj/Pph0j9AugepFw==","Date":"Thu, 21 Sep 2017 14:22:58 -0500","From":"Seth Forshee ","To":"Joseph Salisbury ","Subject":"ACK / APPLIED[artful]: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix\n\tvlun resize failure in the shrink path","Message-ID":"<20170921192258.4a4fekbtmqwbjdwd@ubuntu-xps13>","References":"\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1776533,"web_url":"http://patchwork.ozlabs.org/comment/1776533/","msgid":"<3c566852-ab59-1fe3-9712-a6d3a4c07081@canonical.com>","list_archive_url":null,"date":"2017-09-27T18:42:32","subject":"ACK: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix vlun resize failure\n\tin the shrink path","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 20.09.2017 11:47, Joseph Salisbury wrote:\n> From: Uma Krishnan \n> \n> BugLink: http://bugs.launchpad.net/bugs/1713575\n> \n> The ioctl DK_CAPI_VLUN_RESIZE can fail if the allocated vlun size is\n> reduced from almost maximum capacity and then increased again.\n> \n> The shrink_lxt() routine is currently using the SISL_ASTATUS_MASK to\n> mask the higher 48 bits of the lxt entry. This is unnecessary and\n> incorrect as it uses a mask designed for the asynchronous interrupt\n> status register. When the 4 port support was added to cxlflash, the\n> SISL_ASTATUS_MASK was updated to reflect the status bits for all 4\n> ports. This change indirectly affected the shrink_lxt() code path.\n> \n> To extract the base, simply shift the bits without masking.\n> \n> Fixes: 565180723294 (\"scsi: cxlflash: SISlite updates to support 4 ports\")\n> Signed-off-by: Uma Krishnan \n> Signed-off-by: Martin K. Petersen \n> (cherry picked from commit 07a191f762a7b8d0db13c38036380927116e29bb)\n> Signed-off-by: Joseph Salisbury \nAcked-by: Stefan Bader \n\n> ---\n> drivers/scsi/cxlflash/vlun.c | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/drivers/scsi/cxlflash/vlun.c b/drivers/scsi/cxlflash/vlun.c\n> index 6c4cd3f..8de6a80 100644\n> --- a/drivers/scsi/cxlflash/vlun.c\n> +++ b/drivers/scsi/cxlflash/vlun.c\n> @@ -694,11 +694,7 @@ static int shrink_lxt(struct afu *afu,\n> \t/* Free LBAs allocated to freed chunks */\n> \tmutex_lock(&blka->mutex);\n> \tfor (i = delta - 1; i >= 0; i--) {\n> -\t\t/* Mask the higher 48 bits before shifting, even though\n> -\t\t * it is a noop\n> -\t\t */\n> -\t\taun = (lxt_old[my_new_size + i].rlba_base & SISL_ASTATUS_MASK);\n> -\t\taun = (aun >> MC_CHUNK_SHIFT);\n> +\t\taun = lxt_old[my_new_size + i].rlba_base >> MC_CHUNK_SHIFT;\n> \t\tif (needs_ws)\n> \t\t\twrite_same16(sdev, aun, MC_CHUNK_SIZE);\n> \t\tba_free(&blka->ba_lun, aun);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2RWz37Q7z9tXQ;\n\tThu, 28 Sep 2017 04:42:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dxHI3-0000lc-E8; Wed, 27 Sep 2017 18:42:35 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dxHI2-0000ku-3o\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:42:34 +0000","from rrcs-69-193-151-51.nyc.biz.rr.com ([69.193.151.51]\n\thelo=[10.155.52.21]) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dxHI1-0008Mh-QT\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:42:33 +0000"],"Subject":"ACK: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix vlun resize failure\n\tin the shrink path","To":"kernel-team@lists.ubuntu.com","References":"\n\t","From":"Stefan Bader ","Message-ID":"<3c566852-ab59-1fe3-9712-a6d3a4c07081@canonical.com>","Date":"Wed, 27 Sep 2017 14:42:32 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============0466485831007003277==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1782881,"web_url":"http://patchwork.ozlabs.org/comment/1782881/","msgid":"<20171009141618.uqhb4ap7a2l6s73w@calabresa>","list_archive_url":null,"date":"2017-10-09T14:16:19","subject":"APPLIED: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix vlun resize\n\tfailure in the shrink path","submitter":{"id":70574,"url":"http://patchwork.ozlabs.org/api/people/70574/","name":"Thadeu Lima de Souza Cascardo","email":"cascardo@canonical.com"},"content":"Applied to zesty master-next branch.\n\nThanks.\nCascardo.\n\nApplied-to: zesty/master-next","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9j3K2mFzz9tXQ;\n\tTue, 10 Oct 2017 01:16:29 +1100 (AEDT)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1e1Yr3-0003oa-Qt; Mon, 09 Oct 2017 14:16:25 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1e1Yr1-0003o5-Lk\n\tfor kernel-team@lists.ubuntu.com; Mon, 09 Oct 2017 14:16:23 +0000","from [177.94.55.56] (helo=calabresa)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1e1Yr1-00008s-0X; Mon, 09 Oct 2017 14:16:23 +0000"],"Date":"Mon, 9 Oct 2017 11:16:19 -0300","From":"Thadeu Lima de Souza Cascardo ","To":"Joseph Salisbury ","Subject":"APPLIED: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix vlun resize\n\tfailure in the shrink path","Message-ID":"<20171009141618.uqhb4ap7a2l6s73w@calabresa>","References":"\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]