[{"id":1772047,"web_url":"http://patchwork.ozlabs.org/comment/1772047/","msgid":"<626da179-e410-e793-8c25-661c940d37d5@linaro.org>","list_archive_url":null,"date":"2017-09-20T16:31:54","subject":"Re: [Qemu-devel] [PATCH v3 3/3] s390x/tcg: add basic MSA features","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/20/2017 10:30 AM, David Hildenbrand wrote:\n> The STFLE bits for the MSA (extension) facilities simply indicate that\n> the respective instructions can be executed. The QUERY subfunction can then\n> be used to identify which features exactly are available.\n> \n> Availability of subfunctions can also vary on real hardware. For now, we\n> simply implement a CPU model without any available subfunctions except\n> QUERY (which is always around).\n> \n> As all MSA functions behave quite similarly, we can use one translation\n> handler for now. Prepare the code for implementation of actual subfunctions.\n> \n> At least MSA is helpful for now, as older Linux kernels require this\n> facility when compiled for a z9 model. Allow to enable the facilities\n> for the qemu cpu model.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/Makefile.objs | 2 +-\n> target/s390x/cpu_models.c | 4 +++\n> target/s390x/crypto_helper.c | 65 ++++++++++++++++++++++++++++++++++++++++++++\n> target/s390x/helper.h | 1 +\n> target/s390x/insn-data.def | 13 +++++++++\n> target/s390x/translate.c | 56 ++++++++++++++++++++++++++++++++++++++\n> 6 files changed, 140 insertions(+), 1 deletion(-)\n> create mode 100644 target/s390x/crypto_helper.c\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"fiDDpmWu\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy52V39jTz9t2Q\n\tfor ;\n\tThu, 21 Sep 2017 02:35:29 +1000 (AEST)","from localhost ([::1]:49654 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duhyB-0001ur-3z\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 12:35:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51437)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duhut-0008Os-UB\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 12:32:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duhur-00025E-Bc\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 12:32:03 -0400","from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]:54260)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duhur-00023z-6i\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 12:32:01 -0400","by mail-io0-x22c.google.com with SMTP id q11so4761962ioe.10\n\tfor ; Wed, 20 Sep 2017 09:31:59 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\tp205sm1414208oia.14.2017.09.20.09.31.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 09:31:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=aJNIMpsk58rXIHHf1MYv22kyAROk7cJbAQ+HsS/M5YY=;\n\tb=fiDDpmWufCcpRmkt0ORh8uroPL7HZhgsvHRHLj/whoKACeGuIt0MdQnysYTOl2wjjL\n\tCMd5ldspHkNxLozznuEbpAq/BZi8dAzp5H9j/Vn+TCP6ajr/D0F3d4Y6wJwxn7j3xg5Y\n\tDMLCX//qLnWzTJn6lrgd9RNTLZ8XiwWdUICu8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=aJNIMpsk58rXIHHf1MYv22kyAROk7cJbAQ+HsS/M5YY=;\n\tb=m/mTajUTqlI11G09Jrfa/2Dc2Y4Pvp5cqg/pZ5vYSJsenhqDcK6H19VLTluN8hU/1X\n\t3EVGh7xPOHu6ksAIzChYGAZ9FeFF0f1d5bS6cNgYVqSUHpR5z5sApLBK4O9vgsi+HGvG\n\tuIrEBGi0Ms3Bb/dVznMkzPjOzhObHvm3JePrW4HTENET5LLJzXSjtM5tYO8Le5GE72qB\n\t/DatqA7q/aMHUzmNnUuRoaz5RW+umHg1z5IrGeiMB0DpW+l7XQgYVAj6o9qHu6oTZlNq\n\tsE0tCcjnBdAIvz80JMwW1A6wBd3kItI6tJnFn9uzL1JQumrnXBCViPAmLbRxTEMayQTV\n\t8cig==","X-Gm-Message-State":"AHPjjUiIGXLBMHtcNBdiTY/q3c600rkfFOcQbH8Bqnk2BxgxwMc4nGes\n\t57E1iNBfwOLH87fXSoWgR9akcw==","X-Google-Smtp-Source":"AOwi7QAgZE2arZjY7ph8xB2vk9YHYAHeZb2jSZhEGf0Vw/WpC94BsXngvfboLdM4xNGnrb7lr9vPJA==","X-Received":"by 10.202.96.86 with SMTP id u83mr6651647oib.264.1505925119048; \n\tWed, 20 Sep 2017 09:31:59 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170920153016.3858-1-david@redhat.com>\n\t<20170920153016.3858-4-david@redhat.com>","From":"Richard Henderson ","Message-ID":"<626da179-e410-e793-8c25-661c940d37d5@linaro.org>","Date":"Wed, 20 Sep 2017 11:31:54 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920153016.3858-4-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::22c","Subject":"Re: [Qemu-devel] [PATCH v3 3/3] s390x/tcg: add basic MSA features","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com, Alexander Graf ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]