[{"id":1773392,"web_url":"http://patchwork.ozlabs.org/comment/1773392/","msgid":"<0c8965a8-2241-0f3b-ebee-4454b8307261@denx.de>","list_archive_url":null,"date":"2017-09-22T09:37:24","subject":"Re: [swupdate] [PATCH] core: don't unlink if final equals temp\n\tlocation","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 20/09/2017 17:34, Christian Storm wrote:\n> If the temporary location of an artifact happens to\n> be identical to the final location of the artifact,\n> SWUpdate deletes the artifact after installation\n> (if CONFIG_NOCLEANUP isn't set, that is).\n> \n> Consider the following sw-description with default\n> TMPDIR=/tmp set:\n> \n> software =\n> {\n> version = \"0.0.1\";\n> files: (\n> {\n> filename = \"dummy.file\";\n> path = \"/tmp/dummy.file\";\n> }\n> );\n> }\n> \n> After installation, /tmp/dummy.file will be removed.\n> Prevent its removal and issue a warning. Additionally,\n> if dummy.file is referenced more than once, issue a\n> warning stating its removal reason.\n> \n> Signed-off-by: Christian Storm \n> ---\n> corelib/installer.c | 18 +++++++++++++++++-\n> 1 file changed, 17 insertions(+), 1 deletion(-)\n> \n> diff --git a/corelib/installer.c b/corelib/installer.c\n> index 8a188a1..6c6271c 100644\n> --- a/corelib/installer.c\n> +++ b/corelib/installer.c\n> @@ -326,7 +326,23 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile)\n> \t\t\t\tcontinue;\n> \t\t}\n> \n> -\t\tret = install_single_image(img);\n> +\t\tif (strncmp(img->path, img->extract_file, sizeof(img->path)) == 0) {\n> +\t\t\tstruct img_type *tmpimg;\n> +\t\t\tWARN(\"Temporary and final location for %s is identical, skip \"\n> +\t\t\t \"processing.\", img->path);\n> +\t\t\tLIST_REMOVE(img, next);\n> +\t\t\tLIST_FOREACH(tmpimg, &sw->images, next) {\n> +\t\t\t\tif (strncmp(tmpimg->fname, img->fname, sizeof(img->fname)) == 0) {\n> +\t\t\t\t\tWARN(\"%s will be removed, it's referenced more \"\n> +\t\t\t\t\t \"than once.\", img->path);\n> +\t\t\t\t\tbreak;\n> +\t\t\t\t}\n> +\t\t\t}\n> +\t\t\tfree(img);\n> +\t\t\tret = 0;\n> +\t\t} else {\n> +\t\t\tret = install_single_image(img);\n> +\t\t}\n> \n> \t\tif (!fromfile)\n> \t\t\tclose(img->fdin);\n> \n\nApplied to -master, thanks!\n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c09::240;\n\thelo=mail-wm0-x240.google.com;\n\tenvelope-from=swupdate+bncbaabbwftsphakgqenjyv5ma@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"K/4k/QM/\"; dkim-atps=neutral"],"Received":["from mail-wm0-x240.google.com (mail-wm0-x240.google.com\n\t[IPv6:2a00:1450:400c:c09::240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz7gH0MTsz9s5L\n\tfor ;\n\tFri, 22 Sep 2017 19:37:30 +1000 (AEST)","by mail-wm0-x240.google.com with SMTP id b82sf39298wmh.8\n\tfor ;\n\tFri, 22 Sep 2017 02:37:30 -0700 (PDT)","by 10.28.216.71 with SMTP id p68ls46504wmg.2.gmail;\n\tFri, 22 Sep 2017 02:37:28 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10])\n\tby gmr-mx.google.com with ESMTPS id\n\tj4si327711wmi.2.2017.09.22.02.37.27 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 02:37:28 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xz7gC5ySdz1qw85;\n\tFri, 22 Sep 2017 11:37:27 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xz7gC5jGzz1qrmG;\n\tFri, 22 Sep 2017 11:37:27 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id CzPzzXU7QdI0; Fri, 22 Sep 2017 11:37:27 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tFri, 22 Sep 2017 11:37:27 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 9B159454052E;\n\tFri, 22 Sep 2017 11:37:26 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id u-LfXr1xoOSs; Fri, 22 Sep 2017 11:37:24 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 47EB64540472;\n\tFri, 22 Sep 2017 11:37:24 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1506073048; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=XLf9rz6On0NFofSUxQk4RLLH6o7B6el1yKC6ysJAm0jWrY3HiyFVnh9OTYTeX8MRHp\n\ttHWNMa/UAqAV9jub+em3iDkqBDzdjc1YqFuxWpa16pqYGR8bBedjpJFiiYHI9wA4/DkK\n\twKJozErso70J1QSoNmFi1Z8TD/NacnvB174DsIEKNca6Tu70IZT9+EGb5Aw8GltVzf7j\n\tLVDYp+kORboiQJ0T7bVrtaTlQlDshJw43e+M/royr0EfY4gNxVc9fPRBl01LavXiICfm\n\ta9yXhcvYz9ugXdoxaHYhgzlgauTFb9qOa4MFqQEz6I6Aidpqhlxp69eFD1pcFgVIC1iV\n\tHl7A==","i=1; a=rsa-sha256; t=1506073048; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=yzOJ7UkMkLByptxdtLuGYJHw5ILa77yK4soh3lEQV+8ELQLuRl437BoSTe+O6UVY6J\n\t2TvlJB4kOXNFn+5Oxb2lE2LXZzkeN8JiexEpp3kOWNbJLYn0ARKxzdQhk7FOeX0ffRFt\n\tBGkxcU2CqfMPHulDdpzumMqiBoz1SmL7Zu0BkGvleymrPzzw6KK+Spo8e4W4AvkmIQjM\n\tPqRIbM4qAaTtVgbnDZQYwQvmV1UtKKviaLUxKrPRUW6v1WxhUDEbPk3acLGFBJL2QdLO\n\tQuJtOEPTzDvqJI/41vMK3/8RN4SsfmIncjZubG8mKQ7VwsOkWE5kkwmrMcL+ljqHrSN0\n\tJoSQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=8MzfvMa9G461aZ/KixlxVedjEB/QbHB+fS3GM7s3om4=;\n\tb=Y5ZeIr2AKJcDMR/8Esr/zrCN5jGQMO3shLxBxytK99bQS72HK4HJMWx2mf8pn+/wYy\n\td/UcvoEKD1LaAY8RVegSHbhSePD/QAktL5dy/8UbCh2qFc0xJdoKXGn2GBo/SHIL37Y/\n\taJ1obhauPqIwRBIlKU+rKNWbF1eOyk+PLNSjdvYMHvj7vWMkLKX6K5S8+p7CteuJCqTS\n\tCz++FNDbmkI+Cm4eIg2Yvb4/wLDIRufzE/dBZter9g5LGBBQbKwXK3qBvVTXp/ol3u6T\n\tFxnI5rqRJOliKKCmAhl9DxLC2VmN2yp8xZPOljPvTA34/axc08ReAyM9FBQsPV0WFNS2\n\tC9DQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=dEa1GdynoiJzsOmm12HqwIvUfAtn4rXucolOj5/TuCA=;\n\tb=y5oVzbAmDWSjICB6Mb5qRimohnjR4o6RV1O7U48Q5Tu29wLUAr/8YrMbyzJaXr+VgE\n\to37yFxzKMV5SaLkacZcsInPt6RKfeX00WN7Zl7B+lLvp6Q0q3c4kgn1YUEY6kCWRR5XL\n\tNt9mB72/+3F+c3eNsuEFcLcyCjO65aNgSxQ0LBRtpzNw2cHZjFMCJZ5C/F+afZLK5Jg3\n\tNPvvXW7HnbUEtQMYUEV84G6Z6K4WHAjfA4vspkgAJAZPstaNDYH0BGsZl+ysZdLrDqto\n\t3APgNnF5MkvdgSoMXNkqsQji++2/KJ8JjUAb+3Xw503uN6hyTR3oVBy/weWRIdzTPEkz\n\tNY5w=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=8MzfvMa9G461aZ/KixlxVedjEB/QbHB+fS3GM7s3om4=;\n\tb=K/4k/QM/DZ6A3DSNFJmuy6nf79TUd97WJVgqjDK8YWm0N5I1P4Q8AX5W0krNVuL1Vi\n\tqZykvQAVBrezkQswfQhbQpmD01h8/Bgpp6896cBG2Lto1ej/+84mtUuMkI4no7MeTDB1\n\tkyomqQte863GrQFpnU/xdVhivWrSo34ADV7Mp9eF+kskbWxc5MDlh1EqJ0w3T6v1jo+f\n\tMKQxJvKtsXBeO3U8nHihr+cZwFC0CGKpscCUom92fGMA6YcJgvYx3/COVWxCMllq0HYE\n\tfzVO3ZO2AcimmwDlPgtQagwkn+prEJLe6OF6pmY+Qp3RGyreg/Ho/WUyffLIYYzMu6i7\n\tkqkg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=8MzfvMa9G461aZ/KixlxVedjEB/QbHB+fS3GM7s3om4=;\n\tb=qnr+SGZLjcfIEBbCgRfCKc+56xeiS1L0ZHnHUI+HyzMIG5USFWuIyI2aGiQTJAoiwS\n\t572T67nY6sv7/ai8ExcAchxLql0k6Eo+iW53UW7vnrYtSKHuDvQkQ9KiuZRYHhNg1WiJ\n\tui8z8rVlPhL4ZMsn27CsKbEZNvRsFQGFkomUdURxBlUEKK1lU2nWNtow0uGUTIDGE9ac\n\tln3dnensu5rYMkJuvP1NfqtPYRjSNRwuVmE6zZpPAQT9pu8sDTjkFIVuYS2YFx3880Fb\n\tgjV5xM+GPRLrUUZaW/1maMmvomQhUougm+8A9sfotOo0eLHo3MFwvrZr+SZEe1awYN9c\n\tjeCQ==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUgDOPiAs1Ah1cIShLMf2PVS9UsZ/z+LF/jIz5S7hy3u8kQVYQFn\n\tBx4TS7Xykns0rWFrU1Oi+P4=","X-Google-Smtp-Source":"AOwi7QAp2a2RVAW8B2d4essU0ArvVR4dzgqrknmhQX5VEIEdBIg+zAC55zgNNKCF6YKgaABXnpGjXw==","X-Received":["by 10.28.63.19 with SMTP id m19mr7743wma.28.1506073048396;\n\tFri, 22 Sep 2017 02:37:28 -0700 (PDT)","by 10.28.63.130 with SMTP id m124mr119023wma.20.1506073048076;\n\tFri, 22 Sep 2017 02:37:28 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 212.18.0.10 is neither permitted nor\n\tdenied by best guess record for domain of sbabic@denx.de)\n\tclient-ip=212.18.0.10; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH] core: don't unlink if final equals temp\n\tlocation","To":"Christian Storm , swupdate@googlegroups.com","References":"<20170920153433.15343-1-christian.storm@siemens.com>","From":"Stefano Babic ","Message-ID":"<0c8965a8-2241-0f3b-ebee-4454b8307261@denx.de>","Date":"Fri, 22 Sep 2017 11:37:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920153433.15343-1-christian.storm@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"de-DE","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 212.18.0.10 is neither permitted nor denied by best\n\tguess record\n\tfor domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1776310,"web_url":"http://patchwork.ozlabs.org/comment/1776310/","msgid":"<20170927123705.fgvysegnwbmq7izb@MD1KR9XC.ww002.siemens.net>","list_archive_url":null,"date":"2017-09-27T12:37:05","subject":"Re: [swupdate] [PATCH] core: don't unlink if final equals temp\n\tlocation","submitter":{"id":72180,"url":"http://patchwork.ozlabs.org/api/people/72180/","name":"Storm, Christian","email":"christian.storm@siemens.com"},"content":"Hi Stefano,\n\n> On 20/09/2017 17:34, Christian Storm wrote:\n> > If the temporary location of an artifact happens to\n> > be identical to the final location of the artifact,\n> > SWUpdate deletes the artifact after installation\n> > (if CONFIG_NOCLEANUP isn't set, that is).\n> > \n> > Consider the following sw-description with default\n> > TMPDIR=/tmp set:\n> > \n> > software =\n> > {\n> > version = \"0.0.1\";\n> > files: (\n> > {\n> > filename = \"dummy.file\";\n> > path = \"/tmp/dummy.file\";\n> > }\n> > );\n> > }\n> > \n> > After installation, /tmp/dummy.file will be removed.\n> > Prevent its removal and issue a warning. Additionally,\n> > if dummy.file is referenced more than once, issue a\n> > warning stating its removal reason.\n> > \n> > Signed-off-by: Christian Storm \n> > ---\n> > corelib/installer.c | 18 +++++++++++++++++-\n> > 1 file changed, 17 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/corelib/installer.c b/corelib/installer.c\n> > index 8a188a1..6c6271c 100644\n> > --- a/corelib/installer.c\n> > +++ b/corelib/installer.c\n> > @@ -326,7 +326,23 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile)\n> > \t\t\t\tcontinue;\n> > \t\t}\n> > \n> > -\t\tret = install_single_image(img);\n> > +\t\tif (strncmp(img->path, img->extract_file, sizeof(img->path)) == 0) {\n> > +\t\t\tstruct img_type *tmpimg;\n> > +\t\t\tWARN(\"Temporary and final location for %s is identical, skip \"\n> > +\t\t\t \"processing.\", img->path);\n> > +\t\t\tLIST_REMOVE(img, next);\n> > +\t\t\tLIST_FOREACH(tmpimg, &sw->images, next) {\n> > +\t\t\t\tif (strncmp(tmpimg->fname, img->fname, sizeof(img->fname)) == 0) {\n> > +\t\t\t\t\tWARN(\"%s will be removed, it's referenced more \"\n> > +\t\t\t\t\t \"than once.\", img->path);\n> > +\t\t\t\t\tbreak;\n> > +\t\t\t\t}\n> > +\t\t\t}\n> > +\t\t\tfree(img);\n> > +\t\t\tret = 0;\n> > +\t\t} else {\n> > +\t\t\tret = install_single_image(img);\n> > +\t\t}\n> > \n> > \t\tif (!fromfile)\n> > \t\t\tclose(img->fdin);\n> > \n> \n> Applied to -master, thanks!\n\nHm, I cannot find it upstream on -master and it's gone in patchwork\nas well. Am I bind or has it slipped through?\n\n\nKind regards,\n Christian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c0c::238;\n\thelo=mail-wr0-x238.google.com;\n\tenvelope-from=swupdate+bncbdd6bwv65qpbbjfyv3hakgqedvbrw7a@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"mExTVCZ+\"; dkim-atps=neutral"],"Received":["from mail-wr0-x238.google.com (mail-wr0-x238.google.com\n\t[IPv6:2a00:1450:400c:c0c::238])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2HTh473Lz9t33\n\tfor ;\n\tWed, 27 Sep 2017 22:40:07 +1000 (AEST)","by mail-wr0-x238.google.com with SMTP id l39sf2585982wrl.20\n\tfor ;\n\tWed, 27 Sep 2017 05:40:07 -0700 (PDT)","by 10.28.142.199 with SMTP id q190ls389275wmd.4.canary-gmail; Wed,\n\t27 Sep 2017 05:40:04 -0700 (PDT)","from goliath.siemens.de (goliath.siemens.de. [192.35.17.28])\n\tby gmr-mx.google.com with ESMTPS id\n\tb203si253621wmh.4.2017.09.27.05.40.04\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 05:40:04 -0700 (PDT)","from mail2.siemens.de (mail2.siemens.de [139.25.208.11])\n\tby goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v8RCe4Pe020892\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)\n\tfor ; Wed, 27 Sep 2017 14:40:04 +0200","from localhost ([139.25.69.251])\n\tby mail2.siemens.de (8.15.2/8.15.2) with ESMTPS id v8RCe4m6008603\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)\n\tfor ; Wed, 27 Sep 2017 14:40:04 +0200"],"ARC-Seal":["i=2; a=rsa-sha256; t=1506516005; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=ZEmdiH/c1fFtBn/wut61giO3UFI/8En3Kyk+DTdIS+tI0pnBQwbwykiQJJ1T8OIY4z\n\tgSVb+MMwZ/fIDkUsu28oy+7guS0yhZs9R/ZXliJpS3JKwbw98jgKptcihRbXC2SYiITN\n\tH7Le84qRxO0l9ifz/Fc4xxV8J5akNcYAR/EKFCed5vdf5Q3NuglxthiGLSlDIl8Ihm+X\n\tRj7QputYCb2D3s0S/MSi0NQwKNkONkZ/xabu2a4ZkNLqxaUErW2wV/ez+FzCkSRUbO6g\n\tTCb+Bxu5SbdxXQHBoi8cCxETc0i1BZga3PBRNyaBTgWIrqWMuKNG3vTK55qtLNhLXYyR\n\tFP1A==","i=1; a=rsa-sha256; t=1506516004; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=Ye0e1KKpxTFKFvrDiAGQE4JoesHU1q9qTwzp8P+TSddXoThU9zAegYvqYw7rpyDfTQ\n\tTK0VedrzwIUFBrR6LkhGpFm4Sx0G2+46NQsqfYwyqZPQqorDgZjjsAFc9Quveb8yEDlx\n\t1m0+AD6COYMCqBnwr6dX+/cYRY9gy9V4kbEZePcC6Q6lYYKroy68NGWBT8HoJ3P+KurR\n\tUW7G3lWRVq9VhOLtW4Vijk8vkK9qyskJj7FVgPXF1ghhB0FhlaVaeQrtUIPrcubX2pYy\n\tIM4Ro92SHR/ctT69ZDWsxUKZvp05HrEG3SokaW5WAM5tZViq7CitUfYR2Wx9eX2Ek3gZ\n\taPvw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:user-agent:in-reply-to\n\t:content-transfer-encoding:content-disposition:mime-version\n\t:mail-followup-to:message-id:subject:to:from:date\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=rYUD1JH5QqnEiVYMx7ULfwDgHWDshrElONNjhf09wHo=;\n\tb=Cx5rpfRt3eLIabs3uEMSCr4F6WCs0+CJMHWn4RMbfp17r9RHJTq3/qICwTIV9Tj43Q\n\t87wj4Vmb5Hh7iBT9Jfm0RED2dr2MZ8seyfTh/jU+7Z0ElbmytWMkHD8E7a/iF8byS7Lx\n\taIJwuSyCnLfah4lat49DqnRiRit6Rgwj2O9An47F+JGe0QKNww4tLfVkEj+Z6RNsc4bn\n\t+fwjJBDF8+iUL6n8K2DlCpaKeE2PVNukd4BNCa3D0bAdD3v6yqzEdN7fbBVCK7AOBF2t\n\tLno9XgoHDhVCkZ3Uv2yqyblHs8E3RNJlnJdLpKYuVUo8g10IkvCEAkQD08s17ZkqZvsK\n\tbucQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=user-agent:in-reply-to:content-transfer-encoding\n\t:content-disposition:mime-version:mail-followup-to:message-id\n\t:subject:to:from:date:arc-authentication-results;\n\tbh=H9tc6vXYkp4MOUFwyHN3FDOW91wRFPBmpdWfwRaxPt0=;\n\tb=d/f+gbVzpQjCZlAR8yC7FDDzS+Vy9cr+ASSVm+KaTCol9FrkB4A6m+WVkif7nu2/7t\n\tsTjAbscWX8COK+Q85hy0qYJR5NFhb2f9ExGt7m5vD0FsoMd2/pLAizRqHwD7SkkLLRrh\n\tQhIPzR+EqQ57afqvE9rbkY8wt46KB2aATjaV43YpgMHdThUiVpydTnmD15qXFctb2+SU\n\tjKoB8PuPPeWNvd5xfdCLYWhRy0OEnplIuTyyRsX0PeUNWYtaBDM8hri3to8yFD8nA9Zp\n\tv4298qr7Oklt7+jiYRPKou4gmu7Az+FZ5eW1hcqSjuEFT6oOkVf0heW7woOlKM3PvSEk\n\tx3BQ=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.28 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.28 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:date:from:to:subject:message-id:mail-followup-to\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=rYUD1JH5QqnEiVYMx7ULfwDgHWDshrElONNjhf09wHo=;\n\tb=mExTVCZ+H7bF//jMbMH/jZ5Gwvm9QDHOkev9EpIG7UPYs6fUjhkfXnQQpSxrAd5kWT\n\thLuAZ5dPR2NNv8sgxgkuwswqZvtapMM3aR8otUr1phmKi9bACBsB9s2ZQW0my2GQs6kM\n\tzZV/oKSv76URSgn9aOSPdT8eBmFhjhhRaNEZWqPM9ofXjAhxnUWmTaTrx2HLfyb9/1kw\n\tMwLQRCzpmQW8u5rBc0ALCEuBbbv1hAHmpabWW34SsW8iC7CY4YqkLjgCS0PoPt8UStZA\n\tnzy60miU0UMbGOYH6oZLg5ZhBBye4Ytm9l0ampygWPgAajCkz7jYn4rH+q3Jv0w00Qej\n\tt8Ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:date:from:to:subject:message-id\n\t:mail-followup-to:mime-version:content-disposition\n\t:content-transfer-encoding:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=rYUD1JH5QqnEiVYMx7ULfwDgHWDshrElONNjhf09wHo=;\n\tb=aGbE5AZTgPGQGKn2FQdoSuGWSdOgsBv5ThyFhuIa01KqzcZCyRg7tU+U77JrlcLvzp\n\tCwjyzzhkzqfvLoOGMbyob4d+1/3LibKwJlokCJxIS0Ocy6TZtioUPUMs9q+wx5YR9LiJ\n\tVg66NOmICU7fhrCMKXeLzfMBc5VPJv2kDBmjO0MA/A0BVuuNe4EYlsXqyz3OMojMoa2p\n\tC6sY/lUTL6n1oPfaTLacKk+qn4lZy+xRFG+5QkqH1XbY93OnnwiAYBJeYUdIzqWRnuG1\n\td4mkLmp5bx/lUtcANQ0bin1zSgtRBlQwNmEgj1WZMDHIRREluONetAQ/2pyMLTTSmSGL\n\tIPvQ==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AMCzsaUibasUlcMhDktD7nE2NIM0wV+siP8eeV7ThWJqnnPPjRa4+HL8\n\tz5u/Rr0qeinTTTHIK4KAK/E=","X-Google-Smtp-Source":"AOwi7QAZI98/texWn0o5CsDyNgovto/U33/Q7UcxG97UCm530WlSmf835sIGODVLbWZo6BgAKnopKg==","X-Received":["by 10.28.170.202 with SMTP id t193mr4063wme.8.1506516005103;\n\tWed, 27 Sep 2017 05:40:05 -0700 (PDT)","by 10.28.4.69 with SMTP id 66mr207428wme.25.1506516004628;\n\tWed, 27 Sep 2017 05:40:04 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 192.35.17.28 is neither permitted nor\n\tdenied by best guess record for domain of\n\tchristian.storm@siemens.com) client-ip=192.35.17.28; ","Date":"Wed, 27 Sep 2017 14:37:05 +0200","From":"Christian Storm ","To":"swupdate@googlegroups.com","Subject":"Re: [swupdate] [PATCH] core: don't unlink if final equals temp\n\tlocation","Message-ID":"<20170927123705.fgvysegnwbmq7izb@MD1KR9XC.ww002.siemens.net>","Mail-Followup-To":"swupdate@googlegroups.com","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Disposition":"inline","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<0c8965a8-2241-0f3b-ebee-4454b8307261@denx.de>","User-Agent":"Mutt/20170113 (1.7.2)","X-Original-Sender":"christian.storm@siemens.com","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 192.35.17.28 is neither permitted nor denied by best\n\tguess\n\trecord for domain of christian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1776313,"web_url":"http://patchwork.ozlabs.org/comment/1776313/","msgid":"<549bf535-c378-9940-c51a-bbe2e8c46146@denx.de>","list_archive_url":null,"date":"2017-09-27T12:44:42","subject":"Re: [swupdate] [PATCH] core: don't unlink if final equals temp\n\tlocation","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 27/09/2017 14:37, Christian Storm wrote:\n> Hi Stefano,\n> \n>> On 20/09/2017 17:34, Christian Storm wrote:\n>>> If the temporary location of an artifact happens to\n>>> be identical to the final location of the artifact,\n>>> SWUpdate deletes the artifact after installation\n>>> (if CONFIG_NOCLEANUP isn't set, that is).\n>>>\n>>> Consider the following sw-description with default\n>>> TMPDIR=/tmp set:\n>>>\n>>> software =\n>>> {\n>>> version = \"0.0.1\";\n>>> files: (\n>>> {\n>>> filename = \"dummy.file\";\n>>> path = \"/tmp/dummy.file\";\n>>> }\n>>> );\n>>> }\n>>>\n>>> After installation, /tmp/dummy.file will be removed.\n>>> Prevent its removal and issue a warning. Additionally,\n>>> if dummy.file is referenced more than once, issue a\n>>> warning stating its removal reason.\n>>>\n>>> Signed-off-by: Christian Storm \n>>> ---\n>>> corelib/installer.c | 18 +++++++++++++++++-\n>>> 1 file changed, 17 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/corelib/installer.c b/corelib/installer.c\n>>> index 8a188a1..6c6271c 100644\n>>> --- a/corelib/installer.c\n>>> +++ b/corelib/installer.c\n>>> @@ -326,7 +326,23 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile)\n>>> \t\t\t\tcontinue;\n>>> \t\t}\n>>> \n>>> -\t\tret = install_single_image(img);\n>>> +\t\tif (strncmp(img->path, img->extract_file, sizeof(img->path)) == 0) {\n>>> +\t\t\tstruct img_type *tmpimg;\n>>> +\t\t\tWARN(\"Temporary and final location for %s is identical, skip \"\n>>> +\t\t\t \"processing.\", img->path);\n>>> +\t\t\tLIST_REMOVE(img, next);\n>>> +\t\t\tLIST_FOREACH(tmpimg, &sw->images, next) {\n>>> +\t\t\t\tif (strncmp(tmpimg->fname, img->fname, sizeof(img->fname)) == 0) {\n>>> +\t\t\t\t\tWARN(\"%s will be removed, it's referenced more \"\n>>> +\t\t\t\t\t \"than once.\", img->path);\n>>> +\t\t\t\t\tbreak;\n>>> +\t\t\t\t}\n>>> +\t\t\t}\n>>> +\t\t\tfree(img);\n>>> +\t\t\tret = 0;\n>>> +\t\t} else {\n>>> +\t\t\tret = install_single_image(img);\n>>> +\t\t}\n>>> \n>>> \t\tif (!fromfile)\n>>> \t\t\tclose(img->fdin);\n>>>\n>>\n>> Applied to -master, thanks!\n> \n> Hm, I cannot find it upstream on -master and it's gone in patchwork\n> as well. Am I bind or has it slipped through?\n\nI do not know what went wrong - I picked it up again and pushedit, thanks !\n\nBest regards,\nStefano","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c0c::237;\n\thelo=mail-wr0-x237.google.com;\n\tenvelope-from=swupdate+bncbaabbqv2v3hakgqexvdnsdy@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"jLPgajmf\"; dkim-atps=neutral"],"Received":["from mail-wr0-x237.google.com (mail-wr0-x237.google.com\n\t[IPv6:2a00:1450:400c:c0c::237])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2HbB6s8Tz9t5l\n\tfor ;\n\tWed, 27 Sep 2017 22:44:54 +1000 (AEST)","by mail-wr0-x237.google.com with SMTP id w12sf2594231wrc.2\n\tfor ;\n\tWed, 27 Sep 2017 05:44:54 -0700 (PDT)","by 10.28.11.143 with SMTP id 137ls403096wml.0.canary-gmail; Wed, 27\n\tSep 2017 05:44:50 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net.\n\t[2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id\n\tp200si444426wmg.4.2017.09.27.05.44.50\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 05:44:50 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y2Hb632chz1qshC;\n\tWed, 27 Sep 2017 14:44:50 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y2Hb62pD6z1r0wb;\n\tWed, 27 Sep 2017 14:44:50 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id pf_9ROGylPzZ; Wed, 27 Sep 2017 14:44:49 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 27 Sep 2017 14:44:49 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 524B84540694;\n\tWed, 27 Sep 2017 14:44:45 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id Jd9IMF5B2IAT; Wed, 27 Sep 2017 14:44:42 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id A3CC645403D2;\n\tWed, 27 Sep 2017 14:44:42 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1506516291; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=hPxWydezHQJlapHgbEJ2MrFm6id829+ZGPGkodL/hOiGP/rX+QNquHRnp8KZRArjq3\n\t/ghb80t/tEwlCmHcmMx4Z+2E2LRCSgKYS8pk+afPNSCUw9oNJ1leODHnR2+bkFBOxCAw\n\tjIyg7PB+wouWbgbQIDtcoW9w45xUuXEvGSnT0B149ObiEBnxiFluTADWW/thZFVlP1M9\n\tcS6FgfE2F1/KCkVgkBildCFAVJYqA8ljqd6jMvk7crHwWb86/Zv4cZA2xntGGcBBP3SY\n\tpk6cVJpU+FENSVqE9jeGLGfa4+GTmin/4A09BJE48ccqkIP6yCOpuxJeTI0MCN6bTN4f\n\t4wvg==","i=1; a=rsa-sha256; t=1506516290; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=QYL0HB5sK/lZg84Px1Wt5lmSTv9tfn+MrOSXTO2kqz4WoFJtHCCvCWJOqbso8g7zAx\n\tSAFjOkA/XYVOhri+bAH9KkcmBAfEAzzO98e8WZxq1qrCNHAdJ7ppc2sYzA3ONNiLhxw/\n\ttiugrUqMxJFntad5xk9mjsoFxBZA1Fbx3UpeiqgptMHp09sQg6ymiK+34IV1A79nU/zH\n\tTSff3yPYo+wuB+duQfJwKt2P2D6QYqxm2fkrx1qlzLOUUEIhlQq+TP1tlFWK1JK5DlXC\n\tNEsiNejrOnJZSkXnNxtfKfDW5Of7Guth9vMjxJjXi8KGP7cnw72lPU9wtG1xkaTomzRJ\n\tCPrQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:to:cc:references\n\t:subject:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=mQFwsuTnteHgpez3uwIaJqIDo+BnQlJV/h7uAmFl5qY=;\n\tb=qd0dhWwHtZgn4mN7xuFp3MB/fgB/UlXZeiy8m7pUyi6sL4+Vqwr1e9oonM+F259UAh\n\tWwCMre7luyGsd7aTVIBTPu3uvhMxUc/oXS65tSZFTTU5qHhVw3rGpoLHzVYlO1Lj+YzH\n\tbEi5JTVjSeajmrj9ItFsHr7VHxTQ+LRA8NTzMeiZKoK4/IVZyelu7e98Dfe9d5N5+Gov\n\tG1G+yYb0LGwRqOqmfnDoYt+TpvjrOuPu5WwiyBbPn3ufRZ65qLYEQJ+DMVnrPPIHRFW0\n\tunneEMh8L4KqE06kJty8PaMNOkdhpW/iPaajX4qTPv9Uab/a9fIhTiZru4bL+yWMrajC\n\tWyLg==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:to:cc:references:subject\n\t:arc-authentication-results;\n\tbh=qvQGOk+I31/D05Sx1bFzL1pT6wqE4WN5xWz/KkV2Hfk=;\n\tb=jC/4TaVb1L4kJKoilzlTz/Gl55X2DPYTkUgRFwn/6Sp/j+MJKHewWrBVt0+xfprFAs\n\tqC9iG3xIY45Py07UNVAgM0OHUDdi45LvPi98ogEqKuTVtHrSSPMHIxv97gzhxxh66yDk\n\tdWpvoaVuCDu4KZOcdK3Uq6Oz0JwBhdXLGS8W3ZJ9y8KLOtVsfLOs+VM0rz7BgEq2RbUX\n\ttElOUBHNzp2Q1zt+peTnTzv6iua7jhuw86mQ+wMiQH39rd+oOv222g34wlABoCFKokhr\n\t7qzVzgPoKYTbpHB0bC23gXwJbowx/IZ1U+zQuwR7HPRtET3odvk1uUQWamwcRpQrbjdx\n\t5GGg=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:references:cc:to:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=mQFwsuTnteHgpez3uwIaJqIDo+BnQlJV/h7uAmFl5qY=;\n\tb=jLPgajmfdVbnPSUEkjoxhR/Hf2VakZrEdAhVvPBKT9sur3YntPJKOWsMV8V670C8sL\n\t5zXWG0omQFGERp7C1Sx3XoNJFDvEXSO2Qz2Hn+1fGEb9+9hHOpFTHuYac5V+XS5n0Sy5\n\ttcIAlOEVsImhY6Sfo+hQsTOrTYbOaZVHZbWAjVnMVHRkEIbPrdOxvUZXzSXe098CQxnY\n\ta6qtHlhvEutQgznWXuV8TmxrEWYgLtjPxr3gh2RWuCLNA1rZdm4wgWuPwkg/LnRF7Bpk\n\troHwkgFwehncJbOt3hEQSM8JIhgWRRmMV29PhBxdNFV7teYzJtEtd9+04BuPghpgvYji\n\tI5zg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:references:cc:to:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=mQFwsuTnteHgpez3uwIaJqIDo+BnQlJV/h7uAmFl5qY=;\n\tb=EiRPSqc2snZ1XMy9iF3opDVPQvZKM5sNLOkmjtTzC1sha+gqF/InrLC8aaF2YAr5+4\n\t82RmzKQ72DyVnQhkw6YiUjLcY2fivrCS/x3ZoyY++EpRntriNQrE6hb95zIbVFgvQyF0\n\t1js2UnGKUPz3NXZcDbkyTzJ7QslYxUGS8HHxXkYVj3SWjAMKKo5Q84FtRUp8gPVzrzVy\n\tSyVKU/uLYaWtTqTpQqq/Af/t7s+h2wdM8UIB2QmsyPz5v2lF4qFrmz8FlSQsQ2hY40md\n\tAoxJFmRMP/eDwIQ0LWWhU3HpDZY3izuFc3BAneU1tyRgHzF83y/uZp8Xv+NMafWW0qxY\n\tpK6Q==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUj1T4j1dys+cDsi9BQvAhYdWhFg7B2v6G6jPhNlu6MSvHbxqFaJ\n\ttNgJxeMFUJgy83PmQx+cupA=","X-Google-Smtp-Source":"AOwi7QBWWDmf2VM8I6DMXeSy2A9BGYCLKZhzS3gdgbw4GZmqNc16dkNHdwVKTxWr3Is7zmnGdKcMDQ==","X-Received":["by 10.28.95.86 with SMTP id t83mr6391wmb.24.1506516291032;\n\tWed, 27 Sep 2017 05:44:51 -0700 (PDT)","by 10.28.131.14 with SMTP id f14mr206450wmd.25.1506516290675;\n\tWed, 27 Sep 2017 05:44:50 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither\n\tpermitted nor denied by best guess record for domain of\n\tsbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH] core: don't unlink if final equals temp\n\tlocation","References":"<20170927123705.fgvysegnwbmq7izb@MD1KR9XC.ww002.siemens.net>","Cc":"swupdate@googlegroups.com","To":"Christian Storm ","From":"Stefano Babic ","Message-ID":"<549bf535-c378-9940-c51a-bbe2e8c46146@denx.de>","Date":"Wed, 27 Sep 2017 14:44:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927123705.fgvysegnwbmq7izb@MD1KR9XC.ww002.siemens.net>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"de-DE","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied\n\tby best\n\tguess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]