[{"id":1772455,"web_url":"http://patchwork.ozlabs.org/comment/1772455/","msgid":"<1505976596.7353.0.camel@redhat.com>","list_archive_url":null,"date":"2017-09-21T06:49:56","subject":"Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating\n\tproblems with pflash","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote:\n> pflash toggles mr->romd_mode. So this assert does not always hold.\n> \n> 1) a device was added with !mr->romd_mode, therefore effectively not\n>    creating a kvm slot as we want to trap every access (add = false).\n> 2) mr->romd_mode was toggled on before remove it. There is now\n>    actually no slot to remove and the asser is wrong.\n> \n> So let's just drop the assert.\n\nWorks without any obvious bad side effects.\n\nTested-by: Gerd Hoffmann \n\ncheers,\n Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyS1H6b8Mz9sBZ\n\tfor ;\n\tThu, 21 Sep 2017 16:50:43 +1000 (AEST)","from localhost ([::1]:52092 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duvJq-0003Gq-0S\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 02:50:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44152)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duvJH-0003Dq-8L\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:50:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duvJC-00080j-92\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:50:07 -0400","from mx1.redhat.com ([209.132.183.28]:33472)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duvJC-0007zY-35\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:50:02 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id CBEA968C2;\n\tThu, 21 Sep 2017 06:50:00 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-116-116.ams2.redhat.com\n\t[10.36.116.116])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C2CB95D97C;\n\tThu, 21 Sep 2017 06:49:57 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id E0DEEA200;\n\tThu, 21 Sep 2017 08:49:56 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com CBEA968C2","Message-ID":"<1505976596.7353.0.camel@redhat.com>","From":"Gerd Hoffmann ","To":"David Hildenbrand , qemu-devel@nongnu.org","Date":"Thu, 21 Sep 2017 08:49:56 +0200","In-Reply-To":"<20170920145025.19403-1-david@redhat.com>","References":"<20170920145025.19403-1-david@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 21 Sep 2017 06:50:00 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating\n\tproblems with pflash","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , kvm@vger.kernel.org, Radim\n\t=?utf-8?b?S3LEjW3DocWZ?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772661,"web_url":"http://patchwork.ozlabs.org/comment/1772661/","msgid":"<059a4497-affa-23b7-2875-42efa82c65de@redhat.com>","list_archive_url":null,"date":"2017-09-21T10:34:50","subject":"Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating\n\tproblems with pflash","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On 21/09/2017 08:49, Gerd Hoffmann wrote:\n> On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote:\n>> pflash toggles mr->romd_mode. So this assert does not always hold.\n>>\n>> 1) a device was added with !mr->romd_mode, therefore effectively not\n>>    creating a kvm slot as we want to trap every access (add = false).\n>> 2) mr->romd_mode was toggled on before remove it. There is now\n>>    actually no slot to remove and the asser is wrong.\n>>\n>> So let's just drop the assert.\n> \n> Works without any obvious bad side effects.\n> \n> Tested-by: Gerd Hoffmann \n\nQueued, thanks.\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyY0d1JR7z9s0Z\n\tfor ;\n\tThu, 21 Sep 2017 20:35:29 +1000 (AEST)","from localhost ([::1]:52821 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duypL-0001cw-9q\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 06:35:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46770)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duyox-0001cS-Pl\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 06:35:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duyot-0001Du-QQ\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 06:35:03 -0400","from mx1.redhat.com ([209.132.183.28]:51962)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duyot-0001BS-KK\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 06:34:59 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4225781E01;\n\tThu, 21 Sep 2017 10:34:58 +0000 (UTC)","from [10.36.117.52] (ovpn-117-52.ams2.redhat.com [10.36.117.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 854D15C8B2;\n\tThu, 21 Sep 2017 10:34:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4225781E01","To":"Gerd Hoffmann , David Hildenbrand , \n\tqemu-devel@nongnu.org","References":"<20170920145025.19403-1-david@redhat.com>\n\t<1505976596.7353.0.camel@redhat.com>","From":"Paolo Bonzini ","Message-ID":"<059a4497-affa-23b7-2875-42efa82c65de@redhat.com>","Date":"Thu, 21 Sep 2017 12:34:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505976596.7353.0.camel@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 21 Sep 2017 10:34:58 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating\n\tproblems with pflash","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kvm@vger.kernel.org, =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]