[{"id":1772082,"web_url":"http://patchwork.ozlabs.org/comment/1772082/","msgid":"","list_archive_url":null,"date":"2017-09-20T17:14:01","subject":"Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give\n\tmemory_region_transaction_commit a hint","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On 20/09/2017 13:46, Alexey Kardashevskiy wrote:\n> This extends memory_region_transaction_commit() to receive a MR as\n> if it is a root MR or its topmost parent is, then we can only rebuild\n> its FlatView and update it for address spaces sharing it.\n> \n> The optimization gets disabled though if there is full update about to\n> commit.\n> \n> memory_region_set_enabled() is a special case here, it does not use\n> a hint when MR is being disabled.\n> \n> On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings\n> down the boot time from 20s to 12s, the total memory footprint\n> goes down (17G -> 8G).\n\nI think this is incorrect if MR has an alias (no matter if enabling or\ndisabling)?\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy5vk4F21z9s0Z\n\tfor ;\n\tThu, 21 Sep 2017 03:14:42 +1000 (AEST)","from localhost ([::1]:49856 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duia8-0007A9-NO\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 13:14:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46395)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duiZc-00078q-QT\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:14:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duiZY-0000G0-MA\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:14:08 -0400","from mx1.redhat.com ([209.132.183.28]:48628)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duiZY-0000FO-Fb\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:14:04 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A5E8946213;\n\tWed, 20 Sep 2017 17:14:03 +0000 (UTC)","from [10.36.117.211] (ovpn-117-211.ams2.redhat.com [10.36.117.211])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 121CA60241;\n\tWed, 20 Sep 2017 17:14:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A5E8946213","To":"Alexey Kardashevskiy , qemu-devel@nongnu.org","References":"<20170920114637.42004-1-aik@ozlabs.ru>\n\t<20170920114637.42004-19-aik@ozlabs.ru>","From":"Paolo Bonzini ","Message-ID":"","Date":"Wed, 20 Sep 2017 19:14:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920114637.42004-19-aik@ozlabs.ru>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 20 Sep 2017 17:14:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give\n\tmemory_region_transaction_commit a hint","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772321,"web_url":"http://patchwork.ozlabs.org/comment/1772321/","msgid":"","list_archive_url":null,"date":"2017-09-21T00:02:02","subject":"Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give\n\tmemory_region_transaction_commit a hint","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"content":"On 21/09/17 03:14, Paolo Bonzini wrote:\n> On 20/09/2017 13:46, Alexey Kardashevskiy wrote:\n>> This extends memory_region_transaction_commit() to receive a MR as\n>> if it is a root MR or its topmost parent is, then we can only rebuild\n>> its FlatView and update it for address spaces sharing it.\n>>\n>> The optimization gets disabled though if there is full update about to\n>> commit.\n>>\n>> memory_region_set_enabled() is a special case here, it does not use\n>> a hint when MR is being disabled.\n>>\n>> On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings\n>> down the boot time from 20s to 12s, the total memory footprint\n>> goes down (17G -> 8G).\n> \n> I think this is incorrect if MR has an alias (no matter if enabling or\n> disabling)?\n\nHmmm. Right. I can add a aliases_nr counter to an MR (it does not even have\nto go down as aliases are not creared/destroyed often) and take the slow\npath if it is not zero, does it make sense?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ozlabs-ru.20150623.gappssmtp.com\n\theader.i=@ozlabs-ru.20150623.gappssmtp.com\n\theader.b=\"J33Y0NUW\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyGyW5BJ1z9s81\n\tfor ;\n\tThu, 21 Sep 2017 10:02:42 +1000 (AEST)","from localhost ([::1]:51148 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duowx-0002FG-TT\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 20:02:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40896)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duowX-0002Ev-Rd\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 20:02:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duowT-0000VB-0G\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 20:02:13 -0400","from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:33995)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1duowS-0000Tn-QV\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 20:02:08 -0400","by mail-pf0-x241.google.com with SMTP id g65so1790929pfe.1\n\tfor ; Wed, 20 Sep 2017 17:02:08 -0700 (PDT)","from [192.168.10.22] (124-171-134-202.dyn.iinet.net.au.\n\t[124.171.134.202]) by smtp.googlemail.com with ESMTPSA id\n\ts17sm127499pgq.25.2017.09.20.17.02.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 17:02:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ozlabs-ru.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=SiWpP/lNRwnATzlCXabeVMPmb3Qs6oDgOaVlKSua5PQ=;\n\tb=J33Y0NUW47kZtk1+/0DdNapoMyfv1AM0wxWURD6vdXRiag4HMKGvqe+ldqJv6BYSQM\n\ttbHjxUgZpa/QMafEJ+k2qTAmuiIjnaC8T0F3Bd7aeiRkpSNeTcZy6i8YshzJUulOHli5\n\t7gQm5hVSJPcWblIa/+ktkjo2UWgwGZMKZzB41eZVmw6r83F/F1PNeDew88BJDL2QZSth\n\ts4z48y2csoA5UxZglgYS2S2uACx8nUCNCUN9PjE2Xxq/Oxr1sMowyM56SdRTMpZUqMNX\n\tj8Y797TPJzaL+bh45tWkmCr4ONUufyldfyyOaf7K2Jp8P5HU7C2fFMkuWSykOQj7NOjd\n\th37g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=SiWpP/lNRwnATzlCXabeVMPmb3Qs6oDgOaVlKSua5PQ=;\n\tb=ggOhnzDJlJlEqzxixYUHBF+4+zzLhI/U2fmQfq0oQycM0zwRMhHbvur9cSAv9zuk5E\n\tBpLuXQ7V0U/CQkmP2tVq027SzTR5yAfZ16LBoXoWkEa3f9byExzQF4tzdXaNn6Ghcs0y\n\tsIwV2cY1WBnoKekXz6fHiHRKLbLjL8yhCq7KSL4zuUZiFjGSd+EUsXb0A4WYF5Nshabt\n\tLc2dN03a5m1WE/JCYLNrnVD86ypB4j0hUP0kskruh0UN50Lf68OLeguMCBjRBxU73NAT\n\tw05JYo54cx72CEbsVTdA+ai0Mgj57/6HoyCglZXrnLvJwf6LKbvKH8UAtKSJ2VGS3OPg\n\tMUqg==","X-Gm-Message-State":"AHPjjUiwr0ewQi8+c4CK/nAM6Nsqac39b/pNtH3q3DeJL4i4YbxZ5VIO\n\t9Odmbra2B/+Nm/b0SXsU/Sr4Iloe","X-Google-Smtp-Source":"AOwi7QAgAtq+Ggb5+HHzobNq1m+BcMahWgmjy6d1lms5wGqZ7qaKB5YK8OqD4keeePM0yWOB8fLPQA==","X-Received":"by 10.84.132.110 with SMTP id 101mr3668405ple.67.1505952127180; \n\tWed, 20 Sep 2017 17:02:07 -0700 (PDT)","To":"Paolo Bonzini , qemu-devel@nongnu.org","References":"<20170920114637.42004-1-aik@ozlabs.ru>\n\t<20170920114637.42004-19-aik@ozlabs.ru>\n\t","From":"Alexey Kardashevskiy ","Message-ID":"","Date":"Thu, 21 Sep 2017 10:02:02 +1000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-AU","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::241","Subject":"Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give\n\tmemory_region_transaction_commit a hint","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772495,"web_url":"http://patchwork.ozlabs.org/comment/1772495/","msgid":"<222247850.7271421.1505979264047.JavaMail.zimbra@redhat.com>","list_archive_url":null,"date":"2017-09-21T07:34:24","subject":"Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give\n\tmemory_region_transaction_commit a hint","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"----- Original Message -----\n> From: \"Alexey Kardashevskiy\" \n> To: \"Paolo Bonzini\" , qemu-devel@nongnu.org\n> Sent: Thursday, September 21, 2017 2:02:02 AM\n> Subject: Re: [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint\n> \n> On 21/09/17 03:14, Paolo Bonzini wrote:\n> > On 20/09/2017 13:46, Alexey Kardashevskiy wrote:\n> >> This extends memory_region_transaction_commit() to receive a MR as\n> >> if it is a root MR or its topmost parent is, then we can only rebuild\n> >> its FlatView and update it for address spaces sharing it.\n> >>\n> >> The optimization gets disabled though if there is full update about to\n> >> commit.\n> >>\n> >> memory_region_set_enabled() is a special case here, it does not use\n> >> a hint when MR is being disabled.\n> >>\n> >> On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings\n> >> down the boot time from 20s to 12s, the total memory footprint\n> >> goes down (17G -> 8G).\n> > \n> > I think this is incorrect if MR has an alias (no matter if enabling or\n> > disabling)?\n> \n> Hmmm. Right. I can add a aliases_nr counter to an MR (it does not even have\n> to go down as aliases are not creared/destroyed often) and take the slow\n> path if it is not zero, does it make sense?\n\nIt should be a separate series anyway. Let's get the infrastructure in\nso it's easier to experiment.\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyT0L2Q9Fz9sNw\n\tfor ;\n\tThu, 21 Sep 2017 17:34:58 +1000 (AEST)","from localhost ([::1]:52171 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duw0e-0002Qm-FO\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 03:34:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58189)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duw0D-0002PS-2z\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 03:34:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duw09-0000Hx-Ts\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 03:34:29 -0400","from mx1.redhat.com ([209.132.183.28]:60822)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duw09-0000H3-OI\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 03:34:25 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C2A42C047B77;\n\tThu, 21 Sep 2017 07:34:24 +0000 (UTC)","from colo-mx.corp.redhat.com\n\t(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id B9532600C2;\n\tThu, 21 Sep 2017 07:34:24 +0000 (UTC)","from zmail18.collab.prod.int.phx2.redhat.com\n\t(zmail18.collab.prod.int.phx2.redhat.com [10.5.83.21])\n\tby colo-mx.corp.redhat.com (Postfix) with ESMTP id B12961855940;\n\tThu, 21 Sep 2017 07:34:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C2A42C047B77","Date":"Thu, 21 Sep 2017 03:34:24 -0400 (EDT)","From":"Paolo Bonzini ","To":"Alexey Kardashevskiy ","Message-ID":"<222247850.7271421.1505979264047.JavaMail.zimbra@redhat.com>","In-Reply-To":"","References":"<20170920114637.42004-1-aik@ozlabs.ru>\n\t<20170920114637.42004-19-aik@ozlabs.ru>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[78.12.246.117, 10.4.196.4, 10.4.195.27]","Thread-Topic":"memory: Give memory_region_transaction_commit a hint","Thread-Index":"TB25Ba3gF6HnjpnGJGg7QizVNo4B1w==","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 21 Sep 2017 07:34:24 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give\n\tmemory_region_transaction_commit a hint","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]