[{"id":1771936,"web_url":"http://patchwork.ozlabs.org/comment/1771936/","msgid":"<20170920122421.GD4730@localhost.localdomain>","list_archive_url":null,"date":"2017-09-20T12:24:21","subject":"Re: [Qemu-devel] [PATCH 1/2] block/block-backend.c: add\n\tblk_check_byte_request call to blk_pread/blk_pwrite","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 20.09.2017 um 13:43 hat Manos Pitsidianakis geschrieben:\n> blk_check_byte_request() is called from the blk_co_pwritev/blk_co_preadv to\n> check if the request offset and request bytes parameters are valid for the\n> given Blockbackend. Let's do that in blk_pread/blk_pwrite too.\n> \n> Signed-off-by: Manos Pitsidianakis \n\nI don't think this is necessary, blk_pread/pwrite() are only wrappers\naround blk_co_preadv/pwritev(), so we're already checking the\nparameters.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy2Xl6TZqz9sPt\n\tfor ;\n\tThu, 21 Sep 2017 00:43:03 +1000 (AEST)","from localhost ([::1]:48552 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dugDO-0003sG-1M\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 10:43:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45936)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dufHw-00004s-MY\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:43:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dufHv-0005Lf-U2\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:43:40 -0400","from mx1.redhat.com ([209.132.183.28]:53584)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dufHp-0005GZ-3c; Wed, 20 Sep 2017 09:43:33 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1B4ECC07F9A3;\n\tWed, 20 Sep 2017 12:24:28 +0000 (UTC)","from localhost.localdomain (ovpn-116-76.ams2.redhat.com\n\t[10.36.116.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5BA006046B;\n\tWed, 20 Sep 2017 12:24:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1B4ECC07F9A3","Date":"Wed, 20 Sep 2017 14:24:21 +0200","From":"Kevin Wolf ","To":"Manos Pitsidianakis ","Message-ID":"<20170920122421.GD4730@localhost.localdomain>","References":"<20170920114310.13080-1-el13635@mail.ntua.gr>\n\t<20170920114310.13080-2-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170920114310.13080-2-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 20 Sep 2017 12:24:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] block/block-backend.c: add\n\tblk_check_byte_request call to blk_pread/blk_pwrite","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"John Snow , qemu-devel ,\n\tqemu-block , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771988,"web_url":"http://patchwork.ozlabs.org/comment/1771988/","msgid":"<20170920143512.cfup2svar5uf4vdw@postretch>","list_archive_url":null,"date":"2017-09-20T14:35:12","subject":"Re: [Qemu-devel] [PATCH 1/2] block/block-backend.c: add\n\tblk_check_byte_request call to blk_pread/blk_pwrite","submitter":{"id":71571,"url":"http://patchwork.ozlabs.org/api/people/71571/","name":"Manos Pitsidianakis","email":"el13635@mail.ntua.gr"},"content":"On Wed, Sep 20, 2017 at 02:24:21PM +0200, Kevin Wolf wrote:\n>Am 20.09.2017 um 13:43 hat Manos Pitsidianakis geschrieben:\n>> blk_check_byte_request() is called from the blk_co_pwritev/blk_co_preadv to\n>> check if the request offset and request bytes parameters are valid for the\n>> given Blockbackend. Let's do that in blk_pread/blk_pwrite too.\n>>\n>> Signed-off-by: Manos Pitsidianakis \n>\n>I don't think this is necessary, blk_pread/pwrite() are only wrappers\n>around blk_co_preadv/pwritev(), so we're already checking the\n>parameters.\n>\n>Kevin\n\n\nAlright, this can be dropped then. Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy3cD3KTtz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 01:31:08 +1000 (AEST)","from localhost ([::1]:48887 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dugxu-0008He-Dt\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:31:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33670)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dug64-00060L-Gd\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:35:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dug60-0004xZ-L2\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 10:35:28 -0400","from smtp1.ntua.gr ([2001:648:2000:de::183]:23784)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dug5u-0004uJ-L0; Wed, 20 Sep 2017 10:35:18 -0400","from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60])\n\t(authenticated bits=0)\n\tby smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v8KEZCn0083425\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Wed, 20 Sep 2017 17:35:13 +0300 (EEST)\n\t(envelope-from el13635@mail.ntua.gr)"],"X-Authentication-Warning":"smtp1.ntua.gr: Host carp0.noc.ntua.gr\n\t[147.102.222.60] claimed to be mail.ntua.gr","Date":"Wed, 20 Sep 2017 17:35:12 +0300","From":"Manos Pitsidianakis ","To":"Kevin Wolf ","Message-ID":"<20170920143512.cfup2svar5uf4vdw@postretch>","Mail-Followup-To":"Manos Pitsidianakis ,\n\tKevin Wolf , qemu-devel ,\n\tqemu-block , Max Reitz ,\n\tJohn Snow ","References":"<20170920114310.13080-1-el13635@mail.ntua.gr>\n\t<20170920114310.13080-2-el13635@mail.ntua.gr>\n\t<20170920122421.GD4730@localhost.localdomain>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"yectdcsawkfkpogx\"","Content-Disposition":"inline","In-Reply-To":"<20170920122421.GD4730@localhost.localdomain>","User-Agent":"NeoMutt/20170609-57-1e93be (1.8.3)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:648:2000:de::183","Subject":"Re: [Qemu-devel] [PATCH 1/2] block/block-backend.c: add\n\tblk_check_byte_request call to blk_pread/blk_pwrite","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"John Snow , qemu-devel ,\n\tqemu-block , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]