[{"id":1780493,"web_url":"http://patchwork.ozlabs.org/comment/1780493/","msgid":"","list_archive_url":null,"date":"2017-10-05T11:22:42","subject":"Re: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet wrote:\n\n> Offset on meson pinctrl and gpios is something that was carried from the\n> vendor driver, where there is a weird link between the 2\n> controllers. Since these 2 controllers are independent, this offset adds\n> an unnecessary complexity.\n>\n> This patch remove this manually set offset and rely on pinctrl to figure\n> out the gpio base offset\n>\n> Tested-by: Martin Blumenstingl \n> Signed-off-by: Jerome Brunet \n\nPatch applied.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"GCH994vT\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y79Nt6z7fz9t2h\n\tfor ;\n\tThu, 5 Oct 2017 22:22:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751866AbdJELWp (ORCPT );\n\tThu, 5 Oct 2017 07:22:45 -0400","from mail-io0-f179.google.com ([209.85.223.179]:48975 \"EHLO\n\tmail-io0-f179.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751720AbdJELWo (ORCPT\n\t); Thu, 5 Oct 2017 07:22:44 -0400","by mail-io0-f179.google.com with SMTP id f72so6634677ioj.5\n\tfor ;\n\tThu, 05 Oct 2017 04:22:43 -0700 (PDT)","by 10.79.14.140 with HTTP; Thu, 5 Oct 2017 04:22:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=WeP/tkhX1gMKSyrW87Ox+AfdwJHsFlnrVmYSzTcr1fY=;\n\tb=GCH994vTucwqVtmC9R5aP4QOWpG4y/sJVjXHzcXmJkvaI8Tmc10ZRM6cvK08TvfDqT\n\tKsvxodI4lyp/gv7ThIpm+bP/qg9vz3kdqEmHli/dx/C8BT/BLYr1cGNN7vaXrnBkrv1P\n\tahdH9kh8d87Ul8acpbjbUPmrhTXzTEG47Agjk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=WeP/tkhX1gMKSyrW87Ox+AfdwJHsFlnrVmYSzTcr1fY=;\n\tb=iHf00e+PlHPc9+1xucNAOrR/ghYwvTXHJ1qgN7Gr2PMUzhfhuaW7t/qalxQqOjQRfG\n\tqQyxX5jM7BwNB/MRsMf3Eho+WBiv6jkHvctx7N2sZINH787uEQkm0SEUbEcsLrqWCBp7\n\tWtMe2geuVZlz/d7QwfUjizcYWkTYlXvEet5r1bzt6FTSeU5exRDY5NdjWM4g+HSsz6xc\n\tiX6TmD7TtbV7im6cCfsRONRyfwIFO91sq7o1ybjf0AfgkKI1zTqLaaKdEEbA6AZ2uyQF\n\tbA/jAK+bTZ+V6Bd33mO9gDvGCIARr4P8+4QMwTNhx0DuJVaQ27oRcNSKF9kCQAAbkns9\n\tNsTg==","X-Gm-Message-State":"AMCzsaXn4LlLOgSrTDqTwanw4wOQLhsQ/7El/TGdOO2tR2wZ6E0+Zhhj\n\tFbMZnKPa5WNI2Mt9liEFkWDLbPSJZHg7qAhRBTlMcg==","X-Google-Smtp-Source":"AOwi7QBvkwAJbjlMR7Rtjbr4RGwLnpEQxCOVzjI+SCY9XAF3klCfKpCHRhF4NhvdeRCd+x5QPNRKcahUXMzVfXAf6WA=","X-Received":"by 10.107.197.198 with SMTP id v189mr9183338iof.94.1507202563367;\n\tThu, 05 Oct 2017 04:22:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920133927.17390-2-jbrunet@baylibre.com>","References":"<20170920133927.17390-1-jbrunet@baylibre.com>\n\t<20170920133927.17390-2-jbrunet@baylibre.com>","From":"Linus Walleij ","Date":"Thu, 5 Oct 2017 13:22:42 +0200","Message-ID":"","Subject":"Re: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl","To":"Jerome Brunet ","Cc":"Kevin Hilman , Carlo Caione ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"open list:ARM/Amlogic Meson...\" , \n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tMartin Blumenstingl ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1780528,"web_url":"http://patchwork.ozlabs.org/comment/1780528/","msgid":"<1507204068.17300.204.camel@baylibre.com>","list_archive_url":null,"date":"2017-10-05T11:47:48","subject":"Re: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl","submitter":{"id":69839,"url":"http://patchwork.ozlabs.org/api/people/69839/","name":"Jerome Brunet","email":"jbrunet@baylibre.com"},"content":"On Thu, 2017-10-05 at 13:22 +0200, Linus Walleij wrote:\n> On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet wrote:\n> \n> > Offset on meson pinctrl and gpios is something that was carried from the\n> > vendor driver, where there is a weird link between the 2\n> > controllers. Since these 2 controllers are independent, this offset adds\n> > an unnecessary complexity.\n> > \n> > This patch remove this manually set offset and rely on pinctrl to figure\n> > out the gpio base offset\n> > \n> > Tested-by: Martin Blumenstingl \n> > Signed-off-by: Jerome Brunet \n> \n> Patch applied.\n\nThx Linus.\n\nJust to be sure, did you remember to squash patch 1 to 5 together ?\n\nI know it is a bit unusual but, as explained earlier, those patches were only\nsplit to ease the review. Keeping the change split would break bisect.\n\n> \n> Yours,\n> Linus Walleij\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=baylibre-com.20150623.gappssmtp.com\n\theader.i=@baylibre-com.20150623.gappssmtp.com\n\theader.b=\"mfIe/pKv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y79xy2s3Jz9t3h\n\tfor ;\n\tThu, 5 Oct 2017 22:48:06 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751347AbdJELrw (ORCPT );\n\tThu, 5 Oct 2017 07:47:52 -0400","from mail-wm0-f49.google.com ([74.125.82.49]:55680 \"EHLO\n\tmail-wm0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751239AbdJELrv (ORCPT\n\t); Thu, 5 Oct 2017 07:47:51 -0400","by mail-wm0-f49.google.com with SMTP id u138so1637564wmu.4\n\tfor ;\n\tThu, 05 Oct 2017 04:47:50 -0700 (PDT)","from boomer.home ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id\n\tj73sm38242482wmf.15.2017.10.05.04.47.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 05 Oct 2017 04:47:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=F3BRjn4Mx21Xw7zmCZ2s2drhXoZ9/dqFlSNEOBfeuN4=;\n\tb=mfIe/pKvUckee/YJmBFWC6hYEZsXRQO+10ialPX3fOuLfok9ySH1dA+sE71Qv0G/Zj\n\t83i36BfQ6DqsA2XHAGr06hqc2CFal0hsp8VNZcMOF+G4PkWxFTBqAFWSvTJQl0bzk5TU\n\tDUineBP12yWDWpxLXbJ3bRzeb0goS62T3e/1Htck93XJ4Wk5mBK7xazjn3bY4kniwYMI\n\tqckO3DhdS1NjM78a67i4oFDl88syEclwo28moDoNepiukuteJ+9Z8PINizdGHZ+9EdCS\n\tGk+OZ6KjA8CCOElA47EnZJtGYf883DitWQuObWNMOvgy+dtucphNekep+Oh2T+b9S+pZ\n\tBX6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=F3BRjn4Mx21Xw7zmCZ2s2drhXoZ9/dqFlSNEOBfeuN4=;\n\tb=WgjZSnsroa5s7Fvy6L7DUiL4NZBprFJ1IYxwFrbBtjF99LzL3kOmxC0kg/BkcG24wQ\n\tYpD4fZMIeau93di7XDV1FG/jQgrYzF0trcOkqomJ93gCrHiabI+wz50noQn/aWkQatkj\n\tcA6aCGo2GpNHdBtfvPA1xm1KZy5ngttsLuTfqjG8BP+K7YryIHHIVeV+ikAccEvxFwuG\n\t952trNQ3Ru7/opgh9ftD134S8ViQGe4Oo8aEUG4RZvr9AV3MOlLFLiS7ARCpB8Av5sqZ\n\tW8fvisN3oF8U0mke8Tpb4EDBHH2GQJAneEePIQZ/FIjQxPd/yAoQiLxQrX1YxU9RPFau\n\tVqLg==","X-Gm-Message-State":"AMCzsaXLisad8XZ/RBd33he98PNL5J51qJNoLHMG8CcoTb6cLUmxr0D+\n\tAkViU8UW4t9kIj9RpkBs67npnQ==","X-Google-Smtp-Source":"AOwi7QB1/dLka2eSpCQvxDVs4y0p1q8mRWswjFx4fzgTYUYvtAsQmmb2U3IJ5PKD6qguc+Kf9n+pEw==","X-Received":"by 10.28.2.2 with SMTP id 2mr14282793wmc.128.1507204070010;\n\tThu, 05 Oct 2017 04:47:50 -0700 (PDT)","Message-ID":"<1507204068.17300.204.camel@baylibre.com>","Subject":"Re: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl","From":"Jerome Brunet ","To":"Linus Walleij ","Cc":"Kevin Hilman , Carlo Caione ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"open list:ARM/Amlogic Meson...\" , \n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tMartin Blumenstingl ","Date":"Thu, 05 Oct 2017 13:47:48 +0200","In-Reply-To":"","References":"<20170920133927.17390-1-jbrunet@baylibre.com>\n\t<20170920133927.17390-2-jbrunet@baylibre.com>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]