[{"id":1773410,"web_url":"http://patchwork.ozlabs.org/comment/1773410/","msgid":"<7D3DAF88-9AED-426C-845D-7A8E62A1C4B8@vmware.com>","list_archive_url":null,"date":"2017-09-22T09:44:37","subject":"Re: [ovs-dev] [PATCH v2 09/12] netdev-dpdk: Minor cleanup of\n\tnetdev_dpdk_send__.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"I applied the patch to dpdk_merge here\n\nhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_darball_ovs_commits_dpdk-5Fmerge&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=A2_FCacqbp2moAo3HGFlTuxsjONUGhlN42OBcAuQQ6w&s=b6btPKhgvOFr2GOUYvktND6kaC6jc3fXI-mXfvNgXOU&e=\n\n\nOn 9/20/17, 6:29 AM, \"ovs-dev-bounces@openvswitch.org on behalf of Bhanuprakash Bodireddy\" wrote:\n\n The variable 'cnt' is initialized and reused in multiple function calls\n inside netdev_dpdk_send__() and is confusing sometimes. Instead introduce\n 'batch_cnt' to hold the original packet count and 'tx_cnt' to store\n the final packet count resulting after filtering and qos operations.\n \n Finally 'tx_cnt' packets gets transmitted on the respective 'qid'.\n \n Signed-off-by: Bhanuprakash Bodireddy \n ---\n lib/netdev-dpdk.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n \n diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\n index 60887e5..3ff79c1 100644\n --- a/lib/netdev-dpdk.c\n +++ b/lib/netdev-dpdk.c\n @@ -1938,17 +1938,17 @@ netdev_dpdk_send__(struct netdev_dpdk *dev, int qid,\n dpdk_do_tx_copy(netdev, qid, batch);\n dp_packet_delete_batch(batch, may_steal);\n } else {\n - int dropped;\n - int cnt = batch->count;\n + int tx_cnt, dropped;\n + int batch_cnt = dp_packet_batch_size(batch);\n struct rte_mbuf **pkts = (struct rte_mbuf **) batch->packets;\n \n dp_packet_batch_apply_cutlen(batch);\n \n - cnt = netdev_dpdk_filter_packet_len(dev, pkts, cnt);\n - cnt = netdev_dpdk_qos_run(dev, pkts, cnt, true);\n - dropped = batch->count - cnt;\n + tx_cnt = netdev_dpdk_filter_packet_len(dev, pkts, batch_cnt);\n + tx_cnt = netdev_dpdk_qos_run(dev, pkts, tx_cnt, true);\n + dropped = batch_cnt - tx_cnt;\n \n - dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, cnt);\n + dropped += netdev_dpdk_eth_tx_burst(dev, qid, pkts, tx_cnt);\n \n if (OVS_UNLIKELY(dropped)) {\n rte_spinlock_lock(&dev->stats_lock);\n -- \n 2.4.11\n \n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=94xvksxdcL0BYyKG9ub9r_JkAoF4zpW2FVu_-reGIsE&s=ZsShQg3zIb1bSyp1NEtQvzQOX7UjQKQqNk-OoJ8q0GI&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Lqy4DiQk\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz7x740cVz9s9Y\n\tfor ;\n\tFri, 22 Sep 2017 19:49:31 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 26534B75;\n\tFri, 22 Sep 2017 09:44:41 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 9AB32AE0\n\tfor ; Fri, 22 Sep 2017 09:44:39 +0000 (UTC)","from NAM02-BL2-obe.outbound.protection.outlook.com\n\t(mail-bl2nam02on0086.outbound.protection.outlook.com [104.47.38.86])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id DF52F17E\n\tfor ; Fri, 22 Sep 2017 09:44:38 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Fri, 22 Sep 2017 09:44:37 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Fri, 22 Sep 2017 09:44:37 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=6uuBEXm82dmEoH5XUx/Ul1MXvGPXrHyMxONzqmUWN1I=;\n\tb=Lqy4DiQkycsgkmhIGZTnIV8AfDRVtO4hpWP44AhzrjDeRSE08FPQLDcYIkEfZY3BOp1o72aoHhJPCwIpWftNUsnPgtwixPMRbUneI8I+rR1Cw+NkP3SKkEE22jhohGs3o6ku9X0h+YBcixUtkv5yL22UW4Nv5pGV+riZBzRdZ/k=","From":"Darrell Ball ","To":"Bhanuprakash Bodireddy ,\n\t\"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH v2 09/12] netdev-dpdk: Minor cleanup of\n\tnetdev_dpdk_send__.","Thread-Index":"AQHTM4dnjKVLgaL6o06SDsWO2xMZDQ==","Date":"Fri, 22 Sep 2017 09:44:37 +0000","Message-ID":"<7D3DAF88-9AED-426C-845D-7A8E62A1C4B8@vmware.com>","References":"<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1505913181-82547-10-git-send-email-bhanuprakash.bodireddy@intel.com>","In-Reply-To":"<1505913181-82547-10-git-send-email-bhanuprakash.bodireddy@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3406;\n\t20:XJhYFwYaW+EGwOq5cWZLmRTH8VzzYUXv+6Bfb42W/N9qeaO20pFlbtrZOypW2Fvd+QgQOE86EyoUsQQ8MC+75ot92DMk+afbHFBVhcKGiQjpP6nqlHZ+5X9aSCTDJVrebEwnM4J2aHORidaNfoR0a9U8g27RmWmFXSoZtsKoOcI=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"b07329ff-e02f-497c-751a-08d5019e8a01","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3406; ","x-ms-traffictypediagnostic":"MWHPR05MB3406:","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Lqy4DiQk\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565)(228905959029699)(17755550239193);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3406; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3406; ","x-forefront-prvs":"0438F90F17","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(189002)(377454003)(199003)(24454002)(86362001)(81156014)(81166006)(97736004)(83506001)(106356001)(8676002)(99286003)(6306002)(7736002)(305945005)(6512007)(6436002)(575784001)(6486002)(77096006)(58126008)(82746002)(316002)(66066001)(8936002)(6506006)(229853002)(189998001)(110136005)(2900100001)(53546010)(5660300001)(14454004)(6246003)(2501003)(3280700002)(54356999)(76176999)(50986999)(2906002)(101416001)(33656002)(2950100002)(478600001)(83716003)(105586002)(36756003)(102836003)(25786009)(966005)(68736007)(3660700001)(6116002)(53936002)(3846002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3406;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"22 Sep 2017 09:44:37.2105\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3406","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v2 09/12] netdev-dpdk: Minor cleanup of\n\tnetdev_dpdk_send__.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]