[{"id":1798900,"web_url":"http://patchwork.ozlabs.org/comment/1798900/","msgid":"<20171103202300.GL27530@ovn.org>","list_archive_url":null,"date":"2017-11-03T20:23:00","subject":"Re: [ovs-dev] [PATCH v2 04/12] netdev-bsd: Use\n\tDP_PACKET_BATCH_FOR_EACH in netdev_bsd_send.","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Wed, Sep 20, 2017 at 02:12:53PM +0100, Bhanuprakash Bodireddy wrote:\n> Use DP_PACKET_BATCH_FOR_EACH macro in netdev_bsd_send().\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n> ---\n> lib/netdev-bsd.c | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c\n> index 8a4cdb3..96ba71c 100644\n> --- a/lib/netdev-bsd.c\n> +++ b/lib/netdev-bsd.c\n> @@ -685,6 +685,7 @@ netdev_bsd_send(struct netdev *netdev_, int qid OVS_UNUSED,\n> {\n> struct netdev_bsd *dev = netdev_bsd_cast(netdev_);\n> const char *name = netdev_get_name(netdev_);\n> + struct dp_packet *packet;\n> int error;\n> int i;\n> \n> @@ -695,9 +696,9 @@ netdev_bsd_send(struct netdev *netdev_, int qid OVS_UNUSED,\n> error = 0;\n> }\n> \n> - for (i = 0; i < batch->count; i++) {\n> - const void *data = dp_packet_data(batch->packets[i]);\n> - size_t size = dp_packet_get_send_len(batch->packets[i]);\n> + DP_PACKET_BATCH_FOR_EACH (packet, batch) {\n> + const void *data = dp_packet_data(packet);\n> + size_t size = dp_packet_get_send_len(packet);\n\nIt looks to me like this produces a duplicate variable named 'i' in an\ninner scope, probably leaving the outer 'i' unused.\n\n(I guess that DP_PACKET_BATCH_FOR_EACH should use a name other than 'i',\nwhich has to be one of the most common variable names it could possibly\nuse.)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTD0x00ZHz9sNV\n\tfor ;\n\tSat, 4 Nov 2017 07:23:12 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 87F84A80;\n\tFri, 3 Nov 2017 20:23:08 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5E36B9BA\n\tfor ; Fri, 3 Nov 2017 20:23:07 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id E2122500\n\tfor ; Fri, 3 Nov 2017 20:23:06 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8925541C087;\n\tFri, 3 Nov 2017 21:23:02 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 3 Nov 2017 13:23:00 -0700","From":"Ben Pfaff ","To":"Bhanuprakash Bodireddy ","Message-ID":"<20171103202300.GL27530@ovn.org>","References":"<1505913181-82547-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1505913181-82547-5-git-send-email-bhanuprakash.bodireddy@intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505913181-82547-5-git-send-email-bhanuprakash.bodireddy@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v2 04/12] netdev-bsd: Use\n\tDP_PACKET_BATCH_FOR_EACH in netdev_bsd_send.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]