[{"id":1772313,"web_url":"http://patchwork.ozlabs.org/comment/1772313/","msgid":"","list_archive_url":null,"date":"2017-09-20T23:26:21","subject":"Re: [PATCH] net_sched: always reset qdisc backlog in qdisc_reset()","submitter":{"id":211,"url":"http://patchwork.ozlabs.org/api/people/211/","name":"Cong Wang","email":"xiyou.wangcong@gmail.com"},"content":"On Wed, Sep 20, 2017 at 5:45 AM, Konstantin Khlebnikov\n wrote:\n> SKB stored in qdisc->gso_skb also counted into backlog.\n>\n> Some qdiscs don't reset backlog to zero in ->reset(),\n> for example sfq just dequeue and free all queued skb.\n>\n> Signed-off-by: Konstantin Khlebnikov \n> Fixes: 2ccccf5fb43f (\"net_sched: update hierarchical backlog too\")\n\nLooks good.\n\nsch->qstats.backlog = 0 can be removed from each ->reset()\nafter this patch.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tsVnfTsi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyG920c3Pz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 09:26:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751881AbdITX0n (ORCPT );\n\tWed, 20 Sep 2017 19:26:43 -0400","from mail-pf0-f180.google.com ([209.85.192.180]:49683 \"EHLO\n\tmail-pf0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751813AbdITX0m (ORCPT\n\t); Wed, 20 Sep 2017 19:26:42 -0400","by mail-pf0-f180.google.com with SMTP id l188so2291496pfc.6\n\tfor ; Wed, 20 Sep 2017 16:26:42 -0700 (PDT)","by 10.100.160.131 with HTTP; Wed, 20 Sep 2017 16:26:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=GQr+xg6VdfmsSBmnxFCBpDplbBerSPGMl7fQS46X3OQ=;\n\tb=tsVnfTsi6fADe/WgTKCn3k/Z2sXyF9jAsUtyi89ZC1E6lbJc+r/4SpHuMeq2IXg20S\n\tpK4UdAw7QWmIWZ41juNOi0FjtqB7513CMnOJ3Ijqv44JXkG+nGtoxIbAlnXuBzm0a7/F\n\tw2SCSqRZMaOD+iyeSGePjgI4B23CXPr07QX25wHF2ZpHYH9PK+scBtH+7+EEqKasineE\n\t5hEK7GTfcBhwHTtDO3JQfLw4X9tqAtFCsd1gGQPZhRPjHDBjm8McMq8+EZSq1jbtUI0D\n\tjLuZ8dgUWEVFAmY0J6PsEyVKqaBOu1MMPPpgRjcjjoHyX7eZ6x8DYP3LK+AVUsgUGt+y\n\tLSgQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=GQr+xg6VdfmsSBmnxFCBpDplbBerSPGMl7fQS46X3OQ=;\n\tb=kZQ0rH+IUB+QTjh1DP3wUUvk4Hg3bsI3z/wGUHkiLwOe3l/peUisR4/TzaLmK20/yW\n\tUQDxDFxOIJ7VwOXO6qXl+D2pA0jEGoYFZP1O2tZLW5eUEfqDAjT6p/ivm/OSvY1C0F9O\n\tA84hZ8KR4woSyYiRKkufEne9yDkMsVIoifdTJsZLJKyKtQqiD/m7YfPJnpDZTSrlnrE+\n\tCUQe7aO92muhXtnuACVDsHStU4Ft8yVZ1aPZ6lYU6YUdPWwbYUteOeAehlUzdhThnkfU\n\tJzk8y28AilMbOlPqv/rSoUX6zfhalcpI/PvEphlGwMZfpnIVWllM4WCr4xST5wqZVWAp\n\toreQ==","X-Gm-Message-State":"AHPjjUjSiooKge2MuNxkGQiRZ6M60UBefALJUSDlXXcxzMmt6BUr/yS7\n\tWHrZgvXnyQTiw1caoRDg50SVOypmAwLIU6NLQp76sc+V","X-Google-Smtp-Source":"AOwi7QDO12HMJqALViLVtZhevLdrxwVmV0gfY3D8qRNSP7lsPEHiPOzhlwiRcULnLgsD+6pi1T3MrA7AnqW5o1+JFVk=","X-Received":"by 10.99.37.66 with SMTP id l63mr3842258pgl.348.1505950002134;\n\tWed, 20 Sep 2017 16:26:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150591153693.113604.8604505743746410801.stgit@buzz>","References":"<150591153693.113604.8604505743746410801.stgit@buzz>","From":"Cong Wang ","Date":"Wed, 20 Sep 2017 16:26:21 -0700","Message-ID":"","Subject":"Re: [PATCH] net_sched: always reset qdisc backlog in qdisc_reset()","To":"Konstantin Khlebnikov ","Cc":"Linux Kernel Network Developers ,\n\t\"David S. Miller\" , Jiri Pirko ,\n\tJamal Hadi Salim ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773069,"web_url":"http://patchwork.ozlabs.org/comment/1773069/","msgid":"<20170921.115754.1809328103208394223.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-21T18:57:54","subject":"Re: [PATCH] net_sched: always reset qdisc backlog in qdisc_reset()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Konstantin Khlebnikov \nDate: Wed, 20 Sep 2017 15:45:36 +0300\n\n> SKB stored in qdisc->gso_skb also counted into backlog.\n> \n> Some qdiscs don't reset backlog to zero in ->reset(),\n> for example sfq just dequeue and free all queued skb.\n> \n> Signed-off-by: Konstantin Khlebnikov \n> Fixes: 2ccccf5fb43f (\"net_sched: update hierarchical backlog too\")\n\nApplied and queued up for -stable.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xym8Q4c5Jz9s8J\n\tfor ;\n\tFri, 22 Sep 2017 04:57:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751729AbdIUS54 (ORCPT );\n\tThu, 21 Sep 2017 14:57:56 -0400","from shards.monkeyblade.net ([184.105.139.130]:52774 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750790AbdIUS5z (ORCPT\n\t); Thu, 21 Sep 2017 14:57:55 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id CEC8113401132;\n\tThu, 21 Sep 2017 11:57:54 -0700 (PDT)"],"Date":"Thu, 21 Sep 2017 11:57:54 -0700 (PDT)","Message-Id":"<20170921.115754.1809328103208394223.davem@davemloft.net>","To":"khlebnikov@yandex-team.ru","Cc":"netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us,\n\tjhs@mojatatu.com","Subject":"Re: [PATCH] net_sched: always reset qdisc backlog in qdisc_reset()","From":"David Miller ","In-Reply-To":"<150591153693.113604.8604505743746410801.stgit@buzz>","References":"<150591153693.113604.8604505743746410801.stgit@buzz>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Thu, 21 Sep 2017 11:57:55 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]