[{"id":1774380,"web_url":"http://patchwork.ozlabs.org/comment/1774380/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:13:31","subject":"Re: [U-Boot] [PATCH] dm: ofnode: query correct property in livetree\n\tofnode_get_addr_size","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 20 September 2017 at 05:50, Klaus Goger\n wrote:\n> The livetree codepath of ofnode_get_addr_size always used the \"reg\"\n> property for of_get_property. Use the property parameter of the function\n> call instead and check the return value if the property exists.\n> Otherwise return FDT_ADDR_T_NONE.\n>\n> This was discoverd while using SPI NOR with livetree.\n> spi_flash_decode_fdt checks for memory-map and will not fail with\n> livetree even if the property does not exist.\n>\n> Signed-off-by: Klaus Goger \n> Reviewed-by: Philipp Tomsich \n>\n> ---\n>\n> drivers/core/ofnode.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"pC0PUj7z\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Lj2P/e61\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0pLM5G3Hz9t30\n\tfor ;\n\tMon, 25 Sep 2017 12:43:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 70028C22227; Mon, 25 Sep 2017 02:23:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E7F8BC21F49;\n\tMon, 25 Sep 2017 02:23:51 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 26F86C221A9; Mon, 25 Sep 2017 02:14:02 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id ACA71C22156\n\tfor ; Mon, 25 Sep 2017 02:13:53 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id b82so5381209qkc.4\n\tfor ; Sun, 24 Sep 2017 19:13:53 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:13:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=OZUhk677zr6nsaDbIz1gMZmD9h/+qRcYIXq7djjarao=;\n\tb=pC0PUj7zWv1sUeDAIfiTgR/VafK14I1GOLgJtW6LJ+E84beF9xWNTSTSpmkZqI34VX\n\tNMGFk9ayPtxpktBsGRbxN6Xl41QZfQn1tng7OjQqfoRCUbLhvuwMXrc1t4q2+FotvK8U\n\tMEmxquaRhku3lGWeNceINLj9wUp7CbOdxYWcVjy0muPTkjp9aNniBCknEbca0CFCYlV0\n\trAYK7wTTcvLEAmaLqUD5aeZ2VCcxcdT8o39buAhV6SodwKZU55gHJXRGxVCd0YjWYAs1\n\tSf+yYYb9VRnCTg6/31DDdw2/OeL7qAvR9m19oa5kZCWJ184OsEWfVVUMBDKkGd+DpBdE\n\tq6Jw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=OZUhk677zr6nsaDbIz1gMZmD9h/+qRcYIXq7djjarao=;\n\tb=Lj2P/e610UOll4y6mk4UP0hEoRZWx1HsaBEh/ao42oy2WqYgRS/ZZz37LjlEPj8lrF\n\tm8mIRLbtfL17Sep+wMu0ngk4umajjreFgzOBn4+QXT561g0cW7DPVSp+6xJUu/j/PCJI\n\tTc5gcPg6g4z55pGDcSG61hm0Ua5q6PT0ix51I="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=OZUhk677zr6nsaDbIz1gMZmD9h/+qRcYIXq7djjarao=;\n\tb=PZV+/mvaou4DeEkdULfA6vGtCFa23tPDDv58/AfZfArFgjkW30qP+ITqXRr7IBn92g\n\t89+nAjYNHTsR8RBGH+giuQ/GPY0iEClRV5biMUJt0aV1Kf6OX1fdtZOOYDi3cbyzrikd\n\tv5gfIJlBV6JrCrH9Lsz0E3ZVuQKyW+Jil68v25SjmSzcEroRpQWgDHIvpvzOqsutAH8n\n\teUtjyiOSGBbIBifnSXKgtraJXn+6dIZpjVRPft6eY5Pb8/NrSLfoRLrqwgN8znhypTZN\n\tIxx5BLNUf5j72biGpz7b0w822Of+Xpfjtk+pPMWhL/yyJ8YY/XgZe9OlnkAPxtHrpFU/\n\tSzZQ==","X-Gm-Message-State":"AHPjjUh1LHuAbcrFHRy6NpBrQV62IPeIsHn2kTuKfC63bmETRmPQvxAV\n\tpmewJKGHju809OKJ29t4w5XZ3dGMxRxP+IngeUBNBnar","X-Google-Smtp-Source":"AOwi7QA3pfJJ9TIMwiShCq6FAJXsf2iYXUcWnX1hn/tdsqPsT+wWxX7b2A/ho+n0RtgSqzII3xySyR5GF+f94jcbNaw=","X-Received":"by 10.55.17.207 with SMTP id 76mr8136549qkr.178.1506305632424;\n\tSun, 24 Sep 2017 19:13:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920115041.2307-1-klaus.goger@theobroma-systems.com>","References":"<20170920115041.2307-1-klaus.goger@theobroma-systems.com>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:13:31 -0400","X-Google-Sender-Auth":"lKYvWQEj_Xt9CdrfAIHgtLZB2fc","Message-ID":"","To":"Klaus Goger ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH] dm: ofnode: query correct property in livetree\n\tofnode_get_addr_size","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777796,"web_url":"http://patchwork.ozlabs.org/comment/1777796/","msgid":"","list_archive_url":null,"date":"2017-09-29T21:00:29","subject":"Re: [U-Boot] [PATCH] dm: ofnode: query correct property in livetree\n\tofnode_get_addr_size","submitter":{"id":12501,"url":"http://patchwork.ozlabs.org/api/people/12501/","name":"Simon Glass","email":"sjg@google.com"},"content":"On 20 September 2017 at 05:50, Klaus Goger\n wrote:\n> The livetree codepath of ofnode_get_addr_size always used the \"reg\"\n> property for of_get_property. Use the property parameter of the function\n> call instead and check the return value if the property exists.\n> Otherwise return FDT_ADDR_T_NONE.\n>\n> This was discoverd while using SPI NOR with livetree.\n> spi_flash_decode_fdt checks for memory-map and will not fail with\n> livetree even if the property does not exist.\n>\n> Signed-off-by: Klaus Goger \n> Reviewed-by: Philipp Tomsich \n>\n> ---\n>\n> drivers/core/ofnode.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n\nReviewed-by: Simon Glass \n\nApplied to u-boot-dm thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"IDUbH+28\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3kVN6Cmvz9t5l\n\tfor ;\n\tSat, 30 Sep 2017 07:00:43 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8E5B0C21EE7; Fri, 29 Sep 2017 21:00:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 24384C21DAA;\n\tFri, 29 Sep 2017 21:00:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BF6BEC21DAA; Fri, 29 Sep 2017 21:00:32 +0000 (UTC)","from mail-qk0-f179.google.com (mail-qk0-f179.google.com\n\t[209.85.220.179])\n\tby lists.denx.de (Postfix) with ESMTPS id 37DD5C21C26\n\tfor ; Fri, 29 Sep 2017 21:00:32 +0000 (UTC)","by mail-qk0-f179.google.com with SMTP id z143so869019qkb.3\n\tfor ; Fri, 29 Sep 2017 14:00:32 -0700 (PDT)","from 480794996271 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 29 Sep 2017 14:00:29 -0700"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL, T_DKIM_INVALID,\n\tUNPARSEABLE_RELAY autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:from:in-reply-to:references:date:message-id\n\t:subject:to:cc;\n\tbh=lON84P9Vl35Qihebdz8eHnvuemReQtbU0RXbnucNU1Q=;\n\tb=IDUbH+28DHw7ZlMbuI0NmGWOP8vLPlH0WQAzk2KUzYwSeZzhhq5yJoSjw/iArjCmSk\n\tnmnulEEL8triAP0uMl5wKo+tyKh5JxR4QL5Eisjl3jVsIyvksPvpbKf14tPjua5h6ZyC\n\tRZgLiQ3nhuTgQpmhixoExajCtYDschbCY5uEeKGb7VL9hBPOSU9h5+TxYnkUJNP4lJYB\n\t44z8KcW0LG8zv6M0x80t9iaeTHinhowQxKlTZ9tZcVSSWVx+cbN215tGovRCRMIWJa2V\n\tTUBnqeKs2QGzJ18/etk02+1SUGfLl+bimzDltmc09Wc259bVYPsUZQtSz2C5Bf1xl8X5\n\tt5VA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:from:in-reply-to:references\n\t:date:message-id:subject:to:cc;\n\tbh=lON84P9Vl35Qihebdz8eHnvuemReQtbU0RXbnucNU1Q=;\n\tb=Po/5RFI8fw380HfIYI8ZIdMXuBHqtmnkKqbhB9NALaVbFB6bduGeezjtKqV0Lo55w7\n\taWHP7FQ/ss6KjBG0C2l27iszBqHYkGbPDt/Mot9LW74LHa0TdtSfZGxZHtFZmGs6iZ/W\n\tZVIljVy63bEo+OyBK4C0ypCuEbniiARXtvf67NGDcXNmt3ERYxVrbFvpThhZ3RREqixl\n\tsWV8e+SRDh0/ilqpcbTNKVrwuO7ZZ5sQT7aF5fgh7sFhG1Xi9p0y8xkFy2WBfn2oPKMl\n\tH7qoWQBl7eNPEzrpwAe4/K5tgoag23YBilOABRLY1ow6pYPeTxeJXQfZolDvr+PRzDvZ\n\txIAw==","X-Gm-Message-State":"AMCzsaW75YDawiawX0IncOU2VglJAAMrdxAQG3s2geGhWzk3Upbz42WR\n\t4YJ+fXPd4mpJqQPuCSJGywsGkjBBsVo4bhuDCU3FCA==","X-Google-Smtp-Source":"AOwi7QDbu+x95TiYbhnTNLiCyKEeAQsHNsomYiPmgkVP/tk7WsIEQStLV7I8SsELGLWhPSqD9rp2bIu1f6eh8y9gncQ=","X-Received":"by 10.55.215.202 with SMTP id t71mr2179154qkt.188.1506718830688; \n\tFri, 29 Sep 2017 14:00:30 -0700 (PDT)","MIME-Version":"1.0","From":"sjg@google.com","In-Reply-To":"","References":"\n\t<20170920115041.2307-1-klaus.goger@theobroma-systems.com>","Date":"Fri, 29 Sep 2017 14:00:29 -0700","X-Google-Sender-Auth":"vGwsdkKGILPAQr3moZtwm703LQI","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ,\n\tKlaus Goger ","Subject":"Re: [U-Boot] [PATCH] dm: ofnode: query correct property in livetree\n\tofnode_get_addr_size","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]