[{"id":1771812,"web_url":"http://patchwork.ozlabs.org/comment/1771812/","msgid":"<20170920124726.GA26836@leverpostej>","list_archive_url":null,"date":"2017-09-20T12:47:26","subject":"Re: [PATCH v2] bootwrapper: SVE: Enable SVE for EL2 and below","submitter":{"id":8806,"url":"http://patchwork.ozlabs.org/api/people/8806/","name":"Mark Rutland","email":"mark.rutland@arm.com"},"content":"On Wed, Sep 20, 2017 at 01:09:48PM +0100, Dave Martin wrote:\n> By default, SVE will trap to EL3. We also want to make sure that\n> lower ELs have access to the full SVE vector length before dropping\n> down.\n> \n> This patch programs CPTR_EL3 and ZCR_EL3 appropriately to enable\n> SVE for lower exception levels and make sure that they can use the\n> full vector length provided by the hardware.\n> \n> Signed-off-by: Dave Martin \n> Cc: Mark Rutland \n> Cc: Alex Bennée \n\nThis looks fine, builds with my toolchain collection, and I assume\nyou've boot-tested this.\n\nI've pushed this out now.\n\nThanks,\nMark.\n\n> ---\n> \n> This is basically the same as v1 [1], but rebased to an up-to-date\n> bootwrapper tree. (I was previously tracking Catalin's tree, which no\n> longer exists...)\n> \n> [1] [PATCH] bootwrapper: SVE: Enable SVE for EL2 and below\n> http://lists.infradead.org/pipermail/linux-arm-kernel/2017-August/527000.html\n> \n> \n> arch/aarch64/boot.S | 13 +++++++++++++\n> arch/aarch64/include/asm/cpu.h | 5 +++++\n> 2 files changed, 18 insertions(+)\n> \n> diff --git a/arch/aarch64/boot.S b/arch/aarch64/boot.S\n> index ceeee76..f7d795a 100644\n> --- a/arch/aarch64/boot.S\n> +++ b/arch/aarch64/boot.S\n> @@ -45,6 +45,19 @@ _start:\n> \n> \tmsr\tcptr_el3, xzr\t\t\t// Disable copro. traps to EL3\n> \n> +\tmrs\tx0, id_aa64pfr0_el1\n> +\tubfx\tx0, x0, #32, #4\t\t\t// SVE present?\n> +\tcbz\tx0, 1f\t\t\t\t// Skip SVE init if not\n> +\n> +\tmrs\tx0, cptr_el3\n> +\torr\tx0, x0, #CPTR_EL3_EZ\t\t// enable SVE\n> +\tmsr\tcptr_el3, x0\n> +\tisb\n> +\n> +\tmov\tx0, #ZCR_EL3_LEN_MASK\t\t// SVE: Enable full vector len\n> +\tmsr\tZCR_EL3, x0\t\t\t// for EL2.\n> +\n> +1:\n> \tldr\tx0, =CNTFRQ\n> \tmsr\tcntfrq_el0, x0\n> \n> diff --git a/arch/aarch64/include/asm/cpu.h b/arch/aarch64/include/asm/cpu.h\n> index 66726ef..ccb5397 100644\n> --- a/arch/aarch64/include/asm/cpu.h\n> +++ b/arch/aarch64/include/asm/cpu.h\n> @@ -27,6 +27,11 @@\n> #define SPSR_EL2H\t\t(9 << 0)\t/* EL2 Handler mode */\n> #define SPSR_HYP\t\t(0x1a << 0)\t/* M[3:0] = hyp, M[4] = AArch32 */\n> \n> +#define CPTR_EL3_EZ\t\t(1 << 8)\n> +\n> +#define ZCR_EL3\t\t\ts3_6_c1_c2_0\n> +#define ZCR_EL3_LEN_MASK\t0x1ff\n> +\n> #define SCTLR_EL1_CP15BEN\t(1 << 5)\n> #define SCTLR_EL1_RES1\t\t(3 << 28 | 3 << 22 | 1 << 11)\n> \n> -- \n> 2.1.4\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"CclullB/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy01s6tRbz9s7B\n\tfor ;\n\tWed, 20 Sep 2017 22:49:37 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dueRa-0003Wl-CV; Wed, 20 Sep 2017 12:49:34 +0000","from foss.arm.com ([217.140.101.70])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dueRG-0003FC-E5 for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 12:49:31 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1015380D;\n\tWed, 20 Sep 2017 05:48:54 -0700 (PDT)","from leverpostej (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t42A153F578; Wed, 20 Sep 2017 05:48:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7EnDcLbWisSfs+L6m1ZcwUa8OQpwkPcDG2A1eM22d9M=;\n\tb=CclullB/Vn7wKK\n\ttAGJ5riXkTwEz/WbthCgzA54SHSRJgM8ZQaMWaL16JPz1rR7hzbpzMv12Ezdz9ZmU/BAQhPzfOBtk\n\t8mMDykRtnGKlEIyjuADvz9S94Br0g4TJ1K9gHt9kFkxac4F0RKwFDRxiShB2/sMeOpscw8962V2zh\n\tehVpYyWeu88fMG4AzRIqlyX4ETurOrVwZY813N4QTshB9SZuk1k81HmCERR9j3AkPK1TyQPlHdUGw\n\tQxZr748DRgtG5poMfX/bXfC0wEe35oIHB4Mai23HF3F+HheETyyLnYQyXKeBFA44BpiKlZKdEjW4A\n\tAjNZNOwR5uYZEZuRpGcQ==;","Date":"Wed, 20 Sep 2017 13:47:26 +0100","From":"Mark Rutland ","To":"Dave Martin ","Subject":"Re: [PATCH v2] bootwrapper: SVE: Enable SVE for EL2 and below","Message-ID":"<20170920124726.GA26836@leverpostej>","References":"<1505909388-13513-1-git-send-email-Dave.Martin@arm.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505909388-13513-1-git-send-email-Dave.Martin@arm.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_054914_779179_EB4D9AD5 ","X-CRM114-Status":"GOOD ( 13.75 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alex =?utf-8?q?Benn=C3=A9e?= ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]