[{"id":1772430,"web_url":"http://patchwork.ozlabs.org/comment/1772430/","msgid":"<158274cf-a525-eb15-98de-a2e21f221742@canonical.com>","list_archive_url":null,"date":"2017-09-21T05:59:15","subject":"ACK [PATCH 1/3] UBUNTU: SAUCE: opennsl: bcm-knet: check for null\n\tsinfo to avoid a null pointer dereference","submitter":{"id":71819,"url":"http://patchwork.ozlabs.org/api/people/71819/","name":"Juerg Haefliger","email":"juerg.haefliger@canonical.com"},"content":"On 09/20/2017 12:27 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> BugLink: https://launchpad.net/bugs/1718388\n> \n> sinfo can potentially be null, so add a null check to avoid a null\n> pointer deference on sinfo->info_id.\n> \n> Detected by CoverityScan CID#1456902 (\"Dereference before null check\")\n> \n> Signed-off-by: Colin Ian King \n> ---\n> .../systems/linux/kernel/modules/bcm-knet/bcm-knet.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n> index 9dc94b3..9aed5dc 100644\n> --- a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n> +++ b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n> @@ -5605,7 +5605,8 @@ bkn_get_next_dma_event(kcom_msg_dma_info_t *kmsg)\n> sinfo = bkn_sinfo_from_unit(dev_no);\n> }\n> \n> - if ((sinfo->inst_id != 0) && ((sinfo->inst_id & (1 << dev_evt)) == 0)){\n> + if (sinfo && (sinfo->inst_id != 0) &&\n> +\t ((sinfo->inst_id & (1 << dev_evt)) == 0)) {\n> DBG_INST((\" %s skip dev(%d)\\n\",__FUNCTION__,dev_evt));\n> continue;\n> }\n> \n\nAcked-by: Juerg Haefliger ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyQt46BFgz9sNw;\n\tThu, 21 Sep 2017 15:59:24 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1duuW6-0001Vm-Ev; Thu, 21 Sep 2017 05:59:18 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1duuW5-0001VG-J3\n\tfor kernel-team@lists.ubuntu.com; Thu, 21 Sep 2017 05:59:17 +0000","from mail-wr0-f199.google.com ([209.85.128.199])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1duuW5-0008Tn-Bd\n\tfor kernel-team@lists.ubuntu.com; Thu, 21 Sep 2017 05:59:17 +0000","by mail-wr0-f199.google.com with SMTP id w12so5238673wrc.2\n\tfor ;\n\tWed, 20 Sep 2017 22:59:17 -0700 (PDT)","from [192.168.1.99] (adsl-84-227-115-101.adslplus.ch.\n\t[84.227.115.101]) by smtp.gmail.com with ESMTPSA id\n\tz102sm440431ede.85.2017.09.20.22.59.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 22:59:16 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=ohqL2WjCLOqzE/Akf3egnlSRq7mu/MBlTFhSU0iUmoI=;\n\tb=FP6jOkfRS9KjAKNrRrWL8VYiuhudfDA48Hj2QB9bfNPsBlKXEcSt9b1DbHrpTsGUnA\n\t/utYy2fnh5iu9JcUmJO1+MXbAqF2Sdg4l1aX+A52z7kkR/V7z3LxKvvn2PEq6bBV+Un7\n\thTb7SCcO67EbXKpaKpHujr0LJ7ugfb9ZcsszSg8S1P/M2fN5p4ZQxL6ef/7sRRhJyxOJ\n\t9mHxgMEuS5szJB5n9Cup2IQgnOgCbuMIyKfjwNmUygY7r/EsZHxM+2IGAwJhb+rnxJGa\n\tp3GywlUj4+4B9lwhTd705jmajXZiAY3iL4kV3p6Sw3h+7mF9iFgqJK0RSuRMKt+xCcfq\n\tBSBQ==","X-Gm-Message-State":"AHPjjUh0HmjE1E6qe7OOsyv9bqZ1G58LM7cVFtSopjs1oOuX/CoN010V\n\tXI4e+45gFj4NgNtfidMm1uXpM2dRfA+FT+3n1sOQWdtgHXh5gvJ1P9wTnnsFyo8krpzFm+VNykG\n\tei0IxKsNfeWbVD5ouY74yYE4UbwvXIrxNcqjzOwxB3w==","X-Received":["by 10.80.213.211 with SMTP id g19mr1189632edj.277.1505973556893; \n\tWed, 20 Sep 2017 22:59:16 -0700 (PDT)","by 10.80.213.211 with SMTP id g19mr1189623edj.277.1505973556702; \n\tWed, 20 Sep 2017 22:59:16 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QAO6HozQ/39nslxKhMyrfCBYDTOi4eBqxKRFe8u9CNzYzaLXjgnwcyGchhi+i200ehb6TzEKg==","Subject":"ACK [PATCH 1/3] UBUNTU: SAUCE: opennsl: bcm-knet: check for null\n\tsinfo to avoid a null pointer dereference","To":"Colin King , kernel-team@lists.ubuntu.com","References":"<20170920102707.8266-1-colin.king@canonical.com>\n\t<20170920102707.8266-2-colin.king@canonical.com>","From":"Juerg Haefliger ","Message-ID":"<158274cf-a525-eb15-98de-a2e21f221742@canonical.com>","Date":"Thu, 21 Sep 2017 07:59:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170920102707.8266-2-colin.king@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]