[{"id":1772436,"web_url":"http://patchwork.ozlabs.org/comment/1772436/","msgid":"<291b475c-c8ef-c373-e4cc-f05e8ff54994@canonical.com>","list_archive_url":null,"date":"2017-09-21T06:09:58","subject":"ACK [PATCH 2/3] UBUNTU: SAUCE: opennsl: bcm-knet: remove redundant\n\tnull checks on dev->name","submitter":{"id":71819,"url":"http://patchwork.ozlabs.org/api/people/71819/","name":"Juerg Haefliger","email":"juerg.haefliger@canonical.com"},"content":"On 09/20/2017 12:27 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> BugLink: https://launchpad.net/bugs/1718388\n> \n> dev->name is a char array and hence can never be null and so the\n> null checks on dev->name are redundant. Remove them.\n> \n> Detected by CoverityScan CID#1456897, CID#145690 (\"Array compared\n> against 0\")\n> \n> Signed-off-by: Colin Ian King \n> ---\n> .../systems/linux/kernel/modules/bcm-knet/bcm-knet.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n> index 9aed5dc..8f9589f 100644\n> --- a/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n> +++ b/ubuntu/opennsl/OpenNSL/sdk-6.4.10-gpl-modules/systems/linux/kernel/modules/bcm-knet/bcm-knet.c\n> @@ -3786,7 +3786,7 @@ bkn_proc_link_show(struct seq_file *m, void *v)\n> list_for_each(dlist, &sinfo->ndev_list) {\n> priv = (bkn_priv_t *)dlist;\n> dev = priv->dev;\n> - if (dev && dev->name) {\n> + if (dev) {\n> seq_printf(m, \" %-14s %s\\n\", dev->name,\n> netif_carrier_ok(dev) ? \"up\" : \"down\");\n> }\n> @@ -3847,7 +3847,7 @@ bkn_proc_link_write(struct file *file, const char *buf,\n> list_for_each(dlist, &sinfo->ndev_list) {\n> priv = (bkn_priv_t *)dlist;\n> dev = priv->dev;\n> - if (dev && dev->name) {\n> + if (dev) {\n> if (memcmp(dev->name, link_str, len) == 0) {\n> break;\n> }\n> \n\nAcked-by: Juerg Haefliger ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyRGb6Hq5z9t3m;\n\tThu, 21 Sep 2017 16:17:11 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1duunL-0007nm-JY; Thu, 21 Sep 2017 06:17:07 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1duunI-0007hM-Kn\n\tfor kernel-team@lists.ubuntu.com; Thu, 21 Sep 2017 06:17:04 +0000","from mail-wm0-f69.google.com ([74.125.82.69])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1duugS-0001S7-Gp\n\tfor kernel-team@lists.ubuntu.com; Thu, 21 Sep 2017 06:10:00 +0000","by mail-wm0-f69.google.com with SMTP id e64so4827119wmi.0\n\tfor ;\n\tWed, 20 Sep 2017 23:10:00 -0700 (PDT)","from [192.168.1.99] (adsl-84-227-115-101.adslplus.ch.\n\t[84.227.115.101])\n\tby smtp.gmail.com with ESMTPSA id o55sm6752edc.90.2017.09.20.23.09.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 23:09:59 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=aZ+lyLb9QQPp2eRlRLyoFq12kFlk78peRIIgMVsF9Rc=;\n\tb=DMTO8ji9KCH5hbL6FduAP2U8LN5eKuyBd+0faQmDK17PxKQzrF3SqM/pOaoS3HsKWy\n\tx2Jsjox/nhkxuVEKPGqN9v7mU9aIyegJ6DrvdOgg00w4CBPrSh9qp0IAWYG/woZks9b1\n\tecMRY7kvK4oSD3GagFu4J2T6S8/H1Rh0+e0CoIvGB8dZkGYb47UInsK4r9ahJTpsr4bx\n\t4elsPVEUngocRGL2kA9vCSj68FS2stJ+wivjRefk78w5VYIz6i5yp+VDqG5GHSjy40mi\n\tH5x1RRaFa63mhViRaP7SOBLI9payv82+8/nWKpOq9CU9TVx79dFy0CMXQlH3GlX5OHgm\n\t8lAw==","X-Gm-Message-State":"AHPjjUgyGM3PKtEeHoPIbKgA8HFwSYbgv0Ras+tgec/pBrA9snvQ3UI+\n\taRPvf2uuOLbomfIPlzn5fW8ZlXU3JPpYQjyJ4XiHX2bKVc2cy9+cvRiAQhQNDqXicSGsHpaMIYc\n\tkW63VXcvE+WzoJ6D51fAxxFUE/A3IWGnAE/+kUlgD7Q==","X-Received":["by 10.80.240.140 with SMTP id v12mr1273166edl.52.1505974199863; \n\tWed, 20 Sep 2017 23:09:59 -0700 (PDT)","by 10.80.240.140 with SMTP id v12mr1273162edl.52.1505974199693; \n\tWed, 20 Sep 2017 23:09:59 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QBeZAIkEC5uWYGM2JQ1vbM7BwGy2XVqurwdBkp2nYogAgf3iNtalBH8jPOJ4Po93dsoWjwgTA==","Subject":"ACK [PATCH 2/3] UBUNTU: SAUCE: opennsl: bcm-knet: remove redundant\n\tnull checks on dev->name","To":"Colin King , kernel-team@lists.ubuntu.com","References":"<20170920102707.8266-1-colin.king@canonical.com>\n\t<20170920102707.8266-3-colin.king@canonical.com>","From":"Juerg Haefliger ","Message-ID":"<291b475c-c8ef-c373-e4cc-f05e8ff54994@canonical.com>","Date":"Thu, 21 Sep 2017 08:09:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170920102707.8266-3-colin.king@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]