[{"id":1772404,"web_url":"http://patchwork.ozlabs.org/comment/1772404/","msgid":"<87377glkpl.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-21T04:49:42","subject":"Re: [Skiboot] [PATCH 3/3] hdata/smplink: Increment index of\n\tassociated PHB","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Oliver O'Halloran writes:\n> The PHB number of the NPU device needs to be incremented per-chip or bad\n> things are going to occur.\n>\n> Signed-off-by: Oliver O'Halloran \n> ---\n> hdata/spira.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/hdata/spira.c b/hdata/spira.c\n> index 5e3d6ccc05d5..7dc8d5fa061f 100644\n> --- a/hdata/spira.c\n> +++ b/hdata/spira.c\n> @@ -1463,7 +1463,7 @@ static void add_npus(void)\n> \n> \t\t/* some hostboots will give us an empty array */\n> \t\tif (be32_to_cpu(links->ecnt))\n> -\t\t\tadd_npu(xscom, links, npu_index, phb_index);\n> +\t\t\tadd_npu(xscom, links, npu_index, phb_index++);\n> \t}\n\nSeries merged to master as of 577b75727d9ee9d57e1468e52275a7d838bbabf0,\nwith the change discussed on Slack where npu_index++ also","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyPKz1JbVz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 14:49:59 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xyPKz0DMCzDr5G\n\tfor ;\n\tThu, 21 Sep 2017 14:49:59 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xyPKt0Q9rzDqZ4\n\tfor ; Thu, 21 Sep 2017 14:49:53 +1000 (AEST)","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8L4mbge004839\n\tfor ; Thu, 21 Sep 2017 00:49:50 -0400","from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d462f1scs-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 21 Sep 2017 00:49:50 -0400","from localhost\n\tby e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 21 Sep 2017 00:49:49 -0400","from b01cxnp22034.gho.pok.ibm.com (9.57.198.24)\n\tby e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 21 Sep 2017 00:49:47 -0400","from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com\n\t[9.57.199.109])\n\tby b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8L4nktH53084352; Thu, 21 Sep 2017 04:49:46 GMT","from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D692C112047;\n\tThu, 21 Sep 2017 00:49:26 -0400 (EDT)","from birb.localdomain (unknown [9.83.1.138])\n\tby b01ledav004.gho.pok.ibm.com (Postfix) with SMTP id 178A3112034;\n\tThu, 21 Sep 2017 00:49:25 -0400 (EDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid 0B8B14F0F8F; Thu, 21 Sep 2017 14:49:42 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"\"Oliver O'Halloran\" , skiboot@lists.ozlabs.org","In-Reply-To":"<20170920094602.4838-3-oohall@gmail.com>","References":"<20170920094602.4838-1-oohall@gmail.com>\n\t<20170920094602.4838-3-oohall@gmail.com>","Date":"Thu, 21 Sep 2017 14:49:42 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17092104-0052-0000-0000-000002650147","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007770; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000230; SDB=6.00920070; UDB=6.00462291;\n\tIPR=6.00700293; \n\tBA=6.00005599; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017230;\n\tXFM=3.00000015; UTC=2017-09-21 04:49:48","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092104-0053-0000-0000-0000521389EA","Message-Id":"<87377glkpl.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-21_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709210066","Subject":"Re: [Skiboot] [PATCH 3/3] hdata/smplink: Increment index of\n\tassociated PHB","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]