[{"id":1771714,"web_url":"http://patchwork.ozlabs.org/comment/1771714/","msgid":"<20170920095043.GA16198@kroah.com>","list_archive_url":null,"date":"2017-09-20T09:50:43","subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Wed, Sep 20, 2017 at 05:24:41PM +0800, yinbo.zhu@nxp.com wrote:\n> From: \"yinbo.zhu\" \n\nFor some reason I doubt your \"legal name\" has a \".\" in it :(\n\nPlease fix this up, and the same string in the signed-off-by: line, at\nthe least, in order for us to be able to take this patch.\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"QGLdP7kh\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxw5y2xFwz9s03\n\tfor ;\n\tWed, 20 Sep 2017 19:52:54 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dubgX-0007wI-S3; Wed, 20 Sep 2017 09:52:49 +0000","from mail.linuxfoundation.org ([140.211.169.12])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dubeg-0006ML-Ne for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 09:51:30 +0000","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 8F47CB76;\n\tWed, 20 Sep 2017 09:50:32 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=XhURYqEv6z+LnDnrHhrqWkKLPqHm3p1xzmVAtuIlOCY=;\n\tb=QGLdP7kh0Crjur\n\tjqvXAADfh4Cx/YmW6EgDkytw0XAWhDXFuwdp2nif7hSi9YySPafcgJNvOCnDz8F3Qb4rvyle0EkTY\n\tM0TmAGuhxEEiWewVHrSrrk79vBH2/gtgIal4FJtdGTtYGd46FH86bJCP9TMEXjqKXbLU69h1Cqrp2\n\t3Q5V9gLPYae39AmoD1J15+0OTVfxAfmY0R9mPZESrLOfDF8SBkGJHNssGp2tzX8K54E9bUJqa/AXn\n\tZRM/iJFZapodfOWw3UodS8iEsoLipDyF2917BPkB1CbhK5KazIaaLeo7bgm3J9f5CYmZmXZIIW2eK\n\tRroNHx/m2PsbEYKAHd6w==;","Date":"Wed, 20 Sep 2017 11:50:43 +0200","From":"Greg Kroah-Hartman ","To":"yinbo.zhu@nxp.com","Subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","Message-ID":"<20170920095043.GA16198@kroah.com>","References":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_025055_234188_629B991C ","X-CRM114-Status":"UNSURE ( 6.95 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [140.211.169.12 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Felipe Balbi ,\n\tMathias Nyman ,\n\t\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\"\n\t,\n\t\"open list:DESIGNWARE USB3 DRD IP DRIVER\" ,\n\tRussell King ,\n\topen list , \n\tRob Herring ,\n\t\"moderated list:ARM PORT\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771718,"web_url":"http://patchwork.ozlabs.org/comment/1771718/","msgid":"<20170920095312.GB16198@kroah.com>","list_archive_url":null,"date":"2017-09-20T09:53:12","subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Wed, Sep 20, 2017 at 05:24:41PM +0800, yinbo.zhu@nxp.com wrote:\n> From: \"yinbo.zhu\" \n> \n> When a transaction error (defined in Section 4.10.2.3, \"USB\n> Transaction Error\" of the xHCI Specification) occurs on the\n> USB, the host controller reports this through a transfer\n> event with the completion code \"USB Transaction Error\". When\n> this happens, the endpoint is placed in the Halted state.\n> In response, software must issue a Reset Endpoint command to\n> transition the endpoint to the Stopped state. In order to\n> restart the transfer, the driver can perform either of the\n> following:\n> • Ring the doorbell again, which restarts the transfer from\n> where it stopped, or\n> • Issue a Set TR (Transfer Ring) Dequeue Pointer command for\n> the endpoint to start the transfer from a different\n> Transfer Ring pointer Consider the following scenario:\n> 1. The xHCI driver prepares a control transfer read to one\n> of the device's control endpoints;\n> 2. During the IN data stage, a transaction error occurs on\n> the USB, causing a transfer event with the completion\n> code \"USB Transaction Error\";\n> 3. The driver issues a Reset Endpoint command;\n> 4. The driver rings the doorbell of the control endpoint to\n> resume the transfer. In this scenario, the controller\n> may reverse the direction of the data stage from IN to OUT.\n> Instead of sending an ACK to the endpoint to poll for read\n> data, it sends a Data Packet (DP) to the endpoint. It\n> fetches the data from the data stage Transfer Request Block\n> (TRB) that is being resumed, even though the data buffer is\n> setup to receive data and not transmit it.\n> NOTE\n> This issue occurs only if the transaction error happens during\n> an IN data stage. There is no issue if the transaction error\n> happens during an OUT data stage.\n> \n> Impact: When this issue occurs, the device likely responds in\n> one of the following ways:\n> • The device responds with a STALL because the data stage has\n> unexpectedly changed directions. The controller then generates\n> a Stall Error transfer event, to which software must issue a\n> Reset Endpoint command followed by a Set TR Dequeue Pointer\n> command pointing to a new Setup TRB to clear the STALL condition.\n> • The device does not respond to the inverted data stage and the\n> transaction times out. The controller generates another USB\n> Transaction Error transfer event, to which software likely\n> performs a USB Reset to the device because it is unresponsive.\n> It is not expected that any of these recovery steps will cause\n> instability in the system because this recovery is part of a\n> standard xHCI driver and could happen regardless of the defect.\n> Another possible system-level impact is that the controller\n> attempts to read from the memory location pointed at by the Data\n> Stage TRB or a Normal TRB chained to it. associated with this\n> TRB is intended to be written by the controller, but the\n> controller reads from it instead. Normally, this does not cause\n> a problem. However, if the system has some type of memory\n> protection where this unexpected read is treated as a bus error,\n> it may cause the system to become unstable or to crash.\n> \n> Workaround: If a USB Transaction Error occurs during the IN\n> data phase of a control transfer, the driver must use the\n> Set TR Dequeue Pointer command to either restart the data\n> phase or restart the entire control transfer from the\n> Setup phase.\n> \n> Configs Affected:\n> LS1021-20-22A-R1.0, LS1021-20-22A-R2.007463\n\nWhat does this reference?\n\nSame for the subject: line, I don't know what that means.\n\n> Signed-off-by: yinbo.zhu \n> ---\n> arch/arm/boot/dts/ls1021a.dtsi | 1 +\n> drivers/usb/dwc3/core.c | 2 ++\n> drivers/usb/dwc3/core.h | 2 ++\n> drivers/usb/dwc3/host.c | 2 ++\n> drivers/usb/host/xhci-plat.c | 3 +++\n> drivers/usb/host/xhci-ring.c | 28 +++++++++++++++++++++++-----\n> drivers/usb/host/xhci.h | 3 ++-\n> 7 files changed, 35 insertions(+), 6 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi\n> index 7bb9df2c1460..9f76b2b82dce 100644\n> --- a/arch/arm/boot/dts/ls1021a.dtsi\n> +++ b/arch/arm/boot/dts/ls1021a.dtsi\n> @@ -683,6 +683,7 @@\n> \t\t\tdr_mode = \"host\";\n> \t\t\tsnps,quirk-frame-length-adjustment = <0x20>;\n> \t\t\tsnps,dis_rxdet_inp3_quirk;\n> +\t\t\tsnps,quirk_reverse_in_out;\n\nDoesn't that value have to be added to some other DT documentation file?\n\n> -\t\t/* Issue a reset endpoint command to clear the host side\n> -\t\t * halt, followed by a set dequeue command to move the\n> -\t\t * dequeue pointer past the TD.\n> -\t\t * The class driver clears the device side halt later.\n> +\t\t/*\n> +\t\t * A-007463: After transaction error, controller switches\n> +\t\t * control transfer data stage from IN to OUT direction.\n> \t\t */\n\nWhat does A-007463 refer to?\n\n> --- a/drivers/usb/host/xhci.h\n> +++ b/drivers/usb/host/xhci.h\n> @@ -1780,7 +1780,7 @@ struct xhci_hcd {\n> #define XHCI_STATE_DYING\t(1 << 0)\n> #define XHCI_STATE_HALTED\t(1 << 1)\n> #define XHCI_STATE_REMOVING\t(1 << 2)\n> -\tunsigned int\t\tquirks;\n> +\tu64 quirks;\n\nWhy change this to a u64?\n\nthanks,\n\ngreg k-h","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"e6WKI92q\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxw7n5mWfz9s03\n\tfor ;\n\tWed, 20 Sep 2017 19:54:29 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dubi5-0000OY-8k; Wed, 20 Sep 2017 09:54:25 +0000","from mail.linuxfoundation.org ([140.211.169.12])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dubh4-00086E-5w for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 09:54:22 +0000","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 5B164B76;\n\tWed, 20 Sep 2017 09:53:01 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Oe9HIvU32A2rwqYXXpeb5KrmKsJT9zvW/5Fyusqh5vE=;\n\tb=e6WKI92qGoLkuS\n\tePUd/yF5q12s7dFzO59uSoIuBYPFxVDEiTfqa218Uap+I1GBhCBLT+AKstlDP81ZSM4Qwc4sVwlFp\n\t8mjH7i/LpQ7p92tMzDvHOWma6fc643l50Y/RRnR6qDzlsPUUW3EMup07Y7hMBjwJoMn0BXjJbbuDw\n\tQmr236opznG0pA1La9Y6qdrQdhI1+5RVhJD9N5aRY+tpOMKj5re4e7HiFsZY6es2/tHXM7yAYbPBp\n\tmoykqesBSO6F8I9bvjLLM+u4ie0RthEYr3eKyS0Bocdd8wprmhzX0+Eyi7HGs+DpWjGtCaIjcddXq\n\t+MtyakmmnIofRB5FiTvA==;","Date":"Wed, 20 Sep 2017 11:53:12 +0200","From":"Greg Kroah-Hartman ","To":"yinbo.zhu@nxp.com","Subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","Message-ID":"<20170920095312.GB16198@kroah.com>","References":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_025324_528313_BA3ED64E ","X-CRM114-Status":"GOOD ( 27.13 )","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [140.211.169.12 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Felipe Balbi ,\n\tMathias Nyman ,\n\t\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\"\n\t,\n\t\"open list:DESIGNWARE USB3 DRD IP DRIVER\" ,\n\tRussell King ,\n\topen list , \n\tRob Herring ,\n\t\"moderated list:ARM PORT\" ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771815,"web_url":"http://patchwork.ozlabs.org/comment/1771815/","msgid":"<59C265B1.6020909@linux.intel.com>","list_archive_url":null,"date":"2017-09-20T12:57:21","subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","submitter":{"id":63937,"url":"http://patchwork.ozlabs.org/api/people/63937/","name":"Mathias Nyman","email":"mathias.nyman@linux.intel.com"},"content":"On 20.09.2017 12:24, yinbo.zhu@nxp.com wrote:\n> From: \"yinbo.zhu\" \n>\n> When a transaction error (defined in Section 4.10.2.3, \"USB\n> Transaction Error\" of the xHCI Specification) occurs on the\n> USB, the host controller reports this through a transfer\n> event with the completion code \"USB Transaction Error\". When\n> this happens, the endpoint is placed in the Halted state.\n> In response, software must issue a Reset Endpoint command to\n> transition the endpoint to the Stopped state. In order to\n> restart the transfer, the driver can perform either of the\n> following:\n> • Ring the doorbell again, which restarts the transfer from\n> where it stopped, or\n> • Issue a Set TR (Transfer Ring) Dequeue Pointer command for\n> the endpoint to start the transfer from a different\n> Transfer Ring pointer Consider the following scenario:\n> 1. The xHCI driver prepares a control transfer read to one\n> of the device's control endpoints;\n> 2. During the IN data stage, a transaction error occurs on\n> the USB, causing a transfer event with the completion\n> code \"USB Transaction Error\";\n> 3. The driver issues a Reset Endpoint command;\n> 4. The driver rings the doorbell of the control endpoint to\n> resume the transfer. In this scenario, the controller\n> may reverse the direction of the data stage from IN to OUT.\n> Instead of sending an ACK to the endpoint to poll for read\n> data, it sends a Data Packet (DP) to the endpoint. It\n> fetches the data from the data stage Transfer Request Block\n> (TRB) that is being resumed, even though the data buffer is\n> setup to receive data and not transmit it.\n\nSound very odd,\nCan you check the xhci side if the data stage TRB in the control\nendpoint ring still looks valid after endpoint reset?\nThat is, make sure that the data stage TRB still has DIR bit 16 set.\n\nIf something zeroed that TRB then the DIR bit it would be set to 0\nwhich means DIR OUT.\nReset endpoint command forces xHC hardware to re-read the TRB from\nmemory (i.e. the endpoint ring).\nzeroing the trb could happen for example if the TRB gets turned\ninto a no-op.\n\n> NOTE\n> This issue occurs only if the transaction error happens during\n> an IN data stage. There is no issue if the transaction error\n> happens during an OUT data stage.\n>\n> Impact: When this issue occurs, the device likely responds in\n> one of the following ways:\n> • The device responds with a STALL because the data stage has\n> unexpectedly changed directions. The controller then generates\n> a Stall Error transfer event, to which software must issue a\n> Reset Endpoint command followed by a Set TR Dequeue Pointer\n> command pointing to a new Setup TRB to clear the STALL condition.\n> • The device does not respond to the inverted data stage and the\n> transaction times out. The controller generates another USB\n> Transaction Error transfer event, to which software likely\n> performs a USB Reset to the device because it is unresponsive.\n> It is not expected that any of these recovery steps will cause\n> instability in the system because this recovery is part of a\n> standard xHCI driver and could happen regardless of the defect.\n> Another possible system-level impact is that the controller\n> attempts to read from the memory location pointed at by the Data\n> Stage TRB or a Normal TRB chained to it. associated with this\n> TRB is intended to be written by the controller, but the\n> controller reads from it instead. Normally, this does not cause\n> a problem. However, if the system has some type of memory\n> protection where this unexpected read is treated as a bus error,\n> it may cause the system to become unstable or to crash.\n>\n> Workaround: If a USB Transaction Error occurs during the IN\n> data phase of a control transfer, the driver must use the\n> Set TR Dequeue Pointer command to either restart the data\n> phase or restart the entire control transfer from the\n> Setup phase.\n\n\nThis is already the intended workflow.\nWe should already queue a new Set TR Dequeue pointer if\nwe receive a transaction error on the TD the xHC is processing.\nthe whole control transfer (SETUP, DATA and STATUS) is one TD.\n\ncode flow when we receive a TRANSACTION_ERROR in finish_td:\n\nxhci_requires_manual_halt_endpoint() // true due to transaction error\n xhci_cleanup_halted_endpoint(EP_HARD_RESET);\n ep->ep_state |= EP_HALTED;\n xhci_queue_reset_ep();\n xhci_cleanup_stalled_ring();\n xhci_find_new_dequeue_state()\n xhci_queue_new_dequeue_state()\n\nwhat your code does different is that it skips the reset endpoint command.\n\nIt's also possible this is toggle/sequence number issue,\nyou could try issuing a EP_SOFT_RESET endpoint reset instead.\n\n-Mathias","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"EWIf2zOq\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0770gYNz9s7B\n\tfor ;\n\tWed, 20 Sep 2017 22:54:11 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dueW0-0005pO-1P; Wed, 20 Sep 2017 12:54:08 +0000","from mga14.intel.com ([192.55.52.115])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dueVv-0005lr-PJ for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 12:54:05 +0000","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2017 05:53:39 -0700","from mattu-haswell.fi.intel.com (HELO [10.237.72.164])\n\t([10.237.72.164])\n\tby fmsmga001.fm.intel.com with ESMTP; 20 Sep 2017 05:53:37 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=i9JzTiwQLhz9pz4whitbClWST1QJ5dI9KFAW3XAY9+g=;\n\tb=EWIf2zOqDZLV+X9RXBih9R/nF\n\tPVaRNIAwRL5kGt5q7K5r5tQdIdDi4Q+xDILrlaJJHzYyoZaYQbQusYsdPMrRvO++9GQN4rZO8tXUi\n\t2U9AibHA+afJnR16qW2l4vk7V/1/6xDp3/rSQfLCTdTbfwTNyjfHATrep9TYZZ7gaD9i9PC7CEUmT\n\toJqAVZE/E8mH29SMyFxynaNV9Pyl4A3jRLe0CFqtRmkR0gQPXQE9PGTTPfyjiYdLAlQEpOn2hkNgD\n\t+cEsspMXbMzrmVszAUTs3a8Y0mrnz3CDu3kQx65OTp8B8wuiNVJvCXEw6GlIwmNqNDbFGYucpmJ0h\n\tF1sLwkdCA==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,421,1500966000\"; d=\"scan'208\";\n\ta=\"1197159376\"","Subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","To":"yinbo.zhu@nxp.com, Rob Herring ,\n\tMark Rutland ,\n\tRussell King , Felipe Balbi ","References":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","From":"Mathias Nyman ","Message-ID":"<59C265B1.6020909@linux.intel.com>","Date":"Wed, 20 Sep 2017 15:57:21 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.8.0","MIME-Version":"1.0","In-Reply-To":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_055403_882640_40EE51B2 ","X-CRM114-Status":"GOOD ( 26.50 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [192.55.52.115 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\"\n\t, Mathias Nyman ,\n\tGreg Kroah-Hartman ,\n\t\"open list:DESIGNWARE USB3 DRD IP DRIVER\" ,\n\topen list ,\n\t\"moderated list:ARM PORT\" ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771895,"web_url":"http://patchwork.ozlabs.org/comment/1771895/","msgid":"","list_archive_url":null,"date":"2017-09-20T14:07:13","subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","submitter":{"id":60,"url":"http://patchwork.ozlabs.org/api/people/60/","name":"Alan Stern","email":"stern@rowland.harvard.edu"},"content":"The Subject: line should specify which type of USB host controller the\npatch is for. The kernel contains lots of different USB host\ncontroller drivers. How are we supposed to know that Erratum A-007463\napplies to dwc3 xHCI controllers?\n\nThe Subject: line should say something like:\n\n[PATCH v1] USB: host: dwc3: Implement workaround for Erratum A-007643\n\nAlan Stern","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"Cu42Cvrb\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy1m113w5z9s82\n\tfor ;\n\tThu, 21 Sep 2017 00:07:45 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duffB-0006jJ-Qn; Wed, 20 Sep 2017 14:07:41 +0000","from iolanthe.rowland.org ([192.131.102.54])\n\tby bombadil.infradead.org with smtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duff8-0006eW-D0 for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 14:07:40 +0000","(qmail 1686 invoked by uid 2102); 20 Sep 2017 10:07:13 -0400","from localhost (sendmail-bs@127.0.0.1)\n\tby localhost with SMTP; 20 Sep 2017 10:07:13 -0400"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:\n\tSubject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:\n\tList-Owner; bh=IquMe09P+XRNGVJpMndIDEGNOEBmIkdeI4u7C/QM+i8=;\n\tb=Cu42CvrbJfEzh8\n\t5S+uf0YE9UDQmZEUTkw03Jt3cdDPUGXaa8BJ8O8lG7bLQ1A0ghEHz98UtyWJizp8jBuliDhRVdi2N\n\tdJQvykEXaWtWJgLw3lQNTAZay0ihRSeEXO3CCfRV4hIA+GxV+EkSD5+A/hd1HXs7YO633jrUbnhqv\n\t3jZP05ZwT5C6dYBAJYy9YvTh9lBY4RPdYpFuVhj8YardWcYOQ9gVeh1RgH+4VH+So147J5t6zbCZJ\n\t6ThyXXBK71TbNs/d+1STRj33BFHcURdVNmxkYabB9kz1LgGeGQJ1Qx56jpGs8Dsb1EqkGrRXNkXd6\n\txCJZHpDDI3I2krdYO/RA==;","Date":"Wed, 20 Sep 2017 10:07:13 -0400 (EDT)","From":"Alan Stern ","X-X-Sender":"stern@iolanthe.rowland.org","To":"yinbo.zhu@nxp.com","Subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","In-Reply-To":"<20170920092441.21292-1-yinbo.zhu@nxp.com>","Message-ID":"","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_070738_664660_C5BB2768 ","X-CRM114-Status":"UNSURE ( 3.49 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Felipe Balbi ,\n\tMathias Nyman ,\n\t\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\"\n\t,\n\tGreg Kroah-Hartman , \n\t\"open list:DESIGNWARE USB3 DRD IP DRIVER\" ,\n\tRussell King ,\n\topen list , \n\tRob Herring ,\n\t\"moderated list:ARM PORT\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1772451,"web_url":"http://patchwork.ozlabs.org/comment/1772451/","msgid":"<87fubg4kf0.fsf@linux.intel.com>","list_archive_url":null,"date":"2017-09-21T06:48:03","subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","submitter":{"id":68254,"url":"http://patchwork.ozlabs.org/api/people/68254/","name":"Felipe Balbi","email":"balbi@kernel.org"},"content":"Hi,\n\nAlan Stern writes:\n\n> The Subject: line should specify which type of USB host controller the\n> patch is for. The kernel contains lots of different USB host\n> controller drivers. How are we supposed to know that Erratum A-007463\n> applies to dwc3 xHCI controllers?\n>\n> The Subject: line should say something like:\n>\n> [PATCH v1] USB: host: dwc3: Implement workaround for Erratum A-007643\n\nIf we're talking about a dwc3 implementation, we need a quirk flag on\ndwc3 core to be passed down to the xhci-plat device, like every other\nquirk on this controller.\n\nI also need a reference to SNPS stars ticket that talks about this problem.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"IDsdIGTc\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyRz35NgRz9s03\n\tfor ;\n\tThu, 21 Sep 2017 16:48:47 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duvHu-0001Yw-BR; Thu, 21 Sep 2017 06:48:42 +0000","from mga05.intel.com ([192.55.52.43])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duvHq-0001Ro-Cf for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 06:48:40 +0000","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP; 20 Sep 2017 23:48:17 -0700","from pipin.fi.intel.com (HELO localhost) ([10.237.68.37])\n\tby orsmga003.jf.intel.com with ESMTP; 20 Sep 2017 23:48:14 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=bWp2jOJNrucqq/k3+8rCsbFMfjQCVE5XQSPXnoBRP4k=;\n\tb=IDsdIGTcW9T+gr\n\tlHFNia3/Cbg+3zckybYooLEiTfyGAtMoJwn5IDMhcXynh1qpeJ0AD/qAeSwlMsiNDYwHTbFI2dkhb\n\tHOy7uw35OGBQ0gqfMqYqbAY9Yz5CacD77n6ydbkCkin6LvP7qMfd8zH7Aigdn3D72x2tZXUhZzYvO\n\tNzZTWdHNRisbrmCTDl0iofjoVJl/C0cPcfZdZ9W30mhHHoCFfGgAsnMcNn6iorsPIrm+ErcXR7L4E\n\tuBsQGodKbf/COQmi4zMdl0GDJMNtw5rF77q1SsIzxtB68jl/QoQ0Xf8fDFeRXj2oREn8QzQe0X7hh\n\tHB07dsFAUtdAu+6YfMTA==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,424,1500966000\"; d=\"scan'208\";\n\ta=\"1016871529\"","From":"Felipe Balbi ","To":"Alan Stern , yinbo.zhu@nxp.com","Subject":"Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463","In-Reply-To":"","References":"","Date":"Thu, 21 Sep 2017 09:48:03 +0300","Message-ID":"<87fubg4kf0.fsf@linux.intel.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_234838_591175_D2454567 ","X-CRM114-Status":"UNSURE ( 5.49 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [192.55.52.43 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland ,\n\t\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\"\n\t, Mathias Nyman ,\n\tGreg Kroah-Hartman ,\n\t\"open list:DESIGNWARE USB3 DRD IP DRIVER\" ,\n\tRussell King ,\n\topen list , \n\tRob Herring ,\n\t\"moderated list:ARM PORT\" ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]