[{"id":1772390,"web_url":"http://patchwork.ozlabs.org/comment/1772390/","msgid":"","list_archive_url":null,"date":"2017-09-21T03:24:52","subject":"Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf","submitter":{"id":62738,"url":"http://patchwork.ozlabs.org/api/people/62738/","name":"Gregory Fong","email":"gregory.0xf0@gmail.com"},"content":"On Wed, Sep 20, 2017 at 12:13 AM, Arvind Yadav\n wrote:\n> devm_kasprintf() can fail here and we must check its return value.\n>\n> Signed-off-by: Arvind Yadav \n> ---\n> drivers/gpio/gpio-brcmstb.c | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c\n> index dd0308c..1227d6e 100644\n> --- a/drivers/gpio/gpio-brcmstb.c\n> +++ b/drivers/gpio/gpio-brcmstb.c\n> @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)\n> gc->of_node = np;\n> gc->owner = THIS_MODULE;\n> gc->label = devm_kasprintf(dev, GFP_KERNEL, \"%pOF\", dev->of_node);\n> + if (!gc->label)\n> + goto fail;\n\nPlease also set err to -ENOMEM.\n\n> +\n> gc->base = gpio_base;\n> gc->of_gpio_n_cells = 2;\n> gc->of_xlate = brcmstb_gpio_of_xlate;\n> --\n> 1.9.1\n>\n\nThanks,\nGregory\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jDKF3Eel\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyMSR1sbzz9sBZ\n\tfor ;\n\tThu, 21 Sep 2017 13:25:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751343AbdIUDZZ (ORCPT );\n\tWed, 20 Sep 2017 23:25:25 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:35236 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751283AbdIUDZY (ORCPT\n\t); Wed, 20 Sep 2017 23:25:24 -0400","by mail-wr0-f195.google.com with SMTP id n64so2421210wrb.2;\n\tWed, 20 Sep 2017 20:25:23 -0700 (PDT)","by 10.28.175.197 with HTTP; Wed, 20 Sep 2017 20:24:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4YkvEeEobi6Nf41Yr9GzUzMxFBMK/I6xU/F2qInjR2A=;\n\tb=jDKF3EelzmFBUf60F+oH7LZM+xgn41gdROLe1onoUekQpe8ZYp8gxX4wLm3afdG62j\n\tIqTLS4gHeQRm88pMGUcYwcLu0YlgxWc4plBb/Eg/6rTfi7h4Qw7nRe9T6cHb2JUIbHnR\n\thKLolVCUEvix08afi/DzUZmZgsWcfoQytRVao0th0mQrNqLj7o38Y1TVcOW6DsL1BLwF\n\thrXXnr9lCeelya7z12l85VWTqhLwjw8s159kaCXv1n84axPnz6gboVjA7EXZNFszRThD\n\teSpOPdh6Edrr6bp01Wn2S8HYkQrVYGK1r3PFoEaktTrdqAPZGNz/Gl61V0/NqPdhsCdy\n\tP38g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4YkvEeEobi6Nf41Yr9GzUzMxFBMK/I6xU/F2qInjR2A=;\n\tb=Df5UM6lf0XOLdwYkmgFuNBvu7MKunSYhIcJFmKbKw6M8wMg79PvcpYzOxch0LHgagB\n\ti6iZ8ZV5JBoeBTNTzJ5TSo5J1TzYUVDAksWAejEu7DovICPJSAW0AzO0ffWU9aGJeHyi\n\tqoirO4HIZm8WNcfFv/8OdtRzGL6SCqp4h/MbC0sS5JEYGzoVPn311tv5SiProgHjXyyr\n\tOu5M+/kgz2zuZQfZieHjNb0aJSpuNzx5GTJ470pOwzsVtHzM/5ekYpfC2F1BXp5qXJvP\n\tX+RtwbN4NsqtagogPWb2jwsir9oBctbbhI3T/wciS5tgaogW8xB6SEzY2dbq8yH171kq\n\tEisw==","X-Gm-Message-State":"AHPjjUjKibbXfiHTUQ2djXxv4IDBQohxnurpfQ9BdATU7RdnA5hmdTft\n\tTikZSlaScFbkNuOAnjl3K6o79bSObt8oiePshT5AWQ==","X-Google-Smtp-Source":"AOwi7QAewEPpcsm778csWz6qA6GqKJ9fBhJgz1JqUWz/bF6hCWmrWHCqTM2sK8kYv0r9W4jRbIkDRvuZdiU2SAMLYF8=","X-Received":"by 10.223.165.29 with SMTP id i29mr499525wrb.163.1505964323111; \n\tWed, 20 Sep 2017 20:25:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com>","References":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>\n\t<1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com>","From":"Gregory Fong ","Date":"Wed, 20 Sep 2017 20:24:52 -0700","Message-ID":"","Subject":"Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf","To":"Arvind Yadav ","Cc":"Linus Walleij ,\n\tBrian Norris ,\n\tFlorian Fainelli ,\n\tbcm-kernel-feedback-list ,\n\tlinux-gpio@vger.kernel.org, \"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]