[{"id":1782371,"web_url":"http://patchwork.ozlabs.org/comment/1782371/","msgid":"<1507510072.5452.151.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-09T00:47:52","subject":"Re: [Qemu-devel] [PATCH v2 6/6] aspeed: add the pc9552 chips to the\n\twitherspoon machine","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n> The pca9552 LED blinkers on the Witherspoon machine are used for leds\n> but also as GPIOs to control fans and GPUs.\n> \n> Signed-off-by: Cédric Le Goater \n\nReviewed-by: Andrew Jeffery \n\n> ---\n>  hw/arm/aspeed.c | 4 ++++\n>  1 file changed, 4 insertions(+)\n> \n> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n> index 462f8008cff5..2ae46d71bff7 100644\n> --- a/hw/arm/aspeed.c\n> +++ b/hw/arm/aspeed.c\n> @@ -379,6 +379,8 @@ static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>      AspeedSoCState *soc = &bmc->soc;\n>      uint8_t *eeprom_buf = g_malloc0(8 * 1024);\n>  \n> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 3), \"pca9552\", 0x60);\n> +\n>      i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n>      i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n>  \n> @@ -390,6 +392,8 @@ static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>  \n>      smbus_eeprom_init_one(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), 0x51,\n>                            eeprom_buf);\n> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 11), \"pca9552\",\n> +                     0x60);\n>  }\n>  \n>  static void witherspoon_bmc_init(MachineState *machine)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"T2jGdMMk\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"B+9+eKXm\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9M720XjXz9t2d\n\tfor ;\n\tMon, 9 Oct 2017 11:48:30 +1100 (AEDT)","from localhost ([::1]:55620 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1MFA-00083E-6G\n\tfor incoming@patchwork.ozlabs.org; Sun, 08 Oct 2017 20:48:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49155)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1MEn-000822-FM\n\tfor qemu-devel@nongnu.org; Sun, 08 Oct 2017 20:48:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1MEm-0000Bv-Kx\n\tfor qemu-devel@nongnu.org; Sun, 08 Oct 2017 20:48:05 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:51345)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1MEi-00008a-6v; Sun, 08 Oct 2017 20:48:00 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id CA49E209D5;\n\tSun, 8 Oct 2017 20:47:59 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Sun, 08 Oct 2017 20:47:59 -0400","from keelia (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 61880247DD;\n\tSun, 8 Oct 2017 20:47:56 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=lUoJobJOVPlBIEzSONLObqz+el6U0GsS96+GPPHzY\n\tUw=; b=T2jGdMMkN9iRTWe/WMAIO7mPBkUdD2R9FXcPd1FFv8zT+wIyfybMlaoGw\n\tG7G3W2aZWTnNun3HtgPgvP45N4zfopmEMNf1XnqZ9BjOeGxHT+Pnyohw41cS4PoR\n\tbXNgfTjp7Q3MRpYFFBecgB5uMdGsUrliqKBknWMt//n3hrIdmxjLt6oZqHhPNQLL\n\tdi0OXxk7Rtb290dMWWWB856IAcPlb73I8DJkf0uhKAm1NRZbM5HqmKtFvpJy77YS\n\tch/ksfAp8wcBtmnlRJMmX5xwG9dTFX4RwSGcq6kMO5RgRGq8KOw/1Patni0FGora\n\t/QZLjDJLxWVX7Yj7DyUT1OyNsiMew==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=lUoJobJOVPlBIEzSON\n\tLObqz+el6U0GsS96+GPPHzYUw=; b=B+9+eKXmD5JkM63fZ1gZWPCy8BUdW8ZXMI\n\tryOUQIY5N43mVPanL0XTkym4H0BZtRClCvkKZ2DQ8allRL15R3FUSda0D9E13dpA\n\tilieOTxz3kA9+Xh9ZzaXLV3FgyVsorbYTN3nBoUCuWWjFWh2o1dovbM91+s31neX\n\tbgBZgwARivwxoJp4pfFsSwls1Ld2G/yoe6JbuOAhBt3Ap+VBVb590eGlbEUMCi2s\n\t0p0HacgBEw7mCYr4Qh024mXNqj96u1+v6YtGhgCa5tkGnoqhsg6rkPE+foHfcLgw\n\tJDrlrIhIS30HBEWMGIxkA/igibmTThyZLcKpIMF8auHJQPJ/TyXg=="],"X-ME-Sender":"","X-Sasl-enc":"CzndMjGuqUIS8vdo3+Eg8yVNLKitpxee/hRBqKv4zrlc 1507510078","Message-ID":"<1507510072.5452.151.camel@aj.id.au>","From":"Andrew Jeffery ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater , Peter Maydell\n\t","Date":"Mon, 09 Oct 2017 11:17:52 +1030","In-Reply-To":"<20170920070135.31379-7-clg@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-7-clg@kaod.org>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-eTx3SJYtBYAbjZOoBSKH\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH v2 6/6] aspeed: add the pc9552 chips to the\n\twitherspoon machine","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tqemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]