[{"id":1781715,"web_url":"http://patchwork.ozlabs.org/comment/1781715/","msgid":"","list_archive_url":null,"date":"2017-10-06T15:10:20","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 20 September 2017 at 08:01, Cédric Le Goater wrote:\n> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n> Let's add support for their BMC including a couple of I2C devices as\n> found on real HW.\n>\n> Signed-off-by: Cédric Le Goater \n> ---\n> hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 49 insertions(+)\n>\n> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n> index ab895ad490af..81f522f711ae 100644\n> --- a/hw/arm/aspeed.c\n> +++ b/hw/arm/aspeed.c\n> @@ -46,6 +46,7 @@ enum {\n> PALMETTO_BMC,\n> AST2500_EVB,\n> ROMULUS_BMC,\n> + WITHERSPOON_BMC,\n> };\n>\n> /* Palmetto hardware value: 0x120CE416 */\n> @@ -83,8 +84,12 @@ enum {\n> SCU_AST2500_HW_STRAP_ACPI_ENABLE | \\\n> SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n>\n> +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n> +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n> +\n> static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n> static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n>\n> static const AspeedBoardConfig aspeed_boards[] = {\n> [PALMETTO_BMC] = {\n> @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n> .spi_model = \"mx66l1g45g\",\n> .num_cs = 2,\n> },\n> + [WITHERSPOON_BMC] = {\n> + .soc_name = \"ast2500-a1\",\n> + .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n> + .fmc_model = \"mx25l25635e\",\n> + .spi_model = \"mx66l1g45g\",\n> + .num_cs = 2,\n> + .i2c_init = witherspoon_bmc_i2c_init,\n> + },\n> };\n>\n> #define FIRMWARE_ADDR 0x0\n> @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n> .class_init = romulus_bmc_class_init,\n> };\n>\n> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n> +{\n> + AspeedSoCState *soc = &bmc->soc;\n> +\n> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n> +\n> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n> +}\n> +\n> +static void witherspoon_bmc_init(MachineState *machine)\n> +{\n> + aspeed_board_init(machine, &aspeed_boards[WITHERSPOON_BMC]);\n> +}\n> +\n> +static void witherspoon_bmc_class_init(ObjectClass *oc, void *data)\n> +{\n> + MachineClass *mc = MACHINE_CLASS(oc);\n> +\n> + mc->desc = \"OpenPOWER Witherspoon BMC (ARM1176)\";\n> + mc->init = witherspoon_bmc_init;\n> + mc->max_cpus = 1;\n> + mc->no_sdcard = 1;\n> + mc->no_floppy = 1;\n> + mc->no_cdrom = 1;\n> + mc->no_parallel = 1;\n> + mc->ignore_memory_transaction_failures = true;\n\nPlease don't set this flag for new board models, it is only\nfor our legacy existing ones. Instead implement any devices\nthat you need for guest code to boot (stub them out with\ncreate_unimplemented_device() if you like).\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DrjuhTDb\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7tPm4crMz9sMN\n\tfor ;\n\tSat, 7 Oct 2017 02:11:08 +1100 (AEDT)","from localhost ([::1]:45410 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0UHK-0000zZ-Ou\n\tfor incoming@patchwork.ozlabs.org; Fri, 06 Oct 2017 11:11:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37588)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e0UGx-0000xL-7d\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:10:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e0UGw-0002jE-5v\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:10:43 -0400","from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:57078)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e0UGv-0002hv-VM\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:10:42 -0400","by mail-wr0-x232.google.com with SMTP id r79so7896882wrb.13\n\tfor ; Fri, 06 Oct 2017 08:10:41 -0700 (PDT)","by 10.223.128.207 with HTTP; Fri, 6 Oct 2017 08:10:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=eFr22qtis9lHtauhPvrRwMJACbMnNF7db50e1Mn7a+c=;\n\tb=DrjuhTDb6Btmx4bmT+31diyzdJuT7tbLrXPBRIEvhjxa7kz8jsTlxV0iHiDdpGdTJW\n\tSWrOUqlaksEdoG4BirMLlPHegiYLzYDjOV+OlvpIMe3QAgMGrkOWG8x2hzBPBJ+etGa+\n\t+r0zw5eG5+IIhM0+g/FTYrQiR19GyKj+iwsuI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=eFr22qtis9lHtauhPvrRwMJACbMnNF7db50e1Mn7a+c=;\n\tb=iUe5m7ZEnAL5koF6VLmlA/+81IbDBSydENeicgZjuah6UoLZj11N4AofqZuBqsHVuo\n\tp8C84lc7edRvmVucA0bMBRCx3gl+5GsD8+t32dYYUZolxM+AK09mNJ3Zq9iPzE1YFZBF\n\tDkJyjUEOMErpn2ALuQ/vk6tsway9KD7EGhbX5qcBLAw4X+I0bVbPzuzJ0X7Z9J2Baj1C\n\te6i5wGtq/yod47D/0VwB6EZI0/Jg9nM97bu2vfCBa6g+krw4qESmR63sYnpFj7Jn4Sep\n\to7N3ouG1hsTwd/D3nawIGevgCkZB99FssR2hK3cUK+zXgEtJxqWyhF+rAo9KQJ+Sg6OQ\n\tWpGw==","X-Gm-Message-State":"AMCzsaURTFsSoR8p26X4i5DEz9m6okiKmVLn3QVMsrTxlGcE0RapLYvW\n\tMHzk2H/clNz6Eg3owfW3PBpX2yrHwHfXKX2x3n7rOkrk","X-Google-Smtp-Source":"AOwi7QBPn7HEtdxsMExJLOeUNx4AxeS8uPCADiOuuRT7gQSI96ATONIluj3eK17dwlLgOdJ6HeYZ2wDLmSvVuDg/D8w=","X-Received":"by 10.223.186.201 with SMTP id w9mr2319598wrg.230.1507302640789; \n\tFri, 06 Oct 2017 08:10:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920070135.31379-2-clg@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>","From":"Peter Maydell ","Date":"Fri, 6 Oct 2017 16:10:20 +0100","Message-ID":"","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::232","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1782151,"web_url":"http://patchwork.ozlabs.org/comment/1782151/","msgid":"<528c49b8-0d94-dad7-c664-c8a91b6b4a2e@kaod.org>","list_archive_url":null,"date":"2017-10-07T16:42:17","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/06/2017 05:10 PM, Peter Maydell wrote:\n> On 20 September 2017 at 08:01, Cédric Le Goater wrote:\n>> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n>> Let's add support for their BMC including a couple of I2C devices as\n>> found on real HW.\n>>\n>> Signed-off-by: Cédric Le Goater \n>> ---\n>> hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n>> 1 file changed, 49 insertions(+)\n>>\n>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n>> index ab895ad490af..81f522f711ae 100644\n>> --- a/hw/arm/aspeed.c\n>> +++ b/hw/arm/aspeed.c\n>> @@ -46,6 +46,7 @@ enum {\n>> PALMETTO_BMC,\n>> AST2500_EVB,\n>> ROMULUS_BMC,\n>> + WITHERSPOON_BMC,\n>> };\n>>\n>> /* Palmetto hardware value: 0x120CE416 */\n>> @@ -83,8 +84,12 @@ enum {\n>> SCU_AST2500_HW_STRAP_ACPI_ENABLE | \\\n>> SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n>>\n>> +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n>> +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n>> +\n>> static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n>> static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n>>\n>> static const AspeedBoardConfig aspeed_boards[] = {\n>> [PALMETTO_BMC] = {\n>> @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n>> .spi_model = \"mx66l1g45g\",\n>> .num_cs = 2,\n>> },\n>> + [WITHERSPOON_BMC] = {\n>> + .soc_name = \"ast2500-a1\",\n>> + .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n>> + .fmc_model = \"mx25l25635e\",\n>> + .spi_model = \"mx66l1g45g\",\n>> + .num_cs = 2,\n>> + .i2c_init = witherspoon_bmc_i2c_init,\n>> + },\n>> };\n>>\n>> #define FIRMWARE_ADDR 0x0\n>> @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n>> .class_init = romulus_bmc_class_init,\n>> };\n>>\n>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>> +{\n>> + AspeedSoCState *soc = &bmc->soc;\n>> +\n>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n>> +\n>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n>> +}\n>> +\n>> +static void witherspoon_bmc_init(MachineState *machine)\n>> +{\n>> + aspeed_board_init(machine, &aspeed_boards[WITHERSPOON_BMC]);\n>> +}\n>> +\n>> +static void witherspoon_bmc_class_init(ObjectClass *oc, void *data)\n>> +{\n>> + MachineClass *mc = MACHINE_CLASS(oc);\n>> +\n>> + mc->desc = \"OpenPOWER Witherspoon BMC (ARM1176)\";\n>> + mc->init = witherspoon_bmc_init;\n>> + mc->max_cpus = 1;\n>> + mc->no_sdcard = 1;\n>> + mc->no_floppy = 1;\n>> + mc->no_cdrom = 1;\n>> + mc->no_parallel = 1;\n>> + mc->ignore_memory_transaction_failures = true;\n> \n> Please don't set this flag for new board models, it is only\n> for our legacy existing ones. Instead implement any devices\n> that you need for guest code to boot (stub them out with\n> create_unimplemented_device() if you like).\n\nOK. I am discovering this. I will take a look for the next\nround.\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8XQ42kvjz9t6Y\n\tfor ;\n\tSun, 8 Oct 2017 03:43:40 +1100 (AEDT)","from localhost ([::1]:50412 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0sCO-0007Yp-Qy\n\tfor incoming@patchwork.ozlabs.org; Sat, 07 Oct 2017 12:43:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41681)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e0sBI-0007Ay-15\n\tfor qemu-devel@nongnu.org; Sat, 07 Oct 2017 12:42:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e0sBE-0004Wk-V1\n\tfor qemu-devel@nongnu.org; Sat, 07 Oct 2017 12:42:28 -0400","from 1.mo177.mail-out.ovh.net ([178.33.107.143]:34488)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e0sBE-0004WC-P7\n\tfor qemu-devel@nongnu.org; Sat, 07 Oct 2017 12:42:24 -0400","from player779.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id B494979680\n\tfor ; Sat, 7 Oct 2017 18:42:23 +0200 (CEST)","from zorba.kaod.org (i15-les03-th2-31-37-69-229.sfr.lns.abo.bbox.fr\n\t[31.37.69.229]) (Authenticated sender: postmaster@kaod.org)\n\tby player779.ha.ovh.net (Postfix) with ESMTPSA id EF5D97C0084;\n\tSat, 7 Oct 2017 18:42:17 +0200 (CEST)"],"To":"Peter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<528c49b8-0d94-dad7-c664-c8a91b6b4a2e@kaod.org>","Date":"Sat, 7 Oct 2017 18:42:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"283445305816157124","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrleehgddutdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"178.33.107.143","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1782366,"web_url":"http://patchwork.ozlabs.org/comment/1782366/","msgid":"<1507507449.5452.147.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-09T00:04:09","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n> Let's add support for their BMC including a couple of I2C devices as\n> found on real HW.\n> \n> Signed-off-by: Cédric Le Goater \n> ---\n>  hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n>  1 file changed, 49 insertions(+)\n> \n> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n> index ab895ad490af..81f522f711ae 100644\n> --- a/hw/arm/aspeed.c\n> +++ b/hw/arm/aspeed.c\n> @@ -46,6 +46,7 @@ enum {\n>      PALMETTO_BMC,\n>      AST2500_EVB,\n>      ROMULUS_BMC,\n> +    WITHERSPOON_BMC,\n>  };\n>  \n>  /* Palmetto hardware value: 0x120CE416 */\n> @@ -83,8 +84,12 @@ enum {\n>          SCU_AST2500_HW_STRAP_ACPI_ENABLE |                              \\\n>          SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n>  \n> +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n> +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n> +\n>  static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n>  static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n>  \n>  static const AspeedBoardConfig aspeed_boards[] = {\n>      [PALMETTO_BMC] = {\n> @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n>          .spi_model = \"mx66l1g45g\",\n>          .num_cs    = 2,\n>      },\n> +    [WITHERSPOON_BMC]  = {\n> +        .soc_name  = \"ast2500-a1\",\n> +        .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n> +        .fmc_model = \"mx25l25635e\",\n> +        .spi_model = \"mx66l1g45g\",\n> +        .num_cs    = 2,\n> +        .i2c_init  = witherspoon_bmc_i2c_init,\n> +    },\n>  };\n>  \n>  #define FIRMWARE_ADDR 0x0\n> @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n>      .class_init = romulus_bmc_class_init,\n>  };\n>  \n> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n> +{\n> +    AspeedSoCState *soc = &bmc->soc;\n> +\n> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n> +\n> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n\nLooks like I need to track down newer versions of the schematics I have.\n\n> +}\n> +\n> +static void witherspoon_bmc_init(MachineState *machine)\n> +{\n> +    aspeed_board_init(machine, &aspeed_boards[WITHERSPOON_BMC]);\n> +}\n> +\n> +static void witherspoon_bmc_class_init(ObjectClass *oc, void *data)\n> +{\n> +    MachineClass *mc = MACHINE_CLASS(oc);\n> +\n> +    mc->desc = \"OpenPOWER Witherspoon BMC (ARM1176)\";\n> +    mc->init = witherspoon_bmc_init;\n> +    mc->max_cpus = 1;\n> +    mc->no_sdcard = 1;\n> +    mc->no_floppy = 1;\n> +    mc->no_cdrom = 1;\n> +    mc->no_parallel = 1;\n> +    mc->ignore_memory_transaction_failures = true;\n\nAside from the issue with the above as pointed out by Peter,\n\nReviewed-by: Andrew Jeffery \n\n> +}\n> +\n> +static const TypeInfo witherspoon_bmc_type = {\n> +    .name = MACHINE_TYPE_NAME(\"witherspoon-bmc\"),\n> +    .parent = TYPE_MACHINE,\n> +    .class_init = witherspoon_bmc_class_init,\n> +};\n> +\n>  static void aspeed_machine_init(void)\n>  {\n>      type_register_static(&palmetto_bmc_type);\n>      type_register_static(&ast2500_evb_type);\n>      type_register_static(&romulus_bmc_type);\n> +    type_register_static(&witherspoon_bmc_type);\n>  }\n>  \n>  type_init(aspeed_machine_init)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"cl+j2slr\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"VlMiErvk\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9L8h5v7Kz9t2c\n\tfor ;\n\tMon, 9 Oct 2017 11:04:50 +1100 (AEDT)","from localhost ([::1]:55529 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1LYt-0007Ln-Af\n\tfor incoming@patchwork.ozlabs.org; Sun, 08 Oct 2017 20:04:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42464)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1LYV-0007Ds-9k\n\tfor qemu-devel@nongnu.org; Sun, 08 Oct 2017 20:04:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1LYU-0004VE-9T\n\tfor qemu-devel@nongnu.org; Sun, 08 Oct 2017 20:04:23 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:58137)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1LYP-0004Ku-Ak; Sun, 08 Oct 2017 20:04:17 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 69F0F20BF3;\n\tSun, 8 Oct 2017 20:04:15 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Sun, 08 Oct 2017 20:04:15 -0400","from keelia (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id E42FA247A6;\n\tSun, 8 Oct 2017 20:04:12 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=fm1; bh=DYZhfeR/pzFk8uG7GC4IAjG78JdtY3lcvZL2vFqE8\n\t34=; b=cl+j2slrecZrax30sEnBhMPFO8bfTKXSaHODLb5FgeOmG59SqVbh1ZOHJ\n\tAkj7WVG+cFPZ+E5Rc+oXCen+GeTfXjed6oKykfXTJK/f5qC5X29BWM5QkhLuVKoU\n\tZTNKAl4Nvd0pGBigr2ZALk3/1uL/Sh82QL2Qq5hjNXgEZsw5NOwlfUBlw1zh4ypT\n\tPvy+O0hwEhU+yvl64YY2DQvtQmygi4pObpDARtWMSuVVM5FZV+VmPoDwCALWeGb1\n\t7QUSXJvcCKjnW6CFbMqgLi7mrZtxKkPSgpr/odqTbrNcqnY9+TJglt2vHTdClKk0\n\txNW5M2GbWR33YH/WzGndEIXfJ0knQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=DYZhfeR/pzFk8uG7GC\n\t4IAjG78JdtY3lcvZL2vFqE834=; b=VlMiErvk1OEWNIvZvXx9b2gbLvz01aZRvC\n\t2aF3vQJB+3B1fPHoQNYcLKpLnM5fz7VvhVvFkTP8LSjA6iCyMxz6mpz1BhZcGZTu\n\tkkXyxKXgtZAJYA8so1yu7s7e8SBhCClDROByTnNjnn9csa74pP1iI7XyMdjvSEHS\n\tQv1jwycswIsHc542vqUxidbrkhnzvSVyroeAy4Uzh6I9/17Gm/NeTrgJ9PK5NYqX\n\t74qEs9OvmHVmR0ej9Ufpq55hs3FZwncr/XOHpCmnGozUD/URNYolA9oNIj3v3YKY\n\tCgB7U9DEe0eHXGxNt2pGA5U3de7+7Xjuo5xbmpG0qTfhOtyOf3FQ=="],"X-ME-Sender":"","X-Sasl-enc":"3j+RDnvhjyOMJ2atWo534EArwPADI1/4miRfriiDY8X4 1507507454","Message-ID":"<1507507449.5452.147.camel@aj.id.au>","From":"Andrew Jeffery ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater , Peter Maydell\n\t","Date":"Mon, 09 Oct 2017 10:34:09 +1030","In-Reply-To":"<20170920070135.31379-2-clg@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-oY3VsICoF9BwTCvYHlV6\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tqemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783539,"web_url":"http://patchwork.ozlabs.org/comment/1783539/","msgid":"","list_archive_url":null,"date":"2017-10-10T09:19:09","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/06/2017 05:10 PM, Peter Maydell wrote:\n> On 20 September 2017 at 08:01, Cédric Le Goater wrote:\n>> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n>> Let's add support for their BMC including a couple of I2C devices as\n>> found on real HW.\n>>\n>> Signed-off-by: Cédric Le Goater \n>> ---\n>> hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n>> 1 file changed, 49 insertions(+)\n>>\n>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n>> index ab895ad490af..81f522f711ae 100644\n>> --- a/hw/arm/aspeed.c\n>> +++ b/hw/arm/aspeed.c\n>> @@ -46,6 +46,7 @@ enum {\n>> PALMETTO_BMC,\n>> AST2500_EVB,\n>> ROMULUS_BMC,\n>> + WITHERSPOON_BMC,\n>> };\n>>\n>> /* Palmetto hardware value: 0x120CE416 */\n>> @@ -83,8 +84,12 @@ enum {\n>> SCU_AST2500_HW_STRAP_ACPI_ENABLE | \\\n>> SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n>>\n>> +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n>> +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n>> +\n>> static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n>> static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n>>\n>> static const AspeedBoardConfig aspeed_boards[] = {\n>> [PALMETTO_BMC] = {\n>> @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n>> .spi_model = \"mx66l1g45g\",\n>> .num_cs = 2,\n>> },\n>> + [WITHERSPOON_BMC] = {\n>> + .soc_name = \"ast2500-a1\",\n>> + .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n>> + .fmc_model = \"mx25l25635e\",\n>> + .spi_model = \"mx66l1g45g\",\n>> + .num_cs = 2,\n>> + .i2c_init = witherspoon_bmc_i2c_init,\n>> + },\n>> };\n>>\n>> #define FIRMWARE_ADDR 0x0\n>> @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n>> .class_init = romulus_bmc_class_init,\n>> };\n>>\n>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>> +{\n>> + AspeedSoCState *soc = &bmc->soc;\n>> +\n>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n>> +\n>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n>> +}\n>> +\n>> +static void witherspoon_bmc_init(MachineState *machine)\n>> +{\n>> + aspeed_board_init(machine, &aspeed_boards[WITHERSPOON_BMC]);\n>> +}\n>> +\n>> +static void witherspoon_bmc_class_init(ObjectClass *oc, void *data)\n>> +{\n>> + MachineClass *mc = MACHINE_CLASS(oc);\n>> +\n>> + mc->desc = \"OpenPOWER Witherspoon BMC (ARM1176)\";\n>> + mc->init = witherspoon_bmc_init;\n>> + mc->max_cpus = 1;\n>> + mc->no_sdcard = 1;\n>> + mc->no_floppy = 1;\n>> + mc->no_cdrom = 1;\n>> + mc->no_parallel = 1;\n>> + mc->ignore_memory_transaction_failures = true;\n> \n> Please don't set this flag for new board models, it is only\n> for our legacy existing ones. Instead implement any devices\n> that you need for guest code to boot (stub them out with\n> create_unimplemented_device() if you like).\n\nI have dug into this a little more and it seems that it is \nrequired for the Aspeed bootloader (a modified u-boot) which \nuses static variables in early init phases. So legacy firmwares \nwon't work in QEMU but will on real HW. \n\nIt's fine with me but what is the goal of the approach ? Force \nSoC providers into fixing their FW when they use QEMU ?\n\nThanks,\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBBQv6g2Xz9tYB\n\tfor ;\n\tTue, 10 Oct 2017 20:20:03 +1100 (AEDT)","from localhost ([::1]:33690 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1qhj-00087w-40\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 05:19:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38150)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1qhF-00087Y-Rp\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:19:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1qhC-0001Jn-Nc\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:19:29 -0400","from 10.mo178.mail-out.ovh.net ([46.105.76.150]:46721)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e1qhC-0001Hx-GT\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:19:26 -0400","from player728.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo178.mail-out.ovh.net (Postfix) with ESMTP id 689C85A3FA\n\tfor ; Tue, 10 Oct 2017 11:19:19 +0200 (CEST)","from zorba.kaod.org (deibp9eh1--blueice3n7.emea.ibm.com\n\t[195.212.29.177]) (Authenticated sender: postmaster@kaod.org)\n\tby player728.ha.ovh.net (Postfix) with ESMTPSA id 591185400A4;\n\tTue, 10 Oct 2017 11:19:10 +0200 (CEST)"],"To":"Peter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"","Date":"Tue, 10 Oct 2017 11:19:09 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"10418514788376415172","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledruddtuddgudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.76.150","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783571,"web_url":"http://patchwork.ozlabs.org/comment/1783571/","msgid":"","list_archive_url":null,"date":"2017-10-10T09:54:30","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 10 October 2017 at 10:19, Cédric Le Goater wrote:\n> On 10/06/2017 05:10 PM, Peter Maydell wrote:\n>>> + mc->ignore_memory_transaction_failures = true;\n>>\n>> Please don't set this flag for new board models, it is only\n>> for our legacy existing ones. Instead implement any devices\n>> that you need for guest code to boot (stub them out with\n>> create_unimplemented_device() if you like).\n>\n> I have dug into this a little more and it seems that it is\n> required for the Aspeed bootloader (a modified u-boot) which\n> uses static variables in early init phases. So legacy firmwares\n> won't work in QEMU but will on real HW.\n>\n> It's fine with me but what is the goal of the approach ? Force\n> SoC providers into fixing their FW when they use QEMU ?\n\nThe goal is to model hardware correctly. Hardware gives\naborts if you touch a physical address with no device there,\nand so QEMU's model should do the same. If you have guest\ncode that touches a physical address and blows up because\nof an abort (but doesn't when run on h/w) then either:\n * it is trying to probe a device that exists in real h/w:\n you need to provide a stub implementation in QEMU\n * the SoC's bus fabric really doesn't pass aborts back\n to the CPU; I think this is unlikely, but you can model\n it at the SoC level with a suitable default memory region\n\nThe purpose of the flag is purely for existing board models,\nwhere it is impossible to enable the correct (abort)\nbehaviour without possibly breaking guest code images that\nwork for people using released QEMU code. On a new board\nmodel we don't have that problem and we can get it right\nfrom the start. If we don't get it right from the start\nthen we will never have a chance to fix it in future.\n\nOur mismodelling of this (not turning accesses to invalid\naddresses into CPU aborts) meant that in the past it was\npossible to be lazy when implementing a board model and\njust not model half the hardware at all. Now it isn't,\nbut I don't think that adding a set of calls to\ncreate_unimplemented_device() is a significant imposition.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RPz9B2vg\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBCCY3Dtvz9tY2\n\tfor ;\n\tTue, 10 Oct 2017 20:55:21 +1100 (AEDT)","from localhost ([::1]:33815 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1rFv-0002TH-Jc\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 05:55:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48028)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1rFV-0002T5-OS\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:54:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1rFU-00070X-SN\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:54:53 -0400","from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:46718)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1rFU-0006zx-MN\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:54:52 -0400","by mail-wm0-x233.google.com with SMTP id m72so3472773wmc.1\n\tfor ; Tue, 10 Oct 2017 02:54:52 -0700 (PDT)","by 10.223.128.207 with HTTP; Tue, 10 Oct 2017 02:54:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=nXcfDHeR4l72LGSZWQ4hsam1cn3Uc6gn4O/i3sIcWEU=;\n\tb=RPz9B2vgnMXb5kfBIuIm6LV1fDd2XscSuzNWMX5sbr6YPOU57eBPJs9H01KzIl9vxz\n\tv1yFyMKF21zDjo+rBPDGTUfmwxFgqXP9aDSybp4LWxMx+52f3+Sj44397X3wkU9usvsm\n\taLb6vEeABs8kOVFxQJoxOOb64+gwLr/ZYcn7c=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=nXcfDHeR4l72LGSZWQ4hsam1cn3Uc6gn4O/i3sIcWEU=;\n\tb=XvCvtdY9RMGaATftRWCEIB1ooarq/WXYX/NBcNwI3kbCZfQvSeNMX69fnseq2SgXDP\n\t+/TLEfMygnGocfl9l6NQLczCSNZ26CJxAYk7Tr8qVeeqh7zBjsbGjq/isGIAiuG3kY0t\n\tOos7Y5WsYi6z6rL5lPARHwOvYpjZyM3ujWvu2deaNWl5Wf6JZ9i5VP/hZ+wcXTBQILQC\n\tajXqBJKhzthGxxNQRqbRtbp98ioLmrwjEt/vFlqHzzmv3c3SgpvxtpbKvoWhMM5asdkU\n\tSMYmmypE+ZNKuechzzBBIdEmRr+i0etmSRbhi3QxEONON9k87QudFGeA3dm8vaKKfroI\n\tsmpw==","X-Gm-Message-State":"AMCzsaXajCqxEaq80ihOH9QFqI8N3jiTjC1cc+58U9ggf0s/A6mRvIE6\n\t4kgZASfU+y4qIJ8mQqGypsW5AGXSqxHbE1lmoxJcmw==","X-Google-Smtp-Source":"AOwi7QAMfgByag75IdcZCUHGaI2KPe4zoHQPQmAYXu17NNysxW9aVE2YBEHTqWPM5fYP6GcofR9GzlGEMBYMDRMJpsk=","X-Received":"by 10.28.113.196 with SMTP id d65mr9533457wmi.151.1507629291519; \n\tTue, 10 Oct 2017 02:54:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t\n\t","From":"Peter Maydell ","Date":"Tue, 10 Oct 2017 10:54:30 +0100","Message-ID":"","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::233","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783718,"web_url":"http://patchwork.ozlabs.org/comment/1783718/","msgid":"<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>","list_archive_url":null,"date":"2017-10-10T13:21:02","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/10/2017 11:54 AM, Peter Maydell wrote:\n> On 10 October 2017 at 10:19, Cédric Le Goater wrote:\n>> On 10/06/2017 05:10 PM, Peter Maydell wrote:\n>>>> + mc->ignore_memory_transaction_failures = true;\n>>>\n>>> Please don't set this flag for new board models, it is only\n>>> for our legacy existing ones. Instead implement any devices\n>>> that you need for guest code to boot (stub them out with\n>>> create_unimplemented_device() if you like).\n>>\n>> I have dug into this a little more and it seems that it is\n>> required for the Aspeed bootloader (a modified u-boot) which\n>> uses static variables in early init phases. So legacy firmwares\n>> won't work in QEMU but will on real HW.\n>>\n>> It's fine with me but what is the goal of the approach ? Force\n>> SoC providers into fixing their FW when they use QEMU ?\n> \n> The goal is to model hardware correctly. Hardware gives\n> aborts if you touch a physical address with no device there,\n> and so QEMU's model should do the same. If you have guest\n> code that touches a physical address and blows up because\n> of an abort (but doesn't when run on h/w) then either:\n> * it is trying to probe a device that exists in real h/w:\n> you need to provide a stub implementation in QEMU\n> * the SoC's bus fabric really doesn't pass aborts back\n> to the CPU; I think this is unlikely, but you can model\n> it at the SoC level with a suitable default memory region\n\nwell, that is case it seems. \n\nAnyhow, I found the required fixes in u-boot, so I will go with \nignore_memory_transaction_failures=false with this new machine.\n\nThanks,\n\nC. \n \n> The purpose of the flag is purely for existing board models,\n> where it is impossible to enable the correct (abort)\n> behaviour without possibly breaking guest code images that\n> work for people using released QEMU code. On a new board\n> model we don't have that problem and we can get it right\n> from the start. If we don't get it right from the start\n> then we will never have a chance to fix it in future.\n> \n> Our mismodelling of this (not turning accesses to invalid\n> addresses into CPU aborts) meant that in the past it was\n> possible to be lazy when implementing a board model and\n> just not model half the hardware at all. Now it isn't,\n> but I don't think that adding a set of calls to\n> create_unimplemented_device() is a significant imposition.\n> \n> thanks\n> -- PMM\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBHnt49f6z9tYM\n\tfor ;\n\tWed, 11 Oct 2017 00:21:53 +1100 (AEDT)","from localhost ([::1]:35057 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1uTm-0001nw-Sd\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 09:21:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55152)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1uTF-0001nl-QZ\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:21:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1uTA-00035J-Qm\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:21:17 -0400","from 9.mo178.mail-out.ovh.net ([46.105.75.45]:53961)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e1uTA-00033k-KH\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:21:12 -0400","from player728.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo178.mail-out.ovh.net (Postfix) with ESMTP id 902075A3EC\n\tfor ; Tue, 10 Oct 2017 15:21:09 +0200 (CEST)","from zorba.kaod.org (deibp9eh1--blueice3n7.emea.ibm.com\n\t[195.212.29.177]) (Authenticated sender: postmaster@kaod.org)\n\tby player728.ha.ovh.net (Postfix) with ESMTPSA id D64805400A1;\n\tTue, 10 Oct 2017 15:21:02 +0200 (CEST)"],"To":"Peter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t\n\t\n\t","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>","Date":"Tue, 10 Oct 2017 15:21:02 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"14502998177632586692","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrgedttddrtddtgdeggecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.75.45","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783720,"web_url":"http://patchwork.ozlabs.org/comment/1783720/","msgid":"","list_archive_url":null,"date":"2017-10-10T13:24:41","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 10 October 2017 at 14:21, Cédric Le Goater wrote:\n> On 10/10/2017 11:54 AM, Peter Maydell wrote:\n>> The goal is to model hardware correctly. Hardware gives\n>> aborts if you touch a physical address with no device there,\n>> and so QEMU's model should do the same. If you have guest\n>> code that touches a physical address and blows up because\n>> of an abort (but doesn't when run on h/w) then either:\n>> * it is trying to probe a device that exists in real h/w:\n>> you need to provide a stub implementation in QEMU\n>> * the SoC's bus fabric really doesn't pass aborts back\n>> to the CPU; I think this is unlikely, but you can model\n>> it at the SoC level with a suitable default memory region\n>\n> well, that is case it seems.\n\nIf it is, then we should model the SoC that way, ie find\nout from the hardware docs what part of the bus fabric\nignores decode errors and use memory regions with the\nright default behaviour to cover the relevant address\nranges.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"kbGG6j1Z\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBHtQ5l3cz9tYN\n\tfor ;\n\tWed, 11 Oct 2017 00:25:50 +1100 (AEDT)","from localhost ([::1]:35078 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1uXc-0003pD-SA\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 09:25:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56137)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1uX3-0003gN-7t\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:25:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1uWt-0004rt-C1\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:25:13 -0400","from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:53886)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1uWt-0004rU-69\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:25:03 -0400","by mail-wm0-x231.google.com with SMTP id q132so5303210wmd.2\n\tfor ; Tue, 10 Oct 2017 06:25:03 -0700 (PDT)","by 10.223.128.207 with HTTP; Tue, 10 Oct 2017 06:24:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=hEIGFO0eWyZwSULlqUfsYSkytV2XyqAJd/KDlR4DL1E=;\n\tb=kbGG6j1Zp+dfO9Zo/bXigHT+l1fVPFp/i5THMDvkBkE2TGT9Ciw5F5XMoXcpO4p44U\n\t6xeYVdnf6UmEzFI7R0pGKcPuSzh2YUDq5buC4mXbIj66VEJF8mh6ZQQaO82j4hK3xGA4\n\t9YYhehKQ4vBapd5jJoQ45NGGFwyX7NZNuUsDk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=hEIGFO0eWyZwSULlqUfsYSkytV2XyqAJd/KDlR4DL1E=;\n\tb=Ba5EJaGrKvit8QGhlUKXF+9CQhRFtX2YtuRnTgUU2Ud7OPvDwkxe34ufnHUHTx0xlm\n\tIcgERXSiCYZQNGH2VhyOGeJxm+4J2pAfb6JqD6avAfOm9xo1pCDB2/PupVfz2fm+NZ/2\n\t/EQwUJJ0So9IDY0AEIfLBhr2pZb1itDil2mrAkYYrCigAzosA2YoFlS8TQ19x7MOuw9Z\n\t30kp2OU9eklnHzz8vAetgudGDnFmgeg5vFZq5kfhrtiVxFkpwv0NuB67p9cPIYaeXAoD\n\tQt6OiVDw2ztQbn+1ymnVHobXe72ap7X2SJ7FkrLmU9hK9Gg0FpKOJSB7YsHmXzIR+5jq\n\t/lug==","X-Gm-Message-State":"AMCzsaX8F/PLepTDJCGQNFvFMNUrvLyksAZr3S427F42QjWwCCS9NHf0\n\thf3MkZEgKFWjfdfx/qjRgawRthO8NJLRfiU3Amqzthsw","X-Google-Smtp-Source":"AOwi7QANI+p7c77/CZIw8QRGt98UDE8yHQNJTHWANAf3YDrW8dlC+7/mkqrwYEb70D/4IkzxG3USHmPyGp7oVnvlqbI=","X-Received":"by 10.223.186.201 with SMTP id w9mr12285078wrg.230.1507641901946;\n\tTue, 10 Oct 2017 06:25:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t\n\t\n\t\n\t<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>","From":"Peter Maydell ","Date":"Tue, 10 Oct 2017 14:24:41 +0100","Message-ID":"","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::231","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783727,"web_url":"http://patchwork.ozlabs.org/comment/1783727/","msgid":"<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>","list_archive_url":null,"date":"2017-10-10T13:30:22","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/09/2017 02:04 AM, Andrew Jeffery wrote:\n> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n>> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n>> Let's add support for their BMC including a couple of I2C devices as\n>> found on real HW.\n>>  \n>> Signed-off-by: Cédric Le Goater \n>> ---\n>>  hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n>>  1 file changed, 49 insertions(+)\n>>  \n>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n>> index ab895ad490af..81f522f711ae 100644\n>> --- a/hw/arm/aspeed.c\n>> +++ b/hw/arm/aspeed.c\n>> @@ -46,6 +46,7 @@ enum {\n>>      PALMETTO_BMC,\n>>      AST2500_EVB,\n>>      ROMULUS_BMC,\n>> +    WITHERSPOON_BMC,\n>>  };\n>>  \n>>  /* Palmetto hardware value: 0x120CE416 */\n>> @@ -83,8 +84,12 @@ enum {\n>>          SCU_AST2500_HW_STRAP_ACPI_ENABLE |                              \\\n>>          SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n>>  \n>> +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n>> +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n>> +\n>>  static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n>>  static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n>>  \n>>  static const AspeedBoardConfig aspeed_boards[] = {\n>>      [PALMETTO_BMC] = {\n>> @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n>>          .spi_model = \"mx66l1g45g\",\n>>          .num_cs    = 2,\n>>      },\n>> +    [WITHERSPOON_BMC]  = {\n>> +        .soc_name  = \"ast2500-a1\",\n>> +        .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n>> +        .fmc_model = \"mx25l25635e\",\n>> +        .spi_model = \"mx66l1g45g\",\n>> +        .num_cs    = 2,\n>> +        .i2c_init  = witherspoon_bmc_i2c_init,\n>> +    },\n>>  };\n>>  \n>>  #define FIRMWARE_ADDR 0x0\n>> @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n>>      .class_init = romulus_bmc_class_init,\n>>  };\n>>  \n>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>> +{\n>> +    AspeedSoCState *soc = &bmc->soc;\n>> +\n>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n>> +\n>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n> \n> Looks like I need to track down newer versions of the schematics I have.\n\nthe device on the board is a tmp275 but the tmp105 model is compatible. \n\n\n>> +}\n>> +\n>> +static void witherspoon_bmc_init(MachineState *machine)\n>> +{\n>> +    aspeed_board_init(machine, &aspeed_boards[WITHERSPOON_BMC]);\n>> +}\n>> +\n>> +static void witherspoon_bmc_class_init(ObjectClass *oc, void *data)\n>> +{\n>> +    MachineClass *mc = MACHINE_CLASS(oc);\n>> +\n>> +    mc->desc = \"OpenPOWER Witherspoon BMC (ARM1176)\";\n>> +    mc->init = witherspoon_bmc_init;\n>> +    mc->max_cpus = 1;\n>> +    mc->no_sdcard = 1;\n>> +    mc->no_floppy = 1;\n>> +    mc->no_cdrom = 1;\n>> +    mc->no_parallel = 1;\n>> +    mc->ignore_memory_transaction_failures = true;\n> \n> Aside from the issue with the above as pointed out by Peter,\n> \n> Reviewed-by: Andrew Jeffery \n\nThanks,\n\nC. \n\n> \n>> +}\n>> +\n>> +static const TypeInfo witherspoon_bmc_type = {\n>> +    .name = MACHINE_TYPE_NAME(\"witherspoon-bmc\"),\n>> +    .parent = TYPE_MACHINE,\n>> +    .class_init = witherspoon_bmc_class_init,\n>> +};\n>> +\n>>  static void aspeed_machine_init(void)\n>>  {\n>>      type_register_static(&palmetto_bmc_type);\n>>      type_register_static(&ast2500_evb_type);\n>>      type_register_static(&romulus_bmc_type);\n>> +    type_register_static(&witherspoon_bmc_type);\n>>  }\n>>  \n>>  type_init(aspeed_machine_init)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBJ102n1Rz9tYN\n\tfor ;\n\tWed, 11 Oct 2017 00:31:31 +1100 (AEDT)","from localhost ([::1]:35107 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1ud7-0007X0-Vu\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 09:31:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58589)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1ucN-0007Kj-P3\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:30:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1ucI-0008OR-RW\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:30:43 -0400","from 8.mo178.mail-out.ovh.net ([46.105.74.227]:50102)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e1ucI-0008NR-Hk\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:30:38 -0400","from player728.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo178.mail-out.ovh.net (Postfix) with ESMTP id 69EB75A455\n\tfor ; Tue, 10 Oct 2017 15:30:30 +0200 (CEST)","from zorba.kaod.org (deibp9eh1--blueice3n7.emea.ibm.com\n\t[195.212.29.177]) (Authenticated sender: postmaster@kaod.org)\n\tby player728.ha.ovh.net (Postfix) with ESMTPSA id 8786654009F;\n\tTue, 10 Oct 2017 15:30:22 +0200 (CEST)"],"To":"Andrew Jeffery ,\n\tPeter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t<1507507449.5452.147.camel@aj.id.au>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>","Date":"Tue, 10 Oct 2017 15:30:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1507507449.5452.147.camel@aj.id.au>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"14660624163889253316","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrgedttddrtddtgdegiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.74.227","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tqemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783732,"web_url":"http://patchwork.ozlabs.org/comment/1783732/","msgid":"","list_archive_url":null,"date":"2017-10-10T13:32:32","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 10 October 2017 at 14:30, Cédric Le Goater wrote:\n> On 10/09/2017 02:04 AM, Andrew Jeffery wrote:\n>> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n>>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>>> +{\n>>> + AspeedSoCState *soc = &bmc->soc;\n>>> +\n>>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n>>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n>>> +\n>>> + i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n>>\n>> Looks like I need to track down newer versions of the schematics I have.\n>\n> the device on the board is a tmp275 but the tmp105 model is compatible.\n\nThis kind of deviation from the real hardware is worth having\na comment to document, I think.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MTolcJwp\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBJ323Dt5z9tYN\n\tfor ;\n\tWed, 11 Oct 2017 00:33:18 +1100 (AEDT)","from localhost ([::1]:35118 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1ueq-0008MY-CC\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 09:33:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59424)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1ueV-0008MS-Sc\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:32:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1ueV-0000us-0S\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:32:55 -0400","from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:46891)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1ueU-0000ua-OH\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 09:32:54 -0400","by mail-wm0-x235.google.com with SMTP id m72so5230541wmc.1\n\tfor ; Tue, 10 Oct 2017 06:32:54 -0700 (PDT)","by 10.223.128.207 with HTTP; Tue, 10 Oct 2017 06:32:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=Xzm5lie6Prj14HHxiay+vzBu73jkQETslqvQInjzeW0=;\n\tb=MTolcJwpgsbbc314uHVYOZEz5LTYuNYjLoUmPcKVz+oETG2ALImedhUeyo3aJ7ib/O\n\t2rJcrn24+fwN1izDNOUWTYNUDKMTOVV6Nkv7DqPLUsKqMq7mCvXEP/MgAU6FNot3Wj5R\n\twwru8ATQiFj28425hedbB5nbpVO6tfj2TuDS0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=Xzm5lie6Prj14HHxiay+vzBu73jkQETslqvQInjzeW0=;\n\tb=l+q3bhYsnD5vuakP6jOUg18A9BZ0L0uYVGO4fDujlpq///5+9shQe9Yuy6Wj5DGmgt\n\t4DQauykg26CkyrBGs66qe34iAyHWDWqnB01NARjXWa7Zg8zmnfwzPmV2IxmMdsiWjDKu\n\tkfvuvvMQKpam4pE12SPtTM8tFT9vHt3yT/GbYjlCuSN4ExbdQidgqmmvqRyPhuixzGN/\n\tO9q+aiYQYADXaC2nSH1caInGIWjVyOlhNTI5CHco7ILezRrjAQlZ06rMlKF2sRWVktPd\n\tEL2vJJizw+IQ9y11t358ANRd7TD+z+6dno4ESgZaZMYcQp01n9eIvHP/ybTG0mH7kF2I\n\twqrQ==","X-Gm-Message-State":"AMCzsaVzJcJCUGIb0TcxRYbnPcQRHVVPIvovBarmfhp8oeszMlAvjHVJ\n\tGTquf7vkcTT1JjQkOpjOvgSs/x6jIAE1N6y7gOVhrQ==","X-Google-Smtp-Source":"AOwi7QB3ZypYhIPaLILSFKzcDCMZzxEdQQL1L6EpBr5m0IWxP1cnVCeWSkmo2hkyU6UDOswBMgdnqM7MwgqSsnFA0ow=","X-Received":"by 10.223.186.201 with SMTP id w9mr12306876wrg.230.1507642373555;\n\tTue, 10 Oct 2017 06:32:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t<1507507449.5452.147.camel@aj.id.au>\n\t<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>","From":"Peter Maydell ","Date":"Tue, 10 Oct 2017 14:32:32 +0100","Message-ID":"","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::235","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783845,"web_url":"http://patchwork.ozlabs.org/comment/1783845/","msgid":"","list_archive_url":null,"date":"2017-10-10T15:38:31","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/10/2017 03:24 PM, Peter Maydell wrote:\n> On 10 October 2017 at 14:21, Cédric Le Goater wrote:\n>> On 10/10/2017 11:54 AM, Peter Maydell wrote:\n>>> The goal is to model hardware correctly. Hardware gives\n>>> aborts if you touch a physical address with no device there,\n>>> and so QEMU's model should do the same. If you have guest\n>>> code that touches a physical address and blows up because\n>>> of an abort (but doesn't when run on h/w) then either:\n>>> * it is trying to probe a device that exists in real h/w:\n>>> you need to provide a stub implementation in QEMU\n>>> * the SoC's bus fabric really doesn't pass aborts back\n>>> to the CPU; I think this is unlikely, but you can model\n>>> it at the SoC level with a suitable default memory region\n>>\n>> well, that is case it seems.\n> \n> If it is, then we should model the SoC that way, ie find\n> out from the hardware docs what part of the bus fabric\n> ignores decode errors and use memory regions with the\n> right default behaviour to cover the relevant address\n> ranges.\n\nThe addresses generating memory fault errors are all in \nthe region where the BMC SPI Flash Memory is mapped : \n[ 20000000-2FFFFFFF ]\n\nbut we should not be doing any writes there. I will make\nsome inquiries.\n\nThanks,\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBLs02Q3vz9s7h\n\tfor ;\n\tWed, 11 Oct 2017 02:39:48 +1100 (AEDT)","from localhost ([::1]:35660 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1wdG-0007uV-8S\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 11:39:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46067)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1wcR-0007lH-Kz\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:39:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1wcM-0000dF-3i\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:38:55 -0400","from 4.mo178.mail-out.ovh.net ([46.105.49.171]:58658)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e1wcL-0000b8-RT\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:38:50 -0400","from player728.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo178.mail-out.ovh.net (Postfix) with ESMTP id B59A558BAA\n\tfor ; Tue, 10 Oct 2017 17:38:41 +0200 (CEST)","from zorba.kaod.org (deibp9eh1--blueice3n7.emea.ibm.com\n\t[195.212.29.177]) (Authenticated sender: postmaster@kaod.org)\n\tby player728.ha.ovh.net (Postfix) with ESMTPSA id 137FD54007A;\n\tTue, 10 Oct 2017 17:38:31 +0200 (CEST)"],"To":"Peter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t\n\t\n\t\n\t<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>\n\t","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"","Date":"Tue, 10 Oct 2017 17:38:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"16824885259841801156","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrgedttddrtddtgdejudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.49.171","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783852,"web_url":"http://patchwork.ozlabs.org/comment/1783852/","msgid":"","list_archive_url":null,"date":"2017-10-10T15:45:17","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 10 October 2017 at 16:38, Cédric Le Goater wrote:\n> On 10/10/2017 03:24 PM, Peter Maydell wrote:\n>> On 10 October 2017 at 14:21, Cédric Le Goater wrote:\n>>> On 10/10/2017 11:54 AM, Peter Maydell wrote:\n>>>> The goal is to model hardware correctly. Hardware gives\n>>>> aborts if you touch a physical address with no device there,\n>>>> and so QEMU's model should do the same. If you have guest\n>>>> code that touches a physical address and blows up because\n>>>> of an abort (but doesn't when run on h/w) then either:\n>>>> * it is trying to probe a device that exists in real h/w:\n>>>> you need to provide a stub implementation in QEMU\n>>>> * the SoC's bus fabric really doesn't pass aborts back\n>>>> to the CPU; I think this is unlikely, but you can model\n>>>> it at the SoC level with a suitable default memory region\n>>>\n>>> well, that is case it seems.\n>>\n>> If it is, then we should model the SoC that way, ie find\n>> out from the hardware docs what part of the bus fabric\n>> ignores decode errors and use memory regions with the\n>> right default behaviour to cover the relevant address\n>> ranges.\n>\n> The addresses generating memory fault errors are all in\n> the region where the BMC SPI Flash Memory is mapped :\n> [ 20000000-2FFFFFFF ]\n\nIf there's an actual flash device there then this sounds\nlike my first case above, where we just need to stub out\nthat range of addresses until we get round to really\nimplementing the flash device.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"JcEH3aQ1\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBM4N1NL5z9tXl\n\tfor ;\n\tWed, 11 Oct 2017 02:49:38 +1100 (AEDT)","from localhost ([::1]:35709 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1wmk-0006uY-On\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 11:49:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48283)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1wiy-0004Nt-0M\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:45:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1wix-0003yC-3r\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:45:40 -0400","from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:43393)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1wiw-0003xm-Sg\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:45:39 -0400","by mail-wm0-x22e.google.com with SMTP id m72so16487445wmc.0\n\tfor ; Tue, 10 Oct 2017 08:45:38 -0700 (PDT)","by 10.223.128.207 with HTTP; Tue, 10 Oct 2017 08:45:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=KHFQ2sC0Y9B5BkCNj0rRGgqHKEfGRfMldb1Y+7gq4hs=;\n\tb=JcEH3aQ1m8iBJrN7AXU4jdiYIg1K5JVUuEldDNk9pM2+SoCTLbZHEzRJXtDkmPzxDD\n\t4HSIRB9ludytI75LhwgFAFHUnP76MlvcqapeOEBCDuu4NoCO0nZxzxDd6TWletwduhK5\n\tjBKfMZXrMZNT7MLNQpmPPJyrrh59GTcynt/KA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=KHFQ2sC0Y9B5BkCNj0rRGgqHKEfGRfMldb1Y+7gq4hs=;\n\tb=ccrjh9BYCbw3jsTyMYRy/2c5a4H2+Xd0BCB9BhxTYVY3ZRhhvoiOsDu+OTYjcKRgJf\n\tQC8BkdOXvR2/ANQIA0ySS9pAtRXqLNpRISLwAn1HGZaukG/iMIMyTF4U+xP3czDFJnhR\n\tj0lWKFUueb9Pi25VC6e19UXwQYlVD5zNWIipwQzXIIrxxOLlIJf2A7RUASfRoDPio+RA\n\tNAn87HCYMLttOrq3VJe3osOQ3/BGAtuvN3Jhqq7H7BNUwWTi4PM5PTkcKQi8DxpLAmkI\n\t7pxnfduKScLeYqFF+EA0plFhXXH7SmvIFRvJPDXFbUTLwdak5PP/0gM8RTpmPEDYhG29\n\tFVsQ==","X-Gm-Message-State":"AMCzsaXCCOf6zwHiRL3dgpQNcWcYiDqrisZAQqsDzM5l/a7hGAoM1oZm\n\t4p9HkltflCTbFe8AEvT5OgFjLK5OjGd4dfM+XIByCg==","X-Google-Smtp-Source":"AOwi7QBfYqBVdWYyamjeVovnuDiOA1QjNsULb+NshVO8fy8eOmaktDipKjOv9R6jb0UA4IJe9/er94b5Q5pzuU0hXQ0=","X-Received":"by 10.28.113.196 with SMTP id d65mr10347984wmi.151.1507650337778;\n\tTue, 10 Oct 2017 08:45:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t\n\t\n\t\n\t<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>\n\t\n\t","From":"Peter Maydell ","Date":"Tue, 10 Oct 2017 16:45:17 +0100","Message-ID":"","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22e","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783857,"web_url":"http://patchwork.ozlabs.org/comment/1783857/","msgid":"<10c8381c-904f-681a-28c1-1f069ba29219@kaod.org>","list_archive_url":null,"date":"2017-10-10T15:54:30","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/10/2017 05:45 PM, Peter Maydell wrote:\n> On 10 October 2017 at 16:38, Cédric Le Goater wrote:\n>> On 10/10/2017 03:24 PM, Peter Maydell wrote:\n>>> On 10 October 2017 at 14:21, Cédric Le Goater wrote:\n>>>> On 10/10/2017 11:54 AM, Peter Maydell wrote:\n>>>>> The goal is to model hardware correctly. Hardware gives\n>>>>> aborts if you touch a physical address with no device there,\n>>>>> and so QEMU's model should do the same. If you have guest\n>>>>> code that touches a physical address and blows up because\n>>>>> of an abort (but doesn't when run on h/w) then either:\n>>>>> * it is trying to probe a device that exists in real h/w:\n>>>>> you need to provide a stub implementation in QEMU\n>>>>> * the SoC's bus fabric really doesn't pass aborts back\n>>>>> to the CPU; I think this is unlikely, but you can model\n>>>>> it at the SoC level with a suitable default memory region\n>>>>\n>>>> well, that is case it seems.\n>>>\n>>> If it is, then we should model the SoC that way, ie find\n>>> out from the hardware docs what part of the bus fabric\n>>> ignores decode errors and use memory regions with the\n>>> right default behaviour to cover the relevant address\n>>> ranges.\n>>\n>> The addresses generating memory fault errors are all in\n>> the region where the BMC SPI Flash Memory is mapped :\n>> [ 20000000-2FFFFFFF ]\n> \n> If there's an actual flash device there then this sounds\n> like my first case above, where we just need to stub out\n> that range of addresses until we get round to really\n> implementing the flash device.\n\nbut it is implemented ! and the region available.\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBMC55L9cz9tYK\n\tfor ;\n\tWed, 11 Oct 2017 02:55:29 +1100 (AEDT)","from localhost ([::1]:35746 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1wsR-0001bw-My\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 11:55:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51682)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1wrl-0001ZG-NW\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:54:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1wrg-0000fA-W0\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:54:45 -0400","from 4.mo178.mail-out.ovh.net ([46.105.49.171]:33887)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e1wrg-0000eM-Qh\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 11:54:40 -0400","from player728.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo178.mail-out.ovh.net (Postfix) with ESMTP id CB02459E91\n\tfor ; Tue, 10 Oct 2017 17:54:38 +0200 (CEST)","from zorba.kaod.org (deibp9eh1--blueice3n7.emea.ibm.com\n\t[195.212.29.177]) (Authenticated sender: postmaster@kaod.org)\n\tby player728.ha.ovh.net (Postfix) with ESMTPSA id C1C6F540091;\n\tTue, 10 Oct 2017 17:54:30 +0200 (CEST)"],"To":"Peter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t\n\t\n\t\n\t<900ffff3-3667-7e17-bf38-7c6a520ed838@kaod.org>\n\t\n\t\n\t","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<10c8381c-904f-681a-28c1-1f069ba29219@kaod.org>","Date":"Tue, 10 Oct 2017 17:54:30 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"17094819764193496004","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrgedttddrtddtgdejhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.49.171","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1784277,"web_url":"http://patchwork.ozlabs.org/comment/1784277/","msgid":"<1507693785.5452.175.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-11T03:49:45","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote:\n> On 10/09/2017 02:04 AM, Andrew Jeffery wrote:\n> > On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n> > > The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n> > > Let's add support for their BMC including a couple of I2C devices as\n> > > found on real HW.\n> > >  \n> > > > > > Signed-off-by: Cédric Le Goater \n> > > ---\n> > >  hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n> > >  1 file changed, 49 insertions(+)\n> > >  \n> > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n> > > index ab895ad490af..81f522f711ae 100644\n> > > --- a/hw/arm/aspeed.c\n> > > +++ b/hw/arm/aspeed.c\n> > > @@ -46,6 +46,7 @@ enum {\n> > >      PALMETTO_BMC,\n> > >      AST2500_EVB,\n> > >      ROMULUS_BMC,\n> > > +    WITHERSPOON_BMC,\n> > >  };\n> > >  \n> > >  /* Palmetto hardware value: 0x120CE416 */\n> > > @@ -83,8 +84,12 @@ enum {\n> > >          SCU_AST2500_HW_STRAP_ACPI_ENABLE |                              \\\n> > >          SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n> > >  \n> > > +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n> > > +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n> > > +\n> > >  static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n> > >  static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n> > > +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n> > >  \n> > >  static const AspeedBoardConfig aspeed_boards[] = {\n> > >      [PALMETTO_BMC] = {\n> > > @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n> > >          .spi_model = \"mx66l1g45g\",\n> > >          .num_cs    = 2,\n> > >      },\n> > > +    [WITHERSPOON_BMC]  = {\n> > > +        .soc_name  = \"ast2500-a1\",\n> > > +        .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n> > > +        .fmc_model = \"mx25l25635e\",\n> > > +        .spi_model = \"mx66l1g45g\",\n> > > +        .num_cs    = 2,\n> > > +        .i2c_init  = witherspoon_bmc_i2c_init,\n> > > +    },\n> > >  };\n> > >  \n> > >  #define FIRMWARE_ADDR 0x0\n> > > @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n> > >      .class_init = romulus_bmc_class_init,\n> > >  };\n> > >  \n> > > +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n> > > +{\n> > > +    AspeedSoCState *soc = &bmc->soc;\n> > > +\n> > > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n> > > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n> > > +\n> > > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n> > \n> > Looks like I need to track down newer versions of the schematics I have.\n> \n> the device on the board is a tmp275 but the tmp105 model is compatible.\n\nIt neither device is listed in the version I have :)\n\nAndrew","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"SKsHiLKa\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"dIv1yyk8\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBg411Wrkz9t2S\n\tfor ;\n\tWed, 11 Oct 2017 14:50:25 +1100 (AEDT)","from localhost ([::1]:38352 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e282J-0004oc-9a\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 23:50:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35093)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e281v-0004lh-EQ\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 23:50:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e281u-0007fD-G0\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 23:49:59 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:52917)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e281p-0007ZA-Bs; Tue, 10 Oct 2017 23:49:53 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id E329120C1F;\n\tTue, 10 Oct 2017 23:49:50 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Tue, 10 Oct 2017 23:49:50 -0400","from keelia23 (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 308927E69D;\n\tTue, 10 Oct 2017 23:49:47 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm1; bh=5jqggpbg/tKsFRlKgrkIza8SYfW8NSKkpNGYNXGcc1g=; b=SKsHiLKa\n\tCsDTXeSkrWRPRTMXqqFYuH/kVw5fLt45kT4dBSm20Vmizy7TffhG6xqS7vfronvf\n\t2riCxH4HBEkCVPo/GL8KLzs2KJkQNwkhGHvWrMp+oEVnFUGtLqdAqajdIN3pfTik\n\tWEFY9WV4oPR5V1JbByZDrmUWJHQLyyYnzY6P2xdHWpu25fIsh21S74F1cunUN4tW\n\tFvlLdrwuPZiPbvAsibUQzqLEs19bMqwPMNttpzsa5FUALEbKptEyAJZw2NrSMV9d\n\t+4lfInhZS+j66n3ygNBRTLjJhS4AS9DowQKTn5gsTYT5Hbz1rODRtvMbQUXpd/Ga\n\tbQsvIph+u0OWvg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=fm1; bh=5jqggpbg/tKsFRlKgrkIza8SYfW8N\n\tSKkpNGYNXGcc1g=; b=dIv1yyk8oZLHAcYSFy5gT7STG4MhKCYJVbrSVfR9t1EY8\n\t+46xNdnopi7mmeEj0T2JKaGs9Cw3HHDagt/YP538P8jY7fAiV5giaoOAKc79NJUX\n\tJ6DT9vZvc/CrFiSP5+J/qg8wdsIbd4j+t+Fpx3oAfywm4Gg+RM3gTd6S7807d/+6\n\tUW9cnlOdzAvJaDWj8WI4IT65SR7raKT3EVmjraCPkBkAnB/glYtWTyEYQkPpRYMO\n\tIYVaF4BbwO5H1mF16yldHnPNczYYhjmWtyOEsj23HGeMUXRyIxRvk3EV5Z8H1uYQ\n\tx+utOiIGXcm/Ycjf3Ot2+hr5QHtrmEQ6/k+DJwkMg=="],"X-ME-Sender":"","Message-ID":"<1507693785.5452.175.camel@aj.id.au>","From":"Andrew Jeffery ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater , Peter Maydell\n\t","Date":"Wed, 11 Oct 2017 14:19:45 +1030","In-Reply-To":"<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t<1507507449.5452.147.camel@aj.id.au>\n\t<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-GQfEwtRaPYaNTDX4TOmI\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tqemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1784336,"web_url":"http://patchwork.ozlabs.org/comment/1784336/","msgid":"","list_archive_url":null,"date":"2017-10-11T07:28:14","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/11/2017 05:49 AM, Andrew Jeffery wrote:\n> On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote:\n>> On 10/09/2017 02:04 AM, Andrew Jeffery wrote:\n>>> On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n>>>> The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n>>>> Let's add support for their BMC including a couple of I2C devices as\n>>>> found on real HW.\n>>>>  \n>>>>>>> Signed-off-by: Cédric Le Goater \n>>>> ---\n>>>>  hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n>>>>  1 file changed, 49 insertions(+)\n>>>>  \n>>>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n>>>> index ab895ad490af..81f522f711ae 100644\n>>>> --- a/hw/arm/aspeed.c\n>>>> +++ b/hw/arm/aspeed.c\n>>>> @@ -46,6 +46,7 @@ enum {\n>>>>      PALMETTO_BMC,\n>>>>      AST2500_EVB,\n>>>>      ROMULUS_BMC,\n>>>> +    WITHERSPOON_BMC,\n>>>>  };\n>>>>  \n>>>>  /* Palmetto hardware value: 0x120CE416 */\n>>>> @@ -83,8 +84,12 @@ enum {\n>>>>          SCU_AST2500_HW_STRAP_ACPI_ENABLE |                              \\\n>>>>          SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n>>>>  \n>>>> +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n>>>> +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n>>>> +\n>>>>  static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n>>>>  static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n>>>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n>>>>  \n>>>>  static const AspeedBoardConfig aspeed_boards[] = {\n>>>>      [PALMETTO_BMC] = {\n>>>> @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n>>>>          .spi_model = \"mx66l1g45g\",\n>>>>          .num_cs    = 2,\n>>>>      },\n>>>> +    [WITHERSPOON_BMC]  = {\n>>>> +        .soc_name  = \"ast2500-a1\",\n>>>> +        .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n>>>> +        .fmc_model = \"mx25l25635e\",\n>>>> +        .spi_model = \"mx66l1g45g\",\n>>>> +        .num_cs    = 2,\n>>>> +        .i2c_init  = witherspoon_bmc_i2c_init,\n>>>> +    },\n>>>>  };\n>>>>  \n>>>>  #define FIRMWARE_ADDR 0x0\n>>>> @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n>>>>      .class_init = romulus_bmc_class_init,\n>>>>  };\n>>>>  \n>>>> +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n>>>> +{\n>>>> +    AspeedSoCState *soc = &bmc->soc;\n>>>> +\n>>>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n>>>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n>>>> +\n>>>> +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n>>>\n>>> Looks like I need to track down newer versions of the schematics I have.\n>>\n>> the device on the board is a tmp275 but the tmp105 model is compatible.\n> \n> It neither device is listed in the version I have :)\n\nHere is my source :\n\n\thttps://github.com/openbmc/linux/blob/dev-4.10/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts#L504\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBlw85tzpz9t4V\n\tfor ;\n\tWed, 11 Oct 2017 18:28:55 +1100 (AEDT)","from localhost ([::1]:38957 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2BRk-0006Db-P6\n\tfor incoming@patchwork.ozlabs.org; Wed, 11 Oct 2017 03:28:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43097)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2BRL-0006DP-3p\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 03:28:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e2BRH-0005Q8-5w\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 03:28:27 -0400","from 1.mo177.mail-out.ovh.net ([178.33.107.143]:41570)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e2BRG-0005Pg-VB\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 03:28:23 -0400","from player792.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id 323B77C19F\n\tfor ; Wed, 11 Oct 2017 09:28:20 +0200 (CEST)","from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: postmaster@kaod.org)\n\tby player792.ha.ovh.net (Postfix) with ESMTPSA id BC027A0074;\n\tWed, 11 Oct 2017 09:28:14 +0200 (CEST)"],"To":"Andrew Jeffery ,\n\tPeter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t<1507507449.5452.147.camel@aj.id.au>\n\t<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>\n\t<1507693785.5452.175.camel@aj.id.au>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"","Date":"Wed, 11 Oct 2017 09:28:14 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1507693785.5452.175.camel@aj.id.au>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"14417148310479145924","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrgedttddrtddugdduvddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"178.33.107.143","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tqemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1787111,"web_url":"http://patchwork.ozlabs.org/comment/1787111/","msgid":"<1508118927.24322.0.camel@aj.id.au>","list_archive_url":null,"date":"2017-10-16T01:55:27","subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"On Wed, 2017-10-11 at 09:28 +0200, Cédric Le Goater wrote:\n> On 10/11/2017 05:49 AM, Andrew Jeffery wrote:\n> > On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote:\n> > > On 10/09/2017 02:04 AM, Andrew Jeffery wrote:\n> > > > On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote:\n> > > > > The Witherspoon boards are OpenPOWER system hosting POWER9 Processors.\n> > > > > Let's add support for their BMC including a couple of I2C devices as\n> > > > > found on real HW.\n> > > > >  \n> > > > > > > > Signed-off-by: Cédric Le Goater \n> > > > > \n> > > > > ---\n> > > > >  hw/arm/aspeed.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n> > > > >  1 file changed, 49 insertions(+)\n> > > > >  \n> > > > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n> > > > > index ab895ad490af..81f522f711ae 100644\n> > > > > --- a/hw/arm/aspeed.c\n> > > > > +++ b/hw/arm/aspeed.c\n> > > > > @@ -46,6 +46,7 @@ enum {\n> > > > >      PALMETTO_BMC,\n> > > > >      AST2500_EVB,\n> > > > >      ROMULUS_BMC,\n> > > > > +    WITHERSPOON_BMC,\n> > > > >  };\n> > > > >  \n> > > > >  /* Palmetto hardware value: 0x120CE416 */\n> > > > > @@ -83,8 +84,12 @@ enum {\n> > > > >          SCU_AST2500_HW_STRAP_ACPI_ENABLE |                              \\\n> > > > >          SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_MASTER))\n> > > > >  \n> > > > > +/* Witherspoon hardware value: 0xF10AD216 (but use romulus definition) */\n> > > > > +#define WITHERSPOON_BMC_HW_STRAP1 ROMULUS_BMC_HW_STRAP1\n> > > > > +\n> > > > >  static void palmetto_bmc_i2c_init(AspeedBoardState *bmc);\n> > > > >  static void ast2500_evb_i2c_init(AspeedBoardState *bmc);\n> > > > > +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc);\n> > > > >  \n> > > > >  static const AspeedBoardConfig aspeed_boards[] = {\n> > > > >      [PALMETTO_BMC] = {\n> > > > > @@ -110,6 +115,14 @@ static const AspeedBoardConfig aspeed_boards[] = {\n> > > > >          .spi_model = \"mx66l1g45g\",\n> > > > >          .num_cs    = 2,\n> > > > >      },\n> > > > > +    [WITHERSPOON_BMC]  = {\n> > > > > +        .soc_name  = \"ast2500-a1\",\n> > > > > +        .hw_strap1 = WITHERSPOON_BMC_HW_STRAP1,\n> > > > > +        .fmc_model = \"mx25l25635e\",\n> > > > > +        .spi_model = \"mx66l1g45g\",\n> > > > > +        .num_cs    = 2,\n> > > > > +        .i2c_init  = witherspoon_bmc_i2c_init,\n> > > > > +    },\n> > > > >  };\n> > > > >  \n> > > > >  #define FIRMWARE_ADDR 0x0\n> > > > > @@ -337,11 +350,47 @@ static const TypeInfo romulus_bmc_type = {\n> > > > >      .class_init = romulus_bmc_class_init,\n> > > > >  };\n> > > > >  \n> > > > > +static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)\n> > > > > +{\n> > > > > +    AspeedSoCState *soc = &bmc->soc;\n> > > > > +\n> > > > > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), \"tmp423\", 0x4c);\n> > > > > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), \"tmp423\", 0x4c);\n> > > > > +\n> > > > > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 9), \"tmp105\", 0x4a);\n> > > > \n> > > > Looks like I need to track down newer versions of the schematics I have.\n> > > \n> > > the device on the board is a tmp275 but the tmp105 model is compatible.\n> > \n> > It neither device is listed in the version I have :)\n> \n> Here is my source :\n> \n> \thttps://github.com/openbmc/linux/blob/dev-4.10/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts#L504\n> \n\nYeah, I ended up jumping on a machine and verifying the device was on\nthe bus.\n\nCheers,\n\nAndrew","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"ikJcggjo\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"ruRc2BY+\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yFhJl26l1z9sP1\n\tfor ;\n\tMon, 16 Oct 2017 12:56:53 +1100 (AEDT)","from localhost ([::1]:58949 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e3ue6-0006TO-0s\n\tfor incoming@patchwork.ozlabs.org; Sun, 15 Oct 2017 21:56:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35111)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e3ud8-0006JU-1D\n\tfor qemu-devel@nongnu.org; Sun, 15 Oct 2017 21:55:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e3ud6-0006qE-Rv\n\tfor qemu-devel@nongnu.org; Sun, 15 Oct 2017 21:55:46 -0400","from out4-smtp.messagingengine.com ([66.111.4.28]:58429)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e3ud0-0006mi-HH; Sun, 15 Oct 2017 21:55:38 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 8A84320881;\n\tSun, 15 Oct 2017 21:55:36 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Sun, 15 Oct 2017 21:55:36 -0400","from keelia (unknown [203.0.153.9])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id CDAEE24135;\n\tSun, 15 Oct 2017 21:55:33 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm1; bh=DhRVsTSkKKD/zRDMPK6RpaEv74015Co2zq+TFim4Pns=; b=ikJcggjo\n\tQJ8dvNbprScNpwt9RpH2Uho14zNOjCb2A2EXSuICR31ojUphPg3VsNFbfk3DSiuN\n\t+FXCqlm5/JCvGPOrNrWc5gtMehDAAlFKc85jNHQneWVkKL907pOIjenp+jalZbzt\n\tB1BrHNtPzoT/dJCDAHax7N0yH6PpWDyidhkF0euUytp9THSgQXPAFcB3IPAurvy9\n\tRVlVUWT9mmU6PCj0V5ZNEA1xq6tSWuaGmh/8BntwczHEqBwvP1LCaT3HlYmEQV7W\n\tErnhhwpCaMzV2q0KN0j+oy6L7WeXS/PD5X+5zrf/LLDJRK/uv9AhbF0qYGSIgYwe\n\t8VamaDI9rqfVSA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=fm1; bh=DhRVsTSkKKD/zRDMPK6RpaEv74015\n\tCo2zq+TFim4Pns=; b=ruRc2BY+aftJOPqYBcMyuM1LUfiizZY8hubB94KHc3Cnz\n\teCGgkLAO0S9phnlH5Sz8OPQWGVvzfmmlE4Zd4n5P71JToIUWzQm37K5lxJGdOMCj\n\t/DF7dRCyUcux/Zd6q/mhmr1Cc4i3QrUnGlI6ALUZHwJhogWtFtJ5PpCJ2rxQ0rOx\n\txKxjOYF3IpYkGHK9nSieGAa1eJWMgpB+X1XIadpiYJzKR21OgQdv4uVO+IrivssW\n\to1YNBm1CXLY594CdCJS5tm9ftIPStDGJWxC5Kvbs84ZEtROVFD2VFgQKmP+RHNLA\n\tX+doT6L0Mgsf/qybRBemYbbDuKca3rkZos0WmIl0A=="],"X-ME-Sender":"","Message-ID":"<1508118927.24322.0.camel@aj.id.au>","From":"Andrew Jeffery ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater , Peter Maydell\n\t","Date":"Mon, 16 Oct 2017 12:25:27 +1030","In-Reply-To":"","References":"<20170920070135.31379-1-clg@kaod.org>\n\t<20170920070135.31379-2-clg@kaod.org>\n\t<1507507449.5452.147.camel@aj.id.au>\n\t<48144f71-c876-0e89-f01e-cbfe87687aee@kaod.org>\n\t<1507693785.5452.175.camel@aj.id.au>\n\t","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-ZAn+KUcnrehn6Q1D5hz2\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the\n\twitherspoon-bmc board","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tqemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]