[{"id":1771645,"web_url":"http://patchwork.ozlabs.org/comment/1771645/","msgid":"","list_archive_url":null,"date":"2017-09-20T07:42:14","subject":"Re: [swupdate] [PATCH] parser: don't use printf() for logging","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 20/09/2017 09:00, Christian Storm wrote:\n> Signed-off-by: Christian Storm \n> ---\n> parser/parser.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/parser/parser.c b/parser/parser.c\n> index c962b59..a41bc24 100644\n> --- a/parser/parser.c\n> +++ b/parser/parser.c\n> @@ -623,7 +623,7 @@ int parse_cfg (struct swupdate_cfg *swcfg, const char *filename)\n> \t\treturn -1;\n> \t} else {\n> \t\tstrncpy(swcfg->version, str, sizeof(swcfg->version));\n> -\t\tfprintf(stdout, \"Version %s\\n\", swcfg->version);\n> +\t\tTRACE(\"Version %s\", swcfg->version);\n> \t}\n> \tsnprintf(node, sizeof(node), \"%s.embedded-script\",\n> \t\t\tNODEROOT);\n> \n\nReviewed-by: Stefano Babic \n\nBest regards,\nStefano","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:4010:c07::238;\n\thelo=mail-lf0-x238.google.com;\n\tenvelope-from=swupdate+bncbaabbw5xrdhakgqegtworui@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"j4GdM+gs\"; dkim-atps=neutral"],"Received":["from mail-lf0-x238.google.com (mail-lf0-x238.google.com\n\t[IPv6:2a00:1450:4010:c07::238])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxsCM6Nnkz9s81\n\tfor ;\n\tWed, 20 Sep 2017 17:42:23 +1000 (AEST)","by mail-lf0-x238.google.com with SMTP id g77sf271676lfg.6\n\tfor ;\n\tWed, 20 Sep 2017 00:42:22 -0700 (PDT)","by 10.46.41.71 with SMTP id u68ls67266lje.20.gmail;\n\tWed, 20 Sep 2017 00:42:19 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9])\n\tby gmr-mx.google.com with ESMTPS id\n\tt142si120021wmt.2.2017.09.20.00.42.19\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 00:42:19 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xxsCH38Z2z1rLGB;\n\tWed, 20 Sep 2017 09:42:19 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xxsCH302vz1r0wg;\n\tWed, 20 Sep 2017 09:42:19 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id ODt9NOq14wYv; Wed, 20 Sep 2017 09:42:18 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 20 Sep 2017 09:42:18 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 2549845406A6;\n\tWed, 20 Sep 2017 09:42:18 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id HAB7ybM9ZBwR; Wed, 20 Sep 2017 09:42:15 +0200 (CEST)","from [192.168.17.18] (unknown [192.168.17.18])\n\tby babic.homelinux.org (Postfix) with ESMTPS id 5951D45404DD;\n\tWed, 20 Sep 2017 09:42:15 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1505893340; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=EmgydKxIWYeYKh2vIRpibFDLlDNbSRUFmfbpA55jN5pqGy5aFtOGnsCiNexMXbyjq7\n\tnDaXbXq3O6eT5EzE3Ax4lkq4zjPOBecLArzi66hg7HMqiOtt1l5HpnYOJTH/8AxZ6iYr\n\tmUYedal02OO5ZQZa/Kd50yoWTpLbIWX3QHq/OVHd5kweOoqydIlta5KN26B7lvZ13DNE\n\tOgsZXA4baH7dNbKc0GJB55PFn60eFxvNjCGzyeZNCA8d+n2zGPv8/ax6Pw2Q0ES2ENLZ\n\tEWKvnFZXdXcMXGhNtbReKbSS0mNjsIKXFjbb6YUmVwkOm/Ubrkv1IaxM8BQkz+I7OUMz\n\tSn6Q==","i=1; a=rsa-sha256; t=1505893339; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=DZVj/26MXcG561v7u6dIwaxohPPrNtCi2nhNOyYNLzTOSEpYG9e8/jJKziJrduAJYh\n\tZHoT9xDp9mAcCZAX6DifdwIjjGc93DS8cWwHlytm8tm6a3jnmdIa1oBDPOhWioyldpzu\n\tl+MEVCuy+M/0LK9yURejpATTvQ/lbAqyMjhuJWjjyfgN/U1FtM8xxYaVLArLK8w8Y4a6\n\tMSFOD4eKhLQgpFccfqwPuzfpIz2LX3ZZbdc3i5FDWdVdPsLcUBisD22z2Avv7mAwszGz\n\t/Exf2SAzbHNY7n9ICwojpoEJ/LSvaaeOKDymwGtGxAtPvIIVBJf77glUNi63kgqaYQYz\n\tb1ww=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=S1gkOsFS1KqMRZC+E2mh3VONKFUoQj/dmD/SF3GluD8=;\n\tb=cGD2uzm7Z0Aq/NLdmCwgLHMH4au2iEwpv5E/VaWd2C1Tkho4xpaiBO6nDBo8V8wasO\n\tVhABajECzmNbrPkcJQKBoPwS7FCw0nxWrJlwbvEuH+QDXGPyEQateZZxWSCxtfKxZ3nK\n\t8MClA5WfVx0Hnj3LmvK4lkvz8VMptmgYFQxAhpZB2ME+qk3rCvCDquyy2IhMA3gJvZfe\n\tuzY7JYYHUZXytVzz6p1IufOEh+5ubStDGsg5Aboh87ERjztiEw1puhwruhppvqSdRrBY\n\t7PPMW30KngdojdwN1UjwpBqenlc0ACs44ADTT9Oh0kumAQNXvlqC+nFM5Fr9U5daQBtp\n\t1SsA==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=QNpEszl68rJshwK0UTde/CYRBaCczM4jbz9pYGLmHyI=;\n\tb=i5vdeNsu8nBkMPkGjw5tvVHmxFA1GxfWvmO95YlKDyHRDOsXNKrm+ABIJkhAkWOwrq\n\tvyA+Dhz44/+ORVpdHglPRv9DzCGyZJg7+HVIyl4LchfDcxvXAwARRZDtDWEAKLiniaBQ\n\tSd1W33vZV771GikzVAlR6ezltGfnYG6qh3W9uxMKoIz8Yhitt+FH/OU4wCwwpzdpaiEt\n\tH1OD9DBJxSNIC+EJfPReMP4h/5FwSsYInHtvQo8PWmNbG0cQrbTH8VpiTeQGe5iDTrP9\n\tkvdD0/xGYeEr//j9b93KIAKqFxXw6VpPtIRHM3al7dfSVtZoHOimE1CpmkUlos0R3AMS\n\teaRw=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.9 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.9 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=S1gkOsFS1KqMRZC+E2mh3VONKFUoQj/dmD/SF3GluD8=;\n\tb=j4GdM+gscwdu35fOjF9gdKcB4mfLtzwbune9eSrdk9P5zFuOL3i5scIjs1adfmeJ6s\n\tgdS7cnfnvMq6HcdeFTgNHijedEOS7LGFyCz7FKDe/5SuyQDF1aFYvaeeFtg8LDybLToS\n\tDHHpyGHANPZ81UoRZGvad9e4XGuNYTv6VCj9KUBi33kaWBqAsdi5hARGrh7tcRH8ViCV\n\txo+AgG2QEFwAN1HPzwLBpk4lNlW1BBHLWbqnj5m3qewPmopK8eMX+Wh2rs27XCLfmHGS\n\tCEjtqnhbeAM4fK8QBSTbrsZp950xTJAKV77lIW7pXdDEctZ3wwCdrgVG5E9tR9lH4jCJ\n\tmNnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=S1gkOsFS1KqMRZC+E2mh3VONKFUoQj/dmD/SF3GluD8=;\n\tb=Pvwj20o6oHNtqzXobekkmQTSQgOUw1gggxX/RdgPeQK5bPCkLZi78cKkXLY46D27fN\n\toKowe4MpsAgvKOipBAxsI4ovFgNHTb8Huyc1DZ5km42M2eYAGwOsboORGRT79ESLnvDu\n\tp7VMpEGks+5BL1WKgk3ViTaskGjSFIWF/zcWyvzvEAL7FQqPUIqVP27+RiytuR/BErrN\n\tiEVELxDBPVXxoqNkzJ7Woi3XwGjuW75tfBjqDeEtHE0pmFEs6SnRbWnuvy4yc7wU7pRK\n\t+AFrHD+SWc+rHFdHTlj3E2qg2GubKdgBQvK7DkKpZIVFb+WUSB6pmQ6A/oTymY2V3viL\n\tGSvQ==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUjU6E2o0T6hCDDllJ5lCoViO6QPbYVUIQjtJRtuux1OAzNS25Vs\n\t2XPmeMFPXmTBfxt+VzY7ang=","X-Google-Smtp-Source":"AOwi7QB6i8VFdSIac1lX4ZQ1hQChIkOZhRqZj0iP9bFhcHh8abBa+np/H5pugdqsKWhkrmnABX0wig==","X-Received":["by 10.25.42.84 with SMTP id f81mr2032lfl.10.1505893340157;\n\tWed, 20 Sep 2017 00:42:20 -0700 (PDT)","by 10.25.74.88 with SMTP id x85mr104297lfa.27.1505893339721;\n\tWed, 20 Sep 2017 00:42:19 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 212.18.0.9 is neither permitted nor\n\tdenied by best guess record for domain of sbabic@denx.de)\n\tclient-ip=212.18.0.9; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH] parser: don't use printf() for logging","To":"Christian Storm , swupdate@googlegroups.com","References":"<20170920070035.10778-1-christian.storm@siemens.com>","From":"Stefano Babic ","Message-ID":"","Date":"Wed, 20 Sep 2017 09:42:14 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920070035.10778-1-christian.storm@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"en-US","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 212.18.0.9 is neither permitted nor denied by best guess\n\trecord\n\tfor domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]