[{"id":1772159,"web_url":"http://patchwork.ozlabs.org/comment/1772159/","msgid":"<68ca6f8d-5673-4177-fadf-ca512258257b@redhat.com>","list_archive_url":null,"date":"2017-09-20T18:47:43","subject":"Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 19.09.2017 23:36, John Snow wrote:\n> Following commit aef77960, remove now-unused definitions from\n> cpu-models.h.\n> \n> Signed-off-by: John Snow \n> ---\n> target/ppc/cpu-models.h | 32 --------------------------------\n> 1 file changed, 32 deletions(-)\n> \n> diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h\n> index df31d7f..b34b512 100644\n> --- a/target/ppc/cpu-models.h\n> +++ b/target/ppc/cpu-models.h\n> @@ -291,34 +291,6 @@ enum {\n> #endif\n> CPU_POWERPC_e200z5 = 0x81000000,\n> CPU_POWERPC_e200z6 = 0x81120000,\n> - /* MPC55xx microcontrollers */\n> -#define CPU_POWERPC_MPC55xx CPU_POWERPC_MPC5567\n> -#if 0\n> -#define CPU_POWERPC_MPC5514E CPU_POWERPC_MPC5514E_v1\n> -#define CPU_POWERPC_MPC5514E_v0 CPU_POWERPC_e200z0\n> -#define CPU_POWERPC_MPC5514E_v1 CPU_POWERPC_e200z1\n> -#define CPU_POWERPC_MPC5514G CPU_POWERPC_MPC5514G_v1\n> -#define CPU_POWERPC_MPC5514G_v0 CPU_POWERPC_e200z0\n> -#define CPU_POWERPC_MPC5514G_v1 CPU_POWERPC_e200z1\n> -#define CPU_POWERPC_MPC5515S CPU_POWERPC_e200z1\n> -#define CPU_POWERPC_MPC5516E CPU_POWERPC_MPC5516E_v1\n> -#define CPU_POWERPC_MPC5516E_v0 CPU_POWERPC_e200z0\n> -#define CPU_POWERPC_MPC5516E_v1 CPU_POWERPC_e200z1\n> -#define CPU_POWERPC_MPC5516G CPU_POWERPC_MPC5516G_v1\n> -#define CPU_POWERPC_MPC5516G_v0 CPU_POWERPC_e200z0\n> -#define CPU_POWERPC_MPC5516G_v1 CPU_POWERPC_e200z1\n> -#define CPU_POWERPC_MPC5516S CPU_POWERPC_e200z1\n> -#endif\n> -#if 0\n> -#define CPU_POWERPC_MPC5533 CPU_POWERPC_e200z3\n> -#define CPU_POWERPC_MPC5534 CPU_POWERPC_e200z3\n> -#endif\n> -#define CPU_POWERPC_MPC5553 CPU_POWERPC_e200z6\n> -#define CPU_POWERPC_MPC5554 CPU_POWERPC_e200z6\n> -#define CPU_POWERPC_MPC5561 CPU_POWERPC_e200z6\n> -#define CPU_POWERPC_MPC5565 CPU_POWERPC_e200z6\n> -#define CPU_POWERPC_MPC5566 CPU_POWERPC_e200z6\n> -#define CPU_POWERPC_MPC5567 CPU_POWERPC_e200z6\n> /* e300 family */\n> /* e300 cores */\n> CPU_POWERPC_e300c1 = 0x00830010,\n> @@ -326,11 +298,7 @@ enum {\n> CPU_POWERPC_e300c3 = 0x00850010,\n> CPU_POWERPC_e300c4 = 0x00860010,\n> /* MPC83xx microcontrollers */\n\nI think you should also remove the above comment now?\n\n> -#define CPU_POWERPC_MPC831x CPU_POWERPC_e300c3\n> -#define CPU_POWERPC_MPC832x CPU_POWERPC_e300c2\n> #define CPU_POWERPC_MPC834x CPU_POWERPC_e300c1\n> -#define CPU_POWERPC_MPC835x CPU_POWERPC_e300c1\n> -#define CPU_POWERPC_MPC836x CPU_POWERPC_e300c1\n> #define CPU_POWERPC_MPC837x CPU_POWERPC_e300c4\n> /* e500 family */\n> /* e500 cores */\n\nWith the above comment removed:\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy7zg5M90z9s7g\n\tfor ;\n\tThu, 21 Sep 2017 04:48:15 +1000 (AEST)","from localhost ([::1]:50184 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duk2f-00047g-Sc\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 14:48:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33101)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duk2L-00047P-Pi\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:47:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duk2I-0002Sn-Mt\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:47:53 -0400","from mx1.redhat.com ([209.132.183.28]:43302)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duk2I-0002Ow-Ep\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:47:50 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 54205C047B79;\n\tWed, 20 Sep 2017 18:47:49 +0000 (UTC)","from [10.36.116.52] (ovpn-116-52.ams2.redhat.com [10.36.116.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3D941614C0;\n\tWed, 20 Sep 2017 18:47:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 54205C047B79","To":"John Snow , qemu-devel@nongnu.org","References":"<20170919213611.8988-1-jsnow@redhat.com>\n\t<20170919213611.8988-2-jsnow@redhat.com>","From":"Thomas Huth ","Message-ID":"<68ca6f8d-5673-4177-fadf-ca512258257b@redhat.com>","Date":"Wed, 20 Sep 2017 20:47:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919213611.8988-2-jsnow@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 20 Sep 2017 18:47:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"imammedo@redhat.com, agraf@suse.de, david@gibson.dropbear.id.au","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773980,"web_url":"http://patchwork.ozlabs.org/comment/1773980/","msgid":"<20170923052336.GF4998@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-23T05:23:36","subject":"Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Sep 20, 2017 at 08:47:43PM +0200, Thomas Huth wrote:\n> On 19.09.2017 23:36, John Snow wrote:\n> > Following commit aef77960, remove now-unused definitions from\n> > cpu-models.h.\n> > \n> > Signed-off-by: John Snow \n> > ---\n> > target/ppc/cpu-models.h | 32 --------------------------------\n> > 1 file changed, 32 deletions(-)\n> > \n> > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h\n> > index df31d7f..b34b512 100644\n> > --- a/target/ppc/cpu-models.h\n> > +++ b/target/ppc/cpu-models.h\n> > @@ -291,34 +291,6 @@ enum {\n> > #endif\n> > CPU_POWERPC_e200z5 = 0x81000000,\n> > CPU_POWERPC_e200z6 = 0x81120000,\n> > - /* MPC55xx microcontrollers */\n> > -#define CPU_POWERPC_MPC55xx CPU_POWERPC_MPC5567\n> > -#if 0\n> > -#define CPU_POWERPC_MPC5514E CPU_POWERPC_MPC5514E_v1\n> > -#define CPU_POWERPC_MPC5514E_v0 CPU_POWERPC_e200z0\n> > -#define CPU_POWERPC_MPC5514E_v1 CPU_POWERPC_e200z1\n> > -#define CPU_POWERPC_MPC5514G CPU_POWERPC_MPC5514G_v1\n> > -#define CPU_POWERPC_MPC5514G_v0 CPU_POWERPC_e200z0\n> > -#define CPU_POWERPC_MPC5514G_v1 CPU_POWERPC_e200z1\n> > -#define CPU_POWERPC_MPC5515S CPU_POWERPC_e200z1\n> > -#define CPU_POWERPC_MPC5516E CPU_POWERPC_MPC5516E_v1\n> > -#define CPU_POWERPC_MPC5516E_v0 CPU_POWERPC_e200z0\n> > -#define CPU_POWERPC_MPC5516E_v1 CPU_POWERPC_e200z1\n> > -#define CPU_POWERPC_MPC5516G CPU_POWERPC_MPC5516G_v1\n> > -#define CPU_POWERPC_MPC5516G_v0 CPU_POWERPC_e200z0\n> > -#define CPU_POWERPC_MPC5516G_v1 CPU_POWERPC_e200z1\n> > -#define CPU_POWERPC_MPC5516S CPU_POWERPC_e200z1\n> > -#endif\n> > -#if 0\n> > -#define CPU_POWERPC_MPC5533 CPU_POWERPC_e200z3\n> > -#define CPU_POWERPC_MPC5534 CPU_POWERPC_e200z3\n> > -#endif\n> > -#define CPU_POWERPC_MPC5553 CPU_POWERPC_e200z6\n> > -#define CPU_POWERPC_MPC5554 CPU_POWERPC_e200z6\n> > -#define CPU_POWERPC_MPC5561 CPU_POWERPC_e200z6\n> > -#define CPU_POWERPC_MPC5565 CPU_POWERPC_e200z6\n> > -#define CPU_POWERPC_MPC5566 CPU_POWERPC_e200z6\n> > -#define CPU_POWERPC_MPC5567 CPU_POWERPC_e200z6\n> > /* e300 family */\n> > /* e300 cores */\n> > CPU_POWERPC_e300c1 = 0x00830010,\n> > @@ -326,11 +298,7 @@ enum {\n> > CPU_POWERPC_e300c3 = 0x00850010,\n> > CPU_POWERPC_e300c4 = 0x00860010,\n> > /* MPC83xx microcontrollers */\n> \n> I think you should also remove the above comment now?\n> \n> > -#define CPU_POWERPC_MPC831x CPU_POWERPC_e300c3\n> > -#define CPU_POWERPC_MPC832x CPU_POWERPC_e300c2\n> > #define CPU_POWERPC_MPC834x CPU_POWERPC_e300c1\n> > -#define CPU_POWERPC_MPC835x CPU_POWERPC_e300c1\n> > -#define CPU_POWERPC_MPC836x CPU_POWERPC_e300c1\n> > #define CPU_POWERPC_MPC837x CPU_POWERPC_e300c4\n> > /* e500 family */\n> > /* e500 cores */\n> \n> With the above comment removed:\n> \n> Reviewed-by: Thomas Huth \n\nNo, there's still one entry left in that subsection, so the comment\nshould stay. Applied.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"RCFUsqk/\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzfCr5RFgz9t67\n\tfor ;\n\tSat, 23 Sep 2017 15:34:00 +1000 (AEST)","from localhost ([::1]:33749 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvd4g-0001e9-PX\n\tfor incoming@patchwork.ozlabs.org; Sat, 23 Sep 2017 01:33:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36258)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvd0M-0007NB-5J\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvd0K-0002D9-Lb\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:30 -0400","from ozlabs.org ([103.22.144.67]:47155)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dvd0K-0002A2-Ax\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:28 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xzf6S1qMGz9t5Y; Sat, 23 Sep 2017 15:29:19 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506144560;\n\tbh=4qUSp2mjNsOff5PqpDS9zC/4HhPPVsIVYVnxvEOeTp4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RCFUsqk/0NpJFrGboMBP65Obu+gZHndG6c5hbhJmeyJVrKI1RSGe+2h5H5vH9EUWU\n\ttYVq281QFDSe6GVfrE8kNtZAUNx3GigxmsiBaBbL6YZSKJyatixiV0j70ao4i1nual\n\tr4x0naxvjakRxxvq6as5ITvlZBwkLn+L4fl+A0bg=","Date":"Sat, 23 Sep 2017 15:23:36 +1000","From":"David Gibson ","To":"Thomas Huth ","Message-ID":"<20170923052336.GF4998@umbus.fritz.box>","References":"<20170919213611.8988-1-jsnow@redhat.com>\n\t<20170919213611.8988-2-jsnow@redhat.com>\n\t<68ca6f8d-5673-4177-fadf-ca512258257b@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"V4N4TvXMNzuFMHdo\"","Content-Disposition":"inline","In-Reply-To":"<68ca6f8d-5673-4177-fadf-ca512258257b@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"imammedo@redhat.com, John Snow , qemu-devel@nongnu.org,\n\tagraf@suse.de","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]