[{"id":1772161,"web_url":"http://patchwork.ozlabs.org/comment/1772161/","msgid":"<61dd1fd1-c3e7-2884-22bf-5856803c2a1b@redhat.com>","list_archive_url":null,"date":"2017-09-20T18:52:21","subject":"Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 19.09.2017 23:36, John Snow wrote:\n> Remove *all* unused CPU definitions as indicated by compile-time\n> `#if 0` constructs.\n> \n> Signed-off-by: John Snow \n> ---\n> target/ppc/cpu-models.h | 223 ------------------------------------------------\n> 1 file changed, 223 deletions(-)\n> \n> diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h\n> index b34b512..248f833 100644\n> --- a/target/ppc/cpu-models.h\n> +++ b/target/ppc/cpu-models.h\n[...]\n> @@ -234,24 +105,11 @@ enum {\n> CPU_POWERPC_440GXb = 0x51B21851,\n> CPU_POWERPC_440GXc = 0x51B21892,\n> CPU_POWERPC_440GXf = 0x51B21894,\n> -#if 0\n> - CPU_POWERPC_440S = xxx,\n> -#endif\n> CPU_POWERPC_440SP = 0x53221850,\n> CPU_POWERPC_440SP2 = 0x53221891,\n> CPU_POWERPC_440SPE = 0x53421890,\n> /* PowerPC 460 family */\n> -#if 0\n> - /* Generic PowerPC 464 */\n> -#define CPU_POWERPC_464 CPU_POWERPC_464H90\n> -#endif\n> /* PowerPC 464 microcontrolers */\n> -#if 0\n> - CPU_POWERPC_464H90 = xxx,\n> -#endif\n> -#if 0\n> - CPU_POWERPC_464H90FP = xxx,\n> -#endif\n\nI think you could also remove the \"/* PowerPC 460 family */\" and \"/*\nPowerPC 464 microcontrolers */\" lines now.\n\nAnyway:\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy85C5vZSz9s4q\n\tfor ;\n\tThu, 21 Sep 2017 04:53:03 +1000 (AEST)","from localhost ([::1]:50200 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duk7K-00069R-0l\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 14:53:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35914)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duk6o-000682-By\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:52:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duk6l-0004Pu-A7\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:52:30 -0400","from mx1.redhat.com ([209.132.183.28]:50634)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duk6l-0004MS-3x\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 14:52:27 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0701F356D4;\n\tWed, 20 Sep 2017 18:52:26 +0000 (UTC)","from [10.36.116.52] (ovpn-116-52.ams2.redhat.com [10.36.116.52])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D81B05D983;\n\tWed, 20 Sep 2017 18:52:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0701F356D4","To":"John Snow , qemu-devel@nongnu.org","References":"<20170919213611.8988-1-jsnow@redhat.com>\n\t<20170919213611.8988-3-jsnow@redhat.com>","From":"Thomas Huth ","Message-ID":"<61dd1fd1-c3e7-2884-22bf-5856803c2a1b@redhat.com>","Date":"Wed, 20 Sep 2017 20:52:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919213611.8988-3-jsnow@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 20 Sep 2017 18:52:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"imammedo@redhat.com, agraf@suse.de, david@gibson.dropbear.id.au","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773985,"web_url":"http://patchwork.ozlabs.org/comment/1773985/","msgid":"<20170923052849.GG4998@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-23T05:28:49","subject":"Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Sep 20, 2017 at 08:52:21PM +0200, Thomas Huth wrote:\n> On 19.09.2017 23:36, John Snow wrote:\n> > Remove *all* unused CPU definitions as indicated by compile-time\n> > `#if 0` constructs.\n> > \n> > Signed-off-by: John Snow \n> > ---\n> > target/ppc/cpu-models.h | 223 ------------------------------------------------\n> > 1 file changed, 223 deletions(-)\n> > \n> > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h\n> > index b34b512..248f833 100644\n> > --- a/target/ppc/cpu-models.h\n> > +++ b/target/ppc/cpu-models.h\n> [...]\n> > @@ -234,24 +105,11 @@ enum {\n> > CPU_POWERPC_440GXb = 0x51B21851,\n> > CPU_POWERPC_440GXc = 0x51B21892,\n> > CPU_POWERPC_440GXf = 0x51B21894,\n> > -#if 0\n> > - CPU_POWERPC_440S = xxx,\n> > -#endif\n> > CPU_POWERPC_440SP = 0x53221850,\n> > CPU_POWERPC_440SP2 = 0x53221891,\n> > CPU_POWERPC_440SPE = 0x53421890,\n> > /* PowerPC 460 family */\n> > -#if 0\n> > - /* Generic PowerPC 464 */\n> > -#define CPU_POWERPC_464 CPU_POWERPC_464H90\n> > -#endif\n> > /* PowerPC 464 microcontrolers */\n> > -#if 0\n> > - CPU_POWERPC_464H90 = xxx,\n> > -#endif\n> > -#if 0\n> > - CPU_POWERPC_464H90FP = xxx,\n> > -#endif\n> \n> I think you could also remove the \"/* PowerPC 460 family */\" and \"/*\n> PowerPC 464 microcontrolers */\" lines now.\n> \n> Anyway:\n> \n> Reviewed-by: Thomas Huth \n\nYes, I've made that extra change and applied.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"U46K09gf\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzfMw2Gx6z9t67\n\tfor ;\n\tSat, 23 Sep 2017 15:41:00 +1000 (AEST)","from localhost ([::1]:33790 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvdBS-0007EO-FO\n\tfor incoming@patchwork.ozlabs.org; Sat, 23 Sep 2017 01:40:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36249)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvd0L-0007N0-UV\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvd0K-0002DE-Mk\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:29 -0400","from ozlabs.org ([2401:3900:2:1::2]:58505)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dvd0K-0002A0-Bl\n\tfor qemu-devel@nongnu.org; Sat, 23 Sep 2017 01:29:28 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xzf6S2t54z9t5b; Sat, 23 Sep 2017 15:29:19 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506144560;\n\tbh=aCjeUXhCHm306rEOwz4h6DP08xgkgezK+IpvNuHEYnk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U46K09gfWsdhjUnFh2Aa5a4OgAxc69XM1laEJQLKIoqO18kxE9wl8IM9HuWI4wQsh\n\t6+iwIpcWn/bN7IzjSOrXq6wFpYGP+oxRuN3fti4piHGzUUdaGo8uQtkUz7Anr35LCs\n\tUhNjmvHZRygWREgnRYPrFn1cjijbyguZxx6qIHAs=","Date":"Sat, 23 Sep 2017 15:28:49 +1000","From":"David Gibson ","To":"Thomas Huth ","Message-ID":"<20170923052849.GG4998@umbus.fritz.box>","References":"<20170919213611.8988-1-jsnow@redhat.com>\n\t<20170919213611.8988-3-jsnow@redhat.com>\n\t<61dd1fd1-c3e7-2884-22bf-5856803c2a1b@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"Rm5rkB9L8kG9H2n8\"","Content-Disposition":"inline","In-Reply-To":"<61dd1fd1-c3e7-2884-22bf-5856803c2a1b@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"imammedo@redhat.com, John Snow , qemu-devel@nongnu.org,\n\tagraf@suse.de","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]