[{"id":1771563,"web_url":"http://patchwork.ozlabs.org/comment/1771563/","msgid":"","list_archive_url":null,"date":"2017-09-20T05:01:45","subject":"Re: [U-Boot] [PATCH v2 2/6] pci: xilinx: Use pci_generic_mmap_{read,\n\twrite}_config()","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Wed, Sep 20, 2017 at 4:18 AM, Tuomas Tynkkynen\n wrote:\n> Use the new helper function to avoid boilerplate in the driver.\n>\n> Note that this changes __raw_writel et al. to writel. AFAICT this is\n> no problem because:\n>\n> - The Linux driver for the same hardware uses the non-__raw variants as\n> well (via pci_generic_config_write()).\n> - This driver seems to be used only on MIPS so far, where the __raw and\n> non-__raw accessors are the same.\n>\n> Signed-off-by: Tuomas Tynkkynen \n> ---\n> drivers/pci/pcie_xilinx.c | 53 +++++++----------------------------------------\n> 1 file changed, 7 insertions(+), 46 deletions(-)\n>\n\nReviewed-by: Bin Meng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YfI4yNmf\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxngD61wBz9s8J\n\tfor ;\n\tWed, 20 Sep 2017 15:02:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9312FC21D55; Wed, 20 Sep 2017 05:02:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2A745C21D8B;\n\tWed, 20 Sep 2017 05:01:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DAE62C21D5B; Wed, 20 Sep 2017 05:01:46 +0000 (UTC)","from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 47C58C21C40\n\tfor ; Wed, 20 Sep 2017 05:01:46 +0000 (UTC)","by mail-wr0-f194.google.com with SMTP id g50so803672wra.3\n\tfor ; Tue, 19 Sep 2017 22:01:46 -0700 (PDT)","by 10.223.145.3 with HTTP; Tue, 19 Sep 2017 22:01:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=xadz0fwFG6dwNJ+FM+7/h+Sa9M4Q3zz+yb/bp8VLHdg=;\n\tb=YfI4yNmfkbJs9M3uxv+34YAaV5ghaOZk7shBz09zccDhLp8xfgNZ7lNBGLxjC9S/lY\n\t/aDz/p2KQtVr3jajVgo2Dr8ntDWylWdpmNpAcaDQBZMA5DkLcBsVL+5+IzeaFOCY0NLO\n\tVAptGPObPJLIQPlgshJUPTbdpITfbqP1BkE4/zlIaCAys+eRr1i/4lMYgSHXWlM40WoO\n\tpKLmtzPum3kx/hbrg1ZvfFd0Wgj+YEUBtcHLd/mdU3fUzzDU9qrK8VYOXRRPe/+p2I//\n\tSxqAVubvDzx8Bidv72zblhBJstJOSmso1MdEm+pvIGbvTKMMB0ZlpGhDgEZuhilsKFdZ\n\t7BcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=xadz0fwFG6dwNJ+FM+7/h+Sa9M4Q3zz+yb/bp8VLHdg=;\n\tb=tc08uzlAh3LuCkMj4HgirPOqo55JDWZNiHzyjVs8cmi6wZZeqpahFWO6jvYTuFjA9J\n\tLlFsety3QFvGBY9E9Dt3XDx86Y6DyxuAOwHIjHcKYilXt+oBcBP6U4JRR4dqhd7iWea0\n\tdvPzKcv1HogCs3KOTqBkWw3dcdfanKpkORyYoV3Ow4gmOUuLiukkgTKCN9rN6WgRE10b\n\ttZ3JgvRNwIZ8b8Q8+naIqLOeq4r22ysLrs3lzrPxAStk1aQk9AmoywD+Z4LtwCRLeuQb\n\tIwD2DmLT4LDQtStY9nvYk344KMX67WlvjyxZ/flKEnA0FnX1X6Lb75e+5UwoMJNFsK2e\n\t1TmA==","X-Gm-Message-State":"AHPjjUhXqFfRmUNdU1QGEh752BqO/T7yp8XPd8HgHHgxJCDynHuuz9H0\n\tRzCRqjZ66l9hPB5Q9+KnilVdwaR99wQHXW4cgJI=","X-Google-Smtp-Source":"AOwi7QBVCm39wViIeIZxNtafZNZ1yd+OoHzGQWZZivc0u5VseVX52LH+KiM6bPpk0NEtB4z3ugV0+zu+5aFj+43MhEo=","X-Received":"by 10.223.146.197 with SMTP id 63mr3091599wrn.180.1505883705950; \n\tTue, 19 Sep 2017 22:01:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170919201808.11433-3-tuomas.tynkkynen@iki.fi>","References":"<20170919201808.11433-1-tuomas.tynkkynen@iki.fi>\n\t<20170919201808.11433-3-tuomas.tynkkynen@iki.fi>","From":"Bin Meng ","Date":"Wed, 20 Sep 2017 13:01:45 +0800","Message-ID":"","To":"Tuomas Tynkkynen ","Cc":"U-Boot Mailing List , Tom Rini ","Subject":"Re: [U-Boot] [PATCH v2 2/6] pci: xilinx: Use pci_generic_mmap_{read,\n\twrite}_config()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1782113,"web_url":"http://patchwork.ozlabs.org/comment/1782113/","msgid":"<20171007130750.GP25966@bill-the-cat>","list_archive_url":null,"date":"2017-10-07T13:07:50","subject":"Re: [U-Boot] [U-Boot, v2,\n\t2/6] pci: xilinx: Use pci_generic_mmap_{read, write}_config()","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Sep 19, 2017 at 11:18:04PM +0300, Tuomas Tynkkynen wrote:\n\n> Use the new helper function to avoid boilerplate in the driver.\n> \n> Note that this changes __raw_writel et al. to writel. AFAICT this is\n> no problem because:\n> \n> - The Linux driver for the same hardware uses the non-__raw variants as\n> well (via pci_generic_config_write()).\n> - This driver seems to be used only on MIPS so far, where the __raw and\n> non-__raw accessors are the same.\n> \n> Signed-off-by: Tuomas Tynkkynen \n> Reviewed-by: Bin Meng \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"Vfu8eMhs\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y8RpG4L8Jz9t6Z\n\tfor ;\n\tSun, 8 Oct 2017 00:15:50 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 636EEC21E0E; Sat, 7 Oct 2017 13:10:20 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1AD81C21E93;\n\tSat, 7 Oct 2017 13:08:58 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BDA13C21E9C; Sat, 7 Oct 2017 13:07:57 +0000 (UTC)","from mail-qt0-f175.google.com (mail-qt0-f175.google.com\n\t[209.85.216.175])\n\tby lists.denx.de (Postfix) with ESMTPS id 230A7C21E70\n\tfor ; Sat, 7 Oct 2017 13:07:54 +0000 (UTC)","by mail-qt0-f175.google.com with SMTP id 34so18907182qtb.13\n\tfor ; Sat, 07 Oct 2017 06:07:54 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:6821:3a00:ff9f:889e])\n\tby smtp.gmail.com with ESMTPSA id\n\to184sm1543181ywc.52.2017.10.07.06.07.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 07 Oct 2017 06:07:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=ehAkltLEcn0wpkaRs/MaNU58IKWRRYNIRvhIVQdCy9I=;\n\tb=Vfu8eMhs99tfz/m2ZsjMQlwRswflnO0S3D7iEqkSuoyR8tR2v6E7uNQMRja54VlRTz\n\turp0/N0Sj0HhtTkorqEftCbkv9De7zh4a9w9t2kX+LZyKtE2YzRC8OIEKIfPrb1Udq/P\n\tlJZmYCXrtGpkhrWEeyVvXtLl8VQRyYtOpC94s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=ehAkltLEcn0wpkaRs/MaNU58IKWRRYNIRvhIVQdCy9I=;\n\tb=QIwKxq39aw8+56/APf6xAjJ0KlkgWUd3/Cfm4FnfZDwhJ4xw9kYAy0vj6VaCm/f3O8\n\trTf4NXcUZfU2NJkUZcZPB5Go1nzhj5O37rJpUa69Zj8SFjjIQlEONhNGyFPQZrwq/W0F\n\trSWxema1of9MNpE+5mWsgX1aDJRWREhJOQc6uFzcjZ9/M69rxja/K+QUVn+rrr2HUu4I\n\tyDeL9DrT/wZe2FdjvRZNOfb67CV/8LmsvTFGwNCU11ArPAMSA9+4qdlHRqlSj1WK7vLN\n\to+SYbdHpfd4g5vTr6qZHI63IpZPJkdSzaNbTZROzuTFcqbVMakVIJGxKSESB14VKuxUT\n\tfFzA==","X-Gm-Message-State":"AMCzsaVLllqm6ljXaMkeCu2HNo0CICd8dWY87BoQwwm+9f8UbLB8N1Tl\n\tD96BdOa302jVpRg1UQ144V1WTNZ1LTQ=","X-Google-Smtp-Source":"AOwi7QCMV0ial6gl0nW764VyN8kx7jFKEkM4NlQ39RTfuECYTMLcyBfD0vMEYAdDNuGQVAdUFdUfpQ==","X-Received":"by 10.13.198.6 with SMTP id i6mr4158588ywd.18.1507381673101;\n\tSat, 07 Oct 2017 06:07:53 -0700 (PDT)","Date":"Sat, 7 Oct 2017 09:07:50 -0400","From":"Tom Rini ","To":"Tuomas Tynkkynen ","Message-ID":"<20171007130750.GP25966@bill-the-cat>","References":"<20170919201808.11433-3-tuomas.tynkkynen@iki.fi>","MIME-Version":"1.0","In-Reply-To":"<20170919201808.11433-3-tuomas.tynkkynen@iki.fi>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [U-Boot, v2,\n\t2/6] pci: xilinx: Use pci_generic_mmap_{read, write}_config()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============2538685249280002087==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]