[{"id":1772782,"web_url":"http://patchwork.ozlabs.org/comment/1772782/","msgid":"<20170921123908.GF2717@work-vm>","list_archive_url":null,"date":"2017-09-21T12:39:09","subject":"Re: [Qemu-devel] [PATCH v10 09/10] migration: add blocktime\n\tcalculation into postcopy-test","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Alexey Perevalov (a.perevalov@samsung.com) wrote:\n> This patch just requests blocktime calculation, but doesn't\n> add any facility to check or show it.\n> \n> Signed-off-by: Alexey Perevalov \n> ---\n> tests/postcopy-test.c | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c\n> index 8142f2a..1db5359 100644\n> --- a/tests/postcopy-test.c\n> +++ b/tests/postcopy-test.c\n> @@ -425,6 +425,17 @@ static void test_migrate(void)\n> g_assert(qdict_haskey(rsp, \"return\"));\n> QDECREF(rsp);\n> \n> +#ifdef UFFD_FEATURE_THREAD_ID\n> + global_qtest = to;\n> + rsp = qmp(\"{ 'execute': 'migrate-set-capabilities',\"\n> + \"'arguments': { \"\n> + \"'capabilities': [ {\"\n> + \"'capability': 'postcopy-blocktime',\"\n> + \"'state': true } ] } }\");\n> + g_assert(qdict_haskey(rsp, \"return\"));\n> + QDECREF(rsp);\n> +#endif\n> +\n\nI think that'll break; once you sync the kernel headers up,\nwe'll always get that defined even when we're building or running\non an older kernel.\nSo I think you need to try and enable it but fall back if it's not\navailable somehow.\n\nDave\n\n> /* We want to pick a speed slow enough that the test completes\n> * quickly, but that it doesn't complete precopy even on a slow\n> * machine, so also set the downtime.\n> @@ -441,7 +452,6 @@ static void test_migrate(void)\n> g_assert(qdict_haskey(rsp, \"return\"));\n> QDECREF(rsp);\n> \n> -\n> /* Wait for the first serial output from the source */\n> wait_for_serial(\"src_serial\");\n> \n> -- \n> 1.9.1\n> \n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xybm72LFMz9sP1\n\tfor ;\n\tThu, 21 Sep 2017 22:39:51 +1000 (AEST)","from localhost ([::1]:53486 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv0lh-0000SU-ER\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 08:39:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46451)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dv0lE-0000Qz-9e\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:39:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dv0lB-0005Em-7N\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:39:20 -0400","from mx1.redhat.com ([209.132.183.28]:36452)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dv0lB-0005Dz-0o\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:39:17 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1C0CB4E334;\n\tThu, 21 Sep 2017 12:39:16 +0000 (UTC)","from work-vm (ovpn-117-186.ams2.redhat.com [10.36.117.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 96D0760243;\n\tThu, 21 Sep 2017 12:39:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1C0CB4E334","Date":"Thu, 21 Sep 2017 13:39:09 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Alexey Perevalov ","Message-ID":"<20170921123908.GF2717@work-vm>","References":"<1505839684-10046-1-git-send-email-a.perevalov@samsung.com>\n\t\n\t<1505839684-10046-10-git-send-email-a.perevalov@samsung.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505839684-10046-10-git-send-email-a.perevalov@samsung.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 21 Sep 2017 12:39:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v10 09/10] migration: add blocktime\n\tcalculation into postcopy-test","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"heetae82.ahn@samsung.com, quintela@redhat.com, qemu-devel@nongnu.org,\n\tpeterx@redhat.com, i.maximets@samsung.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]