[{"id":1771243,"web_url":"http://patchwork.ozlabs.org/comment/1771243/","msgid":"","list_archive_url":null,"date":"2017-09-19T17:48:17","subject":"Re: [PATCH net-next 2/4] net: dsa: setup master ethtool\n\tunconditionally","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/19/2017 08:56 AM, Vivien Didelot wrote:\n> When a DSA switch tree is meant to be applied, it already has a CPU\n> port. Thus remove the condition of dst->cpu_dp.\n> \n> Moreover, the next lines access dst->cpu_dp unconditionally.\n> \n> Signed-off-by: Vivien Didelot \n\nReviewed-by: Florian Fainelli ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PxIl7xjA\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVjb61v7z9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:48:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751681AbdISRsX (ORCPT );\n\tTue, 19 Sep 2017 13:48:23 -0400","from mail-wr0-f170.google.com ([209.85.128.170]:48463 \"EHLO\n\tmail-wr0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751646AbdISRsW (ORCPT\n\t); Tue, 19 Sep 2017 13:48:22 -0400","by mail-wr0-f170.google.com with SMTP id 108so292503wra.5;\n\tTue, 19 Sep 2017 10:48:21 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tw2sm9777726wrb.67.2017.09.19.10.48.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 10:48:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=YTvYWWKy5T4f1OI5TvLgh/sw1XgLeNRlVBmW0ZCa6Sw=;\n\tb=PxIl7xjAwYAljG2N7/3GyH+oOwxDS7jYEtHNbcQsi5S7ly/qdfCKbmGYnXraSzWXKj\n\tEibIBaoOfxnkA1Nee03b7xTVzziNIQpTBle4ZClOA2xoir0XWnWrLgj1PgzAKGwG2Ne1\n\t3xkwU3RaQihOnDpyZzxvFAMs3SjC/Oz/gm0NPXDBwuBvJV3KHpOvhxEx7n0OuywTEcJU\n\t4+udnf0iEhYWteKvrz1ZpXtut7I5c32ztMtsF2fCJnwSzM7ASN5eCOSjZO6Aak8I7USI\n\tfEOiisSV9Jxt924cV6ylZ8k3m1CmvhTQwUx/qORaCQmiuIGDo0zIeYKI4BLHuccu3ge+\n\tv8GA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=YTvYWWKy5T4f1OI5TvLgh/sw1XgLeNRlVBmW0ZCa6Sw=;\n\tb=kudejE5P61rL7/+NorQj2JUrF775qzT0pUxr/mT989Glta0nBpsifyy7l9z79p90h/\n\tMFZPEpZ5m7ar58UW1zLgZ2klINgT7sYESjOZf4BqVgFBD5kL23c+ziF5hirvxwIDmK1a\n\t+Qgm79+UVPb4AnY6pyJwQFZTlZOUTj5l4Uxgkw8KHFWpNmTfixOsmcfbPvSjm2xdXqbz\n\tb1WsGA64TyPvWzSYoSHNL/uV+Dx3dNNbh7dfKaEAIWyvYflXc5Thd1/0kDSMflMKSVHm\n\tYOGyqv75xQpO4OCt8cstKJjON1IGJVrjtGlzba42xeo2rDAJ4dn7dVc0Jbd3nlt9s+vu\n\tONxg==","X-Gm-Message-State":"AHPjjUi3Oml3Z60QAAG6060hHBZSUra3ZU92nC5fS+BkONAdtfRwj2JG\n\tgHv7GGsrW21iSU8rUhpQAQI=","X-Google-Smtp-Source":"AOwi7QBbd2T0nZk0RCBTANbhhmtzHgD79ctX4iIoWW9oLE9hEwqsFSai51q1cVhQycv/Ay+6gFwfSw==","X-Received":"by 10.223.143.105 with SMTP id p96mr2243989wrb.118.1505843301219;\n\tTue, 19 Sep 2017 10:48:21 -0700 (PDT)","Subject":"Re: [PATCH net-next 2/4] net: dsa: setup master ethtool\n\tunconditionally","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>\n\t<20170919155700.14474-3-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"","Date":"Tue, 19 Sep 2017 10:48:17 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919155700.14474-3-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]