[{"id":1771334,"web_url":"http://patchwork.ozlabs.org/comment/1771334/","msgid":"","list_archive_url":null,"date":"2017-09-19T19:55:54","subject":"Re: [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/19/2017 08:56 AM, Vivien Didelot wrote:\n> There is no need to store a copy of the master ethtool ops, storing the\n> original pointer in DSA and the new one in the master netdev itself is\n> enough.\n> \n> In the meantime, set orig_ethtool_ops to NULL when restoring the master\n> ethtool ops and check the presence of the master original ethtool ops as\n> well as its needed functions before calling them.\n\nI clearly like memcpy() too much, this looks good:\n\nReviewed-by: Florian Fainelli ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BZgERadZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxYXg5tZfz9sMN\n\tfor ;\n\tWed, 20 Sep 2017 05:56:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751602AbdIST4E (ORCPT );\n\tTue, 19 Sep 2017 15:56:04 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:35906 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751541AbdIST4C (ORCPT\n\t); Tue, 19 Sep 2017 15:56:02 -0400","by mail-wm0-f65.google.com with SMTP id r136so586064wmf.3;\n\tTue, 19 Sep 2017 12:56:01 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tf140sm75045wmd.12.2017.09.19.12.55.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 12:55:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=OZbW+TK+tZMdTgmbeWBmpo1Rehq9iFaoH7Y7vS5dHYE=;\n\tb=BZgERadZpQilCCTv4om4VPaOLNtf/WFE/Tbyg6pkkk17hzIieegh+FLKISCIR/j7Tl\n\tO4CJh3TClGV/ydVHqebZzft2Bd+FLjyrBsLwKHIIlS0UmMm2SRnvYaiT/3rdzNxJqdyd\n\tJThqPfHe+sTpQc8UQ6TRCeooIWeALOSct0WIdnu5QEJjdb+KWEMvRpV6HX/QhTVwn+sp\n\tCWj3v8JkmpS25mD/G+mNpXdFJ0LWO8fkZjLc6yzM3n49WY/3rta0fRUJqdVr+n/q0OTx\n\tQS0zfYLjDyjFL9irU2bkrR4tZ/vX/abIQ0RGHR9zswEGH6qnvZ3+9k90nbkGYHA8dBv2\n\tX3Xw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OZbW+TK+tZMdTgmbeWBmpo1Rehq9iFaoH7Y7vS5dHYE=;\n\tb=MD3Sdvk3un69PNHAjQFqsqyLgCBNr1eEmiaiV7xfHbNdNdWXJLEu/8pHSwXZ9OGt8v\n\th24FoNZ/t65EtTCzrey37PgfFLxwEiiTBSDeONmog3MBfXrV8cXfXXghH7r7wjG3UZxS\n\t7jPZ1V1Dhsxpgt+UkXhw6wEmFAHrZgYMypszWQId7v3APPx73HJW/ITgZXAmLW3e8P8o\n\tw0EyqLdLSpTgV8ELNEF4QEWYBzUoxVMyM8PIv7yA+qXucrtcoeNO8Zu/aiyCUFpEv7D5\n\tBAWdl2JMh8CZqIzmAEnoaobmtTId2lAwXoxKm/iu77gatnBIH2nGRXqc71cYlJ45cKLF\n\t/jYg==","X-Gm-Message-State":"AHPjjUgSD+0nCHH1SOAiDBVBD2aN/qxIPswasJqLbW2/wNGQN2fQ1yD7\n\t7TP8okCbpNWKiiGdiQJ5x+A=","X-Google-Smtp-Source":"AOwi7QADUARysxF6SFq86cfy7XIgsQS/nanK33/ZJXq/nzPkEfoNYh+OhIfCaUO5XR1VBIbuCIZoGQ==","X-Received":"by 10.28.156.18 with SMTP id f18mr1912401wme.63.1505850961097;\n\tTue, 19 Sep 2017 12:56:01 -0700 (PDT)","Subject":"Re: [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>\n\t<20170919155700.14474-2-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"","Date":"Tue, 19 Sep 2017 12:55:54 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919155700.14474-2-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]