[{"id":1771245,"web_url":"http://patchwork.ozlabs.org/comment/1771245/","msgid":"<85ebc3f7-b8b1-a2e4-f0e4-32c309857730@gmail.com>","list_archive_url":null,"date":"2017-09-19T17:49:52","subject":"Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after\n\tdsa_ptr","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/19/2017 08:56 AM, Vivien Didelot wrote:\n> DSA overrides the master's ethtool ops so that we can inject its CPU\n> port's statistics. Because of that, we need to setup the ethtool ops\n> after the master's dsa_ptr pointer has been assigned, not before.\n\nYes, good point, technically this is a bugfix, but since we have changed\nthis quite often and the race is tiny, I am not positive we could a)\ntrigger this in real life, and b) provide a proper Fixes tag.\n\n> \n> This patch setups the ethtool ops after dsa_ptr is assigned, and\n> restores them before it gets cleared.\n> \n> Signed-off-by: Vivien Didelot \n\nReviewed-by: Florian Fainelli ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Mpag6Cq1\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVl750zyz9sPk\n\tfor ;\n\tWed, 20 Sep 2017 03:50:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751588AbdISRuA (ORCPT );\n\tTue, 19 Sep 2017 13:50:00 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:36572 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751353AbdISRt6 (ORCPT\n\t); Tue, 19 Sep 2017 13:49:58 -0400","by mail-wm0-f67.google.com with SMTP id r136so314372wmf.3;\n\tTue, 19 Sep 2017 10:49:57 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\t193sm2781752wmh.47.2017.09.19.10.49.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 10:49:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=eF5+US/TFkc0QM4EOreuYuRYBEws1Xz0dHPvU7m5itg=;\n\tb=Mpag6Cq1UiKCib80xZZpyreTIpXNOWs9cdfHhSpaCR+7t7mjKa8l1+pRgrO8b9LtkT\n\tz6aLnUY+MJdEzl38bHlpcor92hNLEqrsoEjqUAtmazGc6TW45s44nNzWnI0KdnNrFVIp\n\tvwp/KDGuyqCnLBmN3zI1QNH50U3xVK6K4m4f+HDuCqtNHFcjcmHSh1o2mY5hVFX/gI1O\n\taDVGJhXLfS7xmWHlQlPaBO/tiAo8Xrk2nWn4gQMGqPjrmUm3uO9G1MvYchDyMyseHpZD\n\tVy2q+uGNBR0rCU4qlh+rI0vDLGA6iuAotbS0JDXKDsCAgk3D8d1aJSHo7sgB2R7LoGZA\n\t5w0w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=eF5+US/TFkc0QM4EOreuYuRYBEws1Xz0dHPvU7m5itg=;\n\tb=HH82u7sl1ZaDT3D4JNCdv/4+SIO68O53AhmqSdcbf8cAoV72pcMg4koRY4h3ehGrii\n\tZUWF91ciAsjQahxMDU14Hz1PPl72RvesOiP5d+7/isdOrzHOOtzSqzDcU1rddaIomTVZ\n\trfJYPO1f7bq2xJl7sPDxOIbn6BvQhv4XzgpBzXO5M5ntKX2dWubVTZouW5asHz4OcTDY\n\tmo2F27mpTe5oxirmtI60zKE5/R3XXywZFI55OGGDMsn6e4bJQIy5vCABPJefbqKLsipu\n\tPyUhUciAa3aVvqWY4BzuX/iAbm4E8v2H6O+9ii7euaLfWHTLnSgWqE0y5gOWM8eoKY3k\n\tGHzw==","X-Gm-Message-State":"AHPjjUjwZWEfpXd2qsRBN3NXGP0lAUIKfPTyMfGf6qxFd9SHZuYum6pM\n\tOnJI5RvAf+CSuBf/PqX8yXc=","X-Google-Smtp-Source":"AOwi7QDk5CtMyxx8xVyZBjr5RGhidHI+EQrtWlX4b1xe7msqY46molBy4kJGToaPxDggivrrYIxyQQ==","X-Received":"by 10.28.29.71 with SMTP id d68mr1941842wmd.114.1505843397279;\n\tTue, 19 Sep 2017 10:49:57 -0700 (PDT)","Subject":"Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after\n\tdsa_ptr","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>\n\t<20170919155700.14474-4-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"<85ebc3f7-b8b1-a2e4-f0e4-32c309857730@gmail.com>","Date":"Tue, 19 Sep 2017 10:49:52 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919155700.14474-4-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]