[{"id":1771841,"web_url":"http://patchwork.ozlabs.org/comment/1771841/","msgid":"<87y3p9d3fq.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-20T11:17:45","subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Richard Henderson writes:\n\n> If configured, prefer this over our rather dated copy of the\n> GPLv2-only binutils. This will be especially apparent with\n> the proposed vector extensions to TCG, as disas/i386.c does\n> not handle AVX.\n>\n> Signed-off-by: Richard Henderson \n\nHmm I get a link failure:\n\n LINK tilegx-linux-user/qemu-tilegx\ndisas.o: In function `cap_disas_start':\n/home/alex/lsrc/qemu/qemu.git/disas.c:196: undefined reference to `cs_open'\n/home/alex/lsrc/qemu/qemu.git/disas.c:210: undefined reference to `cs_option'\n/home/alex/lsrc/qemu/qemu.git/disas.c:214: undefined reference to `cs_malloc'\n/home/alex/lsrc/qemu/qemu.git/disas.c:216: undefined reference to `cs_close'\n/home/alex/lsrc/qemu/qemu.git/disas.c:206: undefined reference to `cs_option'\ndisas.o: In function `cap_disas_target':\n/home/alex/lsrc/qemu/qemu.git/disas.c:244: undefined reference to `cs_disasm_iter'\n/home/alex/lsrc/qemu/qemu.git/disas.c:272: undefined reference to `cs_close'\ndisas.o: In function `cap_disas_host':\n/home/alex/lsrc/qemu/qemu.git/disas.c:292: undefined reference to `cs_disasm_iter'\n/home/alex/lsrc/qemu/qemu.git/disas.c:304: undefined reference to `cs_close'\ncollect2: error: ld returned 1 exit status\nMakefile:199: recipe for target 'qemu-tilegx' failed\nmake[1]: *** [qemu-tilegx] Error 1\nmake[1]: Target 'all' not remade because of errors.\nMakefile:326: recipe for target 'subdir-tilegx-linux-user' failed\nmake: *** [subdir-tilegx-linux-user] Error 2\n LINK x86_64-linux-user/qemu-x86_64\n\nI wonder if this is a version thing?\n\n Package: libcapstone-dev\n Status: install ok installed\n Priority: optional\n Section: libdevel\n Installed-Size: 4079\n Maintainer: Ubuntu Developers \n Architecture: amd64\n Source: capstone\n Version: 3.0.4-0.2\n Depends: libcapstone3 (= 3.0.4-0.2)\n Description: lightweight multi-architecture disassembly framework - devel files\n Capstone is a lightweight multi-platform, multi-architecture disassembly\n framework.\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"PlbTqoLh\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0lr58dlz9rxj\n\tfor ;\n\tWed, 20 Sep 2017 23:22:32 +1000 (AEST)","from localhost ([::1]:48052 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duexS-0006rC-P0\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 09:22:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51015)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duevA-0005kh-4x\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:21:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dueu7-0003Mv-2D\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:20:07 -0400","from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:50198)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dueu6-0003I9-8c\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:19:02 -0400","by mail-wr0-x229.google.com with SMTP id w12so2137377wrc.7\n\tfor ; Wed, 20 Sep 2017 06:19:02 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\to138sm1422359wmg.36.2017.09.20.04.17.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 04:17:43 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 51A0D3E010A;\n\tWed, 20 Sep 2017 12:17:45 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=d82gDEOI2sJxwED1Zu6QXky9JtEF6T25sliiEyFPcAs=;\n\tb=PlbTqoLhz+zYCK9TvQ4OQ7mBXQv8X9xSo+vpedabKaTOZck8U9KkJu0iw9HkZCX9I3\n\t5jA8/HO8sHsw2rx5P/cn6wQAy0GhgKpRNUaj2yUXzSMypGIQphcKdV/u4YNAnTLNCY2r\n\t3q39Ip4Fv6U1QqHLIcH6UnBCY9jSKgvk3Gh9Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=d82gDEOI2sJxwED1Zu6QXky9JtEF6T25sliiEyFPcAs=;\n\tb=f0toZg8mP5479NRCGOZIRyxbit6U2a4zPWtoyBCQNzcELpG98SMBwE03+OUxMM0XeR\n\ti9/ui1c6FafZM4MKh99JFnQLcvJjjL4sL2veADeYnmluMhvUXgiCfFVuwfQiD5fndPP5\n\tmdiSbaU8/rihTHJQmsOSRzyyju/4ibB2hbw60m7d/wQ4sAGFhpQYwbkgAcHYnVyZQgcJ\n\tqOxte0YEZ4RmMiIWQ+1N3CGNN6/pnC3alYubaeW1HJNRiaoAe9LfYj8KT0J209Km8TdX\n\tdkecSn45AUxvwapHBvBSshzBAFxOk7u/d1NLzZgj6pVc2B8c6eIjP7Va8wa0yQIC0B5X\n\tHiyQ==","X-Gm-Message-State":"AHPjjUjSODCZUQMmaoRUHxcjM+RMWyV3zXr2RyaUoTiy6g00cqiDGAQd\n\trK7a/ttW/dW+3pCjut3PNUw78ZXG9ts=","X-Google-Smtp-Source":"AOwi7QAstZ2Db8vIr2mdZk+42kFjZiNm93GEY6CA0EHWMCr25DTLNCpKhHCWU0HfElNdY770YXe+Kw==","X-Received":"by 10.223.161.194 with SMTP id v2mr4214081wrv.45.1505906264608; \n\tWed, 20 Sep 2017 04:17:44 -0700 (PDT)","References":"<20170919150313.10833-1-richard.henderson@linaro.org>\n\t<20170919150313.10833-5-richard.henderson@linaro.org>","User-agent":"mu4e 0.9.19; emacs 25.3.50.1","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Richard Henderson ","In-reply-to":"<20170919150313.10833-5-richard.henderson@linaro.org>","Date":"Wed, 20 Sep 2017 12:17:45 +0100","Message-ID":"<87y3p9d3fq.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::229","Subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771842,"web_url":"http://patchwork.ozlabs.org/comment/1771842/","msgid":"<8deb13bd-af38-9851-085f-6428255297d3@linaro.org>","list_archive_url":null,"date":"2017-09-20T13:04:26","subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/20/2017 06:17 AM, Alex Bennée wrote:\n> \n> Richard Henderson writes:\n> \n>> If configured, prefer this over our rather dated copy of the\n>> GPLv2-only binutils. This will be especially apparent with\n>> the proposed vector extensions to TCG, as disas/i386.c does\n>> not handle AVX.\n>>\n>> Signed-off-by: Richard Henderson \n> \n> Hmm I get a link failure:\n> \n> LINK tilegx-linux-user/qemu-tilegx\n> disas.o: In function `cap_disas_start':\n> /home/alex/lsrc/qemu/qemu.git/disas.c:196: undefined reference to `cs_open'\n\nI'm going to assume that this isn't the first executable to be linked, and\ntherefore it's weirder than what I imagine.\n\n> I wonder if this is a version thing?\n> \n> Package: libcapstone-dev\n> Status: install ok installed\n> Priority: optional\n> Section: libdevel\n> Installed-Size: 4079\n> Maintainer: Ubuntu Developers \n> Architecture: amd64\n> Source: capstone\n> Version: 3.0.4-0.2\n\nNo, I've got capstone-devel-3.0.4-8.fc26.x86_64.\n\nThe only thing I can imagine is that you didn't start from a fresh build tree\nand something went wrong during re-configure.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eMqLdWdx\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0mP5LZcz9rxj\n\tfor ;\n\tWed, 20 Sep 2017 23:23:01 +1000 (AEST)","from localhost ([::1]:48053 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duexv-0007DK-Nx\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 09:22:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42702)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dueoB-00008D-OO\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:13:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duenk-0007Xf-LP\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:12:55 -0400","from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:46876)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duenk-0007XO-FQ\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:12:28 -0400","by mail-oi0-x233.google.com with SMTP id a74so2506512oib.3\n\tfor ; Wed, 20 Sep 2017 06:12:28 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\tf187sm988594oig.24.2017.09.20.06.04.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 06:04:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:subject:to:cc:references:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=gs/nVXrmgeOszjzSz6wD+vd2YKRU5uOm5PaqCOZY1Jo=;\n\tb=eMqLdWdx3jK2rTPUiMa6ACOxz61ylLj2IycIBwHPnBWumVhfe2kRXgcHFFAPbw1GwZ\n\tiGRnnWE0V5cNrg0lhYTcLxvLGzilSUEIFA7P0yFl2zWp74Ar393faGxgG6apu1BCWR5h\n\t6Qszd1YfluCTxhgAsStRG8KGF25eJlii2u4Es=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:subject:to:cc:references:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=gs/nVXrmgeOszjzSz6wD+vd2YKRU5uOm5PaqCOZY1Jo=;\n\tb=piYGw/ofx7PfI+4SDzk4l+dSW59cRFLZRqulEyk48hb2+bJ7moGFde0R3KbN98vDYX\n\t2DbRWkmulkNpp2Squ5845ADQrOdySmWZP59j9FBNCGP0l14JhxVRstcmCBcowNB1nd5O\n\tE/itB08iNnC9t0rebdyfmmpU4Pc9N7VkXs46mUDaa+vmCU51dRwF1IEBF5la+u//CR2H\n\tgvWmZ0gPfMT1tuFdwzVOcRKpRz4YOHgPOJGcP5TIoz5kFs0+HHyfyDjQI0OAeAmUtYiK\n\tAJwbv/LJCCx9YMphTcIM6KduWsqTfH/eheLceXEGRukMAGy/Ifmbtad20yQ3qHxFsgby\n\tRNmA==","X-Gm-Message-State":"AHPjjUjxpudxOPuAa4ven0jj7GTU3C+fp7IoJNX2SNlR4jJFsOqyi/AW\n\tRNwxtzEWls+pKxa7BvUEsp4vw9JT9YE=","X-Google-Smtp-Source":"AOwi7QAd0Ek38OL1DZvwlvZXE7GgHgQktGeWggAHTOgbJiKYDUgVAQBmSe37n/7ebjaZw+UfEd3faw==","X-Received":"by 10.202.4.6 with SMTP id 6mr5578300oie.240.1505912671420;\n\tWed, 20 Sep 2017 06:04:31 -0700 (PDT)","From":"Richard Henderson ","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ","References":"<20170919150313.10833-1-richard.henderson@linaro.org>\n\t<20170919150313.10833-5-richard.henderson@linaro.org>\n\t<87y3p9d3fq.fsf@linaro.org>","Message-ID":"<8deb13bd-af38-9851-085f-6428255297d3@linaro.org>","Date":"Wed, 20 Sep 2017 08:04:26 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87y3p9d3fq.fsf@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4003:c06::233","Subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772242,"web_url":"http://patchwork.ozlabs.org/comment/1772242/","msgid":"<929c47da-b3e6-b8e8-36aa-e02bfc6a31fd@linaro.org>","list_archive_url":null,"date":"2017-09-20T21:06:28","subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/20/2017 06:17 AM, Alex Bennée wrote:\n> Hmm I get a link failure:\n> \n> LINK tilegx-linux-user/qemu-tilegx\n> disas.o: In function `cap_disas_start':\n> /home/alex/lsrc/qemu/qemu.git/disas.c:196: undefined reference to `cs_open'\n\nAs discussed on IRC, this turned out to be wrong link ordering due to me\nplacing -lcapstone in LDFLAGS instead of LIBS. Fixed locally.\n\nAny other comments on the patch set?\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XJfpOrZw\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyC422kpRz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 07:07:14 +1000 (AEST)","from localhost ([::1]:50682 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dumDA-0003ha-Cw\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 17:07:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49642)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dumCa-0003fl-0D\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 17:06:36 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dumCW-0004Yt-Rb\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 17:06:35 -0400","from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]:55848)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dumCW-0004YZ-MM\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 17:06:32 -0400","by mail-io0-x22b.google.com with SMTP id z187so6546246ioz.12\n\tfor ; Wed, 20 Sep 2017 14:06:32 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\tm62sm2235686oib.39.2017.09.20.14.06.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 14:06:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=WLCQAQ8sePJSdg0Y+ZLS66fNWOZDnWUjdGL7V0beOKM=;\n\tb=XJfpOrZw8YM+wMM43ttYNZPlKBIAJZQVd7qZPiP7duAsVBrWQzBdYrSTKXXpT6bhQP\n\tuInf7JcgzKygLP6vPWj+VYH+VRSKZm7epwEQRV4rehdvMHHsHGU2o83F8vC7mPui7hXD\n\toNCNq09JS9xiS2rnnIu22R55U09cvqag+0Q/w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=WLCQAQ8sePJSdg0Y+ZLS66fNWOZDnWUjdGL7V0beOKM=;\n\tb=pRunJz0ecUIyMvO8yzC/Atsvs7Y09HzznhQ1mKoxvy74/DP1gRs0HfFLvT9bxFviwK\n\tj0lj9M35kfb6O5kEfwn95uiyNP69Z7PNvwyaYjFZdlJFkrn7AhFyabWltW62CUS7F/U+\n\tGtgsQrFC6vxqY+4wDOcER8MaPjn83xMyQnikfES+CpYQTitXhfwltoj9Zxh2EF51gu6J\n\tD1aXqX1AfHVbEr2Trh9vpTIfYga1IqBEw+SisIJ0g2KPLytfdUlu51poMhApDCPJi2Q8\n\tqZwaBFY1wmL7d+RK0eST4mA7OcsieWhDDnXVnKnTqgpxtbnO93zIWylgyAJrlHJcYlbr\n\t54Ow==","X-Gm-Message-State":"AHPjjUgVoDSC4R6E2KnXIAyD5PSnlfqYOE+jcfhU8PRe8QNh8bpgVuHW\n\tnWEe6mXEDYXSKjUSrhjAq3gbLgBKuWo=","X-Google-Smtp-Source":"AOwi7QCt9Lwk7FPU2vLQgCHDlYOQrhCnWPhtvsl7tV7Wib4DbmXTPrOWbELngTWeErR996nknWWkCw==","X-Received":"by 10.202.45.205 with SMTP id t196mr27392oit.111.1505941591778; \n\tWed, 20 Sep 2017 14:06:31 -0700 (PDT)","To":"=?utf-8?q?Alex_Benn=C3=A9e?= ","References":"<20170919150313.10833-1-richard.henderson@linaro.org>\n\t<20170919150313.10833-5-richard.henderson@linaro.org>\n\t<87y3p9d3fq.fsf@linaro.org>","From":"Richard Henderson ","Message-ID":"<929c47da-b3e6-b8e8-36aa-e02bfc6a31fd@linaro.org>","Date":"Wed, 20 Sep 2017 16:06:28 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87y3p9d3fq.fsf@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::22b","Subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775764,"web_url":"http://patchwork.ozlabs.org/comment/1775764/","msgid":"","list_archive_url":null,"date":"2017-09-26T18:20:07","subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/19/2017 08:03 AM, Richard Henderson wrote:\n> + while (1) {\n> + /* We want to read memory for one insn, but generically we do not\n> + know how much memory that is. We have a small buffer which is\n> + known to be sufficient for all supported targets. Try to not\n> + read beyond the page, Just In Case. For even more simplicity,\n> + ignore the actual target page size and use a 1k boundary. If\n> + that turns out to be insufficient, we'll come back around the\n> + loop and read more. */\n> + uint64_t epc = QEMU_ALIGN_UP(pc + csize, 1024);\n> + size_t tsize = MIN(sizeof(cap_buf) - csize, epc - pc);\n...\n> + assert(tsize != 0);\n\nBy inspection, epc must be computed from pc + csize + 1.\nIf csize = 0 and pc % 1024 == 0, epc == pc and tsize == 0,\nwhich will assert.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"e3F+OgzB\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1q5K65KNz9t3h\n\tfor ;\n\tWed, 27 Sep 2017 04:20:52 +1000 (AEST)","from localhost ([::1]:50615 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwuTP-0007Xy-4g\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 14:20:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42388)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwuSv-0007XY-8p\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:20:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwuSs-0007cK-0b\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:20:17 -0400","from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:56487)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwuSr-0007Zn-FB\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:20:13 -0400","by mail-pf0-x233.google.com with SMTP id g65so5923858pfe.13\n\tfor ; Tue, 26 Sep 2017 11:20:11 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tq67sm18901327pfg.160.2017.09.26.11.20.08 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 11:20:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:from:to:references:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=/SS8TAg7sIhfc6dhdrF+omS86daiZRKj/tEKfHXpRBI=;\n\tb=e3F+OgzBauj9SLOnlxBoxI7i66ehWUE/OT7Tn/UMChYeIrKwQAFfTzBgMCxj6nDkGW\n\twbNca8WjOy2cPL8+pvm3TmCTeDgEgnPLdRkQBnbSvvqLcTfiH5M9OPWjtvZqZVKyff1B\n\t6BOW77ne7PbN6oFP2FIcV7S6P8pRFFz7xrqIU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:references:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=/SS8TAg7sIhfc6dhdrF+omS86daiZRKj/tEKfHXpRBI=;\n\tb=cGTPQOXiMF3a3aNuaBlOHQPubupUHYW5VwQAiDgjJfG5Lqp4bk9oFYL9IRSOaitb6Z\n\tO91JKpvoGDDYXBKgdA+mQDxz5P3mlzVu9x3+YqPcGvNuCgs5eqXcHdfiZztT12uD/xV+\n\ttxK8VFBSUiD5rQDsN3fU2pGmQ7KtlMzUZQQwTOrmv9DvitwRU5hdLJlo8l3IHd00v9zR\n\t3fP/NtxYpTYAEjiegr8yA8o62Jz+0eHR9uvVqvhXlH/CXqdlgT8ojpeix1+ndoqk9MiU\n\tfgCt6xIIGJAorLpLbPQQ6NVgGu+7mPn63aND+Rmc56qbvB/LvB+SQ1P43ljLrWFqJpMu\n\tTOZA==","X-Gm-Message-State":"AHPjjUjO1v6ZMdETmCZ82iDwPvHhyihLIqhkbx4tUe555dtjoFLk2Xby\n\t6Y2ns6FviG0OufyC/zFPByf+4+awWxk=","X-Google-Smtp-Source":"AOwi7QBBfZqkLBcqwN5DXYE+/GIcgtwIKchF+N9ogCGLsJryEnCzpD5ne0n04Uox7EY9085XBOLjRw==","X-Received":"by 10.98.78.79 with SMTP id c76mr11803048pfb.20.1506450010503;\n\tTue, 26 Sep 2017 11:20:10 -0700 (PDT)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","References":"<20170919150313.10833-1-richard.henderson@linaro.org>\n\t<20170919150313.10833-5-richard.henderson@linaro.org>","Message-ID":"","Date":"Tue, 26 Sep 2017 11:20:07 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919150313.10833-5-richard.henderson@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::233","Subject":"Re: [Qemu-devel] [PATCH v2 4/8] disas: Support the Capstone\n\tdisassembler library","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]