[{"id":1771184,"web_url":"http://patchwork.ozlabs.org/comment/1771184/","msgid":"<1505837476.2703.88.camel@baylibre.com>","list_archive_url":null,"date":"2017-09-19T16:11:16","subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","submitter":{"id":69839,"url":"http://patchwork.ozlabs.org/api/people/69839/","name":"Jerome Brunet","email":"jbrunet@baylibre.com"},"content":"On Tue, 2017-09-19 at 16:53 +0200, Neil Armstrong wrote:\n> The Khadas VIM2 is a Single Board Computer, respin of the origin\n> Khadas VIM board, using an Amlogic S912 SoC and more server oriented.\n> \n> It provides the same external connectors and header pinout, plus a SPI\n> NOR Flash, a reprogrammable STM8S003 MCU, FPC Connector, Cooling FAN header\n> and Pogo Pads Arrays.\n> \n> Cc: Gouwa \n> Signed-off-by: Neil Armstrong \n> ---\n> Documentation/devicetree/bindings/arm/amlogic.txt | 1 +\n> arch/arm64/boot/dts/amlogic/Makefile | 1 +\n> .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 401\n> +++++++++++++++++++++\n> 3 files changed, 403 insertions(+)\n> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n> \n> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt\n> b/Documentation/devicetree/bindings/arm/amlogic.txt\n> index 4e4bc0b..a445997 100644\n> --- a/Documentation/devicetree/bindings/arm/amlogic.txt\n> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt\n> @@ -71,6 +71,7 @@ Board compatible values (alphabetically, grouped by SoC):\n> \n> - \"amlogic,q200\" (Meson gxm s912)\n> - \"amlogic,q201\" (Meson gxm s912)\n> + - \"khadas,vim2\" (Meson gxm s912)\n> - \"kingnovel,r-box-pro\" (Meson gxm S912)\n> - \"nexbox,a1\" (Meson gxm s912)\n> \n> diff --git a/arch/arm64/boot/dts/amlogic/Makefile\n> b/arch/arm64/boot/dts/amlogic/Makefile\n> index 7a9f48c..70246e3 100644\n> --- a/arch/arm64/boot/dts/amlogic/Makefile\n> +++ b/arch/arm64/boot/dts/amlogic/Makefile\n> @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb\n> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb\n> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n> b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n> new file mode 100644\n> index 0000000..692bb93\n> --- /dev/null\n> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n> @@ -0,0 +1,401 @@\n> +/*\n> + * Copyright (c) 2017 Martin Blumenstingl >.\n> + * Copyright (c) 2017 BayLibre, SAS\n> + * Author: Neil Armstrong \n> + *\n> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)\n> + */\n> +\n> +/dts-v1/;\n> +\n> +#include \n> +#include \n> +\n> +#include \"meson-gxm.dtsi\"\n> +\n> +/ {\n> +\tcompatible = \"khadas,vim2\", \"amlogic,s912\", \"amlogic,meson-gxm\";\n> +\tmodel = \"Khadas VIM2\";\n> +\n> +\taliases {\n> +\t\tserial0 = &uart_AO;\n> +\t\tserial1 = &uart_A;\n> +\t\tserial2 = &uart_AO_B;\n> +\t};\n> +\n> +\tchosen {\n> +\t\tstdout-path = \"serial0:115200n8\";\n> +\t};\n> +\n> +\tmemory@0 {\n> +\t\tdevice_type = \"memory\";\n> +\t\treg = <0x0 0x0 0x0 0x80000000>;\n> +\t};\n> +\n> +\tadc-keys {\n> +\t\tcompatible = \"adc-keys\";\n> +\t\tio-channels = <&saradc 0>;\n> +\t\tio-channel-names = \"buttons\";\n> +\t\tkeyup-threshold-microvolt = <1710000>;\n> +\n> +\t\tbutton-function {\n> +\t\t\tlabel = \"Function\";\n> +\t\t\tlinux,code = ;\n> +\t\t\tpress-threshold-microvolt = <10000>;\n> +\t\t};\n> +\t};\n> +\n> +\temmc_pwrseq: emmc-pwrseq {\n> +\t\tcompatible = \"mmc-pwrseq-emmc\";\n> +\t\treset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;\n> +\t};\n> +\n> +\tgpio_fan: gpio-fan {\n> +\t\tcompatible = \"gpio-fan\";\n> +\t\tgpios = <&gpio GPIODV_14 GPIO_ACTIVE_HIGH\n> +\t\t\t &gpio GPIODV_15 GPIO_ACTIVE_HIGH>;\n> +\t\t/* Dummy RPM values since fan is optional */\n> +\t\tgpio-fan,speed-map = <0 0\n> +\t\t\t\t 1 1\n> +\t\t\t\t 2 2\n> +\t\t\t\t 3 3>;\n> +\t\tcooling-min-level = <0>;\n> +\t\tcooling-max-level = <3>;\n> +\t\t#cooling-cells = <2>;\n> +\t};\n> +\n> +\tgpio-keys-polled {\n> +\t\tcompatible = \"gpio-keys-polled\";\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <0>;\n> +\t\tpoll-interval = <100>;\n> +\n> +\t\tbutton@0 {\n> +\t\t\tlabel = \"power\";\n> +\t\t\tlinux,code = ;\n> +\t\t\tgpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;\n> +\t\t};\n> +\t};\n> +\n> +\thdmi-connector {\n> +\t\tcompatible = \"hdmi-connector\";\n> +\t\ttype = \"a\";\n> +\n> +\t\tport {\n> +\t\t\thdmi_connector_in: endpoint {\n> +\t\t\t\tremote-endpoint = <&hdmi_tx_tmds_out>;\n> +\t\t\t};\n> +\t\t};\n> +\t};\n> +\n> +\tpwmleds {\n> +\t\tcompatible = \"pwm-leds\";\n> +\n> +\t\tpower {\n> +\t\t\tlabel = \"vim:red:power\";\n> +\t\t\tpwms = <&pwm_AO_ab 1 7812500 0>;\n> +\t\t\tmax-brightness = <255>;\n> +\t\t\tlinux,default-trigger = \"default-on\";\n> +\t\t};\n> +\t};\n> +\n> +\tsdio_pwrseq: sdio-pwrseq {\n> +\t\tcompatible = \"mmc-pwrseq-simple\";\n> +\t\treset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;\n> +\t\tclocks = <&wifi32k>;\n> +\t\tclock-names = \"ext_clock\";\n> +\t};\n> +\n> +\tthermal-zones {\n> +\t\tcpu-thermal {\n> +\t\t\tpolling-delay-passive = <250>; /* milliseconds */\n> +\t\t\tpolling-delay = <1000>; /* milliseconds */\n> +\n> +\t\t\tthermal-sensors = <&scpi_sensors 0>;\n> +\n> +\t\t\ttrips {\n> +\t\t\t\tcpu_alert0: cpu-alert0 {\n> +\t\t\t\t\ttemperature = <70000>; /*\n> millicelsius */\n> +\t\t\t\t\thysteresis = <2000>; /* millicelsius\n> */\n> +\t\t\t\t\ttype = \"active\";\n> +\t\t\t\t};\n> +\n> +\t\t\t\tcpu_alert1: cpu-alert1 {\n> +\t\t\t\t\ttemperature = <80000>; /*\n> millicelsius */\n> +\t\t\t\t\thysteresis = <2000>; /* millicelsius\n> */\n> +\t\t\t\t\ttype = \"passive\";\n> +\t\t\t\t};\n> +\t\t\t};\n> +\n> +\t\t\tcooling-maps {\n> +\t\t\t\tmap0 {\n> +\t\t\t\t\ttrip = <&cpu_alert0>;\n> +\t\t\t\t\tcooling-device = <&gpio_fan\n> THERMAL_NO_LIMIT 1>;\n> +\t\t\t\t};\n> +\n> +\t\t\t\tmap1 {\n> +\t\t\t\t\ttrip = <&cpu_alert1>;\n> +\t\t\t\t\tcooling-device = <&gpio_fan 2\n> THERMAL_NO_LIMIT>;\n> +\t\t\t\t};\n> +\n> +\t\t\t\tmap2 {\n> +\t\t\t\t\ttrip = <&cpu_alert1>;\n> +\t\t\t\t\tcooling-device =\n> +\t\t\t\t\t\t<&cpu0 THERMAL_NO_LIMIT\n> THERMAL_NO_LIMIT>;\n> +\t\t\t\t};\n> +\n> +\t\t\t\tmap3 {\n> +\t\t\t\t\ttrip = <&cpu_alert1>;\n> +\t\t\t\t\tcooling-device =\n> +\t\t\t\t\t\t<&cpu4 THERMAL_NO_LIMIT\n> THERMAL_NO_LIMIT>;\n> +\t\t\t\t};\n> +\t\t\t};\n> +\t\t};\n> +\t};\n> +\n> +\tvcc_3v3: regulator-vcc_3v3 {\n> +\t\tcompatible = \"regulator-fixed\";\n> +\t\tregulator-name = \"VCC_3V3\";\n> +\t\tregulator-min-microvolt = <3300000>;\n> +\t\tregulator-max-microvolt = <3300000>;\n> +\t};\n> +\n> +\tvddio_ao18: regulator-vddio_ao18 {\n> +\t\tcompatible = \"regulator-fixed\";\n> +\t\tregulator-name = \"VDDIO_AO18\";\n> +\t\tregulator-min-microvolt = <1800000>;\n> +\t\tregulator-max-microvolt = <1800000>;\n> +\t};\n> +\n> +\tvddio_boot: regulator-vddio_boot {\n> +\t\tcompatible = \"regulator-fixed\";\n> +\t\tregulator-name = \"VDDIO_BOOT\";\n> +\t\tregulator-min-microvolt = <1800000>;\n> +\t\tregulator-max-microvolt = <1800000>;\n> +\t};\n> +\n> +\tvddao_3v3: regulator-vddao_3v3 {\n> +\t\tcompatible = \"regulator-fixed\";\n> +\t\tregulator-name = \"VDDAO_3V3\";\n> +\t\tregulator-min-microvolt = <3300000>;\n> +\t\tregulator-max-microvolt = <3300000>;\n> +\t};\n> +\n> +\twifi32k: wifi32k {\n> +\t\tcompatible = \"pwm-clock\";\n> +\t\t#clock-cells = <0>;\n> +\t\tclock-frequency = <32768>;\n> +\t\tpwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */\n> +\t};\n> +};\n> +\n> +&cec_AO {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&ao_cec_pins>;\n> +\tpinctrl-names = \"default\";\n> +\thdmi-phandle = <&hdmi_tx>;\n> +};\n> +\n> +&cpu0 {\n> +\tcooling-min-level = <0>;\n> +\tcooling-max-level = <6>;\n> +\t#cooling-cells = <2>;\n> +};\n> +\n> +&cpu4 {\n> +\tcooling-min-level = <0>;\n> +\tcooling-max-level = <4>;\n> +\t#cooling-cells = <2>;\n> +};\n> +\n> +ðmac {\n> +\tpinctrl-0 = <ð_pins>;\n> +\tpinctrl-names = \"default\";\n> +\n> +\t/* Select external PHY by default */\n> +\tphy-handle = <&external_phy>;\n> +\n> +\tamlogic,tx-delay-ns = <2>;\n> +\n> +\t/* External PHY reset is shared with internal PHY Led signals */\n> +\tsnps,reset-gpio = <&gpio GPIOZ_14 0>;\n> +\tsnps,reset-delays-us = <0 10000 1000000>;\n> +\tsnps,reset-active-low;\n> +\n> +\t/* External PHY is in RGMII */\n> +\tphy-mode = \"rgmii\";\n> +\n> +\tstatus = \"okay\";\n> +};\n> +\n> +&external_mdio {\n> +\texternal_phy: ethernet-phy@1 {\n> +\t\tcompatible = \"ethernet-phy-id001c.c916\", \"ethernet-phy-\n> ieee802.3-c22\";\n> +\t\treg = <0>;\n> +\t\tmax-speed = <1000>;\nThis entry is not necessary\n\n> +\t};\n> +};\n> +\n> +&hdmi_tx {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;\n> +\tpinctrl-names = \"default\";\n> +};\n> +\n> +&hdmi_tx_tmds_port {\n> +\thdmi_tx_tmds_out: endpoint {\n> +\t\tremote-endpoint = <&hdmi_connector_in>;\n> +\t};\n> +};\n> +\n> +&i2c_A {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&i2c_a_pins>;\n> +\tpinctrl-names = \"default\";\n> +};\n> +\n> +&i2c_B {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&i2c_b_pins>;\n> +\tpinctrl-names = \"default\";\n> +\n> +\trtc: rtc@51 {\n> +\t\t/* has to be enabled manually when a battery is connected: */\n> +\t\tstatus = \"disabled\";\n> +\t\tcompatible = \"haoyu,hym8563\";\n> +\t\treg = <0x51>;\n> +\t\t#clock-cells = <0>;\n> +\t\tclock-frequency = <32768>;\n> +\t\tclock-output-names = \"xin32k\";\n> +\t};\n> +};\n> +\n> +&ir {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&remote_input_ao_pins>;\n> +\tpinctrl-names = \"default\";\n> +\tlinux,rc-map-name = \"rc-geekbox\";\n> +};\n> +\n> +&pwm_AO_ab {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&pwm_ao_a_3_pins>, <&pwm_ao_b_pins>;\n> +\tpinctrl-names = \"default\";\n> +\tclocks = <&clkc CLKID_FCLK_DIV4>;\n> +\tclock-names = \"clkin0\";\n> +};\n> +\n> +&pwm_ef {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&pwm_e_pins>, <&pwm_f_clk_pins>;\n> +\tpinctrl-names = \"default\";\n> +\tclocks = <&clkc CLKID_FCLK_DIV4>;\n> +\tclock-names = \"clkin0\";\n> +};\n> +\n> +&sd_emmc_a {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&sdio_pins>;\n> +\tpinctrl-names = \"default\";\n> +\t#address-cells = <1>;\n> +\t#size-cells = <0>;\n> +\n> +\tbus-width = <4>;\n> +\tcap-sd-highspeed;\n> +\tmax-frequency = <100000000>;\n> +\n> +\tnon-removable;\n> +\tdisable-wp;\n> +\n> +\tmmc-pwrseq = <&sdio_pwrseq>;\n> +\n> +\tvmmc-supply = <&vddao_3v3>;\n> +\tvqmmc-supply = <&vddio_boot>;\n> +\n> +\tbrcmf: wifi@1 {\n> +\t\treg = <1>;\n> +\t\tcompatible = \"brcm,bcm4329-fmac\";\n> +\t};\n> +};\n> +\n> +/* SD card */\n> +&sd_emmc_b {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&sdcard_pins>;\n> +\tpinctrl-names = \"default\";\n> +\n> +\tbus-width = <4>;\n> +\tcap-sd-highspeed;\n> +\tmax-frequency = <100000000>;\n> +\tdisable-wp;\n> +\n> +\tcd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;\n> +\tcd-inverted;\n> +\n> +\tvmmc-supply = <&vddao_3v3>;\n> +\tvqmmc-supply = <&vddio_boot>;\n> +};\n> +\n> +/* eMMC */\n> +&sd_emmc_c {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>;\n> +\tpinctrl-names = \"default\";\n> +\n> +\tbus-width = <8>;\n> +\tcap-sd-highspeed;\nThis entry is not necessary\n\n> +\tcap-mmc-highspeed;\n> +\tmax-frequency = <200000000>;\n> +\tnon-removable;\n> +\tdisable-wp;\n> +\tmmc-ddr-1_8v;\n> +\tmmc-hs200-1_8v;\n> +\n> +\tmmc-pwrseq = <&emmc_pwrseq>;\n> +\tvmmc-supply = <&vcc_3v3>;\n> +\tvqmmc-supply = <&vddio_boot>;\n> +};\n> +\n> +/*\n> + * EMMC_DS pin is shared between SPI NOR CS and eMMC Data Strobe\n> + * Remove emmc_ds_pins from sd_emmc_c pinctrl-0 then spifc can be enabled\n> + */\n> +&spifc {\n> +\tstatus = \"disabled\";\n> +\tpinctrl-0 = <&nor_pins>;\n> +\tpinctrl-names = \"default\";\n> +\n> +\tw25q32: spi-flash@0 {\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <1>;\n> +\t\tcompatible = \"winbond,w25q16\", \"jedec,spi-nor\";\n> +\t\treg = <0>;\n> +\t\tspi-max-frequency = <3000000>;\n> +\t};\n> +};\n> +\n> +/* This one is connected to the Bluetooth module */\n> +&uart_A {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&uart_a_pins>;\n> +\tpinctrl-names = \"default\";\n> +};\n> +\n> +/* This is brought out on the Linux_RX (18) and Linux_TX (19) pins: */\n> +&uart_AO {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&uart_ao_a_pins>;\n> +\tpinctrl-names = \"default\";\n> +};\n> +\n> +/* This is brought out on the UART_RX_AO_B (15) and UART_TX_AO_B (16) pins:\n> */\n> +&uart_AO_B {\n> +\tstatus = \"okay\";\n> +\tpinctrl-0 = <&uart_ao_b_pins>;\n> +\tpinctrl-names = \"default\";\n> +};\n> +\n> +&saradc {\n> +\tstatus = \"okay\";\n> +\tvref-supply = <&vddio_ao18>;\n> +};\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=baylibre-com.20150623.gappssmtp.com\n\theader.i=@baylibre-com.20150623.gappssmtp.com header.b=\"qQg0iyiX\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxSY71jsbz9s7m\n\tfor ;\n\tWed, 20 Sep 2017 02:11:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751628AbdISQLV (ORCPT\n\t);\n\tTue, 19 Sep 2017 12:11:21 -0400","from mail-lf0-f43.google.com ([209.85.215.43]:55789 \"EHLO\n\tmail-lf0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751618AbdISQLU (ORCPT\n\t); Tue, 19 Sep 2017 12:11:20 -0400","by mail-lf0-f43.google.com with SMTP id u21so78997lfk.12\n\tfor ;\n\tTue, 19 Sep 2017 09:11:19 -0700 (PDT)","from boomer.home ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id\n\tu130sm1697861lff.79.2017.09.19.09.11.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 09:11:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OS2fugI6jglga24v5MFJ8JGy5cFv8gQ/H1tGrm9Jayo=;\n\tb=qQg0iyiXN2ouSWYZBqtUOh7b+Sz9/P3aPhIGXQasLm83mj1k/Ohd9VqTy8DWXKpg0a\n\tEUKXklyxxrId7jhP9tdVrF1FNxHckEQKW3cL1DhDqAyI5xtNof4VuwHqxEc/clwur9La\n\tjCIY825EhTLDIif9TXIO+wDWu7TwoXoCsrYeDrzKRzrx8Ao0Ze0GmdtK9yaRUCAvSXQY\n\t3G27zj3xH2s5MSZROjuPlRbQd3/CPm0ytpzuJqz5hpS45fFiKUjpUdTnEIGcjM3RYS0x\n\tfj6t1swfMq7cflOqM5cKb+ZdtiKHgbWGGr74a8woNOnm22roE+rqnWn/nNtKfhJwLmqW\n\t5AWw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OS2fugI6jglga24v5MFJ8JGy5cFv8gQ/H1tGrm9Jayo=;\n\tb=byROEy2nGs05/PJjfjuhGwjc2YutEFduEFCuMLdjYkt0719LsCD7r3larV2hRvD5ZN\n\tWqImZLZ5NEDj3lrDKNrXYJoT4GTtydWDKl70FmbW9aJhQc6PkVwwcbS4ibCP2XTHKYz0\n\tzsCoxlxtk8MhFpwnQuEKHV6TNT8dkevQgNdtCtEnIXJv7MyeUgkVwEL1dye6jkyuIQLN\n\tpukrwYhIqhkiWdGrpwjlQNNREkaoROKlmyVlyV4piOglhi9eAfegzO2vkdjFm34P2FVp\n\tCmD8P4rp6PyamnHuBIhHvCm3PVJhSA6bHzHtxYoU6Jh6evKKMQjIwAAgMRrZAmONyt5h\n\tL7tg==","X-Gm-Message-State":"AHPjjUiulRjz4LxzHKMV4CILviOH1pjBKyUdDW+71OKQPe1vwGNwRV6w\n\tNizw6V/t5xTNm5ZW+r2X14WB8w==","X-Google-Smtp-Source":"AOwi7QAFzJJLm/jbZk2jVg/M+5sX6+F8pdHWpxQg2IbsbM9Zjq4vaKmluWgCAifeQJWZCU3ZXoRM6A==","X-Received":"by 10.46.33.82 with SMTP id h79mr908598ljh.104.1505837478402;\n\tTue, 19 Sep 2017 09:11:18 -0700 (PDT)","Message-ID":"<1505837476.2703.88.camel@baylibre.com>","Subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","From":"Jerome Brunet ","To":"Neil Armstrong , khilman@baylibre.com,\n\tcarlo@caione.org","Cc":"linux-amlogic@lists.infradead.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, Gouwa ","Date":"Tue, 19 Sep 2017 18:11:16 +0200","In-Reply-To":"<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>","References":"<1505832820-3517-1-git-send-email-narmstrong@baylibre.com>\n\t<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771257,"web_url":"http://patchwork.ozlabs.org/comment/1771257/","msgid":"","list_archive_url":null,"date":"2017-09-19T17:55:04","subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","submitter":{"id":66366,"url":"http://patchwork.ozlabs.org/api/people/66366/","name":"Martin Blumenstingl","email":"martin.blumenstingl@googlemail.com"},"content":"Hi Neil,\n\nOn Tue, Sep 19, 2017 at 4:53 PM, Neil Armstrong wrote:\n> The Khadas VIM2 is a Single Board Computer, respin of the origin\n> Khadas VIM board, using an Amlogic S912 SoC and more server oriented.\n>\n> It provides the same external connectors and header pinout, plus a SPI\n> NOR Flash, a reprogrammable STM8S003 MCU, FPC Connector, Cooling FAN header\n> and Pogo Pads Arrays.\n>\n> Cc: Gouwa \n> Signed-off-by: Neil Armstrong \n> ---\n> Documentation/devicetree/bindings/arm/amlogic.txt | 1 +\n> arch/arm64/boot/dts/amlogic/Makefile | 1 +\n> .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 401 +++++++++++++++++++++\n> 3 files changed, 403 insertions(+)\n> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n>\n> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt\n> index 4e4bc0b..a445997 100644\n> --- a/Documentation/devicetree/bindings/arm/amlogic.txt\n> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt\n> @@ -71,6 +71,7 @@ Board compatible values (alphabetically, grouped by SoC):\n>\n> - \"amlogic,q200\" (Meson gxm s912)\n> - \"amlogic,q201\" (Meson gxm s912)\n> + - \"khadas,vim2\" (Meson gxm s912)\n> - \"kingnovel,r-box-pro\" (Meson gxm S912)\n> - \"nexbox,a1\" (Meson gxm s912)\n>\n> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile\n> index 7a9f48c..70246e3 100644\n> --- a/arch/arm64/boot/dts/amlogic/Makefile\n> +++ b/arch/arm64/boot/dts/amlogic/Makefile\n> @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb\n> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb\n> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb\n> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n> new file mode 100644\n> index 0000000..692bb93\n> --- /dev/null\n> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n> @@ -0,0 +1,401 @@\n> +/*\n> + * Copyright (c) 2017 Martin Blumenstingl .\n> + * Copyright (c) 2017 BayLibre, SAS\n> + * Author: Neil Armstrong \n> + *\n> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)\n> + */\n> +\n> +/dts-v1/;\n> +\n> +#include \n> +#include \n> +\n> +#include \"meson-gxm.dtsi\"\n> +\n> +/ {\n> + compatible = \"khadas,vim2\", \"amlogic,s912\", \"amlogic,meson-gxm\";\n> + model = \"Khadas VIM2\";\n> +\n> + aliases {\n> + serial0 = &uart_AO;\n> + serial1 = &uart_A;\n> + serial2 = &uart_AO_B;\n> + };\n> +\n> + chosen {\n> + stdout-path = \"serial0:115200n8\";\n> + };\n> +\n> + memory@0 {\n> + device_type = \"memory\";\n> + reg = <0x0 0x0 0x0 0x80000000>;\n> + };\n> +\n> + adc-keys {\n> + compatible = \"adc-keys\";\n> + io-channels = <&saradc 0>;\n> + io-channel-names = \"buttons\";\n> + keyup-threshold-microvolt = <1710000>;\n> +\n> + button-function {\n> + label = \"Function\";\n> + linux,code = ;\n> + press-threshold-microvolt = <10000>;\n> + };\n> + };\n> +\n> + emmc_pwrseq: emmc-pwrseq {\n> + compatible = \"mmc-pwrseq-emmc\";\n> + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;\n> + };\n> +\n> + gpio_fan: gpio-fan {\n> + compatible = \"gpio-fan\";\n> + gpios = <&gpio GPIODV_14 GPIO_ACTIVE_HIGH\n> + &gpio GPIODV_15 GPIO_ACTIVE_HIGH>;\n> + /* Dummy RPM values since fan is optional */\n> + gpio-fan,speed-map = <0 0\n> + 1 1\n> + 2 2\n> + 3 3>;\n> + cooling-min-level = <0>;\n> + cooling-max-level = <3>;\n> + #cooling-cells = <2>;\n> + };\n> +\n> + gpio-keys-polled {\n> + compatible = \"gpio-keys-polled\";\n> + #address-cells = <1>;\n> + #size-cells = <0>;\n> + poll-interval = <100>;\n> +\n> + button@0 {\n> + label = \"power\";\n> + linux,code = ;\n> + gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;\n> + };\n> + };\n> +\n> + hdmi-connector {\n> + compatible = \"hdmi-connector\";\n> + type = \"a\";\n> +\n> + port {\n> + hdmi_connector_in: endpoint {\n> + remote-endpoint = <&hdmi_tx_tmds_out>;\n> + };\n> + };\n> + };\n> +\n> + pwmleds {\n> + compatible = \"pwm-leds\";\n> +\n> + power {\n> + label = \"vim:red:power\";\n> + pwms = <&pwm_AO_ab 1 7812500 0>;\n> + max-brightness = <255>;\n> + linux,default-trigger = \"default-on\";\n> + };\n> + };\n> +\n> + sdio_pwrseq: sdio-pwrseq {\n> + compatible = \"mmc-pwrseq-simple\";\n> + reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;\n> + clocks = <&wifi32k>;\n> + clock-names = \"ext_clock\";\n> + };\n> +\n> + thermal-zones {\n> + cpu-thermal {\n> + polling-delay-passive = <250>; /* milliseconds */\n> + polling-delay = <1000>; /* milliseconds */\n> +\n> + thermal-sensors = <&scpi_sensors 0>;\n> +\n> + trips {\n> + cpu_alert0: cpu-alert0 {\n> + temperature = <70000>; /* millicelsius */\n> + hysteresis = <2000>; /* millicelsius */\n> + type = \"active\";\n> + };\n> +\n> + cpu_alert1: cpu-alert1 {\n> + temperature = <80000>; /* millicelsius */\n> + hysteresis = <2000>; /* millicelsius */\n> + type = \"passive\";\n> + };\n> + };\n> +\n> + cooling-maps {\n> + map0 {\n> + trip = <&cpu_alert0>;\n> + cooling-device = <&gpio_fan THERMAL_NO_LIMIT 1>;\n> + };\n> +\n> + map1 {\n> + trip = <&cpu_alert1>;\n> + cooling-device = <&gpio_fan 2 THERMAL_NO_LIMIT>;\n> + };\n> +\n> + map2 {\n> + trip = <&cpu_alert1>;\n> + cooling-device =\n> + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;\n> + };\n> +\n> + map3 {\n> + trip = <&cpu_alert1>;\n> + cooling-device =\n> + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;\n> + };\n> + };\n> + };\n> + };\n> +\n> + vcc_3v3: regulator-vcc_3v3 {\n> + compatible = \"regulator-fixed\";\n> + regulator-name = \"VCC_3V3\";\n> + regulator-min-microvolt = <3300000>;\n> + regulator-max-microvolt = <3300000>;\n> + };\n> +\n> + vddio_ao18: regulator-vddio_ao18 {\n> + compatible = \"regulator-fixed\";\n> + regulator-name = \"VDDIO_AO18\";\n> + regulator-min-microvolt = <1800000>;\n> + regulator-max-microvolt = <1800000>;\n> + };\n> +\n> + vddio_boot: regulator-vddio_boot {\n> + compatible = \"regulator-fixed\";\n> + regulator-name = \"VDDIO_BOOT\";\n> + regulator-min-microvolt = <1800000>;\n> + regulator-max-microvolt = <1800000>;\n> + };\n> +\n> + vddao_3v3: regulator-vddao_3v3 {\n> + compatible = \"regulator-fixed\";\n> + regulator-name = \"VDDAO_3V3\";\n> + regulator-min-microvolt = <3300000>;\n> + regulator-max-microvolt = <3300000>;\n> + };\n> +\n> + wifi32k: wifi32k {\n> + compatible = \"pwm-clock\";\n> + #clock-cells = <0>;\n> + clock-frequency = <32768>;\n> + pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */\n> + };\n> +};\n> +\n> +&cec_AO {\n> + status = \"okay\";\n> + pinctrl-0 = <&ao_cec_pins>;\n> + pinctrl-names = \"default\";\n> + hdmi-phandle = <&hdmi_tx>;\n> +};\n> +\n> +&cpu0 {\n> + cooling-min-level = <0>;\n> + cooling-max-level = <6>;\n> + #cooling-cells = <2>;\n> +};\n> +\n> +&cpu4 {\n> + cooling-min-level = <0>;\n> + cooling-max-level = <4>;\n> + #cooling-cells = <2>;\n> +};\n> +\n> +ðmac {\n> + pinctrl-0 = <ð_pins>;\n> + pinctrl-names = \"default\";\n> +\n> + /* Select external PHY by default */\n> + phy-handle = <&external_phy>;\n> +\n> + amlogic,tx-delay-ns = <2>;\n> +\n> + /* External PHY reset is shared with internal PHY Led signals */\n> + snps,reset-gpio = <&gpio GPIOZ_14 0>;\n> + snps,reset-delays-us = <0 10000 1000000>;\n> + snps,reset-active-low;\n> +\n> + /* External PHY is in RGMII */\n> + phy-mode = \"rgmii\";\n> +\n> + status = \"okay\";\n> +};\n> +\n> +&external_mdio {\n> + external_phy: ethernet-phy@1 {\n> + compatible = \"ethernet-phy-id001c.c916\", \"ethernet-phy-ieee802.3-c22\";\ncould you please remove the compatible property and replace it with a\ncomment as explained in [0]?\n\n> + reg = <0>;\n> + max-speed = <1000>;\n> + };\n> +};\n> +\n> +&hdmi_tx {\n> + status = \"okay\";\n> + pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;\n> + pinctrl-names = \"default\";\n> +};\n> +\n> +&hdmi_tx_tmds_port {\n> + hdmi_tx_tmds_out: endpoint {\n> + remote-endpoint = <&hdmi_connector_in>;\n> + };\n> +};\n> +\n> +&i2c_A {\n> + status = \"okay\";\n> + pinctrl-0 = <&i2c_a_pins>;\n> + pinctrl-names = \"default\";\n> +};\n> +\n> +&i2c_B {\n> + status = \"okay\";\n> + pinctrl-0 = <&i2c_b_pins>;\n> + pinctrl-names = \"default\";\n> +\n> + rtc: rtc@51 {\n> + /* has to be enabled manually when a battery is connected: */\n> + status = \"disabled\";\n> + compatible = \"haoyu,hym8563\";\n> + reg = <0x51>;\n> + #clock-cells = <0>;\n> + clock-frequency = <32768>;\n> + clock-output-names = \"xin32k\";\n> + };\n> +};\n> +\n> +&ir {\n> + status = \"okay\";\n> + pinctrl-0 = <&remote_input_ao_pins>;\n> + pinctrl-names = \"default\";\n> + linux,rc-map-name = \"rc-geekbox\";\n> +};\n> +\n> +&pwm_AO_ab {\n> + status = \"okay\";\n> + pinctrl-0 = <&pwm_ao_a_3_pins>, <&pwm_ao_b_pins>;\n> + pinctrl-names = \"default\";\n> + clocks = <&clkc CLKID_FCLK_DIV4>;\n> + clock-names = \"clkin0\";\n> +};\n> +\n> +&pwm_ef {\n> + status = \"okay\";\n> + pinctrl-0 = <&pwm_e_pins>, <&pwm_f_clk_pins>;\n> + pinctrl-names = \"default\";\n> + clocks = <&clkc CLKID_FCLK_DIV4>;\n> + clock-names = \"clkin0\";\n> +};\n> +\n> +&sd_emmc_a {\n> + status = \"okay\";\n> + pinctrl-0 = <&sdio_pins>;\n> + pinctrl-names = \"default\";\n> + #address-cells = <1>;\n> + #size-cells = <0>;\n> +\n> + bus-width = <4>;\n> + cap-sd-highspeed;\n> + max-frequency = <100000000>;\n> +\n> + non-removable;\n> + disable-wp;\n> +\n> + mmc-pwrseq = <&sdio_pwrseq>;\n> +\n> + vmmc-supply = <&vddao_3v3>;\n> + vqmmc-supply = <&vddio_boot>;\n> +\n> + brcmf: wifi@1 {\n> + reg = <1>;\n> + compatible = \"brcm,bcm4329-fmac\";\n> + };\n> +};\n> +\n> +/* SD card */\n> +&sd_emmc_b {\n> + status = \"okay\";\n> + pinctrl-0 = <&sdcard_pins>;\n> + pinctrl-names = \"default\";\n> +\n> + bus-width = <4>;\n> + cap-sd-highspeed;\n> + max-frequency = <100000000>;\n> + disable-wp;\n> +\n> + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>;\n> + cd-inverted;\n> +\n> + vmmc-supply = <&vddao_3v3>;\n> + vqmmc-supply = <&vddio_boot>;\n> +};\n> +\n> +/* eMMC */\n> +&sd_emmc_c {\n> + status = \"okay\";\n> + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>;\n> + pinctrl-names = \"default\";\n> +\n> + bus-width = <8>;\n> + cap-sd-highspeed;\n> + cap-mmc-highspeed;\n> + max-frequency = <200000000>;\n> + non-removable;\n> + disable-wp;\n> + mmc-ddr-1_8v;\n> + mmc-hs200-1_8v;\n> +\n> + mmc-pwrseq = <&emmc_pwrseq>;\n> + vmmc-supply = <&vcc_3v3>;\n> + vqmmc-supply = <&vddio_boot>;\n> +};\n> +\n> +/*\n> + * EMMC_DS pin is shared between SPI NOR CS and eMMC Data Strobe\n> + * Remove emmc_ds_pins from sd_emmc_c pinctrl-0 then spifc can be enabled\n> + */\n> +&spifc {\n> + status = \"disabled\";\n> + pinctrl-0 = <&nor_pins>;\n> + pinctrl-names = \"default\";\n> +\n> + w25q32: spi-flash@0 {\n> + #address-cells = <1>;\n> + #size-cells = <1>;\n> + compatible = \"winbond,w25q16\", \"jedec,spi-nor\";\n> + reg = <0>;\n> + spi-max-frequency = <3000000>;\n> + };\n> +};\n> +\n> +/* This one is connected to the Bluetooth module */\n> +&uart_A {\n> + status = \"okay\";\n> + pinctrl-0 = <&uart_a_pins>;\n> + pinctrl-names = \"default\";\n> +};\n> +\n> +/* This is brought out on the Linux_RX (18) and Linux_TX (19) pins: */\n> +&uart_AO {\n> + status = \"okay\";\n> + pinctrl-0 = <&uart_ao_a_pins>;\n> + pinctrl-names = \"default\";\n> +};\n> +\n> +/* This is brought out on the UART_RX_AO_B (15) and UART_TX_AO_B (16) pins: */\n> +&uart_AO_B {\n> + status = \"okay\";\n> + pinctrl-0 = <&uart_ao_b_pins>;\n> + pinctrl-names = \"default\";\n> +};\n> +\n> +&saradc {\n> + status = \"okay\";\n> + vref-supply = <&vddio_ao18>;\n> +};\n> --\n> 1.9.1\n>\n>\n> _______________________________________________\n> linux-amlogic mailing list\n> linux-amlogic@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/linux-amlogic\n\nwith that and Jerome's comments fixed:\nAcked-by: Martin Blumenstingl \n\n\nRegards,\nMartin\n\n\n[0] http://lists.infradead.org/pipermail/linux-amlogic/2017-September/004729.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"BbYFyLQX\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVt92z1Dz9sPk\n\tfor ;\n\tWed, 20 Sep 2017 03:56:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751394AbdISRz1 (ORCPT\n\t);\n\tTue, 19 Sep 2017 13:55:27 -0400","from mail-io0-f195.google.com ([209.85.223.195]:38636 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750872AbdISRz0 (ORCPT\n\t); Tue, 19 Sep 2017 13:55:26 -0400","by mail-io0-f195.google.com with SMTP id e9so417485iod.5;\n\tTue, 19 Sep 2017 10:55:26 -0700 (PDT)","by 10.2.51.84 with HTTP; Tue, 19 Sep 2017 10:55:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=wz2UYDHDsK95JjQmLT4muP+rN/b7PjaZW+8Tk8tsEqQ=;\n\tb=BbYFyLQXNtiu8PfxhHPEGeUBqgdedoj+WNhqMpsHkXgWO9JXQHsnvSJ3LGFZ9l0AaW\n\tq4JIaNU20OgI5KCachvlobWK5w7YXDvZBfgsJZ7r+evyd921hgeD5mg5HFb8p2lDXR5p\n\tNQGBC2nF0sATOHtkdowLnlY6VUZIGzIi2l0lAC40wLQ7h8HFKhfujdo1cy8kF2qd9jri\n\tILT4FTaYtdLplQ/EqXEpX1rXowNdWnqalYTXY9ixR1sCvHZ/o9mdjHsPUbv1lHn7lblz\n\tz/XWbivt3iGR35v1oiBwhnk7BT5urzo8YfCq6RGytxXIi2XnIAiGwiWwK3gBIgCAfp0N\n\tjChw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=wz2UYDHDsK95JjQmLT4muP+rN/b7PjaZW+8Tk8tsEqQ=;\n\tb=KN66AWMk77sUDNVuFtdgqXN4XhEFAiSUJizcSio7NBL/X6cTLyWwXWMwvKW6LOwNU7\n\tfTm410VPvT7ARnpyaG5nQAzOvJ7kJiz/mib0KOkXvPfEqMdKCdU93Hc4mAvw59w7xjRo\n\tl/zqb9bG39VQerFh11FD4AM19froY1xmhE3ZMlIq9awqmJ6bjapfNUF9eJ57exDqigew\n\tp33qGm6HvVrMHlzl/5R0X2meN14oyjGIJBniJALN/ETKY1cXh6UWyOAogKBizlvFuS50\n\tvwxl+jOtoal9ET5pJLSDmlYevm0mzuLqDSq1uqp1gqq84uQk18o5950m4cX2JzDHbVWP\n\tr6qA==","X-Gm-Message-State":"AHPjjUjKp/T5ydlrUHSvXlJe+d9L/61dFkG4+nVymXUHRZ+fOlGh0XbD\n\t0ka+x1+x1PSR3SuPS1/WqGzO3PggmP8W51B+reQ=","X-Google-Smtp-Source":"AOwi7QDZbMde439A0FlTmEaxQy6j81bWFrVMdlYcgLgPYW7mGl5NNiZdiwmcW1JlsVFh6EyGCS02V0Mr7gZV2I8V7dw=","X-Received":"by 10.107.15.141 with SMTP id 13mr2840290iop.141.1505843725020; \n\tTue, 19 Sep 2017 10:55:25 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>","References":"<1505832820-3517-1-git-send-email-narmstrong@baylibre.com>\n\t<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>","From":"Martin Blumenstingl ","Date":"Tue, 19 Sep 2017 19:55:04 +0200","Message-ID":"","Subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","To":"Neil Armstrong ","Cc":"khilman@baylibre.com, carlo@caione.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,\n\tGouwa , linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771673,"web_url":"http://patchwork.ozlabs.org/comment/1771673/","msgid":"<84171990-f5f2-d7d2-2bf6-d28390daac4a@baylibre.com>","list_archive_url":null,"date":"2017-09-20T08:29:58","subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","submitter":{"id":67289,"url":"http://patchwork.ozlabs.org/api/people/67289/","name":"Neil Armstrong","email":"narmstrong@baylibre.com"},"content":"On 09/19/2017 07:55 PM, Martin Blumenstingl wrote:\n> Hi Neil,\n> \n> On Tue, Sep 19, 2017 at 4:53 PM, Neil Armstrong wrote:\n>> The Khadas VIM2 is a Single Board Computer, respin of the origin\n>> Khadas VIM board, using an Amlogic S912 SoC and more server oriented.\n>>\n>> It provides the same external connectors and header pinout, plus a SPI\n>> NOR Flash, a reprogrammable STM8S003 MCU, FPC Connector, Cooling FAN header\n>> and Pogo Pads Arrays.\n>>\n>> Cc: Gouwa \n>> Signed-off-by: Neil Armstrong \n>> ---\n>> Documentation/devicetree/bindings/arm/amlogic.txt | 1 +\n>> arch/arm64/boot/dts/amlogic/Makefile | 1 +\n>> .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 401 +++++++++++++++++++++\n>> 3 files changed, 403 insertions(+)\n>> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n>>\n\n[...]\n\n>> +&external_mdio {\n>> + external_phy: ethernet-phy@1 {\n>> + compatible = \"ethernet-phy-id001c.c916\", \"ethernet-phy-ieee802.3-c22\";\n> could you please remove the compatible property and replace it with a\n> comment as explained in [0]?\n> \n\nOk\n\n>> + reg = <0>;\n>> + max-speed = <1000>;\n>> + };\n>> +};\n>> +\n\n[...]\n\n> \n> with that and Jerome's comments fixed:\n> Acked-by: Martin Blumenstingl \n> \n> \n> Regards,\n> Martin\n> \n> \n> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-September/004729.html\n> \n\nThanks Martin !\n\nI'll send a v2 when eMMC DTS patches goes in 4.14-rc2.\n\nNeil\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=baylibre-com.20150623.gappssmtp.com\n\theader.i=@baylibre-com.20150623.gappssmtp.com header.b=\"tQxCM+hZ\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxtGP6cBYz9s7p\n\tfor ;\n\tWed, 20 Sep 2017 18:30:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751781AbdITIaE (ORCPT\n\t);\n\tWed, 20 Sep 2017 04:30:04 -0400","from mail-wm0-f43.google.com ([74.125.82.43]:50397 \"EHLO\n\tmail-wm0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751603AbdITIaC (ORCPT\n\t); Wed, 20 Sep 2017 04:30:02 -0400","by mail-wm0-f43.google.com with SMTP id v142so4895458wmv.5\n\tfor ;\n\tWed, 20 Sep 2017 01:30:01 -0700 (PDT)","from [192.168.1.21] ([90.63.244.31])\n\tby smtp.gmail.com with ESMTPSA id\n\ty23sm1141939wrd.57.2017.09.20.01.30.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 01:30:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:organization:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=rkr8iUNpimV1FgJfdb70ulzSp8dz5GevvMF4p6Gvx2k=;\n\tb=tQxCM+hZdoAg8V/FrBJbDpSqwfsu9Kk01aP5SvstBGFJKfZ0wihUX8nWr0DqC46aG4\n\tPfYMgfUXL3oD8lH7+iGHycPBA1XPrzZqPBqrKNotb64E0MPwYXeLAddbWRBmw1hJOf+C\n\tnmWOveqXv34FRGh4aLKgJeb0KtUCfD7YlmgjaDgHP6dcj9kynCuy65j06LJa7HZBipwT\n\th+jFsL/0TF4XnrQfQhu0ESCHuVgXuWDRJ4X6OMIaEB2FhDnezJPlckdZ4VyMLArRlTii\n\toOLCnBf7YeVYu7jWi/hDedUYzNxIEU5tI0oR5qtrEFUjIdGZ2wHJAwmzBVCixzSj7+Rw\n\tAP/w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=rkr8iUNpimV1FgJfdb70ulzSp8dz5GevvMF4p6Gvx2k=;\n\tb=ZmZ2okK+q3QBGnMBIk0WLU/KCrt2+6RCXQn9mTfqRRbMkqimH044CA80JMjFJwisCw\n\tI76Len6ORzBeCl829283mBcKXdpMZ/fxFdEVuyoMb0QTQSKoaYHTDdgSUGV5SIhqXY6a\n\taJFcHWRRKf2UijjHr4WGFRrurS/EjccVO6pbcEM1Fifi/SEdc0OE9VDxzhEIUhEqRGlR\n\tRSbL39QR2r1Sxy132PHS8dNz145AmRC7exUZ9mKaPlh3J/jVO8cQUqOgmIgwKb4t98uJ\n\tKxlsFAxPRlHGd23rZGTbxI27sJoQEJSEkY218Z/fELzO84rl/jsz9QqZHOr4wpC+cmDl\n\tGkqw==","X-Gm-Message-State":"AHPjjUjn3XMJO3GBdlMKkaktiKaVS4kzRgAaHfnlqallo8071kuMlhhP\n\tbVqMmfLgXov+aX0jeobxvEvK0Q==","X-Google-Smtp-Source":"AOwi7QCJfD315mk/kPfdx/pj0qtKHeHLAbYm8OhMpftd4knQI4hVOg7TkPQM8eNmBBZU78pQ6Q7u+A==","X-Received":"by 10.28.193.129 with SMTP id r123mr3048097wmf.93.1505896201002; \n\tWed, 20 Sep 2017 01:30:01 -0700 (PDT)","Subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","To":"Martin Blumenstingl ","Cc":"khilman@baylibre.com, carlo@caione.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,\n\tGouwa , linux-arm-kernel@lists.infradead.org","References":"<1505832820-3517-1-git-send-email-narmstrong@baylibre.com>\n\t<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>\n\t","From":"Neil Armstrong ","Organization":"Baylibre","Message-ID":"<84171990-f5f2-d7d2-2bf6-d28390daac4a@baylibre.com>","Date":"Wed, 20 Sep 2017 10:29:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773196,"web_url":"http://patchwork.ozlabs.org/comment/1773196/","msgid":"<20170921234734.nbjvpz2vukywyrci@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-21T23:47:34","subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 19, 2017 at 04:53:40PM +0200, Neil Armstrong wrote:\n> The Khadas VIM2 is a Single Board Computer, respin of the origin\n> Khadas VIM board, using an Amlogic S912 SoC and more server oriented.\n> \n> It provides the same external connectors and header pinout, plus a SPI\n> NOR Flash, a reprogrammable STM8S003 MCU, FPC Connector, Cooling FAN header\n> and Pogo Pads Arrays.\n> \n> Cc: Gouwa \n> Signed-off-by: Neil Armstrong \n> ---\n> Documentation/devicetree/bindings/arm/amlogic.txt | 1 +\n> arch/arm64/boot/dts/amlogic/Makefile | 1 +\n> .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 401 +++++++++++++++++++++\n> 3 files changed, 403 insertions(+)\n> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts\n\nAcked-by: Rob Herring \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xytd43ZjTz9t3C\n\tfor ;\n\tFri, 22 Sep 2017 09:49:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751791AbdIUXrg (ORCPT\n\t);\n\tThu, 21 Sep 2017 19:47:36 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:33896 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751790AbdIUXrg (ORCPT\n\t); Thu, 21 Sep 2017 19:47:36 -0400","by mail-pg0-f65.google.com with SMTP id u18so4237608pgo.1;\n\tThu, 21 Sep 2017 16:47:36 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\tp5sm3941311pgc.94.2017.09.21.16.47.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Sep 2017 16:47:34 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=vHrGLh2m9EXyOQI+GJ2699hhqbTPujx7SzyeRAUFiX4=;\n\tb=K0MnK9EQtIH7sCtv99KkLz8Mya8PGfalxasSJSM8z5flsDXJHp5OmwH5OZKmlN2SNN\n\tmtQwyod4ordcbq1ftcBTrLBsUNVIKmI/tiabhlD6bPgXgfi4dGKH8dsoKX5hDd10n+0i\n\tK+Z92FJ7bXkpynhRDbr+vicWCrqw8+1f6L1eg/FZ7EK17E1YUdFnHIHy/YJrp6BD1CgD\n\tiVS0zZQmaDV1mRBBknNYIUbyEMyYFRCcpsrcKPFCqI0W+a21yCKyiese3VOrTTmh7prD\n\tBlvyqFu1qFePnCKt1WN01ymhAp8fws8KJkhCbyLEMKDqwtoYuOrwlGbdMfrfO7m35mbK\n\tMvsg==","X-Gm-Message-State":"AHPjjUj1rTiPpKUEgpvJhDbGp66pqbK/5JUkd/0zjt6pqIfGx1s3V086\n\tRaTCNP+qnc1pbYjO+7kZOg==","X-Google-Smtp-Source":"AOwi7QBxTwtKDF3v6gqzNQf6r6IhkxsktFVyr8ANRf9RDo1Xp9amUbnmRziMkvGev+qbIU+egsWElQ==","X-Received":"by 10.99.6.140 with SMTP id 134mr7358044pgg.143.1506037655536;\n\tThu, 21 Sep 2017 16:47:35 -0700 (PDT)","Date":"Thu, 21 Sep 2017 18:47:34 -0500","From":"Rob Herring ","To":"Neil Armstrong ","Cc":"khilman@baylibre.com, carlo@caione.org, linux-amlogic@lists.infradead.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, Gouwa ","Subject":"Re: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2","Message-ID":"<20170921234734.nbjvpz2vukywyrci@rob-hp-laptop>","References":"<1505832820-3517-1-git-send-email-narmstrong@baylibre.com>\n\t<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505832820-3517-3-git-send-email-narmstrong@baylibre.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]