[{"id":1771146,"web_url":"http://patchwork.ozlabs.org/comment/1771146/","msgid":"<20170919150125.GJ3030@localhost.localdomain>","list_archive_url":null,"date":"2017-09-19T15:01:25","subject":"Re: [Qemu-devel] [PATCH v5 2/2] x86_iommu: check if machine has PCI\n\tbus","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Tue, Sep 19, 2017 at 04:51:22PM +0200, Mohammed Gamal wrote:\n> Starting qemu with\n> qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu\n> leads to a segfault. The code assume PCI bus is present and\n> tries to access the bus structure without checking.\n> \n> Since Intel VT-d and AMDVI should only work with PCI, add a\n> check for PCI bus and return error if not present.\n> \n> Signed-off-by: Mohammed Gamal \n\nWhen resubmitting patches without changes, please keep/add the\nReviewed-by lines from previous patch versions.\n\nReviewed-by: Eduardo Habkost ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxRTZ4Wh6z9s7B\n\tfor ;\n\tWed, 20 Sep 2017 01:23:14 +1000 (AEST)","from localhost ([::1]:43511 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duKMi-0007zL-LC\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 11:23:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47847)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duK1r-0006MS-0P\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:01:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duK1o-0002Iu-AS\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:01:39 -0400","from mx1.redhat.com ([209.132.183.28]:47176)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duK1o-0002IL-5O\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:01:36 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2BB3A7E445\n\tfor ; Tue, 19 Sep 2017 15:01:35 +0000 (UTC)","from localhost (ovpn-116-23.gru2.redhat.com [10.97.116.23])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 087575D6A6;\n\tTue, 19 Sep 2017 15:01:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2BB3A7E445","Date":"Tue, 19 Sep 2017 12:01:25 -0300","From":"Eduardo Habkost ","To":"Mohammed Gamal ","Message-ID":"<20170919150125.GJ3030@localhost.localdomain>","References":"<1505832682-27325-1-git-send-email-mgamal@redhat.com>\n\t<1505832682-27325-3-git-send-email-mgamal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505832682-27325-3-git-send-email-mgamal@redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 19 Sep 2017 15:01:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 2/2] x86_iommu: check if machine has PCI\n\tbus","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org,\n\tpeterx@redhat.com, mst@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]