[{"id":1771170,"web_url":"http://patchwork.ozlabs.org/comment/1771170/","msgid":"","list_archive_url":null,"date":"2017-09-19T15:29:18","subject":"Re: [Qemu-devel] [PATCH v2 2/3] s390x/tcg: move wrap_address() to\n\tinternal.h","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/19/2017 11:26 AM, David Hildenbrand wrote:\n> We want to use it in another file.\n> \n> Signed-off-by: David Hildenbrand \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> target/s390x/internal.h | 14 ++++++++++++++\n> target/s390x/mem_helper.c | 14 --------------\n> 2 files changed, 14 insertions(+), 14 deletions(-)\n> \n> diff --git a/target/s390x/internal.h b/target/s390x/internal.h\n> index bc8f83129a..70d2b87e55 100644\n> --- a/target/s390x/internal.h\n> +++ b/target/s390x/internal.h\n> @@ -162,6 +162,20 @@ static inline uint8_t get_per_atmid(CPUS390XState *env)\n> ((env->psw.mask & PSW_ASC_ACCREG) ? (1 << 2) : 0);\n> }\n> \n> +static inline uint64_t wrap_address(CPUS390XState *env, uint64_t a)\n> +{\n> + if (!(env->psw.mask & PSW_MASK_64)) {\n> + if (!(env->psw.mask & PSW_MASK_32)) {\n> + /* 24-Bit mode */\n> + a &= 0x00ffffff;\n> + } else {\n> + /* 31-Bit mode */\n> + a &= 0x7fffffff;\n> + }\n> + }\n> + return a;\n> +}\n> +\n> /* CC optimization */\n> \n> /* Instead of computing the condition codes after each x86 instruction,\n> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c\n> index ec4760e390..a254613dc2 100644\n> --- a/target/s390x/mem_helper.c\n> +++ b/target/s390x/mem_helper.c\n> @@ -122,20 +122,6 @@ static inline void cpu_stsize_data_ra(CPUS390XState *env, uint64_t addr,\n> }\n> }\n> \n> -static inline uint64_t wrap_address(CPUS390XState *env, uint64_t a)\n> -{\n> - if (!(env->psw.mask & PSW_MASK_64)) {\n> - if (!(env->psw.mask & PSW_MASK_32)) {\n> - /* 24-Bit mode */\n> - a &= 0x00ffffff;\n> - } else {\n> - /* 31-Bit mode */\n> - a &= 0x7fffffff;\n> - }\n> - }\n> - return a;\n> -}\n> -\n> static void fast_memset(CPUS390XState *env, uint64_t dest, uint8_t byte,\n> uint32_t l, uintptr_t ra)\n> {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"K1pIku+h\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxS6k1pdRz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 01:51:58 +1000 (AEST)","from localhost ([::1]:43706 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duKoW-0007Iy-A5\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 11:51:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40459)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1duKSl-0006Xj-R2\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:29:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1duKSh-0006HZ-E7\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:29:27 -0400","from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:37413)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duKSh-0006H8-9w\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 11:29:23 -0400","by mail-qt0-x244.google.com with SMTP id u48so2537885qtc.4\n\tfor ; Tue, 19 Sep 2017 08:29:23 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tu49sm7197555qta.85.2017.09.19.08.29.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 08:29:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=zeupmveMBiuoUJWLqrf/dbNgjYyA+ws3hwiK1i4JFT4=;\n\tb=K1pIku+hQvSo1qm6HibHo8hnuC8KfyMsy26aua10Rp6MZikg7tKVMMSFfY/2bA5l8f\n\tEuQBVRzj0cUFsvYc94vRkLcIpvgCd46rdgcVceoTiCzr4c6wgDkS214vLCzJvZH3ibhv\n\tJY8Yf3TGR6LZ7XF2275dArMOfEXwvJ7+Qosy48amQEFMiiReCxYpEv2R8IpqyEOpuyP5\n\tysz2N3Z3Sf8lNyPkBOGgs6iecYW39hlDC9EiiQAUsmbV5SxSG00fNnh2zuc9ZgDV3014\n\tovJ09f01u0nV2F+t870J0i4EB4gR29UNlmlrH8okf+K3zH1rLHr2ZznWTQ4JFKuAd68S\n\tfULw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=zeupmveMBiuoUJWLqrf/dbNgjYyA+ws3hwiK1i4JFT4=;\n\tb=r3daG0hFW/O3XpnbHcHBbYRbBEsUD/9w7vvZSM3SoUNHwSqTXkgvVn5sTza08XhccD\n\t5U8ORdwTox+8XfOp6O0wGChVmrj2sdRQ0vPeaN2YFL+KwTrNAhOJekwUNTInMcS2m24S\n\tOqrm9tHY4VcVIr091HG4iBR3JluVe4ZHL/8GYF6TqzH8GvyYdXBoeryFEpAdPu/62KOj\n\thLDvG+/XxU2H4zdamL/Qk8dbAD8MguUVFHtjgPuX3WQhgAM627HHk0h9pyqsV7tFIx0E\n\tnJT/ScrbEa7cc8+KnmEJ9m4efJtzN2bd16k35KadgMkVYTck5Ni0WvDw01gVeQBUzBew\n\tyFlg==","X-Gm-Message-State":"AHPjjUhNJQu9U12q/cbmsNgQaXHGQUkm7Z6bkOC/2uBb7wTqbKDcE6tY\n\tndQxJqu3sBXLkbkGxRALqwA=","X-Google-Smtp-Source":"AOwi7QDkDsJxxqIpPTnqqT6r2an3f9tXJ9FaJaKUsN8OtVtBk0F2SmFM4IjQodpNVYzEZEfmDnjJVg==","X-Received":"by 10.200.28.123 with SMTP id j56mr2666182qtk.299.1505834962792; \n\tTue, 19 Sep 2017 08:29:22 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170919142654.16369-1-david@redhat.com>\n\t<20170919142654.16369-3-david@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Tue, 19 Sep 2017 12:29:18 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919142654.16369-3-david@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::244","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] s390x/tcg: move wrap_address() to\n\tinternal.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771258,"web_url":"http://patchwork.ozlabs.org/comment/1771258/","msgid":"<94236fbd-5c7b-42d3-ea63-49395c7bab7a@linaro.org>","list_archive_url":null,"date":"2017-09-19T17:24:47","subject":"Re: [Qemu-devel] [PATCH v2 2/3] s390x/tcg: move wrap_address() to\n\tinternal.h","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/19/2017 09:26 AM, David Hildenbrand wrote:\n> We want to use it in another file.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/internal.h | 14 ++++++++++++++\n> target/s390x/mem_helper.c | 14 --------------\n> 2 files changed, 14 insertions(+), 14 deletions(-)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ZTCYyJ+y\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxVxC4dQbz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 03:58:54 +1000 (AEST)","from localhost ([::1]:44607 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duMnL-0003ze-Q7\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 13:58:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40776)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duMGV-0008BK-JV\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 13:24:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duMGS-0000AZ-L0\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 13:24:55 -0400","from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]:55573)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duMGS-0000AG-FB\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 13:24:52 -0400","by mail-io0-x230.google.com with SMTP id z187so729959ioz.12\n\tfor ; Tue, 19 Sep 2017 10:24:52 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.gmail.com with ESMTPSA id\n\to206sm3082014oif.26.2017.09.19.10.24.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 10:24:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=HEqfAqW8LWxwRhqx1dmt6xfzTuDGffgwVguS4X3G9Lc=;\n\tb=ZTCYyJ+yRDrGjIoDTy+ghtvQmrjOZdDFkJJ6WkcbL69I2kqZMn+T0lvjBfQnrNviEp\n\tKZi+22klJrNZhgIg2uK+5hxXlWqnQ/UXON2JsX6xO+e9g4lqbwhG2gMsxbkck089TzlN\n\tXz8Hr8D5iNO3OKY6m5R3xq4RftptaP+4fvyW4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HEqfAqW8LWxwRhqx1dmt6xfzTuDGffgwVguS4X3G9Lc=;\n\tb=kUYFMbVTtFZTBuxqhprTiPpMQj9Boapn6lZvDyDw/8GbCMBaH5/90+7Qds6MyT2FqS\n\tXOkQQefxTC0FVeeV/f5pcxfsOTMKqARtBDZJwRRkiMPX10X7tJoDDVhBD81QVUVmGbF9\n\tVz4vT6ERtjHDiQiN/E1OnOzpod27+lLytnd7Y/u6H1n9gqtMhpkSAl4nyiLNwucVxxwY\n\toIT/KlNC83w9B0enYqR5ZHPBSQXBJGYjPqHBOJV9SzT755R1x0CmFRo7mdhsVNqXzzfb\n\t+lJF1zkegeJx39EQwK+N7Fka9iZpEGZD37EwXlQIJDfOi/J4S+bTMQLkhhlGwAwnwNZD\n\tKTiA==","X-Gm-Message-State":"AHPjjUjXKkEcBdIP5/drunRfgPytX+90GfVNaKPX6VBpzWZOmaaL7Re5\n\tm2M8D6gWsexzBWAYyT1ojpPymg==","X-Google-Smtp-Source":"AOwi7QAwx2I/GimpP+wSgCuRQ+D68VnjXJKdH4mZ+eNwhThQurWHSWEoR+FxT4tVnDDqYGa25yhBqA==","X-Received":"by 10.202.216.214 with SMTP id p205mr2272696oig.35.1505841891587;\n\tTue, 19 Sep 2017 10:24:51 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170919142654.16369-1-david@redhat.com>\n\t<20170919142654.16369-3-david@redhat.com>","From":"Richard Henderson ","Message-ID":"<94236fbd-5c7b-42d3-ea63-49395c7bab7a@linaro.org>","Date":"Tue, 19 Sep 2017 12:24:47 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919142654.16369-3-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::230","Subject":"Re: [Qemu-devel] [PATCH v2 2/3] s390x/tcg: move wrap_address() to\n\tinternal.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, cohuck@redhat.com, Alexander Graf ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]