[{"id":1776296,"web_url":"http://patchwork.ozlabs.org/comment/1776296/","msgid":"<20170927121951.GA26052@salvia>","list_archive_url":null,"date":"2017-09-27T12:19:51","subject":"Re: [PATCH nft 1/2] evaluate: prepare to store expr key rather than\n\tdatatype","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Tue, Sep 19, 2017 at 02:49:53PM +0200, Florian Westphal wrote:\n> currently set definitions store a datatype rather than\n> an expression.\n> \n> In order to support use of unqualified data types (string in particular),\n> this prepares implicit set definition helper to expect an expression instead\n> of plain data type. This also has the advantage that we can use EXPR_CONCAT\n> to retain the original expressions when key concatentation is used, e.g.\n> 'meta iifname . tcp dport'. The netlink serialization code can use\n> this info to store individual key lengths independently of data types.\n> \n> Would also allow later on to store the original names of the\n> expressions, e.g. \"ip daddr\", in the kernel to support a future\n> typeof keyword, e.g. 'type typeof(ip daddr)' instead of 'type ipv4_addr'.\n> \n> Signed-off-by: Florian Westphal \n\nAcked-by: Pablo Neira Ayuso \n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2H2N70Xzz9tXT\n\tfor ;\n\tWed, 27 Sep 2017 22:19:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752303AbdI0MT4 (ORCPT );\n\tWed, 27 Sep 2017 08:19:56 -0400","from ganesha.gnumonks.org ([213.95.27.120]:35710 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752104AbdI0MTz (ORCPT\n\t);\n\tWed, 27 Sep 2017 08:19:55 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dxBJg-0003RE-4O; Wed, 27 Sep 2017 14:19:53 +0200"],"Date":"Wed, 27 Sep 2017 14:19:51 +0200","From":"Pablo Neira Ayuso ","To":"Florian Westphal ","Cc":"netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH nft 1/2] evaluate: prepare to store expr key rather than\n\tdatatype","Message-ID":"<20170927121951.GA26052@salvia>","References":"<20170919124954.26852-1-fw@strlen.de>\n\t<20170919124954.26852-2-fw@strlen.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919124954.26852-2-fw@strlen.de>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]