[{"id":1771004,"web_url":"http://patchwork.ozlabs.org/comment/1771004/","msgid":"<3bb3924d-a7c9-26b3-50a2-8a10ef2585e5@amsat.org>","list_archive_url":null,"date":"2017-09-19T13:27:42","subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED\n\tblinker model","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/19/2017 08:26 AM, Cédric Le Goater wrote:\n> Specs are available here :\n> \n> https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf\n> \n> This is a simple model supporting the basic registers for led and GPIO\n> mode. The device also supports two blinking rates but not the model\n> yet.\n> \n> Signed-off-by: Cédric Le Goater \n> ---\n> default-configs/arm-softmmu.mak | 1 +\n> hw/misc/Makefile.objs | 1 +\n> hw/misc/pca9552.c | 212 ++++++++++++++++++++++++++++++++++++++++\n> include/hw/misc/pca9552.h | 32 ++++++\n\nI'd rather move it to hw/display/\n\n> 4 files changed, 246 insertions(+)\n> create mode 100644 hw/misc/pca9552.c\n> create mode 100644 include/hw/misc/pca9552.h","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iBxu9PJB\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxNxG6gTsz9sBZ\n\tfor ;\n\tTue, 19 Sep 2017 23:28:34 +1000 (AEST)","from localhost ([::1]:42873 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duIZk-00021G-TL\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 09:28:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44081)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1duIZ2-0001zR-Hu\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:27:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1duIZ1-0006me-I4\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:27:48 -0400","from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:38282)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duIZ1-0006lv-D3; Tue, 19 Sep 2017 09:27:47 -0400","by mail-qt0-x244.google.com with SMTP id f24so2300933qte.5;\n\tTue, 19 Sep 2017 06:27:47 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tn34sm6958109qtf.10.2017.09.19.06.27.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 06:27:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=jqw73LWBoxXSPQ6ARPv8EPiBzjvHpYD59rFxitSjDyA=;\n\tb=iBxu9PJBnwv9f+GuWazvgj+10Yln8+BSm5xrsSr2rs7FjHYbDqUYbIiyY6S8SKZnc4\n\tVPc8V3uikiUsrTMzWEAyiFH4ny+Q+APjd0BiICgRWbguKiVVqJ5qUGx4ZGGVZ8SFPN6E\n\tP0c4d2PR7gy51T71nIA3LSCG3yH7J3KMghKcfI3fCwePZxGOXo+at5ARPPMpNpEWbGWZ\n\tvKO7hvHS542UXScbHVqhPdZ9d6cWzd/VAMFutcGhmThbM46NdWZFzn9bSu3vK0mgvchS\n\tixXgfApHwV4anm71XqhKX3XOEiEwk0RQapwzw73hrJtkhxdG2TXsGuupHPUrH+gRtP3q\n\txWuA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=jqw73LWBoxXSPQ6ARPv8EPiBzjvHpYD59rFxitSjDyA=;\n\tb=oNt5L1twu6iybbn1eULOfEESTkaMFRi/Xaua8WM0nMJtqARekHgLtAFKoIYxOnAXLl\n\tyQqlO+syGx3IyeRZEzavaMv98HkCKrttOl549vtC5PE0fQVc8PDQ4ihjeuFVcOohyh+b\n\tBl3sk4b/beSG5reVgbAHEoWBKxuGVUX9YJFSmLLguHm9MtlaH9cMj1k0NErZyDGDBvz3\n\tMC5QSATIxNBKvg+JVLEywZDjufdyjQzBjuwf3sZSTSxW73BB4kX/Bpt1wp3IJcRVIkru\n\tHM14n37NMpr7S5lCOR2EzErVHIXxVxmh3E4XOttklRU/erNXA+UsKZK5xz/dCo0kngoZ\n\tfQKw==","X-Gm-Message-State":"AHPjjUihblSNcA3UkmDirfckuiaF17w61cOGgtEExZ8Put4F8zPETHHR\n\tgCRe+chyaFNAeEcuLLRf2+0=","X-Google-Smtp-Source":"AOwi7QDVJxZNAUAAgjXulcC485LmH9VcudeaiCHNzRylsq7x7MHog50/KrH5afdN9mhrTMDwYFZq9w==","X-Received":"by 10.200.40.104 with SMTP id 37mr1980209qtr.284.1505827666654; \n\tTue, 19 Sep 2017 06:27:46 -0700 (PDT)","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n\tPeter Maydell ","References":"<20170919112645.8574-1-clg@kaod.org>\n\t<20170919112645.8574-5-clg@kaod.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<3bb3924d-a7c9-26b3-50a2-8a10ef2585e5@amsat.org>","Date":"Tue, 19 Sep 2017 10:27:42 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919112645.8574-5-clg@kaod.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::244","Subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED\n\tblinker model","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771629,"web_url":"http://patchwork.ozlabs.org/comment/1771629/","msgid":"","list_archive_url":null,"date":"2017-09-20T06:55:37","subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED\n\tblinker model","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/19/2017 03:27 PM, Philippe Mathieu-Daudé wrote:\n> On 09/19/2017 08:26 AM, Cédric Le Goater wrote:\n>> Specs are available here :\n>>\n>>    https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf\n>>\n>> This is a simple model supporting the basic registers for led and GPIO\n>> mode. The device also supports two blinking rates but not the model\n>> yet.\n>>\n>> Signed-off-by: Cédric Le Goater \n>> ---\n>>   default-configs/arm-softmmu.mak |   1 +\n>>   hw/misc/Makefile.objs           |   1 +\n>>   hw/misc/pca9552.c               | 212 ++++++++++++++++++++++++++++++++++++++++\n>>   include/hw/misc/pca9552.h       |  32 ++++++\n> \n> I'd rather move it to hw/display/\n\nThe device is not related to displays. It is just an I2C expander \nchip. I would leave it under misc/\n\nC. \n\n> \n>>   4 files changed, 246 insertions(+)\n>>   create mode 100644 hw/misc/pca9552.c\n>>   create mode 100644 include/hw/misc/pca9552.h","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxrBX0JqWz9s7p\n\tfor ;\n\tWed, 20 Sep 2017 16:56:36 +1000 (AEST)","from localhost ([::1]:47074 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duYvx-00016N-O4\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 02:56:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40985)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duYvG-0000xJ-RE\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 02:55:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duYvC-0002MA-7A\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 02:55:50 -0400","from 3.mo2.mail-out.ovh.net ([46.105.58.226]:43592)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duYvB-0002Kq-Pd\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 02:55:46 -0400","from player157.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo2.mail-out.ovh.net (Postfix) with ESMTP id 5CFBFAC957\n\tfor ; Wed, 20 Sep 2017 08:55:44 +0200 (CEST)","from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: postmaster@kaod.org)\n\tby player157.ha.ovh.net (Postfix) with ESMTPSA id C821650009E;\n\tWed, 20 Sep 2017 08:55:37 +0200 (CEST)"],"To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell ","References":"<20170919112645.8574-1-clg@kaod.org>\n\t<20170919112645.8574-5-clg@kaod.org>\n\t<3bb3924d-a7c9-26b3-50a2-8a10ef2585e5@amsat.org>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"","Date":"Wed, 20 Sep 2017 08:55:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<3bb3924d-a7c9-26b3-50a2-8a10ef2585e5@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"1220194025043430355","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrheekgdduudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.58.226","Subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED\n\tblinker model","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org, Joel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]