[{"id":1777781,"web_url":"http://patchwork.ozlabs.org/comment/1777781/","msgid":"<20170929202551.GM3112@bill-the-cat>","list_archive_url":null,"date":"2017-09-29T20:25:51","subject":"Re: [U-Boot] [U-Boot, v2,\n\t1/1] kconfiglib: update with 'imply' support","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Tue, Sep 19, 2017 at 12:52:55PM +0200, Ulf Magnusson wrote:\n\n> Corresponds to 375506d (File writing nit) from upstream\n> (https://github.com/ulfalizer/Kconfiglib).\n> \n> Adds proper 'imply' support and fixes a few minor issues, one of which\n> previously triggered the following weird warning:\n> \n> configs/taurus_defconfig: /tmp/tmpisI45S:6: warning: assignment to SPL_LDSCRIPT changes mode of containing choice from \"arch/$(ARCH)/cpu/u-boot-spl.lds\" to \"y\"\n> \n> The change in 8639f69 (genconfig.py: Print defconfig next to warnings)\n> was reapplied.\n> \n> tools/moveconfig.py previously depended on a hack that merged 'select's\n> with 'imply's. It was modified to look at the union of\n> Symbol.get_selected_symbols() and Symbol.get_implied_symbols(), which\n> should give the same behavior.\n> \n> tools/genboardscfg.py was verified to produce identical board.cfg's\n> before and after the change.\n> \n> Signed-off-by: Ulf Magnusson \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"mq9TXXVY\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3jxG6YqVz9t2Q\n\tfor ;\n\tSat, 30 Sep 2017 06:35:30 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A449AC21E7C; Fri, 29 Sep 2017 20:29:51 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 3059FC21E8E;\n\tFri, 29 Sep 2017 20:29:19 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0BFECC21DDA; Fri, 29 Sep 2017 20:25:56 +0000 (UTC)","from mail-yw0-f182.google.com (mail-yw0-f182.google.com\n\t[209.85.161.182])\n\tby lists.denx.de (Postfix) with ESMTPS id 695CAC21DDA\n\tfor ; Fri, 29 Sep 2017 20:25:49 +0000 (UTC)","by mail-yw0-f182.google.com with SMTP id v72so541634ywa.3\n\tfor ; Fri, 29 Sep 2017 13:25:49 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:59d1:1e23:9925:e8d6])\n\tby smtp.gmail.com with ESMTPSA id\n\to190sm2148028ywo.50.2017.09.29.13.25.47\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 29 Sep 2017 13:25:47 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=e+TIV1z3ts+PdsFi6A/jQza186ZHgdqyZ99ZzB5FNbA=;\n\tb=mq9TXXVYV242pwNu4toyTkVcSNHgygrHY/2diAgmSkKjWG0gyBF7OPEVzB/PcsOLZl\n\taoHrbUMxNVLobz9ixdnXd+RuK+DKWda0+nEz2c7DFQq24of6oRX/hwhXYDGrT0LhW6C3\n\tR+5JTl4fQGW5DUrjLn4boREb2/ktZ3yUE9gEo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=e+TIV1z3ts+PdsFi6A/jQza186ZHgdqyZ99ZzB5FNbA=;\n\tb=Q1yDlfHmNiieNvvwPAvqtlDNYFA/If9X1z5qKLtViERcAzzlmoQNnEej+dG2+VYcpo\n\ta6LBjq0a/4b7LqM0EOTvo64b6kYnvsWu63FNWouEnsepLmTFwAPVx5iKcSPIE2bbokM+\n\t1TGEuzSE/ZQsUTykgQviPpQuiysGTs2JVo6HRE8ULe663Nkgz1dLeCXhyKc2VDGopFuH\n\tAFNF5xD3BTxUfD8Xs666M2+LaIL1GS3LNyFEL4zrOkEPKTYj2fIRir1ThSv+JcG/jCmK\n\t8rUypeNVwoV69m/JIcqZ7/cePoVfmjujuuAc1B4o+apk3DGYZNhcYNLUEK8nDLqUqFvM\n\tGd8A==","X-Gm-Message-State":"AHPjjUgQYbBId9APiUdKMnvv7D5/qABZxbz69cYwhhbbUjjUGOY7oGKe\n\tH4fyC+cE019yqFWJx38lTvxWgw==","X-Google-Smtp-Source":"AOwi7QBcvnvSRv/0NQPsFaXop96qihHNzcXTtlRD00xtxXpbCa5VQ1CVqrNW9LCU/wjDzhK/7k1qdg==","X-Received":"by 10.37.31.193 with SMTP id f184mr6880412ybf.2.1506716748127;\n\tFri, 29 Sep 2017 13:25:48 -0700 (PDT)","Date":"Fri, 29 Sep 2017 16:25:51 -0400","From":"Tom Rini ","To":"Ulf Magnusson ","Message-ID":"<20170929202551.GM3112@bill-the-cat>","References":"<1505818375-1066-2-git-send-email-ulfalizer@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<1505818375-1066-2-git-send-email-ulfalizer@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [U-Boot, v2,\n\t1/1] kconfiglib: update with 'imply' support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============7713346443066156336==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1778633,"web_url":"http://patchwork.ozlabs.org/comment/1778633/","msgid":"","list_archive_url":null,"date":"2017-10-02T22:05:19","subject":"Re: [U-Boot] [U-Boot, v2,\n\t1/1] kconfiglib: update with 'imply' support","submitter":{"id":64803,"url":"http://patchwork.ozlabs.org/api/people/64803/","name":"Ulf Magnusson","email":"ulfalizer@gmail.com"},"content":"On Fri, Sep 29, 2017 at 10:25 PM, Tom Rini wrote:\n> On Tue, Sep 19, 2017 at 12:52:55PM +0200, Ulf Magnusson wrote:\n>\n>> Corresponds to 375506d (File writing nit) from upstream\n>> (https://github.com/ulfalizer/Kconfiglib).\n>>\n>> Adds proper 'imply' support and fixes a few minor issues, one of which\n>> previously triggered the following weird warning:\n>>\n>> configs/taurus_defconfig: /tmp/tmpisI45S:6: warning: assignment to SPL_LDSCRIPT changes mode of containing choice from \"arch/$(ARCH)/cpu/u-boot-spl.lds\" to \"y\"\n>>\n>> The change in 8639f69 (genconfig.py: Print defconfig next to warnings)\n>> was reapplied.\n>>\n>> tools/moveconfig.py previously depended on a hack that merged 'select's\n>> with 'imply's. It was modified to look at the union of\n>> Symbol.get_selected_symbols() and Symbol.get_implied_symbols(), which\n>> should give the same behavior.\n>>\n>> tools/genboardscfg.py was verified to produce identical board.cfg's\n>> before and after the change.\n>>\n>> Signed-off-by: Ulf Magnusson \n>\n> Applied to u-boot/master, thanks!\n>\n> --\n> Tom\n\nFor future reference, Kconfiglib is now available on PyPI and can be\ninstalled via e.g. 'pip' (see the updated README at\nhttps://github.com/ulfalizer/Kconfiglib).\n\nMaybe the custom patch in 8639f69a (genconfig.py: Print defconfig next\nto warnings) could be removed if stderr is temporarily redirected to a\nstring (https://stackoverflow.com/questions/1218933/can-i-redirect-the-stdout-in-python-into-some-sort-of-string-buffer).\nI was thinking of adding an optional list argument to some functions\nthat would receive the warning strings if provided, but I'm not sure\nif it's worth it. Would want them printed directly by default at\nleast, because otherwise people will miss them.\n\nCheers,\nUlf","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KBKP2Btn\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5bnn5G2mz9t4c\n\tfor ;\n\tTue, 3 Oct 2017 09:05:33 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 76306C21F0E; Mon, 2 Oct 2017 22:05:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 064A0C21C62;\n\tMon, 2 Oct 2017 22:05:27 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid ED6DEC21C62; Mon, 2 Oct 2017 22:05:24 +0000 (UTC)","from mail-ua0-f193.google.com (mail-ua0-f193.google.com\n\t[209.85.217.193])\n\tby lists.denx.de (Postfix) with ESMTPS id 6B1E2C21C46\n\tfor ; Mon, 2 Oct 2017 22:05:21 +0000 (UTC)","by mail-ua0-f193.google.com with SMTP id 103so125325uas.0\n\tfor ; Mon, 02 Oct 2017 15:05:21 -0700 (PDT)","by 10.103.68.14 with HTTP; Mon, 2 Oct 2017 15:05:19 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=tyrqr1smeEBgviKG7wwp201MNNH4Yffl1X8PlxizZa0=;\n\tb=KBKP2Btnu4VjRqlNr97VtjphGz18ABXCxNa8+HZnVz5C9tMM7zkY6K/EIC0zkHzCpq\n\tRwKnskMyVzn9r10sczaOMaeUUdShMzdo0rIC2x68JDVcaLxN574sbx0kc5BsXbJRFgqG\n\ttJMK2fwKrvYs/BfPEDZWXiaH5TXuWDQIabJGE2TqyUL/lSbXv0svTEkAPhbFT/GyIVS5\n\tDvDHW9PLI8JpZtC25a0BFLK9uJXxSgPOJiXFLSujbBgxF/xD+bbjjzdk7Z2o8K1Yx3Um\n\tb5kiM6m0ARZJx6gkv0CGUsFHBN/lOe3hRat0Gt06Dj+7YDt6JIK1XKfIx386yDC/NlQS\n\t42ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=tyrqr1smeEBgviKG7wwp201MNNH4Yffl1X8PlxizZa0=;\n\tb=Nqc9U/hk2Fyp1YN2meOyMA3ExH1Dmd6fDgjXwCiM2WItjXDTPyGtbsj7x4BlEJNKNw\n\twq2SEFYvN3HZd4YTEt8ThpUuNMgSKEVA7NmK2SAWkp55Qqrl6S0H21/od47R1Rlb2t3J\n\t/sB5nc6nuvzEbNXhxOZ4e1dpZ3VF5Luqe6GqSF+EYqkJoZt5vSxBjgc3MCj2GVDZyerz\n\teeBkjG6Sw2dRq0dg1hRonSMHSz5QOa+6cr3C4wDiqHAG2eWlBygOnUsEareuOOhdRRj0\n\tWCu+OC3R8rXYf1BFjarwK3z3dsh5Of+ovKLwhBiDVhMgp8U6TnGYTMVRr9Zu9NSix4Gs\n\tJiYA==","X-Gm-Message-State":"AMCzsaUVVnDHBnFbk+K8RT6m/3jtF2qEqEmUCsGLSQbNdFivmMTL7wYz\n\tpeCBKOA/+P4O3gREh42BDZyIAauczUIJGsHSRZA=","X-Google-Smtp-Source":"AOwi7QBU9aKUpS9UNiHfebRLkFxFBIIfE2nycY+nFyjBpOP30O13rHdP7LSPVwGaUjo63XSBw9lBhB8tMJS9okhA/Os=","X-Received":"by 10.176.91.18 with SMTP id u18mr1786389uae.77.1506981920096;\n\tMon, 02 Oct 2017 15:05:20 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170929202551.GM3112@bill-the-cat>","References":"<1505818375-1066-2-git-send-email-ulfalizer@gmail.com>\n\t<20170929202551.GM3112@bill-the-cat>","From":"Ulf Magnusson ","Date":"Tue, 3 Oct 2017 00:05:19 +0200","Message-ID":"","To":"Tom Rini , Simon Glass ","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [U-Boot, v2,\n\t1/1] kconfiglib: update with 'imply' support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]