[{"id":1771151,"web_url":"http://patchwork.ozlabs.org/comment/1771151/","msgid":"<20170919152500.ce62nirm7gu3lqvq@rh_laptop>","list_archive_url":null,"date":"2017-09-19T15:25:00","subject":"Re: [PATCH v2] VFS: Handle lazytime in do_mount()","submitter":{"id":4059,"url":"http://patchwork.ozlabs.org/api/people/4059/","name":"Lukas Czerner","email":"lczerner@redhat.com"},"content":"On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote:\n> Since commit e462ec50cb5fa (\"VFS: Differentiate mount flags (MS_*) from\n> internal superblock flags\") the lazytime mount option didn't get passed\n> on anymore.\n> \n> Fix the issue by handling the option in do_mount().\n> \n> Signed-off-by: Markus Trippelsdorf \n> ---\n> fs/namespace.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/fs/namespace.c b/fs/namespace.c\n> index 54059b142d6b..b633838b8f02 100644\n> --- a/fs/namespace.c\n> +++ b/fs/namespace.c\n> @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,\n> \t\t\t SB_MANDLOCK |\n> \t\t\t SB_DIRSYNC |\n> \t\t\t SB_SILENT |\n> -\t\t\t SB_POSIXACL);\n> +\t\t\t SB_POSIXACL |\n> +\t\t\t SB_LAZYTIME);\n\nLooks good. Although I still think that this can be per mountpoint options.\n\nRegardless of that, you can add\nReviewed-by: Lukas Czerner \n\n> \n> \tif (flags & MS_REMOUNT)\n> \t\tretval = do_remount(&path, flags, sb_flags, mnt_flags,\n> -- \n> Markus","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lczerner@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxRXJ4g4sz9sBZ\n\tfor ;\n\tWed, 20 Sep 2017 01:25:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751619AbdISPZF (ORCPT );\n\tTue, 19 Sep 2017 11:25:05 -0400","from mx1.redhat.com ([209.132.183.28]:42734 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751425AbdISPZE (ORCPT );\n\tTue, 19 Sep 2017 11:25:04 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9E030C00DB97;\n\tTue, 19 Sep 2017 15:25:04 +0000 (UTC)","from rh_laptop (unknown [10.43.17.67])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 9AE9D5D6A4;\n\tTue, 19 Sep 2017 15:25:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9E030C00DB97","Date":"Tue, 19 Sep 2017 17:25:00 +0200","From":"Lukas Czerner ","To":"Markus Trippelsdorf ","Cc":"Theodore Ts'o , Andreas Dilger ,\n\tlinux-ext4@vger.kernel.org, Alexander Viro ,\n\tlinux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tDavid Howells ","Subject":"Re: [PATCH v2] VFS: Handle lazytime in do_mount()","Message-ID":"<20170919152500.ce62nirm7gu3lqvq@rh_laptop>","References":"<20170918192644.GA232@x4> <20170919083506.GA233@x4>\n\t<20170919101819.GA233@x4> <20170919103724.GA239@x4>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919103724.GA239@x4>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 19 Sep 2017 15:25:04 +0000 (UTC)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1777887,"web_url":"http://patchwork.ozlabs.org/comment/1777887/","msgid":"<20170930071022.GA238@x4>","list_archive_url":null,"date":"2017-09-30T07:10:22","subject":"Re: [PATCH v2] VFS: Handle lazytime in do_mount()","submitter":{"id":1014,"url":"http://patchwork.ozlabs.org/api/people/1014/","name":"Markus Trippelsdorf","email":"markus@trippelsdorf.de"},"content":"On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote:\n> On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote:\n> > Since commit e462ec50cb5fa (\"VFS: Differentiate mount flags (MS_*) from\n> > internal superblock flags\") the lazytime mount option didn't get passed\n> > on anymore.\n> > \n> > Fix the issue by handling the option in do_mount().\n> > \n> > Signed-off-by: Markus Trippelsdorf \n> > ---\n> > fs/namespace.c | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/fs/namespace.c b/fs/namespace.c\n> > index 54059b142d6b..b633838b8f02 100644\n> > --- a/fs/namespace.c\n> > +++ b/fs/namespace.c\n> > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,\n> > \t\t\t SB_MANDLOCK |\n> > \t\t\t SB_DIRSYNC |\n> > \t\t\t SB_SILENT |\n> > -\t\t\t SB_POSIXACL);\n> > +\t\t\t SB_POSIXACL |\n> > +\t\t\t SB_LAZYTIME);\n> \n> Looks good. Although I still think that this can be per mountpoint options.\n> \n> Regardless of that, you can add\n> Reviewed-by: Lukas Czerner \n\nPing?\nAl could you please take look? \nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mail.ud10.udmedia.de header.i=@mail.ud10.udmedia.de\n\theader.b=\"ov0Qbga8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y40274GnYz9t2r\n\tfor ;\n\tSat, 30 Sep 2017 17:10:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750991AbdI3HK0 (ORCPT );\n\tSat, 30 Sep 2017 03:10:26 -0400","from ud10.udmedia.de ([194.117.254.50]:56956 \"EHLO\n\tmail.ud10.udmedia.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750968AbdI3HKZ (ORCPT\n\t); Sat, 30 Sep 2017 03:10:25 -0400","(qmail 18314 invoked from network); 30 Sep 2017 09:10:22 +0200","from ip5b405f48.dynamic.kabel-deutschland.de (HELO x4)\n\t(ud10?360p3@91.64.95.72)\n\tby mail.ud10.udmedia.de with ESMTPSA (ECDHE-RSA-AES256-SHA encrypted,\n\tauthenticated); 30 Sep 2017 09:10:22 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple; d=mail.ud10.udmedia.de; h=\n\tdate:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; s=k1; bh=WWk+x+AGFxqxHL+4waLjgxV+l/yf\n\ts/W4ncdXfufahfA=; b=ov0Qbga8KVGzfn+zvL3xGuLYmNvACSG06oDcqD+DGDHZ\n\tBI5W18hSMFeMG3WjDD13q4WGl2yEK/vx5gj8WNCtQiXg7Hj5M13nLH+hxApstdIh\n\t6EuvfnMWtcvRVl0e3LyV497YtfPhdOg5IlAvKKpVp6rKcteeJBwWODYfKbEQnWY=","Date":"Sat, 30 Sep 2017 09:10:22 +0200","From":"Markus Trippelsdorf ","To":"Lukas Czerner ","Cc":"Theodore Ts'o , Andreas Dilger ,\n\tlinux-ext4@vger.kernel.org, Alexander Viro ,\n\tlinux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tDavid Howells ","Subject":"Re: [PATCH v2] VFS: Handle lazytime in do_mount()","Message-ID":"<20170930071022.GA238@x4>","References":"<20170918192644.GA232@x4> <20170919083506.GA233@x4>\n\t<20170919101819.GA233@x4> <20170919103724.GA239@x4>\n\t<20170919152500.ce62nirm7gu3lqvq@rh_laptop>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919152500.ce62nirm7gu3lqvq@rh_laptop>","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]