[{"id":1771796,"web_url":"http://patchwork.ozlabs.org/comment/1771796/","msgid":"<828dc523-0956-1550-f94a-f29b7b5d4444@denx.de>","list_archive_url":null,"date":"2017-09-20T12:27:28","subject":"Re: [swupdate] [PATCH] downloader: exit with EXIT_SUCCESS on success","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 19/09/2017 12:21, Christian Storm wrote:\n> Use EXIT_SUCCESS=0 instead of RECOVERY_STATUS:SUCCESS=3\n> on downloader process exit.\n> \n> Signed-off-by: Christian Storm \n> ---\n> corelib/downloader.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/corelib/downloader.c b/corelib/downloader.c\n> index b79d704..18dc12b 100644\n> --- a/corelib/downloader.c\n> +++ b/corelib/downloader.c\n> @@ -394,5 +394,5 @@ int start_download(const char *fname, int argc, char *argv[])\n> \t\tsleep(60);\n> \t}\n> \n> -\texit(result);\n> +\texit(result == SUCCESS ? EXIT_SUCCESS : result);\n> }\n> \n\nApplied to -master, thanks !\n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c0c::23a;\n\thelo=mail-wr0-x23a.google.com;\n\tenvelope-from=swupdate+bncbaabbnf5rhhakgqepsp3bqy@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"d0jKG3Ov\"; dkim-atps=neutral"],"Received":["from mail-wr0-x23a.google.com (mail-wr0-x23a.google.com\n\t[IPv6:2a00:1450:400c:c0c::23a])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxzXS6s2Lz9t2Q\n\tfor ;\n\tWed, 20 Sep 2017 22:27:35 +1000 (AEST)","by mail-wr0-x23a.google.com with SMTP id k10sf252706wrk.23\n\tfor ;\n\tWed, 20 Sep 2017 05:27:35 -0700 (PDT)","by 10.28.211.207 with SMTP id k198ls404252wmg.21.canary-gmail; Wed,\n\t20 Sep 2017 05:27:32 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10])\n\tby gmr-mx.google.com with ESMTPS id\n\tb62si82741wmd.3.2017.09.20.05.27.32 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 05:27:32 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xxzXN167zz1qvNm;\n\tWed, 20 Sep 2017 14:27:32 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xxzXN0vx3z1qql4;\n\tWed, 20 Sep 2017 14:27:32 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id MQts1sFKS1fe; Wed, 20 Sep 2017 14:27:31 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tWed, 20 Sep 2017 14:27:31 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id E940D45406A6;\n\tWed, 20 Sep 2017 14:27:30 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id U_fy0lCPx7NJ; Wed, 20 Sep 2017 14:27:28 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 65FA04540403;\n\tWed, 20 Sep 2017 14:27:28 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1505910452; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=EpSSs5ROz4t40xXEcEjPsoB86wiuF4DCvm91hBln9Fb0WiC2edKlYOyQMsdyJ/qhEp\n\tSo7W6Qs02L61uCt2TkqYbSPvTA0/lWFGSUPcDqpZoG4SHhXxuFAA7gJl/LECHdObJAA9\n\tUtri74QjQMIQ+DB9v4TfMaHhQQsgUdq3BSJQeN+NgQbJ1BUjcILyeUQL+5YNwvdpIaMQ\n\tXqy5DbWdptYMusB4APVNB/fG7PJE08ipXL/GGmYvOuDhM3aRb905pX0hf3uifmOfPtgS\n\tnM5/Yo12DUWFlIz2hzSUBFlAmb1dXdP2tnDTk/jW99UX6k3PAtWrnHXifFwgM1BMG2o+\n\tfQyg==","i=1; a=rsa-sha256; t=1505910452; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=g1ov9r/VNPbTijoFuJZ+RyEZyJi6rTTz4GxM/K5tTC39qsC6/ZHzXgtYaV4z/s6ycp\n\ty6pO0A0qL5vWQtlFwY27f0hjhnne61cM5+i1FVDwNp91NtAmyh6slZx714MHW0Fvo43/\n\tDOeQpk+Rjsx7ICAxQCPaWtYqixmaq0VmbxnbsHx/gUxKChjfWfol/cWzXVF5Vjf1zxC7\n\tiZ0gyJZecq9fII5hU5p4PkfGVIxVfOjry1vMfp6lHOk3DB1MeHv2+YPY96qFSyJe3k51\n\t2g2I7rr9LwEyGL3UyJc6/AKzxsQpXDx3RP6ZrH4ngdSmfrKtlS/gWupSDPS+75bY4Ov7\n\tXxrg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=Hi4soOd9/j9Ps1PAiAbxA78wvD7G4dlH8OQFmvEKH3o=;\n\tb=ifcTXpFelalmxdqg4dioOFWVzs88KmtjADhksE5hKCgngv1mBxspbKIS/xl6XAn0U8\n\t8x3GTJB5F4znXrNMvPE103DU347/gyHSW2JaKHcJln3ln843VtTbaQKh5MDWDZDsBCJA\n\t0pCJX63CIGIi3Ye1tAzjCtlB2NchhMbLw2vTQoFrcc3UYzgcClEku68W+t2CM/vz67nO\n\tBptOcKnoxkJwsuqlGfEjxPdWby+zJbC6oRciVXzktjsbr5QTnnlY6N9sEYLtX/GwbrH9\n\tsT8O7npFoy9ZqMwgfSBQfIkrvy3wy5qmXHZRrLF8eyLd5BmV0chJGMwJao7ilbTk/QwS\n\taVAw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=d1prC+LXSvlQxrYSUsfAZTxIw6KUcBm7HlfiuNl0HH0=;\n\tb=GU63DFJRs1Q2cgLdySQT3mMd9XRbDaCYn3OKvLd/eYIVGAC1MXjGIjJHhMGHo0+axs\n\tj5Fyrm0S1K0qxAhwJ+HqjAuOf+tLcDhy5rROFnDhl9VmN+BhN6xFl98LPVCxPwuRwUsb\n\trwADp+8DPOhHIPQYN+XtXCzD0xzw0kw85Eg7DfUA5nPxdZ3cRXRA43Jn8uB6w2iegaZM\n\tbHmOz2R5IOL7GpXD5U3H3jpsnNgu30w8u4fe7aLFpl3xd6Ng2nSnIvWfNjjdqYJbQX46\n\toW8VeuwuZN+O7oIAPKZxRsGUdEUYDVu1b4e7VsWtVYE01OZBFZdDwI6zO4F29mn3eK9n\n\tj6Zw=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 212.18.0.10 is neither permitted nor denied\n\tby best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Hi4soOd9/j9Ps1PAiAbxA78wvD7G4dlH8OQFmvEKH3o=;\n\tb=d0jKG3OvPejuhP/osi9y6QofwyIJjfGIDCT2+qhzoMKcmSu+GwqJN3P3jzX+tKgFf9\n\tsqtx2zVi1m4F3VPGmXUYUB6qfuz2N9rZ5SntoylpuraMuAfk2duzmxb5/pKBnz9gntek\n\t/1zd3lWnP8z59O67Ss8HxguB0ApIxBilAerMa/FFGttdrmzXZg8U8nDC0eLLJNRp8aNT\n\t1A4vmIzZhB8Wf3i5B32KNvtm0YM+Bx/UKkgAIN04KqrnbhbvWHOcAnS6S3dTfgdm2b9U\n\t/Zr/1CKHL1aRxEIX/cRrLEBULY5p45sNM9bwoN6cRydcaGW/Z7xIFtettEYjKX0s4y2Q\n\t61tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Hi4soOd9/j9Ps1PAiAbxA78wvD7G4dlH8OQFmvEKH3o=;\n\tb=M9DC/cF+V/79NYnUr/l3uBz7F4f0ziiC5sX9ElZB89ZYkXF+awMxOvfDl//eXSWZUp\n\tiNZxUNZTaJPYRwW0WqiS3dMWJejwGDmKZmxzbSSMgPPPwC7aeF/Kx48eWFNmvqYDQKbx\n\tW98s5+mcCyaytqY/DuyYURseQg99CP8GN0Wvo7LAQg7aQMg9wLGYgQYM856wHt8m9Iwp\n\tJijIjyxpJlC59hI6sEZ+JohXIwmmo9Ng9h9Oz6kSAqGCT3GuDA2rbXEEGOIFznjANbKS\n\tIBj54QBkVDG2a/dD3zyLzT97tO+W7Oc43cYcYhVPiJEJcqgGIdomSc8ijOXea11gqK+V\n\tKxEA==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUjYjxgfgyqe1Q9O7lR2JYJKTQk+HFr/Z87ZRmWp9WtGK5Pova4U\n\tJUCJ2fMQFNjR9jyucPb27LU=","X-Google-Smtp-Source":"AOwi7QApg8xI+4Zp2jwXBMcE1ejc6m0R/agUX/t8GvQMYhnxoJ+d3QQZt+G6lK7GpYaAYbRgdPR/fA==","X-Received":["by 10.28.72.135 with SMTP id v129mr9174wma.22.1505910452734;\n\tWed, 20 Sep 2017 05:27:32 -0700 (PDT)","by 10.223.166.39 with SMTP id k36mr339396wrc.19.1505910452397;\n\tWed, 20 Sep 2017 05:27:32 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 212.18.0.10 is neither permitted nor\n\tdenied by best guess record for domain of sbabic@denx.de)\n\tclient-ip=212.18.0.10; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH] downloader: exit with EXIT_SUCCESS on success","To":"Christian Storm , swupdate@googlegroups.com","References":"<20170919102157.24058-1-christian.storm@siemens.com>","From":"Stefano Babic ","Message-ID":"<828dc523-0956-1550-f94a-f29b7b5d4444@denx.de>","Date":"Wed, 20 Sep 2017 14:27:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919102157.24058-1-christian.storm@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"de-DE","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 212.18.0.10 is neither permitted nor denied by best\n\tguess record\n\tfor domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]