[{"id":1775910,"web_url":"http://patchwork.ozlabs.org/comment/1775910/","msgid":"","list_archive_url":null,"date":"2017-09-26T22:08:02","subject":"Re: [U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","submitter":{"id":16347,"url":"http://patchwork.ozlabs.org/api/people/16347/","name":"Dinh Nguyen","email":"dinh.linux@gmail.com"},"content":"On Tue, Sep 19, 2017 at 4:22 AM, wrote:\n> From: Chin Liang See \n>\n> Add Reset Manager driver support for Stratix SoC\n>\n> Signed-off-by: Chin Liang See \n> ---\n> arch/arm/mach-socfpga/Makefile | 1 +\n> arch/arm/mach-socfpga/include/mach/reset_manager.h | 2 +\n> .../mach-socfpga/include/mach/reset_manager_s10.h | 116 +++++++++++++++++\n> arch/arm/mach-socfpga/reset_manager.c | 5 +\n> arch/arm/mach-socfpga/reset_manager_s10.c | 140 +++++++++++++++++++++\n\nI don't see why you need to add a new file for S10? The functionality between\nGen 5 and Stratix10 is identical for the reset manager.\n\nDinh","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"uH1MhM9m\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1w7q5vhxz9t4Z\n\tfor ;\n\tWed, 27 Sep 2017 08:08:22 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5B14CC21C35; Tue, 26 Sep 2017 22:08:18 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 47705C21C29;\n\tTue, 26 Sep 2017 22:08:06 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 97AEBC21C29; Tue, 26 Sep 2017 22:08:04 +0000 (UTC)","from mail-io0-f194.google.com (mail-io0-f194.google.com\n\t[209.85.223.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 0E0E4C21C26\n\tfor ; Tue, 26 Sep 2017 22:08:04 +0000 (UTC)","by mail-io0-f194.google.com with SMTP id g32so5204106ioj.1\n\tfor ; Tue, 26 Sep 2017 15:08:03 -0700 (PDT)","by 10.79.30.194 with HTTP; Tue, 26 Sep 2017 15:08:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=5Kt5zxV8ZveHMhHNYL4WiErJk+4nlOnz2huQZS7oNJU=;\n\tb=uH1MhM9mDfQxyN+ErmNRQhqZAI4taTLPZHBLtWIxRHU/C1ktO5NMaZj1rFdyj+0eFl\n\tbcuf3gwtm/y5mpEXzblr/3mLDVZkNX41xQMEmwFntWc8EGKVnofQSivTFK/aWY3HyMmI\n\tqhThA1sxAsQNACWiMHaf7V/ZhxL8AmcMLaEErSxj+LjxvzzJ8XXd+eexoOn7C6aXLO8M\n\tcYpS52O3eLHpKlzr1dpsJpscpoN1IHoenvRt6K9zKC59fzKvQAecOZuqvuCorPihbqws\n\tdVsYLzWqDVOIn/UOrTsVuHMpLrwHr4J4zznhP1/YmYax8l6F7xPJQh7C0vL4Pyz3/YzB\n\toGzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=5Kt5zxV8ZveHMhHNYL4WiErJk+4nlOnz2huQZS7oNJU=;\n\tb=Qn8qpk44/SpL8WjotM/5FP+pRcxaYQ6qj1AG/GlhCoZ6z56OPXHU+pmfM+KXbXO00w\n\tPOcxJ6h2YB+MD+1OfGBjqcG4/XsCTkpQffae/6byhbtvOyWTv2I1e9ycWeMI+r8cpo27\n\tQFXPBLJH3ooDiav7UDnUlni/dpumQj/xJse/mpv+Cv9Q6wuqupY5szaJARqNO1Eq0AUL\n\t6kHgo46iEkY07YTxjzbMSFS2Pfigiw7Bu/aYuGk3med3US+DQRBfjV2uHrGIbo89BCbJ\n\tN2xaOtuMcHnvzhkBrLGFxM5hmm6MlMT3csXgboQTtEI0ZozqT9Iui+LgiZRxbcw1OeMK\n\tKMyQ==","X-Gm-Message-State":"AHPjjUjXoFGvaHs6wHRhYofqDLWMLS28bul6ITXJrywU1+tY4BrdE/yt\n\tqIIKxqy3HPRPu3GscokeLHVCyD8MYjKVxivu2vs=","X-Google-Smtp-Source":"AOwi7QDzjKdRasp0CIr9+xFYLvOhbPNS6FYnblxGKw497MxcW5GvGq3SmSrHPz2m2SKRhauEBvrV5ZfPz9ZSoZsvO7k=","X-Received":"by 10.107.40.19 with SMTP id o19mr16482907ioo.120.1506463682776; \n\tTue, 26 Sep 2017 15:08:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505812951-25088-5-git-send-email-chin.liang.see@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-5-git-send-email-chin.liang.see@intel.com>","From":"Dinh Nguyen ","Date":"Tue, 26 Sep 2017 17:08:02 -0500","Message-ID":"","To":"Chin Liang See ","Cc":"Marek Vasut , ZY - u-boot ,\n\tTien Fong Chee ","Subject":"Re: [U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777538,"web_url":"http://patchwork.ozlabs.org/comment/1777538/","msgid":"<1506776055.2766.3.camel@intel.com>","list_archive_url":null,"date":"2017-09-29T12:53:27","subject":"Re: [U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","submitter":{"id":70182,"url":"http://patchwork.ozlabs.org/api/people/70182/","name":"See, Chin Liang","email":"chin.liang.see@intel.com"},"content":"On Tue, 2017-09-26 at 17:08 -0500, Dinh Nguyen wrote:\r\n> On Tue, Sep 19, 2017 at 4:22 AM,   wrote:\r\n> > \r\n> > From: Chin Liang See \r\n> > \r\n> > Add Reset Manager driver support for Stratix SoC\r\n> > \r\n> > Signed-off-by: Chin Liang See \r\n> > ---\r\n> >  arch/arm/mach-socfpga/Makefile                     |   1 +\r\n> >  arch/arm/mach-socfpga/include/mach/reset_manager.h |   2 +\r\n> >  .../mach-socfpga/include/mach/reset_manager_s10.h  | 116\r\n> > +++++++++++++++++\r\n> >  arch/arm/mach-socfpga/reset_manager.c              |   5 +\r\n> >  arch/arm/mach-socfpga/reset_manager_s10.c          | 140\r\n> > +++++++++++++++++++++\r\n> I don't see why you need to add a new file for S10? The functionality\r\n> between\r\n> Gen 5 and Stratix10 is identical for the reset manager.\r\n\r\nNot really, they have same functions name but sequences are difference\r\ndue to diff interconnect technology. Hence, try to avoid too much #if\r\n#else\r\n\r\nChin Liang\r\n\r\n> \r\n> Dinh","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3X8S436zz9t2Q\n\tfor ;\n\tFri, 29 Sep 2017 23:14:32 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 385EAC21DAB; Fri, 29 Sep 2017 13:04:05 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 12078C21EC8;\n\tFri, 29 Sep 2017 12:54:24 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DC4C7C21EFE; Fri, 29 Sep 2017 12:53:37 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby lists.denx.de (Postfix) with ESMTPS id 408D9C21E64\n\tfor ; Fri, 29 Sep 2017 12:53:31 +0000 (UTC)","from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga105.fm.intel.com with ESMTP; 29 Sep 2017 05:53:29 -0700","from kmsmsx151.gar.corp.intel.com ([172.21.73.86])\n\tby orsmga004.jf.intel.com with ESMTP; 29 Sep 2017 05:53:28 -0700","from pgsmsx109.gar.corp.intel.com ([169.254.14.159]) by\n\tKMSMSX151.gar.corp.intel.com ([169.254.10.180]) with mapi id\n\t14.03.0319.002; Fri, 29 Sep 2017 20:53:27 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,452,1500966000\"; d=\"scan'208\";a=\"133550889\"","From":"\"See, Chin Liang\" ","To":"\"dinh.linux@gmail.com\" ","Thread-Topic":"[U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","Thread-Index":"AQHTMSkWJ6Pg8dRfdU2Hsal4vQHFDKLHP2gAgAWumoA=","Date":"Fri, 29 Sep 2017 12:53:27 +0000","Message-ID":"<1506776055.2766.3.camel@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-5-git-send-email-chin.liang.see@intel.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[172.30.190.99]","Content-ID":"","MIME-Version":"1.0","Cc":"\"marex@denx.de\" ,\n\t\"u-boot@lists.denx.de\" , \"Chee,\n\tTien Fong\" ","Subject":"Re: [U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1778352,"web_url":"http://patchwork.ozlabs.org/comment/1778352/","msgid":"","list_archive_url":null,"date":"2017-10-02T14:10:31","subject":"Re: [U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","submitter":{"id":16347,"url":"http://patchwork.ozlabs.org/api/people/16347/","name":"Dinh Nguyen","email":"dinh.linux@gmail.com"},"content":"On Fri, Sep 29, 2017 at 7:53 AM, See, Chin Liang\n wrote:\n> On Tue, 2017-09-26 at 17:08 -0500, Dinh Nguyen wrote:\n>> On Tue, Sep 19, 2017 at 4:22 AM, wrote:\n>> >\n>> > From: Chin Liang See \n>> >\n>> > Add Reset Manager driver support for Stratix SoC\n>> >\n>> > Signed-off-by: Chin Liang See \n>> > ---\n>> > arch/arm/mach-socfpga/Makefile | 1 +\n>> > arch/arm/mach-socfpga/include/mach/reset_manager.h | 2 +\n>> > .../mach-socfpga/include/mach/reset_manager_s10.h | 116\n>> > +++++++++++++++++\n>> > arch/arm/mach-socfpga/reset_manager.c | 5 +\n>> > arch/arm/mach-socfpga/reset_manager_s10.c | 140\n>> > +++++++++++++++++++++\n>> I don't see why you need to add a new file for S10? The functionality\n>> between\n>> Gen 5 and Stratix10 is identical for the reset manager.\n>\n> Not really, they have same functions name but sequences are difference\n> due to diff interconnect technology. Hence, try to avoid too much #if\n> #else\n>\n\nHow so? I'm able to re-use the same driver for Linux on the Stratix10.\n\nDinh","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IFncJs8Y\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5PFy0xvLz9t6k\n\tfor ;\n\tTue, 3 Oct 2017 01:10:46 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 2E67FC21F17; Mon, 2 Oct 2017 14:10:39 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 43C38C21CB3;\n\tMon, 2 Oct 2017 14:10:36 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5F7C5C21CB3; Mon, 2 Oct 2017 14:10:35 +0000 (UTC)","from mail-io0-f196.google.com (mail-io0-f196.google.com\n\t[209.85.223.196])\n\tby lists.denx.de (Postfix) with ESMTPS id 01529C21C29\n\tfor ; Mon, 2 Oct 2017 14:10:34 +0000 (UTC)","by mail-io0-f196.google.com with SMTP id e9so3164390iod.5\n\tfor ; Mon, 02 Oct 2017 07:10:33 -0700 (PDT)","by 10.79.30.194 with HTTP; Mon, 2 Oct 2017 07:10:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4XC54Eu0nVWwckKeMkS0rpsPtQpORB5k1vkTxsJ3fHs=;\n\tb=IFncJs8YMr2JO4f+9Yia7+j3UwkwbyT2So8XgNP+MTzBi0upGBkPW5WRSV8DX83/o8\n\t5GOyoeLcqvg/oweaslCPP4e7MgCoddnwrUg61bqu4g58LVz9sYCW36ZrbaEnXiW4yn88\n\tJlxp0lMPPXHOgvhb9pbGxGFLXXxXaBMY1zMcFX+D/Aaiw7sRVN3tfWEHFIU+lziZmf17\n\tKVCeJ92Lp/imwdUG8P11XJCipBKp63Zj/rbFonQ+AN4A+2hF45ozeHzkdYPRMeSEVPIz\n\t+6ic3ZE/dHFpJrDy1ghLKMpCgJ5TE8OhUxfodtPPmytofoxXXiTfJavbIh2IClAQzX5E\n\tKuqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4XC54Eu0nVWwckKeMkS0rpsPtQpORB5k1vkTxsJ3fHs=;\n\tb=iF7NvNVBGEpFVs4eMnQ57uXlJEw4oLtcwml05/j2EPQ7lcxuA9/eecGQE9O8RXVOde\n\tXbUkXp1gRsps3sLAYo/by3ipOufHUBCXG+w6cLkCRduLrDpLORaFW2QxNlLUl7Bb4bic\n\t/ZXPpArYajLYOo0N8RU/cOTuzPdsMkbPKCFsn9kGgc0Kj4hbLRGjNrjW6gBZFeFn1w8Z\n\tm1uHSoihgAROPZ2nIjw0r7qnN1dsQ6aT20vJcBNrUXbiEbPr/uijC9bIcDbe38myRFWo\n\tuUMqb3DVu8ysFzn6saoJOb+TOYoJvshrsuO2mrHQWwMPIxs9zsjBykraV/REcgWKCIZm\n\tj7sA==","X-Gm-Message-State":"AMCzsaWQ5nwfde6fx2+73imbbHmbPUFAxisnRaXWHKrQSRbPv9vL4nuu\n\tqhYYz6nALHH4oDULVZON49bNUu9sWpF8FxeyysU=","X-Google-Smtp-Source":"AOwi7QCujaGMwVigJK/eAv8pT60AN1d1tbAziX2UJhEzyD3btNNZ4z6xj4DIgwZw+Xt6MGQqQkwSgMEUTqN9s+aj5ig=","X-Received":"by 10.107.134.69 with SMTP id i66mr11577187iod.237.1506953432475;\n\tMon, 02 Oct 2017 07:10:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506776055.2766.3.camel@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-5-git-send-email-chin.liang.see@intel.com>\n\t\n\t<1506776055.2766.3.camel@intel.com>","From":"Dinh Nguyen ","Date":"Mon, 2 Oct 2017 09:10:31 -0500","Message-ID":"","To":"\"See, Chin Liang\" ","Cc":"\"marex@denx.de\" ,\n\t\"u-boot@lists.denx.de\" , \"Chee,\n\tTien Fong\" ","Subject":"Re: [U-Boot] [PATCH 04/14] arm: socfpga: stratix10: Add Reset\n\tManager driver for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]