[{"id":1775873,"web_url":"http://patchwork.ozlabs.org/comment/1775873/","msgid":"<CADhT+wcXd7YrZqVQtLGwNjdCO-oXgY+qYeFe2V3V4qgVHWsKaA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T21:34:29","subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","submitter":{"id":16347,"url":"http://patchwork.ozlabs.org/api/people/16347/","name":"Dinh Nguyen","email":"dinh.linux@gmail.com"},"content":"On Tue, Sep 19, 2017 at 4:22 AM,  <chin.liang.see@intel.com> wrote:\n> From: Chin Liang See <chin.liang.see@intel.com>\n>\n> Device tree for Stratix10 SoC\n>\n> Signed-off-by: Chin Liang See <chin.liang.see@intel.com>\n> ---\n>  arch/arm/dts/Makefile                    |   3 +-\n>  arch/arm/dts/socfpga_stratix10_socdk.dts | 141 +++++++++++++++++++++++++++++++\n>  2 files changed, 143 insertions(+), 1 deletion(-)\n>  create mode 100644 arch/arm/dts/socfpga_stratix10_socdk.dts\n>\n> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile\n> index fee4680..4cf5fd0 100644\n> --- a/arch/arm/dts/Makefile\n> +++ b/arch/arm/dts/Makefile\n> @@ -171,7 +171,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA) +=                               \\\n>         socfpga_cyclone5_sockit.dtb                     \\\n>         socfpga_cyclone5_socrates.dtb                   \\\n>         socfpga_cyclone5_sr1500.dtb                     \\\n> -       socfpga_cyclone5_vining_fpga.dtb\n> +       socfpga_cyclone5_vining_fpga.dtb                \\\n> +       socfpga_stratix10_socdk.dtb\n>\n>  dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb  \\\n>         dra72-evm-revc.dtb dra71-evm.dtb dra76-evm.dtb\n> diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts b/arch/arm/dts/socfpga_stratix10_socdk.dts\n> new file mode 100644\n> index 0000000..484c630\n> --- /dev/null\n> +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts\n> @@ -0,0 +1,141 @@\n> +/*\n> + * Copyright (C) 2016-2017 Intel Corporation <www.intel.com>\n> + *\n> + * SPDX-License-Identifier:    GPL-2.0\n> + */\n> +\n> +/dts-v1/;\n> +#include \"skeleton.dtsi\"\n> +#include <dt-bindings/reset/altr,rst-mgr-s10.h>\n\nYou don't add the patch for this include file until patch 4/14, which means\nthe build will fail until patch 4 is applied. You need to move this patch\nafter 4/14.\n\n> +\n> +/ {\n> +       model = \"Intel SOCFPGA Stratix 10 SoC Development Kit\";\n> +       compatible = \"altr,socfpga-stratix10\", \"altr,socfpga\";\n> +\n> +       #address-cells = <1>;\n> +       #size-cells = <1>;\n> +\n> +       chosen {\n> +               bootargs = \"console=ttyS0,115200\";\n> +       };\n> +\n> +       aliases {\n> +               ethernet0 = &gmac0;\n> +               spi0 = &qspi;\n> +       };\n> +\n> +       memory {\n> +               name = \"memory\";\n> +               device_type = \"memory\";\n> +               reg = <0x0 0x80000000>; /* 2GB */\n> +       };\n> +\n> +       regulator_3_3v: 3-3-v-regulator {\n> +               compatible = \"regulator-fixed\";\n> +               regulator-name = \"3.3V\";\n> +               regulator-min-microvolt = <3300000>;\n> +               regulator-max-microvolt = <3300000>;\n> +       };\n> +\n> +       soc {\n> +               #address-cells = <1>;\n> +               #size-cells = <1>;\n> +               compatible = \"simple-bus\";\n> +               device_type = \"soc\";\n> +               ranges;\n> +               u-boot,dm-pre-reloc;\n> +\n> +               rst: rstmgr@ffd11000 {\n> +                       #reset-cells = <1>;\n> +                       compatible = \"altr,rst-mgr\";\n> +                       reg = <0xffd11000 0x100>;\n> +                       altr,modrst-offset = <0x20>;\n> +               };\n> +\n> +               gmac0: ethernet@ff800000 {\n> +                       compatible = \"altr,socfpga-stmmac\", \"snps,dwmac-3.74a\", \"snps,dwmac\";\n> +                       reg = <0xff800000 0x2000>;\n> +                       interrupts = <0 90 4>;\n> +                       interrupt-names = \"macirq\";\n> +                       mac-address = [00 00 00 00 00 00];\n> +                       resets = <&rst EMAC0_RESET>;\n> +                       reset-names = \"stmmaceth\";\n> +                       phy-mode = \"rgmii\";\n> +                       phy-addr = <0xffffffff>; /* probe for phy addr */\n> +                       max-speed = <1000>;\n> +                       txd0-skew-ps = <0>; /* -420ps */\n> +                       txd1-skew-ps = <0>; /* -420ps */\n> +                       txd2-skew-ps = <0>; /* -420ps */\n> +                       txd3-skew-ps = <0>; /* -420ps */\n> +                       rxd0-skew-ps = <420>; /* 0ps */\n> +                       rxd1-skew-ps = <420>; /* 0ps */\n> +                       rxd2-skew-ps = <420>; /* 0ps */\n> +                       rxd3-skew-ps = <420>; /* 0ps */\n> +                       txen-skew-ps = <0>; /* -420ps */\n> +                       txc-skew-ps = <1860>; /* 960ps */\n> +                       rxdv-skew-ps = <420>; /* 0ps */\n> +                       rxc-skew-ps = <1680>; /* 780ps */\n\nThese are PHY properties, which should be in a separate PHY node.\n\nDinh","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lurZ9LrP\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1vP23YX3z9sCZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 07:34:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D8E92C21D78; Tue, 26 Sep 2017 21:34:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 708A8C21C29;\n\tTue, 26 Sep 2017 21:34:33 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 60F3AC21C29; Tue, 26 Sep 2017 21:34:32 +0000 (UTC)","from mail-it0-f67.google.com (mail-it0-f67.google.com\n\t[209.85.214.67])\n\tby lists.denx.de (Postfix) with ESMTPS id C408FC21C26\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 21:34:31 +0000 (UTC)","by mail-it0-f67.google.com with SMTP id o200so5237742itg.1\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 14:34:31 -0700 (PDT)","by 10.79.30.194 with HTTP; Tue, 26 Sep 2017 14:34:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=cWVtipwApKUABSz04ybmrPu24BNVC3pQbR/78YLBvd0=;\n\tb=lurZ9LrP54e6rZLcM0hGOsPIsPSUa/2rNppn4Kyrw7aI1n5odnjCbuQkWs2V5ODjZA\n\tqjmBVxMHe3FNGYalHhfy+cyJ62CKSKuIHMCP02Z9X0j+kmFar8fUf9cNVv7Xh3NiTlyI\n\tnv2hz1kbJPryyT1M1jkUdFhltnPWtROHvmgry4NV8QlD+VDqXGW5wT6f52hqMLZm6AB/\n\tJjj0X0E5r+pPsfm0cec70hyQg+MZv89yuYij2254BIBA17yQb7/KbG/INDOYLaI+i4F+\n\tq3OXH6tprVVATgz2HgPuokUm81qEeE1pbB7dsuDAAsW//7hMOTbBkFQZjxYn9DY1F4z5\n\tQLWw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=cWVtipwApKUABSz04ybmrPu24BNVC3pQbR/78YLBvd0=;\n\tb=Pa0nybcNOccIcrkYdowkKjDy7W+JPJpmoqvs1cjYl9ViXANXi1kVzSrZzULBmDnHb9\n\tKfvC01C2HXYWgCJZhV9l+s0GIP+V8tVEDFkRb6aqATEgUGjnpIbyBnYejKD/IQ+v6Qf2\n\tJlorsesMDA6FfTjUZlW3oncBGhXtTHIz31wAONPJ3YEcH7oGItsPGV2XfFYhVICog6SF\n\t/nkkgvPn9DcsOt9tWkEtojjgRbKn+RnzSQr2rCuhX/3IzBbNFDCm8vGOSErScJNWoDTp\n\tXO+ldhn4IMW+L+2cap186bfgIJsUDL/w2yULO920/KTIQ15eU2+eBm6iyOA5VjoEErv1\n\tSeAw==","X-Gm-Message-State":"AHPjjUiJfHtyM32Bnx9R6qt9wV8RB+aZ2Pxo6gY7+Ur4Fqs6OHJZo3c5\n\t9vlH9uwbuGLLdHCeRuBryq/sCazDwtgtv5izWCU=","X-Google-Smtp-Source":"AOwi7QDVO3aEZSv8ZUw92GEnqIo6J60CXtzfAFEhcpruEhHZZdLGhCOf4w/KSU/xKyElrGHKe56cbHrgmy3Dzd0a/Fo=","X-Received":"by 10.36.110.3 with SMTP id w3mr8485165itc.113.1506461670288;\n\tTue, 26 Sep 2017 14:34:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505812951-25088-3-git-send-email-chin.liang.see@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-3-git-send-email-chin.liang.see@intel.com>","From":"Dinh Nguyen <dinh.linux@gmail.com>","Date":"Tue, 26 Sep 2017 16:34:29 -0500","Message-ID":"<CADhT+wcXd7YrZqVQtLGwNjdCO-oXgY+qYeFe2V3V4qgVHWsKaA@mail.gmail.com>","To":"Chin Liang See <chin.liang.see@intel.com>","Cc":"Marek Vasut <marex@denx.de>, ZY - u-boot <u-boot@lists.denx.de>,\n\tTien Fong Chee <tien.fong.chee@intel.com>","Subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1775878,"web_url":"http://patchwork.ozlabs.org/comment/1775878/","msgid":"<CADhT+we3+TgxnJRkOkAtwbY8T7e9epxjcgFj+Rh05nFciccQ7w@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T21:37:47","subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","submitter":{"id":16347,"url":"http://patchwork.ozlabs.org/api/people/16347/","name":"Dinh Nguyen","email":"dinh.linux@gmail.com"},"content":"On Tue, Sep 19, 2017 at 4:22 AM,  <chin.liang.see@intel.com> wrote:\n> From: Chin Liang See <chin.liang.see@intel.com>\n>\n> Device tree for Stratix10 SoC\n>\n> Signed-off-by: Chin Liang See <chin.liang.see@intel.com>\n> ---\n>  arch/arm/dts/Makefile                    |   3 +-\n>  arch/arm/dts/socfpga_stratix10_socdk.dts | 141 +++++++++++++++++++++++++++++++\n>  2 files changed, 143 insertions(+), 1 deletion(-)\n>  create mode 100644 arch/arm/dts/socfpga_stratix10_socdk.dts\n>\n> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile\n> index fee4680..4cf5fd0 100644\n> --- a/arch/arm/dts/Makefile\n> +++ b/arch/arm/dts/Makefile\n> @@ -171,7 +171,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA) +=                               \\\n>         socfpga_cyclone5_sockit.dtb                     \\\n>         socfpga_cyclone5_socrates.dtb                   \\\n>         socfpga_cyclone5_sr1500.dtb                     \\\n> -       socfpga_cyclone5_vining_fpga.dtb\n> +       socfpga_cyclone5_vining_fpga.dtb                \\\n> +       socfpga_stratix10_socdk.dtb\n>\n>  dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb  \\\n>         dra72-evm-revc.dtb dra71-evm.dtb dra76-evm.dtb\n> diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts b/arch/arm/dts/socfpga_stratix10_socdk.dts\n> new file mode 100644\n> index 0000000..484c630\n> --- /dev/null\n> +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts\n> @@ -0,0 +1,141 @@\n> +/*\n> + * Copyright (C) 2016-2017 Intel Corporation <www.intel.com>\n> + *\n> + * SPDX-License-Identifier:    GPL-2.0\n> + */\n> +\n> +/dts-v1/;\n> +#include \"skeleton.dtsi\"\n> +#include <dt-bindings/reset/altr,rst-mgr-s10.h>\n> +\n> +/ {\n> +       model = \"Intel SOCFPGA Stratix 10 SoC Development Kit\";\n> +       compatible = \"altr,socfpga-stratix10\", \"altr,socfpga\";\n> +\n> +       #address-cells = <1>;\n> +       #size-cells = <1>;\n> +\n> +       chosen {\n> +               bootargs = \"console=ttyS0,115200\";\n> +       };\n> +\n> +       aliases {\n> +               ethernet0 = &gmac0;\n> +               spi0 = &qspi;\n> +       };\n> +\n> +       memory {\n> +               name = \"memory\";\n> +               device_type = \"memory\";\n> +               reg = <0x0 0x80000000>; /* 2GB */\n> +       };\n> +\n> +       regulator_3_3v: 3-3-v-regulator {\n> +               compatible = \"regulator-fixed\";\n> +               regulator-name = \"3.3V\";\n> +               regulator-min-microvolt = <3300000>;\n> +               regulator-max-microvolt = <3300000>;\n> +       };\n> +\n> +       soc {\n> +               #address-cells = <1>;\n> +               #size-cells = <1>;\n> +               compatible = \"simple-bus\";\n> +               device_type = \"soc\";\n> +               ranges;\n> +               u-boot,dm-pre-reloc;\n> +\n> +               rst: rstmgr@ffd11000 {\n> +                       #reset-cells = <1>;\n> +                       compatible = \"altr,rst-mgr\";\n> +                       reg = <0xffd11000 0x100>;\n> +                       altr,modrst-offset = <0x20>;\n> +               };\n\nWhere are the cpu nodes?\n\nDinh","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KLJaGAQS\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1vSj5yzJz9t3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 07:37:57 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 86522C21C35; Tue, 26 Sep 2017 21:37:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D6AF2C21C50;\n\tTue, 26 Sep 2017 21:37:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 69D3CC21C50; Tue, 26 Sep 2017 21:37:51 +0000 (UTC)","from mail-io0-f196.google.com (mail-io0-f196.google.com\n\t[209.85.223.196])\n\tby lists.denx.de (Postfix) with ESMTPS id A5A8BC21C46\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 21:37:49 +0000 (UTC)","by mail-io0-f196.google.com with SMTP id 93so5250535iol.4\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 14:37:49 -0700 (PDT)","by 10.79.30.194 with HTTP; Tue, 26 Sep 2017 14:37:47 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Wzc4GJiAgqZyGUNmi2HOAQDCbn+3FXiU1pH1MpPw+hU=;\n\tb=KLJaGAQSUg/udR++3skNS9gk+abc1WddIaUmWAiA8WIGerxIKLoXQqaNWXIjV0g1VR\n\tb/mvLe/yKeJhz4Y/CEHndmlRd6vFCM9eCGxHadjMISMHvu8Eprlb0m6KLc5AaMXROp2D\n\tiKZd6AHWQ+zQw+IBiwt+87QJhZhQv0owuA/vRVZeIBgwE9tQ67VA9a14N1CPVLHZdPn0\n\tJdujJKBPXgf7aG4ePrQxfQK/njl06/rath5tJ/9Dh3JIrtCWjxn/NuREex72OvfHqpOR\n\tw35MfYrmPDqncaZ40+sSfTshe2tJHIF/RTxFOS8qxPaZLr4DBHm7e+IrNp7cMrFWjgFU\n\tnlag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Wzc4GJiAgqZyGUNmi2HOAQDCbn+3FXiU1pH1MpPw+hU=;\n\tb=E8AMzzcTcqFB2fUP5q7SPMQ3MiYJsE2YUttyDiHtaxyjmJV+WOaKObWsWot7rGwlMV\n\t92ko7WmxPgdP6ljv94aCcKsuGWC+EEDwnEvZ+2WoRKbCke9HA4Dz6gn9VzHPpU4JvDvC\n\tbkOj0YCPk708uBlspRlU0dOck2IrCR+euoP6DG6W6/wJPm8jOxe67svNadQj5SzP9t93\n\t0qVrBKOonTvWWI067k4pGvch5NwwQbHoaPfyHGGvw7SC+ILY5UYJqlBiylWA5Wq4O47K\n\tgz8vIfpHHalfjcDNRSDObygdiiE2AkWXoPbx0AxuTstwvPZgu89d9nKQfOiwwYFFBL+B\n\t20cw==","X-Gm-Message-State":"AHPjjUinHSpILWmDig4v6wPyCDxOBNZGp32cvkJlb3kKxJUeVjKW0j+a\n\txcNuGKxRQwoI1hVA4P1ZKYfFW2pxTnvOxSwVYSk=","X-Google-Smtp-Source":"AOwi7QDb7st1UzYd72ANNCwori4wxv6LSH/wiSkDHQlFsC6L8Mxmc/tiD8EDap4fTDj1Kx4tHciLCp8BE2wfkBu3i1U=","X-Received":"by 10.107.40.19 with SMTP id o19mr16374844ioo.120.1506461868410; \n\tTue, 26 Sep 2017 14:37:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505812951-25088-3-git-send-email-chin.liang.see@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-3-git-send-email-chin.liang.see@intel.com>","From":"Dinh Nguyen <dinh.linux@gmail.com>","Date":"Tue, 26 Sep 2017 16:37:47 -0500","Message-ID":"<CADhT+we3+TgxnJRkOkAtwbY8T7e9epxjcgFj+Rh05nFciccQ7w@mail.gmail.com>","To":"Chin Liang See <chin.liang.see@intel.com>","Cc":"Marek Vasut <marex@denx.de>, ZY - u-boot <u-boot@lists.denx.de>,\n\tTien Fong Chee <tien.fong.chee@intel.com>","Subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1777541,"web_url":"http://patchwork.ozlabs.org/comment/1777541/","msgid":"<1506776839.2766.8.camel@intel.com>","list_archive_url":null,"date":"2017-09-29T13:06:32","subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","submitter":{"id":70182,"url":"http://patchwork.ozlabs.org/api/people/70182/","name":"See, Chin Liang","email":"chin.liang.see@intel.com"},"content":"On Tue, 2017-09-26 at 16:34 -0500, Dinh Nguyen wrote:\r\n> On Tue, Sep 19, 2017 at 4:22 AM,  <chin.liang.see@intel.com> wrote:\r\n> > \r\n> > From: Chin Liang See <chin.liang.see@intel.com>\r\n> > \r\n> > Device tree for Stratix10 SoC\r\n> > \r\n> > Signed-off-by: Chin Liang See <chin.liang.see@intel.com>\r\n> > ---\r\n> >  arch/arm/dts/Makefile                    |   3 +-\r\n> >  arch/arm/dts/socfpga_stratix10_socdk.dts | 141\r\n> > +++++++++++++++++++++++++++++++\r\n> >  2 files changed, 143 insertions(+), 1 deletion(-)\r\n> >  create mode 100644 arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > \r\n> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile\r\n> > index fee4680..4cf5fd0 100644\r\n> > --- a/arch/arm/dts/Makefile\r\n> > +++ b/arch/arm/dts/Makefile\r\n> > @@ -171,7 +171,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA)\r\n> > +=                               \\\r\n> >         socfpga_cyclone5_sockit.dtb                     \\\r\n> >         socfpga_cyclone5_socrates.dtb                   \\\r\n> >         socfpga_cyclone5_sr1500.dtb                     \\\r\n> > -       socfpga_cyclone5_vining_fpga.dtb\r\n> > +       socfpga_cyclone5_vining_fpga.dtb                \\\r\n> > +       socfpga_stratix10_socdk.dtb\r\n> > \r\n> >  dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb  \\\r\n> >         dra72-evm-revc.dtb dra71-evm.dtb dra76-evm.dtb\r\n> > diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > b/arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > new file mode 100644\r\n> > index 0000000..484c630\r\n> > --- /dev/null\r\n> > +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > @@ -0,0 +1,141 @@\r\n> > +/*\r\n> > + * Copyright (C) 2016-2017 Intel Corporation <www.intel.com>\r\n> > + *\r\n> > + * SPDX-License-Identifier:    GPL-2.0\r\n> > + */\r\n> > +\r\n> > +/dts-v1/;\r\n> > +#include \"skeleton.dtsi\"\r\n> > +#include <dt-bindings/reset/altr,rst-mgr-s10.h>\r\n> You don't add the patch for this include file until patch 4/14, which\r\n> means\r\n> the build will fail until patch 4 is applied. You need to move this\r\n> patch\r\n> after 4/14.\r\n\r\nYes, good catch. Let shuffle this\r\n\r\n> \r\n> > \r\n> > +\r\n> > +/ {\r\n> > +       model = \"Intel SOCFPGA Stratix 10 SoC Development Kit\";\r\n> > +       compatible = \"altr,socfpga-stratix10\", \"altr,socfpga\";\r\n> > +\r\n> > +       #address-cells = <1>;\r\n> > +       #size-cells = <1>;\r\n> > +\r\n> > +       chosen {\r\n> > +               bootargs = \"console=ttyS0,115200\";\r\n> > +       };\r\n> > +\r\n> > +       aliases {\r\n> > +               ethernet0 = &gmac0;\r\n> > +               spi0 = &qspi;\r\n> > +       };\r\n> > +\r\n> > +       memory {\r\n> > +               name = \"memory\";\r\n> > +               device_type = \"memory\";\r\n> > +               reg = <0x0 0x80000000>; /* 2GB */\r\n> > +       };\r\n> > +\r\n> > +       regulator_3_3v: 3-3-v-regulator {\r\n> > +               compatible = \"regulator-fixed\";\r\n> > +               regulator-name = \"3.3V\";\r\n> > +               regulator-min-microvolt = <3300000>;\r\n> > +               regulator-max-microvolt = <3300000>;\r\n> > +       };\r\n> > +\r\n> > +       soc {\r\n> > +               #address-cells = <1>;\r\n> > +               #size-cells = <1>;\r\n> > +               compatible = \"simple-bus\";\r\n> > +               device_type = \"soc\";\r\n> > +               ranges;\r\n> > +               u-boot,dm-pre-reloc;\r\n> > +\r\n> > +               rst: rstmgr@ffd11000 {\r\n> > +                       #reset-cells = <1>;\r\n> > +                       compatible = \"altr,rst-mgr\";\r\n> > +                       reg = <0xffd11000 0x100>;\r\n> > +                       altr,modrst-offset = <0x20>;\r\n> > +               };\r\n> > +\r\n> > +               gmac0: ethernet@ff800000 {\r\n> > +                       compatible = \"altr,socfpga-stmmac\",\r\n> > \"snps,dwmac-3.74a\", \"snps,dwmac\";\r\n> > +                       reg = <0xff800000 0x2000>;\r\n> > +                       interrupts = <0 90 4>;\r\n> > +                       interrupt-names = \"macirq\";\r\n> > +                       mac-address = [00 00 00 00 00 00];\r\n> > +                       resets = <&rst EMAC0_RESET>;\r\n> > +                       reset-names = \"stmmaceth\";\r\n> > +                       phy-mode = \"rgmii\";\r\n> > +                       phy-addr = <0xffffffff>; /* probe for phy\r\n> > addr */\r\n> > +                       max-speed = <1000>;\r\n> > +                       txd0-skew-ps = <0>; /* -420ps */\r\n> > +                       txd1-skew-ps = <0>; /* -420ps */\r\n> > +                       txd2-skew-ps = <0>; /* -420ps */\r\n> > +                       txd3-skew-ps = <0>; /* -420ps */\r\n> > +                       rxd0-skew-ps = <420>; /* 0ps */\r\n> > +                       rxd1-skew-ps = <420>; /* 0ps */\r\n> > +                       rxd2-skew-ps = <420>; /* 0ps */\r\n> > +                       rxd3-skew-ps = <420>; /* 0ps */\r\n> > +                       txen-skew-ps = <0>; /* -420ps */\r\n> > +                       txc-skew-ps = <1860>; /* 960ps */\r\n> > +                       rxdv-skew-ps = <420>; /* 0ps */\r\n> > +                       rxc-skew-ps = <1680>; /* 780ps */\r\n> These are PHY properties, which should be in a separate PHY node.\r\n\r\nLet me check on the PHY driver\r\n\r\nChin Liang\r\n\r\n> \r\n> Dinh","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3XPP6WSVz9t3s\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 29 Sep 2017 23:25:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A28FBC21E09; Fri, 29 Sep 2017 13:22:09 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5DE01C21E3C;\n\tFri, 29 Sep 2017 13:16:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D4D68C21E4D; Fri, 29 Sep 2017 13:06:54 +0000 (UTC)","from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby lists.denx.de (Postfix) with ESMTPS id 3B018C21E3A\n\tfor <u-boot@lists.denx.de>; Fri, 29 Sep 2017 13:06:38 +0000 (UTC)","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Sep 2017 06:06:36 -0700","from pgsmsx104.gar.corp.intel.com ([10.221.44.91])\n\tby orsmga003.jf.intel.com with ESMTP; 29 Sep 2017 06:06:35 -0700","from pgsmsx109.gar.corp.intel.com ([169.254.14.159]) by\n\tPGSMSX104.gar.corp.intel.com ([169.254.3.223]) with mapi id\n\t14.03.0319.002; Fri, 29 Sep 2017 21:06:33 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,452,1500966000\"; d=\"scan'208\";\n\ta=\"1019822081\"","From":"\"See, Chin Liang\" <chin.liang.see@intel.com>","To":"\"dinh.linux@gmail.com\" <dinh.linux@gmail.com>","Thread-Topic":"[U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","Thread-Index":"AQHTMSkSN4lSrYT9+0iAi8WHkua09aLHNgmAgAW7n4A=","Date":"Fri, 29 Sep 2017 13:06:32 +0000","Message-ID":"<1506776839.2766.8.camel@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-3-git-send-email-chin.liang.see@intel.com>\n\t<CADhT+wcXd7YrZqVQtLGwNjdCO-oXgY+qYeFe2V3V4qgVHWsKaA@mail.gmail.com>","In-Reply-To":"<CADhT+wcXd7YrZqVQtLGwNjdCO-oXgY+qYeFe2V3V4qgVHWsKaA@mail.gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[172.30.190.99]","Content-ID":"<96E15F3F05520F49B8DD039BE4A7BFD4@intel.com>","MIME-Version":"1.0","Cc":"\"marex@denx.de\" <marex@denx.de>,\n\t\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>, \"Chee,\n\tTien Fong\" <tien.fong.chee@intel.com>","Subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1777555,"web_url":"http://patchwork.ozlabs.org/comment/1777555/","msgid":"<1506776869.2766.9.camel@intel.com>","list_archive_url":null,"date":"2017-09-29T13:07:00","subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","submitter":{"id":70182,"url":"http://patchwork.ozlabs.org/api/people/70182/","name":"See, Chin Liang","email":"chin.liang.see@intel.com"},"content":"On Tue, 2017-09-26 at 16:37 -0500, Dinh Nguyen wrote:\r\n> On Tue, Sep 19, 2017 at 4:22 AM,  <chin.liang.see@intel.com> wrote:\r\n> > \r\n> > From: Chin Liang See <chin.liang.see@intel.com>\r\n> > \r\n> > Device tree for Stratix10 SoC\r\n> > \r\n> > Signed-off-by: Chin Liang See <chin.liang.see@intel.com>\r\n> > ---\r\n> >  arch/arm/dts/Makefile                    |   3 +-\r\n> >  arch/arm/dts/socfpga_stratix10_socdk.dts | 141\r\n> > +++++++++++++++++++++++++++++++\r\n> >  2 files changed, 143 insertions(+), 1 deletion(-)\r\n> >  create mode 100644 arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > \r\n> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile\r\n> > index fee4680..4cf5fd0 100644\r\n> > --- a/arch/arm/dts/Makefile\r\n> > +++ b/arch/arm/dts/Makefile\r\n> > @@ -171,7 +171,8 @@ dtb-$(CONFIG_ARCH_SOCFPGA)\r\n> > +=                               \\\r\n> >         socfpga_cyclone5_sockit.dtb                     \\\r\n> >         socfpga_cyclone5_socrates.dtb                   \\\r\n> >         socfpga_cyclone5_sr1500.dtb                     \\\r\n> > -       socfpga_cyclone5_vining_fpga.dtb\r\n> > +       socfpga_cyclone5_vining_fpga.dtb                \\\r\n> > +       socfpga_stratix10_socdk.dtb\r\n> > \r\n> >  dtb-$(CONFIG_TARGET_DRA7XX_EVM) += dra72-evm.dtb dra7-evm.dtb  \\\r\n> >         dra72-evm-revc.dtb dra71-evm.dtb dra76-evm.dtb\r\n> > diff --git a/arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > b/arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > new file mode 100644\r\n> > index 0000000..484c630\r\n> > --- /dev/null\r\n> > +++ b/arch/arm/dts/socfpga_stratix10_socdk.dts\r\n> > @@ -0,0 +1,141 @@\r\n> > +/*\r\n> > + * Copyright (C) 2016-2017 Intel Corporation <www.intel.com>\r\n> > + *\r\n> > + * SPDX-License-Identifier:    GPL-2.0\r\n> > + */\r\n> > +\r\n> > +/dts-v1/;\r\n> > +#include \"skeleton.dtsi\"\r\n> > +#include <dt-bindings/reset/altr,rst-mgr-s10.h>\r\n> > +\r\n> > +/ {\r\n> > +       model = \"Intel SOCFPGA Stratix 10 SoC Development Kit\";\r\n> > +       compatible = \"altr,socfpga-stratix10\", \"altr,socfpga\";\r\n> > +\r\n> > +       #address-cells = <1>;\r\n> > +       #size-cells = <1>;\r\n> > +\r\n> > +       chosen {\r\n> > +               bootargs = \"console=ttyS0,115200\";\r\n> > +       };\r\n> > +\r\n> > +       aliases {\r\n> > +               ethernet0 = &gmac0;\r\n> > +               spi0 = &qspi;\r\n> > +       };\r\n> > +\r\n> > +       memory {\r\n> > +               name = \"memory\";\r\n> > +               device_type = \"memory\";\r\n> > +               reg = <0x0 0x80000000>; /* 2GB */\r\n> > +       };\r\n> > +\r\n> > +       regulator_3_3v: 3-3-v-regulator {\r\n> > +               compatible = \"regulator-fixed\";\r\n> > +               regulator-name = \"3.3V\";\r\n> > +               regulator-min-microvolt = <3300000>;\r\n> > +               regulator-max-microvolt = <3300000>;\r\n> > +       };\r\n> > +\r\n> > +       soc {\r\n> > +               #address-cells = <1>;\r\n> > +               #size-cells = <1>;\r\n> > +               compatible = \"simple-bus\";\r\n> > +               device_type = \"soc\";\r\n> > +               ranges;\r\n> > +               u-boot,dm-pre-reloc;\r\n> > +\r\n> > +               rst: rstmgr@ffd11000 {\r\n> > +                       #reset-cells = <1>;\r\n> > +                       compatible = \"altr,rst-mgr\";\r\n> > +                       reg = <0xffd11000 0x100>;\r\n> > +                       altr,modrst-offset = <0x20>;\r\n> > +               };\r\n> Where are the cpu nodes?\r\n\r\nyes, need to be added\r\n\r\nCHin Liang\r\n> \r\n> Dinh","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3Xxk3kD6z9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 29 Sep 2017 23:50:18 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 43853C21E1D; Fri, 29 Sep 2017 13:44:05 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B2F45C21E55;\n\tFri, 29 Sep 2017 13:44:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6977FC21E14; Fri, 29 Sep 2017 13:07:14 +0000 (UTC)","from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby lists.denx.de (Postfix) with ESMTPS id 4D957C21EDE\n\tfor <u-boot@lists.denx.de>; Fri, 29 Sep 2017 13:07:04 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Sep 2017 06:07:02 -0700","from pgsmsx106.gar.corp.intel.com ([10.221.44.98])\n\tby fmsmga006.fm.intel.com with ESMTP; 29 Sep 2017 06:07:01 -0700","from pgsmsx109.gar.corp.intel.com ([169.254.14.159]) by\n\tPGSMSX106.gar.corp.intel.com ([169.254.9.199]) with mapi id\n\t14.03.0319.002; Fri, 29 Sep 2017 21:07:00 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,452,1500966000\"; d=\"scan'208\";a=\"157517460\"","From":"\"See, Chin Liang\" <chin.liang.see@intel.com>","To":"\"dinh.linux@gmail.com\" <dinh.linux@gmail.com>","Thread-Topic":"[U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","Thread-Index":"AQHTMSkSN4lSrYT9+0iAi8WHkua09aLHNvWAgAW614A=","Date":"Fri, 29 Sep 2017 13:07:00 +0000","Message-ID":"<1506776869.2766.9.camel@intel.com>","References":"<1505812951-25088-1-git-send-email-chin.liang.see@intel.com>\n\t<1505812951-25088-3-git-send-email-chin.liang.see@intel.com>\n\t<CADhT+we3+TgxnJRkOkAtwbY8T7e9epxjcgFj+Rh05nFciccQ7w@mail.gmail.com>","In-Reply-To":"<CADhT+we3+TgxnJRkOkAtwbY8T7e9epxjcgFj+Rh05nFciccQ7w@mail.gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[172.30.190.99]","Content-ID":"<B22630727D46EB4E939257F86FE2B765@intel.com>","MIME-Version":"1.0","Cc":"\"marex@denx.de\" <marex@denx.de>,\n\t\"u-boot@lists.denx.de\" <u-boot@lists.denx.de>, \"Chee,\n\tTien Fong\" <tien.fong.chee@intel.com>","Subject":"Re: [U-Boot] [PATCH 02/14] arm: dts: Add dts for Stratix10 SoC","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]