[{"id":1770639,"web_url":"http://patchwork.ozlabs.org/comment/1770639/","msgid":"<20170918.211952.1397675528248642600.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T04:19:52","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tom Herbert \nDate: Mon, 18 Sep 2017 17:38:58 -0700\n\n> Allow peers to be specified by IPv6 addresses.\n> \n> Signed-off-by: Tom Herbert \n\nHmmm, can you just check the socket family or something like that?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx8mC4Jl1z9ryr\n\tfor ;\n\tTue, 19 Sep 2017 14:19:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751205AbdISETx (ORCPT );\n\tTue, 19 Sep 2017 00:19:53 -0400","from shards.monkeyblade.net ([184.105.139.130]:38610 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750774AbdISETw (ORCPT\n\t); Tue, 19 Sep 2017 00:19:52 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 7CCAB102ABA29;\n\tMon, 18 Sep 2017 21:19:52 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 21:19:52 -0700 (PDT)","Message-Id":"<20170918.211952.1397675528248642600.davem@davemloft.net>","To":"tom@quantonium.net","Cc":"netdev@vger.kernel.org, pablo@netfilter.org, laforge@gnumonks.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","From":"David Miller ","In-Reply-To":"<20170919003904.5124-9-tom@quantonium.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-9-tom@quantonium.net>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 21:19:52 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770933,"web_url":"http://patchwork.ozlabs.org/comment/1770933/","msgid":"<20170919115954.xeycbdhvrfiwkbmq@nataraja>","list_archive_url":null,"date":"2017-09-19T11:59:54","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Tom,\n\nOn Mon, Sep 18, 2017 at 05:38:58PM -0700, Tom Herbert wrote:\n> Allow peers to be specified by IPv6 addresses.\n\n> +\tu16\t\t\tpeer_af;\n> +\tunion {\n> +\t\tstruct in_addr\tpeer_addr_ip4;\n> +\t\tstruct in6_addr\tpeer_addr_ip6;\n> +\t};\n\nthis will not really work, as an union means that a PDP context\nwill be either IPv4-only or IPV6-only, while in reality there\nare three types, see my other mail. So you have to deal\nwith v4-only, v6-only or v4v6.\n\nThe v6-only is legacy by now, and all modern phones I've tested in\nrecent years can do v4v6 rather than having a v4-only and a v6-only\nPDP context in parallel.\n\nFrom the operator point of view, v4v6 is very desirable, as it basically\nhalves the amount of PDP contexts compared to the old approach, which\nsignificantly reduces signalling load across your network, as well as\nthe amount of memory (and thus capacity) in your core network elements.\n\nI've recently implemented v6 + v4v6 support in osmo-ggsn (see\nhttp://git.osmocom.org/osmo-ggsn/) in case you would like to see another\nFOSS implementation for v6 + v4v6 - though in userspace, of course.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMGr691sz9s4q\n\tfor ;\n\tTue, 19 Sep 2017 22:13:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751697AbdISMNO (ORCPT );\n\tTue, 19 Sep 2017 08:13:14 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45337 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750973AbdISMNN (ORCPT\n\t); Tue, 19 Sep 2017 08:13:13 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1duHOm-0001IX-So; Tue, 19 Sep 2017 14:13:08 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duHBy-0007Yz-WB; Tue, 19 Sep 2017 19:59:55 +0800"],"Date":"Tue, 19 Sep 2017 19:59:54 +0800","From":"Harald Welte ","To":"Tom Herbert ","Cc":"davem@davemloft.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","Message-ID":"<20170919115954.xeycbdhvrfiwkbmq@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-9-tom@quantonium.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919003904.5124-9-tom@quantonium.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772128,"web_url":"http://patchwork.ozlabs.org/comment/1772128/","msgid":"","list_archive_url":null,"date":"2017-09-20T18:03:52","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":65986,"url":"http://patchwork.ozlabs.org/api/people/65986/","name":"Tom Herbert","email":"tom@herbertland.com"},"content":"On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote:\n> From: Tom Herbert \n> Date: Mon, 18 Sep 2017 17:38:58 -0700\n>\n>> Allow peers to be specified by IPv6 addresses.\n>>\n>> Signed-off-by: Tom Herbert \n>\n> Hmmm, can you just check the socket family or something like that?\n\nI'm not sure what code you're referring to.\n\nThanks","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=herbertland-com.20150623.gappssmtp.com\n\theader.i=@herbertland-com.20150623.gappssmtp.com\n\theader.b=\"FfXgUUhJ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy70Y32Hbz9s81\n\tfor ;\n\tThu, 21 Sep 2017 04:03:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751707AbdITSDz (ORCPT );\n\tWed, 20 Sep 2017 14:03:55 -0400","from mail-qk0-f175.google.com ([209.85.220.175]:53949 \"EHLO\n\tmail-qk0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751669AbdITSDy (ORCPT\n\t); Wed, 20 Sep 2017 14:03:54 -0400","by mail-qk0-f175.google.com with SMTP id t184so3513981qke.10\n\tfor ; Wed, 20 Sep 2017 11:03:54 -0700 (PDT)","by 10.237.61.196 with HTTP; Wed, 20 Sep 2017 11:03:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=herbertland-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=M9/Mwm/XEwltmvGlSz4BJv9jSJMAtODDJaKQvt17+3o=;\n\tb=FfXgUUhJXL83MxlJcGDU431PitQvRZ4cYgo7oaUrjT1NVQefPB/1yBPTxBNpr5s+33\n\tdzdz2/iN6MuAHyn0TmJ3u0Yj4xPkX8NuMBHoRJvNLTkasUn0cHVC5iW8AN0PUQ9CGMWD\n\tXdP+Ot8tq+HUiJW6WOQ/4XMlwPl0NFDH+Vxca3cvO85aQx6vR2SOS0eekyKqRoCkvkrZ\n\tswVXrpB920yql2ocnfbnOmGy3XopSVojazfoJA4qBcMkw5iv/BuI/WNZlRqJp3xpAyB6\n\tk/3BUHF0tX7fb9jL17EEdC9C5vsQsVjs6gTyvD1gVu6YyFWQaLgN2fH234pRiIXiL7In\n\tHPUg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=M9/Mwm/XEwltmvGlSz4BJv9jSJMAtODDJaKQvt17+3o=;\n\tb=noKcITnVtobzr3Cl5Qid7ZTdwMNV0zxqvHe0HGiZ9Lkak1tPXhAFy9+/1zHD4UNi8W\n\truLnATaVN4gBAFfyzUiwoP4tAdaVgP3AYVfXLbtep8E8IsgrYLm6L5e33WwTu8ndeswB\n\tdTq1IkhFlzDNVTkLJdQhPl+BSlRYj+NCaFdldi2OiMKK80Np0tcQ5zSGJjX5dUGG6U6w\n\tBbZjvx6L8huwlE8/GbeMAgrgmgHgwpt1KRtgpKXtdMX3grQqKP0jdjhMOYARLaL/26Hs\n\tBAadwkpKZOvD5U2pyWDYD8uXJo7bYf9ekepsjebL4m1J/0Fz3R2FYbwgBBYd17q0OxoR\n\tFLrA==","X-Gm-Message-State":"AHPjjUiR8ZnN/1c7MlQ06fO/ESIBrF64tjOVwE12prsHEXG2nc1BCxQk\n\tmoAxXf3fiUHM+jnmVKIzWgFD3WXVZi2IXhxmuL8hug==","X-Google-Smtp-Source":"AOwi7QBrrQJnJkdjuySc3WJojQ0FX1VykHTqLR6bE+J3y6BMJz0nXgheL7k+mfDmXegm2iSo1UWKbuPAtbm/nTGq5q0=","X-Received":"by 10.55.76.200 with SMTP id z191mr8499943qka.102.1505930633225; \n\tWed, 20 Sep 2017 11:03:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918.211952.1397675528248642600.davem@davemloft.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-9-tom@quantonium.net>\n\t<20170918.211952.1397675528248642600.davem@davemloft.net>","From":"Tom Herbert ","Date":"Wed, 20 Sep 2017 11:03:52 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","To":"David Miller ","Cc":"Tom Herbert ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tHarald Welte , Rohit Seth ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772172,"web_url":"http://patchwork.ozlabs.org/comment/1772172/","msgid":"<20170920.124511.922311380432026759.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-20T19:45:11","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tom Herbert \nDate: Wed, 20 Sep 2017 11:03:52 -0700\n\n> On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote:\n>> From: Tom Herbert \n>> Date: Mon, 18 Sep 2017 17:38:58 -0700\n>>\n>>> Allow peers to be specified by IPv6 addresses.\n>>>\n>>> Signed-off-by: Tom Herbert \n>>\n>> Hmmm, can you just check the socket family or something like that?\n> \n> I'm not sure what code you're referring to.\n\nThere is a socket associated with the tunnel to do the encapsulation\nand it has an address family, right?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy9FS6GSMz9s81\n\tfor ;\n\tThu, 21 Sep 2017 05:45:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdITTpO (ORCPT );\n\tWed, 20 Sep 2017 15:45:14 -0400","from shards.monkeyblade.net ([184.105.139.130]:34656 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751000AbdITTpO (ORCPT\n\t); Wed, 20 Sep 2017 15:45:14 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 6568912E1EE0B;\n\tWed, 20 Sep 2017 12:45:13 -0700 (PDT)"],"Date":"Wed, 20 Sep 2017 12:45:11 -0700 (PDT)","Message-Id":"<20170920.124511.922311380432026759.davem@davemloft.net>","To":"tom@herbertland.com","Cc":"tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\tlaforge@gnumonks.org, rohit@quantonium.net","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","From":"David Miller ","In-Reply-To":"","References":"<20170919003904.5124-9-tom@quantonium.net>\n\t<20170918.211952.1397675528248642600.davem@davemloft.net>\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 20 Sep 2017 12:45:13 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772190,"web_url":"http://patchwork.ozlabs.org/comment/1772190/","msgid":"","list_archive_url":null,"date":"2017-09-20T20:40:54","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":65986,"url":"http://patchwork.ozlabs.org/api/people/65986/","name":"Tom Herbert","email":"tom@herbertland.com"},"content":"On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote:\n> From: Tom Herbert \n> Date: Wed, 20 Sep 2017 11:03:52 -0700\n>\n>> On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote:\n>>> From: Tom Herbert \n>>> Date: Mon, 18 Sep 2017 17:38:58 -0700\n>>>\n>>>> Allow peers to be specified by IPv6 addresses.\n>>>>\n>>>> Signed-off-by: Tom Herbert \n>>>\n>>> Hmmm, can you just check the socket family or something like that?\n>>\n>> I'm not sure what code you're referring to.\n>\n> There is a socket associated with the tunnel to do the encapsulation\n> and it has an address family, right?\n\nIf fd's are set from userspace for the sockets then we could derive\nthe address family from them. I'll change that. Although, looking at\nnow I am wondering why were passing fds into GTP instead of just\nhaving the kernel create the UDP port like is done for other encaps.\n\nTom","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=herbertland-com.20150623.gappssmtp.com\n\theader.i=@herbertland-com.20150623.gappssmtp.com\n\theader.b=\"U/NEItRK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBTl3mKlz9s4s\n\tfor ;\n\tThu, 21 Sep 2017 06:40:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751499AbdITUk5 (ORCPT );\n\tWed, 20 Sep 2017 16:40:57 -0400","from mail-qk0-f182.google.com ([209.85.220.182]:54713 \"EHLO\n\tmail-qk0-f182.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751343AbdITUk4 (ORCPT\n\t); Wed, 20 Sep 2017 16:40:56 -0400","by mail-qk0-f182.google.com with SMTP id d70so3942412qkc.11\n\tfor ; Wed, 20 Sep 2017 13:40:55 -0700 (PDT)","by 10.200.53.168 with HTTP; Wed, 20 Sep 2017 13:40:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=herbertland-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4XABIZBeOSXaqP6iSVTQ3A/wkJ0Jex0fthPUae+vVkg=;\n\tb=U/NEItRKNpzqnF4VqON3edeFIxzq3JL+YG5xbNybktGMGCSXKbee4TkvjNhj8alYPM\n\tKA+xtloVOQW/nvyxZh4KjySOWtsrwiZ9ovqnPnev5NWteLFGaSCoO0lZ7GLpgFeUCCp5\n\tiPCaTn5+o4HCehWVnQhwi3fkcy2HTKuXff4WYgIMvwjtuSjmw44MpknKie9U4Ek9F3cg\n\thqbXV3/cUA3n7Pn3RDarPulMaYhsCDBRXE5DbDaPtB0Ph9LtrrzMmy0A2gIXkj59LjTO\n\trqvU8m6yhYyFto8vQxzRv93UGNeGTc7H1MvevBeFr4PmvPo7EZXhh1LThlanox82Ss43\n\tsAhg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4XABIZBeOSXaqP6iSVTQ3A/wkJ0Jex0fthPUae+vVkg=;\n\tb=S8xSRTGO9/4k4A7Ln1Wu3kG9EI4bbWA2IgL+WcMJ0dkkB5ZZXv9EqIDBEgfpeZmUfV\n\tWC6+gSL0BeRQDWN8fdG4A4B7e17zCcLgecwnyrIIODE/J1E/bZoBIwJ7ghXLgf5uPiFW\n\tqIMqnxs0zGQ3s3MsBQRJFMdh/0DXGJ3K9UZier18yegX7RjxTonCMlAVhOpVwaD5wOoo\n\t6vm/6lDgK5bhe3GNI5M+Jne2LQlfPZCNLEpi9DgeyQE8Jz31CBVoEFdmreW8UO2F5guQ\n\tO3HpQIcRnI2w18CTjQfiJIaOQRocUt/MeJuzIiAj1RAGLoyt5vdAottKyUJDrkRNx84U\n\tvcrw==","X-Gm-Message-State":"AHPjjUh7XRdYKwo355KX0LNdlJS8UEbOPkGTVbdZm6okjKpXB3iNWDsh\n\t3n9KwdeovqCD16+uD0DZ6nJ/MNdYsqsUgJ8lqGQ0zw==","X-Google-Smtp-Source":"AOwi7QD7bGN2dhG6PG6pRbF9+N7PqJnT1m8Gn8a8WSWRlWiXHvOGRLKr+5BQH0L3Qa/CZSFvSofquBHBaBHgE+QVwqw=","X-Received":"by 10.55.76.200 with SMTP id z191mr9173009qka.102.1505940055381; \n\tWed, 20 Sep 2017 13:40:55 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920.124511.922311380432026759.davem@davemloft.net>","References":"<20170919003904.5124-9-tom@quantonium.net>\n\t<20170918.211952.1397675528248642600.davem@davemloft.net>\n\t\n\t<20170920.124511.922311380432026759.davem@davemloft.net>","From":"Tom Herbert ","Date":"Wed, 20 Sep 2017 13:40:54 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","To":"David Miller ","Cc":"Tom Herbert ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tHarald Welte , Rohit Seth ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772323,"web_url":"http://patchwork.ozlabs.org/comment/1772323/","msgid":"<20170921000437.rg2h6vyxsrbc3bel@nataraja>","list_archive_url":null,"date":"2017-09-21T00:04:37","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Tom,\n\nOn Wed, Sep 20, 2017 at 01:40:54PM -0700, Tom Herbert wrote:\n> On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote:\n> > There is a socket associated with the tunnel to do the encapsulation\n> > and it has an address family, right?\n> \n> If fd's are set from userspace for the sockets then we could derive\n> the address family from them. I'll change that. Although, looking at\n> now I am wondering why were passing fds into GTP instead of just\n> having the kernel create the UDP port like is done for other encaps.\n\nbecause the userspace process has to take care of those bits of GTP-U\nthat the kernel doesn't, such as responding to GTP ECHO requests with\nGTP echo responses. Only the \"GTP Message type G-PDU\" is handled in the\nkernel, as only those frames contain user plane. See table 1 of Section\n7.1 of 3GPP TS 29.060.\n\nIf you create the socket in the kernel, how would you hand the socket to\nthe userspace process later on?\n\nIMHO, it feels more natural to simply create it in userspace (like you\nwould do in the non-kernel-accelerated case) and then simply handle the\nG-PDU messages in the kernel while doing the rest in userspace.\n\nBut if there's another method that feels more usual to the kernel\ncommunity, I'm not against any changes - but given kernel policies, we'd\nhave to keep userspace compatbility, right?\n\nRegards,\n\tHarald","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyHC32zcxz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 10:13:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751865AbdIUANd (ORCPT );\n\tWed, 20 Sep 2017 20:13:33 -0400","from ganesha.gnumonks.org ([213.95.27.120]:60999 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751640AbdIUANb (ORCPT\n\t); Wed, 20 Sep 2017 20:13:31 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dup7P-00022W-4L; Thu, 21 Sep 2017 02:13:27 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duoyr-0002ay-GQ; Thu, 21 Sep 2017 08:04:37 +0800"],"Date":"Thu, 21 Sep 2017 08:04:37 +0800","From":"Harald Welte ","To":"Tom Herbert ","Cc":"David Miller , Tom Herbert ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tRohit Seth ","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","Message-ID":"<20170921000437.rg2h6vyxsrbc3bel@nataraja>","References":"<20170919003904.5124-9-tom@quantonium.net>\n\t<20170918.211952.1397675528248642600.davem@davemloft.net>\n\t\n\t<20170920.124511.922311380432026759.davem@davemloft.net>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772325,"web_url":"http://patchwork.ozlabs.org/comment/1772325/","msgid":"","list_archive_url":null,"date":"2017-09-21T00:16:52","subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","submitter":{"id":72064,"url":"http://patchwork.ozlabs.org/api/people/72064/","name":"Tom Herbert","email":"tom@quantonium.net"},"content":"On Wed, Sep 20, 2017 at 5:04 PM, Harald Welte wrote:\n> Hi Tom,\n>\n> On Wed, Sep 20, 2017 at 01:40:54PM -0700, Tom Herbert wrote:\n>> On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote:\n>> > There is a socket associated with the tunnel to do the encapsulation\n>> > and it has an address family, right?\n>>\n>> If fd's are set from userspace for the sockets then we could derive\n>> the address family from them. I'll change that. Although, looking at\n>> now I am wondering why were passing fds into GTP instead of just\n>> having the kernel create the UDP port like is done for other encaps.\n>\n> because the userspace process has to take care of those bits of GTP-U\n> that the kernel doesn't, such as responding to GTP ECHO requests with\n> GTP echo responses. Only the \"GTP Message type G-PDU\" is handled in the\n> kernel, as only those frames contain user plane. See table 1 of Section\n> 7.1 of 3GPP TS 29.060.\n>\nOkay, thanks for the explanation.\n\nTom","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=quantonium-net.20150623.gappssmtp.com\n\theader.i=@quantonium-net.20150623.gappssmtp.com\n\theader.b=\"VyUwk1+I\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyHGx1sM5z9sNr\n\tfor ;\n\tThu, 21 Sep 2017 10:16:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751821AbdIUAQz (ORCPT );\n\tWed, 20 Sep 2017 20:16:55 -0400","from mail-wm0-f48.google.com ([74.125.82.48]:49277 \"EHLO\n\tmail-wm0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751640AbdIUAQy (ORCPT\n\t); Wed, 20 Sep 2017 20:16:54 -0400","by mail-wm0-f48.google.com with SMTP id e71so11287182wmg.4\n\tfor ; Wed, 20 Sep 2017 17:16:53 -0700 (PDT)","by 10.223.158.197 with HTTP; Wed, 20 Sep 2017 17:16:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=quantonium-net.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=3l6/i7HGqlWcZcgY5hDoL37HDTM9KByRASffV+r1O3w=;\n\tb=VyUwk1+IiS12pGEmlMUj8Ni6UE0CQcKwXFpRmd0rnt4l2xWzQJUMigiwWQF1q7STJx\n\tTWNeaK7m4rEB1wjeBamFAk7hrgmk4HpaQ9lSk3fP1SF56oo965UvQlRGICud/ab/BLwg\n\t798MF4kT65BBCSDRy/XG7vBrjqvp9M+TUeEvU+4/pBZAOE0Mxib+tcOjjgPNWO8krHAU\n\toowA4VCO4AbzeL2YlhJRKVPcsyW6/qG3KqKz+wN/uBnSMgGg86dQdMw9L0aHWFd7KkrU\n\tbrCXT58bWm+SsgF+nSiRbU07sbaqYp7xTS4l5BOAFujNdUwFPoyfwxFTzhrlZKbiJ5qt\n\tCXzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=3l6/i7HGqlWcZcgY5hDoL37HDTM9KByRASffV+r1O3w=;\n\tb=CrPMDklSuAxSyGcgIzcEOVWYqtLpTuomaVDPhpzCWHPb2Fin1vyJK/XLJmmrBtSD4o\n\t72yMCWbizRFGVYUGa1sBqM9JVpncxpEofnvC3whWpoqSYoqKDr6W1LnXHldp+QsJEaeV\n\tfR7F6B9xm6UviUDnazIWIA+mrhrrk9tTcjhuBoOqCsCyk5MHQpGrD6aeOmgMFPcb/JB6\n\tc/mnsGYjMyBY/ZzbwwSS+MYnGvscXEwQiZR+O4QFsqI78HrXBhynP6HoA9fHf74xz88A\n\t/et1eYRCUONgJdGKwljouBU9wXvWoTiaZttarf07P8rUrEa6zBUE2gqCxicoXzoUaigU\n\tiBAA==","X-Gm-Message-State":"AHPjjUgez1gejSnCUSUzCbfhQAlL2q4Hzm+EoH2xnUeOO0ii9yadFgB4\n\t3Mid5QeJwOS2Xg3LR0ioann2gQFJtXg5Xv46ASdcEw==","X-Google-Smtp-Source":"AOwi7QC/ZrW98z7q1UIVjXxHpxMCqOXt9kttrLwqOPkXF3g7rofohyXTDTe27l5VolVYioiEH8RZA3CYiqjPWx3ROmQ=","X-Received":"by 10.28.226.84 with SMTP id z81mr5078398wmg.108.1505953013063; \n\tWed, 20 Sep 2017 17:16:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170921000437.rg2h6vyxsrbc3bel@nataraja>","References":"<20170919003904.5124-9-tom@quantonium.net>\n\t<20170918.211952.1397675528248642600.davem@davemloft.net>\n\t\n\t<20170920.124511.922311380432026759.davem@davemloft.net>\n\t\n\t<20170921000437.rg2h6vyxsrbc3bel@nataraja>","From":"Tom Herbert ","Date":"Wed, 20 Sep 2017 17:16:52 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6","To":"Harald Welte ","Cc":"Tom Herbert , David Miller ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tRohit Seth ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]