[{"id":1770906,"web_url":"http://patchwork.ozlabs.org/comment/1770906/","msgid":"<201709191913.n0asYsgt%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-09-19T11:57:46","subject":"Re: [PATCH net-next 13/14] gtp: Support for GRO","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Tom,\n\n[auto build test WARNING on net-next/master]\n\nurl:    https://github.com/0day-ci/linux/commits/Tom-Herbert/gtp-Additional-feature-support/20170919-143920\nreproduce:\n        # apt-get install sparse\n        make ARCH=x86_64 allmodconfig\n        make C=1 CF=-D__CHECK_ENDIAN__\n\n\nsparse warnings: (new ones prefixed by >>)\n\n\nvim +3958 include/linux/netdevice.h\n\n5b33bc6e Tom Herbert 2017-09-18  3944  \n5b33bc6e Tom Herbert 2017-09-18  3945  /* rcu_read_lock() must be held */\n5b33bc6e Tom Herbert 2017-09-18  3946  static inline struct skb_gso_app *skb_gso_app_lookup(struct sk_buff *skb,\n5b33bc6e Tom Herbert 2017-09-18  3947  \t\t\t\t\t\t     netdev_features_t features,\n5b33bc6e Tom Herbert 2017-09-18  3948  \t\t\t\t\t\t     unsigned int check_flags)\n5b33bc6e Tom Herbert 2017-09-18  3949  {\n5b33bc6e Tom Herbert 2017-09-18  3950  \tstruct skb_gso_app *app;\n5b33bc6e Tom Herbert 2017-09-18  3951  \tint type;\n5b33bc6e Tom Herbert 2017-09-18  3952  \n5b33bc6e Tom Herbert 2017-09-18  3953  \tif (!(skb_shinfo(skb)->gso_type & SKB_GSO_APP_MASK))\n5b33bc6e Tom Herbert 2017-09-18  3954  \t\treturn false;\n5b33bc6e Tom Herbert 2017-09-18  3955  \n5b33bc6e Tom Herbert 2017-09-18  3956  \ttype = skb_gso_app_to_index(skb_shinfo(skb)->gso_type);\n5b33bc6e Tom Herbert 2017-09-18  3957  \n5b33bc6e Tom Herbert 2017-09-18 @3958  \tapp = rcu_dereference(skb_gso_apps[type]);\n5b33bc6e Tom Herbert 2017-09-18  3959  \tif (app && app->gso_segment &&\n5b33bc6e Tom Herbert 2017-09-18  3960  \t    (check_flags & app->check_flags))\n5b33bc6e Tom Herbert 2017-09-18  3961  \t\treturn app;\n5b33bc6e Tom Herbert 2017-09-18  3962  \n5b33bc6e Tom Herbert 2017-09-18  3963  \treturn NULL;\n5b33bc6e Tom Herbert 2017-09-18  3964  }\n5b33bc6e Tom Herbert 2017-09-18  3965  \n\n:::::: The code at line 3958 was first introduced by commit\n:::::: 5b33bc6e4fcae1113167c651a3d3a218c7e277c6 net: Add a facility to support application defined GSO\n\n:::::: TO: Tom Herbert <tom@quantonium.net>\n:::::: CC: 0day robot <fengguang.wu@intel.com>\n\n---\n0-DAY kernel test infrastructure                Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all                   Intel Corporation","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxLy82Mwyz9s4q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 21:59:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751726AbdISL7K (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 07:59:10 -0400","from mga03.intel.com ([134.134.136.65]:10522 \"EHLO mga03.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751543AbdISL7J (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 19 Sep 2017 07:59:09 -0400","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2017 04:58:48 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Sep 2017 04:58:46 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from <fengguang.wu@intel.com>)\n\tid 1duHFh-000W8X-M1; Tue, 19 Sep 2017 20:03:45 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,418,1500966000\"; d=\"scan'208\";a=\"1016113992\"","Date":"Tue, 19 Sep 2017 19:57:46 +0800","From":"kbuild test robot <lkp@intel.com>","To":"Tom Herbert <tom@quantonium.net>","Cc":"kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org,\n\tpablo@netfilter.org, laforge@gnumonks.org, rohit@quantonium.net,\n\tTom Herbert <tom@quantonium.net>","Subject":"Re: [PATCH net-next 13/14] gtp: Support for GRO","Message-ID":"<201709191913.n0asYsgt%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919003904.5124-14-tom@quantonium.net>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"<locally generated>","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770932,"web_url":"http://patchwork.ozlabs.org/comment/1770932/","msgid":"<20170919120321.qiw72rsvpwvtj6n2@nataraja>","list_archive_url":null,"date":"2017-09-19T12:03:21","subject":"Re: [PATCH net-next 13/14] gtp: Support for GRO","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"On Mon, Sep 18, 2017 at 05:39:03PM -0700, Tom Herbert wrote:\n> Populate GRO receive and GRO complete functions for GTP-Uv0 and v1.\n\nlooks fine to me, though I'm not the GRO expert here.  Let's say what\nthe netdev gurus have to say in their review.\n\nIf you say it is tested with GRO-capable and non-GRO capable device\ndrivers, I'm fine with the patch.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMGp5l3cz9s4q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 22:13:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751724AbdISMNP (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 08:13:15 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45341 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751476AbdISMNN (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 19 Sep 2017 08:13:13 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from <laforge@gnumonks.org>)\n\tid 1duHOn-0001If-B4; Tue, 19 Sep 2017 14:13:09 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from <laforge@gnumonks.org>)\n\tid 1duHFJ-0007fD-B6; Tue, 19 Sep 2017 20:03:21 +0800"],"Date":"Tue, 19 Sep 2017 20:03:21 +0800","From":"Harald Welte <laforge@gnumonks.org>","To":"Tom Herbert <tom@quantonium.net>","Cc":"davem@davemloft.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 13/14] gtp: Support for GRO","Message-ID":"<20170919120321.qiw72rsvpwvtj6n2@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-14-tom@quantonium.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919003904.5124-14-tom@quantonium.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]