[{"id":1770641,"web_url":"http://patchwork.ozlabs.org/comment/1770641/","msgid":"<20170918.212445.1680068602644706922.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T04:24:45","subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tom Herbert \nDate: Mon, 18 Sep 2017 17:39:02 -0700\n\n> Add configuration to control use of zero checksums on transmit for both\n> IPv4 and IPv6, and control over accepting zero IPv6 checksums on\n> receive.\n> \n> Signed-off-by: Tom Herbert \n\nI thought we were trying to move away from this special case of allowing\nzero UDP checksums with tunnels, especially for ipv6.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx8ss6WtCz9ryr\n\tfor ;\n\tTue, 19 Sep 2017 14:24:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751039AbdISEYr (ORCPT );\n\tTue, 19 Sep 2017 00:24:47 -0400","from shards.monkeyblade.net ([184.105.139.130]:38752 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750750AbdISEYr (ORCPT\n\t); Tue, 19 Sep 2017 00:24:47 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 7EDEF102ABA2F;\n\tMon, 18 Sep 2017 21:24:46 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 21:24:45 -0700 (PDT)","Message-Id":"<20170918.212445.1680068602644706922.davem@davemloft.net>","To":"tom@quantonium.net","Cc":"netdev@vger.kernel.org, pablo@netfilter.org, laforge@gnumonks.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","From":"David Miller ","In-Reply-To":"<20170919003904.5124-13-tom@quantonium.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-13-tom@quantonium.net>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 21:24:46 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772137,"web_url":"http://patchwork.ozlabs.org/comment/1772137/","msgid":"","list_archive_url":null,"date":"2017-09-20T18:09:29","subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","submitter":{"id":65986,"url":"http://patchwork.ozlabs.org/api/people/65986/","name":"Tom Herbert","email":"tom@herbertland.com"},"content":"On Mon, Sep 18, 2017 at 9:24 PM, David Miller wrote:\n> From: Tom Herbert \n> Date: Mon, 18 Sep 2017 17:39:02 -0700\n>\n>> Add configuration to control use of zero checksums on transmit for both\n>> IPv4 and IPv6, and control over accepting zero IPv6 checksums on\n>> receive.\n>>\n>> Signed-off-by: Tom Herbert \n>\n> I thought we were trying to move away from this special case of allowing\n> zero UDP checksums with tunnels, especially for ipv6.\n\nI don't have a strong preference either way. I like consistency with\nVXLAN and foo/UDP, but I guess it's not required. Interestingly, since\nGTP only carries IP, IPv6 zero checksums are actually safer here than\nVXLAN or GRE/UDP.\n\nTom","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=herbertland-com.20150623.gappssmtp.com\n\theader.i=@herbertland-com.20150623.gappssmtp.com\n\theader.b=\"c3jLUcKA\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy7724TLYz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 04:09:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751700AbdITSJb (ORCPT );\n\tWed, 20 Sep 2017 14:09:31 -0400","from mail-qk0-f170.google.com ([209.85.220.170]:44234 \"EHLO\n\tmail-qk0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751676AbdITSJa (ORCPT\n\t); Wed, 20 Sep 2017 14:09:30 -0400","by mail-qk0-f170.google.com with SMTP id b23so3559358qkg.1\n\tfor ; Wed, 20 Sep 2017 11:09:30 -0700 (PDT)","by 10.237.61.196 with HTTP; Wed, 20 Sep 2017 11:09:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=herbertland-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=h9iKf9Gk/XOy/8rgMAFfde14syIsbDXvIp4Cwe6Dacw=;\n\tb=c3jLUcKA0+qFK6z41zlHLIrGKv/CEYRCB/6TmIBYp1zjLzNbjDWIZDE62CqxDfobss\n\t6SCNQtssZQAXGzuhr/svHrrGcywmcbUmMuACOxu8tSdagkFrv3ySBgU/RuYX7ZUAw4bm\n\tIISv84/di29wyexvEovwZkCrPPGlOxFpGjtmyqZUNXAD0BTli6jGZlVi3kCrHx/WnWMl\n\tQmjliXkjOXkx7bCYbaMVGMe2lvJFg0/C0o+M33k9f/L4Wn275+oIWx/miat4rCTURzqJ\n\tb+uyfLEjsJeLYZpoG7u4CndR2NtZO+8bSza2I2jnZzEBNRsgJE8iFebmE5BVa20f4kV9\n\tFa/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=h9iKf9Gk/XOy/8rgMAFfde14syIsbDXvIp4Cwe6Dacw=;\n\tb=f9Mcb8CTvCxPE4k0YKqbMWXvO3m3gcPIEbabL85C0vpzJBen/GbzHf/UrXAJ/wtYPW\n\thDOySHKK2n7Uvx5g0pUDTUG5LbJow5TaY+PzWBWZ4vxifkYnKhF+relHBldhCbzYhM2Q\n\t6UUVLqDAkI425aLG2yv42LmyChvVPTHCRFMNSpi+X5xV/CFC7qRd4XzYj3SF7EiKxq2U\n\td+aErjBffey0CKQR9+ZjFEg9aSoSq6rwObhvRJHBzoXUw0zpsXynFWjgMRAAB+XYdyPI\n\tmd/cZ5coE3JfqjuGdEPEJknBjefkX9OU47KoC/b2gNHhV913wCOPKh+9qCltctx2MwPU\n\tJxYg==","X-Gm-Message-State":"AHPjjUh8M9k+75S1iVTOzNxyJZy0u928jLoRMAwIj9wB9a6CmKIOxuXi\n\trUKXvd9bDB6dm83t4YNaAGbOH3nOyTEKJtxDAUfNYw==","X-Google-Smtp-Source":"AOwi7QCqvIpPwBo2O2whJuybbvAMTgX3G/G31UA0s07PEQbW0fHq8v+WNrc5qaMlqyIz98pyCSy9bpntFFNNNj+f6Fk=","X-Received":"by 10.55.109.131 with SMTP id i125mr8072248qkc.17.1505930970062; \n\tWed, 20 Sep 2017 11:09:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918.212445.1680068602644706922.davem@davemloft.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-13-tom@quantonium.net>\n\t<20170918.212445.1680068602644706922.davem@davemloft.net>","From":"Tom Herbert ","Date":"Wed, 20 Sep 2017 11:09:29 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","To":"David Miller ","Cc":"Tom Herbert ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tHarald Welte , Rohit Seth ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772403,"web_url":"http://patchwork.ozlabs.org/comment/1772403/","msgid":"<20170921015522.sv5netrlcj5vebys@nataraja>","list_archive_url":null,"date":"2017-09-21T01:55:22","subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Tom,\n\nOn Wed, Sep 20, 2017 at 11:09:29AM -0700, Tom Herbert wrote:\n> On Mon, Sep 18, 2017 at 9:24 PM, David Miller wrote:\n> > From: Tom Herbert \n> >> Add configuration to control use of zero checksums on transmit for both\n> >> IPv4 and IPv6, and control over accepting zero IPv6 checksums on\n> >> receive.\n> >\n> > I thought we were trying to move away from this special case of allowing\n> > zero UDP checksums with tunnels, especially for ipv6.\n> \n> I don't have a strong preference either way. I like consistency with\n> VXLAN and foo/UDP, but I guess it's not required. Interestingly, since\n> GTP only carries IP, IPv6 zero checksums are actually safer here than\n> VXLAN or GRE/UDP.\n\nJust for the record: I don't care either way and I defer to the kernel\nnetworking developers to decide if they want to have zero UDP checksum\nin GTP or not.\n\nThe 3GPP specs don't say anything about UDP checksums. So there's no\nrequirement to use them, and hence operation without UDP checksums\nshould be compliant. Cisco GTP implementation has udp checksumming\nconfigurable, so other implementations also seem to provide both ways.\n\nIn general, I would argue one wants UDP checksumming of GTP in all\nsetups, as while the inner IP packet might be protected, the GTP header\nitself is not, and that's what contains important data suhc as the TEID\n(Tunnel Endpoint ID). But that's of course just my personal opinion,\nand I'm not saying we should prevent people from using lower protection\nif that's what they want.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyPKW2gNVz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 14:49:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751578AbdIUEtd (ORCPT );\n\tThu, 21 Sep 2017 00:49:33 -0400","from ganesha.gnumonks.org ([213.95.27.120]:34375 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751436AbdIUEtc (ORCPT\n\t); Thu, 21 Sep 2017 00:49:32 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dutQW-0001gQ-2v; Thu, 21 Sep 2017 06:49:28 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duqi2-0004gF-Vy; Thu, 21 Sep 2017 09:55:22 +0800"],"Date":"Thu, 21 Sep 2017 09:55:22 +0800","From":"Harald Welte ","To":"Tom Herbert ","Cc":"David Miller , Tom Herbert ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tRohit Seth ","Subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","Message-ID":"<20170921015522.sv5netrlcj5vebys@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-13-tom@quantonium.net>\n\t<20170918.212445.1680068602644706922.davem@davemloft.net>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773150,"web_url":"http://patchwork.ozlabs.org/comment/1773150/","msgid":"","list_archive_url":null,"date":"2017-09-21T22:41:03","subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","submitter":{"id":72064,"url":"http://patchwork.ozlabs.org/api/people/72064/","name":"Tom Herbert","email":"tom@quantonium.net"},"content":"On Wed, Sep 20, 2017 at 6:55 PM, Harald Welte wrote:\n> Hi Tom,\n>\n> On Wed, Sep 20, 2017 at 11:09:29AM -0700, Tom Herbert wrote:\n>> On Mon, Sep 18, 2017 at 9:24 PM, David Miller wrote:\n>> > From: Tom Herbert \n>> >> Add configuration to control use of zero checksums on transmit for both\n>> >> IPv4 and IPv6, and control over accepting zero IPv6 checksums on\n>> >> receive.\n>> >\n>> > I thought we were trying to move away from this special case of allowing\n>> > zero UDP checksums with tunnels, especially for ipv6.\n>>\n>> I don't have a strong preference either way. I like consistency with\n>> VXLAN and foo/UDP, but I guess it's not required. Interestingly, since\n>> GTP only carries IP, IPv6 zero checksums are actually safer here than\n>> VXLAN or GRE/UDP.\n>\n> Just for the record: I don't care either way and I defer to the kernel\n> networking developers to decide if they want to have zero UDP checksum\n> in GTP or not.\n>\n> The 3GPP specs don't say anything about UDP checksums. So there's no\n> requirement to use them, and hence operation without UDP checksums\n> should be compliant. Cisco GTP implementation has udp checksumming\n> configurable, so other implementations also seem to provide both ways.\n>\n> In general, I would argue one wants UDP checksumming of GTP in all\n> setups, as while the inner IP packet might be protected, the GTP header\n> itself is not, and that's what contains important data suhc as the TEID\n> (Tunnel Endpoint ID). But that's of course just my personal opinion,\n> and I'm not saying we should prevent people from using lower protection\n> if that's what they want.\n>\nThe tradeoffs and requirements of zero UDP6 checksums are discussed at\nlength in RFC6935 and RFC6936. Given other implementations make it\nconfigurable it should also be here.\n\nTom\n\n> --\n> - Harald Welte http://laforge.gnumonks.org/\n> ============================================================================\n> \"Privacy in residential applications is a desirable marketing option.\"\n> (ETSI EN 300 175-7 Ch. A6)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=quantonium-net.20150623.gappssmtp.com\n\theader.i=@quantonium-net.20150623.gappssmtp.com\n\theader.b=\"TtU+GwpT\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xys5w5HCvz9t30\n\tfor ;\n\tFri, 22 Sep 2017 08:41:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751883AbdIUWlF (ORCPT );\n\tThu, 21 Sep 2017 18:41:05 -0400","from mail-wr0-f170.google.com ([209.85.128.170]:57211 \"EHLO\n\tmail-wr0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751738AbdIUWlE (ORCPT\n\t); Thu, 21 Sep 2017 18:41:04 -0400","by mail-wr0-f170.google.com with SMTP id r74so5601236wrb.13\n\tfor ; Thu, 21 Sep 2017 15:41:04 -0700 (PDT)","by 10.223.158.197 with HTTP; Thu, 21 Sep 2017 15:41:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=quantonium-net.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=MaohzV/WUTTkJjmN6ois+M7W8VaEFg7QVqYTFYVbv3E=;\n\tb=TtU+GwpTNKTcUjdrKLYoiWNf1h0nXfAzER7x/+YXN4xoqhlETvgdoE5zFRoJCd/OXr\n\tmlF1rW2/n74Iqt+6hMYi/4/ZXOSayk5yOCLGaPACnbgjl45i+rYlgrcKr9GYVkeDAkKH\n\tgIuQ1/U7SFWYJeyh11dlzlomfXvELN8btNdP9G9bgdmYfq/gnPBLN+nSj1eioMbKRbzh\n\t8zlupyua6G1FgTRdgO8l3jZJZagIM8e+jrsFBgX6MNMkcZZRP/dVwLi5fRypahdRPgHQ\n\tQ2Nlyd0g5TxIrtAYhwMSdRmtqRjJkTOmCB2mJPuXr3cYbBlY8xoQQbTyBFlHhkFYjmbS\n\tnkIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=MaohzV/WUTTkJjmN6ois+M7W8VaEFg7QVqYTFYVbv3E=;\n\tb=Yi/ANZcbNtRWdrQOUiWW67kg8lpzFIPPkq7dU6JPX7bbtZFnVTSAupHHPsQa2DJxQT\n\tllpZrg8BGl7ToV5CPGxYOwb+JETua5kZuZ9fZ3xTM2eJmCDIEdx3JVYv476JmCSt8sYf\n\tfxnXTuBw942BsBGkXtOAhicvGU7MFxg7KuApLVbZLb8qAsNRFTsh1P0SO85ye6VyGKyf\n\tdBqOpmiQ+M8diR3mdyJHrpLHUxiG1Vb4c4j14vILJ3Za/EAFDdMz5tGhQw68ktrq3TTh\n\tRQJFMB4/CFyMtgimN2hJvW+ZALhqnOuRyuXSEtaO+0A1itc2TA4VjFhsmAgK0r80Ttv0\n\tfOwQ==","X-Gm-Message-State":"AHPjjUjuXRDINugtnBFxF269BxMZAzXu8NYf/iWqW3FP5cVeBJIj+P9U\n\taZoBfHW/uoHRtUawdPio40r8R5osU0t4bnAz6rK0vQ==","X-Google-Smtp-Source":"AOwi7QAKLECaopaNhU4VxcwdKTO+Um3xxCet+5DHTHvys9jYVRsAsqWLNlCNxc0Z9xmpnLT/74qsriv41RuLNg0GUcw=","X-Received":"by 10.223.175.100 with SMTP id z91mr3392294wrc.177.1506033663567;\n\tThu, 21 Sep 2017 15:41:03 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170921015522.sv5netrlcj5vebys@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-13-tom@quantonium.net>\n\t<20170918.212445.1680068602644706922.davem@davemloft.net>\n\t\n\t<20170921015522.sv5netrlcj5vebys@nataraja>","From":"Tom Herbert ","Date":"Thu, 21 Sep 2017 15:41:03 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum","To":"Harald Welte ","Cc":"Tom Herbert , David Miller ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tRohit Seth ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]