[{"id":1770638,"web_url":"http://patchwork.ozlabs.org/comment/1770638/","msgid":"<20170918.211908.2152170523885516973.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T04:19:08","subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tom Herbert \nDate: Mon, 18 Sep 2017 17:38:57 -0700\n\n> @@ -98,6 +104,7 @@ static void pdp_context_delete(struct pdp_ctx *pctx);\n> static inline u32 gtp0_hashfn(u64 tid)\n> {\n> \tu32 *tid32 = (u32 *) &tid;\n> +\n> \treturn jhash_2words(tid32[0], tid32[1], gtp_h_initval);\n> }\n> \n> @@ -111,6 +118,11 @@ static inline u32 ipv4_hashfn(__be32 ip)\n> \treturn jhash_1word((__force u32)ip, gtp_h_initval);\n> }\n> \n> +static inline u32 ipv6_hashfn(const struct in6_addr *a)\n> +{\n> +\treturn __ipv6_addr_jhash(a, gtp_h_initval);\n> +}\n\nI know you are just following the pattern of the existing \"ipv4_hashfn()\" here\nbut this kind of stuff is not very global namespace friendly. Even simply\nadding a \"gtp_\" prefix to these hash functions would be a lot better.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx8lN1YkLz9ryr\n\tfor ;\n\tTue, 19 Sep 2017 14:19:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751039AbdISETK (ORCPT );\n\tTue, 19 Sep 2017 00:19:10 -0400","from shards.monkeyblade.net ([184.105.139.130]:38600 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750750AbdISETJ (ORCPT\n\t); Tue, 19 Sep 2017 00:19:09 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 1269A102ABA29;\n\tMon, 18 Sep 2017 21:19:09 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 21:19:08 -0700 (PDT)","Message-Id":"<20170918.211908.2152170523885516973.davem@davemloft.net>","To":"tom@quantonium.net","Cc":"netdev@vger.kernel.org, pablo@netfilter.org, laforge@gnumonks.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","From":"David Miller ","In-Reply-To":"<20170919003904.5124-8-tom@quantonium.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-8-tom@quantonium.net>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 21:19:09 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770929,"web_url":"http://patchwork.ozlabs.org/comment/1770929/","msgid":"<20170919115327.zbu5s2dnndj2ufx5@nataraja>","list_archive_url":null,"date":"2017-09-19T11:53:27","subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"On Mon, Sep 18, 2017 at 05:38:57PM -0700, Tom Herbert wrote:\n> Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile\n> subscriber address to pdp context and IPv6 specific variants to find pdp\n> contexts by address.\n\nPlease note that there are three different PDP contexts for IP:\n* IPv4 only (what gtp.c implements so far)\n* IPv6 only\n* dual IPv4+IPv6 (called IPv46)\n\nThis information will have to be provisioned by the control plane\nvia netlink for each PDP context. The kernel module then needs to\nmake sure that on a v4-only context no IPv6 packets are accepted\nand vice-versa.\n\nYour proposed patch is missing this kind of screening function and\nI would imagine it could introduce all kinds of security problems :/","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMGb0SHyz9s7c\n\tfor ;\n\tTue, 19 Sep 2017 22:13:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751752AbdISMNQ (ORCPT );\n\tTue, 19 Sep 2017 08:13:16 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45334 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751519AbdISMNN (ORCPT\n\t); Tue, 19 Sep 2017 08:13:13 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1duHOn-0001Ij-IA; Tue, 19 Sep 2017 14:13:09 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duH5j-0007LI-Eh; Tue, 19 Sep 2017 19:53:27 +0800"],"Date":"Tue, 19 Sep 2017 19:53:27 +0800","From":"Harald Welte ","To":"Tom Herbert ","Cc":"davem@davemloft.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","Message-ID":"<20170919115327.zbu5s2dnndj2ufx5@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-8-tom@quantonium.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919003904.5124-8-tom@quantonium.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770934,"web_url":"http://patchwork.ozlabs.org/comment/1770934/","msgid":"<20170919121245.t555dqwndhewmdyw@nataraja>","list_archive_url":null,"date":"2017-09-19T12:12:45","subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Dave,\n\nOn Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote:\n\n> > +static inline u32 ipv6_hashfn(const struct in6_addr *a)\n> > +{\n> > +\treturn __ipv6_addr_jhash(a, gtp_h_initval);\n> > +}\n> \n> I know you are just following the pattern of the existing \"ipv4_hashfn()\" here\n> but this kind of stuff is not very global namespace friendly. Even simply\n> adding a \"gtp_\" prefix to these hash functions would be a lot better.\n\nI would agree if this was an inline function defined in a header file or\na non-static function. But where is the global namespace concern in\ncase of static inline functions defined and used in the same .c file?\n\nIf it makes you happy, I'm all for adding the prefix - I just would like\nto understand the rationale better, thanks :)\n\nRegards,\n\tHarald","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMGx5501z9s7c\n\tfor ;\n\tTue, 19 Sep 2017 22:13:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751679AbdISMNN (ORCPT );\n\tTue, 19 Sep 2017 08:13:13 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45324 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750822AbdISMNN (ORCPT\n\t); Tue, 19 Sep 2017 08:13:13 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1duHOn-0001Ib-3y; Tue, 19 Sep 2017 14:13:09 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duHOQ-0007st-3q; Tue, 19 Sep 2017 20:12:46 +0800"],"Date":"Tue, 19 Sep 2017 20:12:45 +0800","From":"Harald Welte ","To":"David Miller ","Cc":"tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","Message-ID":"<20170919121245.t555dqwndhewmdyw@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-8-tom@quantonium.net>\n\t<20170918.211908.2152170523885516973.davem@davemloft.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918.211908.2152170523885516973.davem@davemloft.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771235,"web_url":"http://patchwork.ozlabs.org/comment/1771235/","msgid":"<20170919.104248.1540128186724107742.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T17:42:48","subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Harald Welte \nDate: Tue, 19 Sep 2017 20:12:45 +0800\n\n> Hi Dave,\n> \n> On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote:\n> \n>> > +static inline u32 ipv6_hashfn(const struct in6_addr *a)\n>> > +{\n>> > +\treturn __ipv6_addr_jhash(a, gtp_h_initval);\n>> > +}\n>> \n>> I know you are just following the pattern of the existing \"ipv4_hashfn()\" here\n>> but this kind of stuff is not very global namespace friendly. Even simply\n>> adding a \"gtp_\" prefix to these hash functions would be a lot better.\n> \n> I would agree if this was an inline function defined in a header file or\n> a non-static function. But where is the global namespace concern in\n> case of static inline functions defined and used in the same .c file?\n\nThe problem is if we create a generic ipv6_hashfn() in linux/ipv6.h or\nsomething like that, then this driver stops building.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVZj0jmjz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:42:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751572AbdISRmu (ORCPT );\n\tTue, 19 Sep 2017 13:42:50 -0400","from shards.monkeyblade.net ([184.105.139.130]:37316 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751480AbdISRmt (ORCPT\n\t); Tue, 19 Sep 2017 13:42:49 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 43199102C1384;\n\tTue, 19 Sep 2017 10:42:49 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 10:42:48 -0700 (PDT)","Message-Id":"<20170919.104248.1540128186724107742.davem@davemloft.net>","To":"laforge@gnumonks.org","Cc":"tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","From":"David Miller ","In-Reply-To":"<20170919121245.t555dqwndhewmdyw@nataraja>","References":"<20170919003904.5124-8-tom@quantonium.net>\n\t<20170918.211908.2152170523885516973.davem@davemloft.net>\n\t<20170919121245.t555dqwndhewmdyw@nataraja>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 10:42:49 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771473,"web_url":"http://patchwork.ozlabs.org/comment/1771473/","msgid":"","list_archive_url":null,"date":"2017-09-20T00:11:54","subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","submitter":{"id":72064,"url":"http://patchwork.ozlabs.org/api/people/72064/","name":"Tom Herbert","email":"tom@quantonium.net"},"content":"On Tue, Sep 19, 2017 at 10:42 AM, David Miller wrote:\n> From: Harald Welte \n> Date: Tue, 19 Sep 2017 20:12:45 +0800\n>\n>> Hi Dave,\n>>\n>> On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote:\n>>\n>>> > +static inline u32 ipv6_hashfn(const struct in6_addr *a)\n>>> > +{\n>>> > + return __ipv6_addr_jhash(a, gtp_h_initval);\n>>> > +}\n>>>\n>>> I know you are just following the pattern of the existing \"ipv4_hashfn()\" here\n>>> but this kind of stuff is not very global namespace friendly. Even simply\n>>> adding a \"gtp_\" prefix to these hash functions would be a lot better.\n>>\n>> I would agree if this was an inline function defined in a header file or\n>> a non-static function. But where is the global namespace concern in\n>> case of static inline functions defined and used in the same .c file?\n>\n> The problem is if we create a generic ipv6_hashfn() in linux/ipv6.h or\n> something like that, then this driver stops building.\n\nIt was a carry over since ipv4_hashfn was already defined in the file.\nI will prefix both functions.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=quantonium-net.20150623.gappssmtp.com\n\theader.i=@quantonium-net.20150623.gappssmtp.com\n\theader.b=\"sH7QW/Xz\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxgCj3TWMz9s06\n\tfor ;\n\tWed, 20 Sep 2017 10:12:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751396AbdITAL4 (ORCPT );\n\tTue, 19 Sep 2017 20:11:56 -0400","from mail-wm0-f43.google.com ([74.125.82.43]:43571 \"EHLO\n\tmail-wm0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751074AbdITALz (ORCPT\n\t); Tue, 19 Sep 2017 20:11:55 -0400","by mail-wm0-f43.google.com with SMTP id a137so2205153wma.0\n\tfor ; Tue, 19 Sep 2017 17:11:55 -0700 (PDT)","by 10.223.158.197 with HTTP; Tue, 19 Sep 2017 17:11:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=quantonium-net.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=30ee56ViXVMLPnyEXwk72M6bzYTMlS7uoohMSWZNN3o=;\n\tb=sH7QW/XzbbmcISnVFUAtGsSTWuk4h3q/G0APBVdi4Zp0GOoAODapWI6FLC+52Mmjad\n\tjpalr1ERdXznvSFGrGWX4Ho9pO4lVOXebFdvN0EnQfVbYJPVpTBilYQgGv+vWuYOr3nH\n\tFZIJrpdcPDBH8EUSzBlvJeRkPE4ecH26JDwDLJm3LyB24r9o1pdxp0szQGFJhvTrEa/f\n\txSTF4df04SXOYBZyMrSLRhxML7jykbESTfjJIP011YM1JNtW0FDO8ap12Is6BcKs5zE6\n\tUQE++uFGunRScj30EpzZyRSnJE3PylaZycFTP7mxtf1Oentpt9cnII6PmXbAwE3ME8A7\n\tMULg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=30ee56ViXVMLPnyEXwk72M6bzYTMlS7uoohMSWZNN3o=;\n\tb=EEBCbC0Ne3FC2Unv/PMhA2tAtGl/14fpkrXiYNmTCK5KP5SRuhSOE5qWeJswAPYrbH\n\tfzXBmc7HN5BUyxwMvTmLgc85dCWDFgwiBVFr2Lg1lBuR4aUDRxpwZdQ8hLU6Gh/z9FGe\n\tyrFEXOn8DmTBFqcxjBIDo/qMFJJR2eY2tiO2qcYKxvoTJ8eNBnDmZDAYuh1SujYVRJ6V\n\t4vxtu148/P9X45hOKVMp6BGZGbAL1suRSiSWOjrEHovLt/oLWNXp80NdNsRyjhusdGoj\n\txRndCaDuHhM0gjPHDtq7O94m7yOJQLkThg7ANfau33DrhOqKaGSwdZT2OTFmQpzRbvyu\n\tnvEQ==","X-Gm-Message-State":"AHPjjUg/du5ZMqAEDSLljWdaYX28YlJOxjP5rsMR5QoJO9Kp1ikBNx0i\n\tqBg/YcbHjHVj7OLMKUowBVsyyNPR9HRQBKF8LEnlVQ==","X-Google-Smtp-Source":"AOwi7QBQrzlYg/mBQSxXkN0hezwI7BzRoBhKIZwojjN1VlkEk3XrQ93eZsVDeT6UDbRZTcuWUa6BusX17yh1pXzhKnE=","X-Received":"by 10.28.21.71 with SMTP id 68mr2469054wmv.139.1505866314585;\n\tTue, 19 Sep 2017 17:11:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170919.104248.1540128186724107742.davem@davemloft.net>","References":"<20170919003904.5124-8-tom@quantonium.net>\n\t<20170918.211908.2152170523885516973.davem@davemloft.net>\n\t<20170919121245.t555dqwndhewmdyw@nataraja>\n\t<20170919.104248.1540128186724107742.davem@davemloft.net>","From":"Tom Herbert ","Date":"Tue, 19 Sep 2017 17:11:54 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6\n\tpackets","To":"David Miller ","Cc":"Harald Welte ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tRohit LastName ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]