[{"id":1770700,"web_url":"http://patchwork.ozlabs.org/comment/1770700/","msgid":"<201709191523.enXn3mfA%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-09-19T07:44:47","subject":"Re: [PATCH net-next 04/14] gtp: udp recv clean up","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Tom,\n\n[auto build test ERROR on net-next/master]\n\nurl: https://github.com/0day-ci/linux/commits/Tom-Herbert/gtp-Additional-feature-support/20170919-143920\nconfig: i386-randconfig-x016-201738 (attached as .config)\ncompiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901\nreproduce:\n # save the attached .config to linux build tree\n make ARCH=i386 \n\nNote: the linux-review/Tom-Herbert/gtp-Additional-feature-support/20170919-143920 HEAD 737a09b8f9cd56706d01703d17523b0fea907f41 builds fine.\n It only hurts bisectibility.\n\nAll errors (new ones prefixed by >>):\n\n drivers//net/gtp.c: In function 'gtp_rx':\n>> drivers//net/gtp.c:222:21: error: 'gtp' undeclared (first use in this function)\n gro_cells_receive(>p->gro_cells, skb);\n ^~~\n drivers//net/gtp.c:222:21: note: each undeclared identifier is reported only once for each function it appears in\n drivers//net/gtp.c: In function 'gtp_link_setup':\n drivers//net/gtp.c:628:18: error: 'gtp' undeclared (first use in this function)\n gro_cells_init(>p->gro_cells, dev);\n ^~~\n\nvim +/gtp +222 drivers//net/gtp.c\n\n 190\t\n 191\tstatic int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb,\n 192\t\t\t\tunsigned int hdrlen, unsigned int role)\n 193\t{\n 194\t\tstruct pcpu_sw_netstats *stats;\n 195\t\n 196\t\tif (!gtp_check_ms(skb, pctx, hdrlen, role)) {\n 197\t\t\tnetdev_dbg(pctx->dev, \"No PDP ctx for this MS\\n\");\n 198\t\t\treturn 1;\n 199\t\t}\n 200\t\n 201\t\t/* Get rid of the GTP + UDP headers. */\n 202\t\tif (iptunnel_pull_header(skb, hdrlen, skb->protocol,\n 203\t\t\t\t\t !net_eq(sock_net(pctx->sk), dev_net(pctx->dev))))\n 204\t\t\treturn -1;\n 205\t\n 206\t\tnetdev_dbg(pctx->dev, \"forwarding packet from GGSN to uplink\\n\");\n 207\t\n 208\t\t/* Now that the UDP and the GTP header have been removed, set up the\n 209\t\t * new network header. This is required by the upper layer to\n 210\t\t * calculate the transport header.\n 211\t\t */\n 212\t\tskb_reset_network_header(skb);\n 213\t\n 214\t\tskb->dev = pctx->dev;\n 215\t\n 216\t\tstats = this_cpu_ptr(pctx->dev->tstats);\n 217\t\tu64_stats_update_begin(&stats->syncp);\n 218\t\tstats->rx_packets++;\n 219\t\tstats->rx_bytes += skb->len;\n 220\t\tu64_stats_update_end(&stats->syncp);\n 221\t\n > 222\t\tgro_cells_receive(>p->gro_cells, skb);\n 223\t\n 224\t\treturn 0;\n 225\t}\n 226\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxF4V27ddz9sBZ\n\tfor ;\n\tTue, 19 Sep 2017 17:34:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751473AbdISHeR (ORCPT );\n\tTue, 19 Sep 2017 03:34:17 -0400","from mga14.intel.com ([192.55.52.115]:40504 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750747AbdISHeO (ORCPT );\n\tTue, 19 Sep 2017 03:34:14 -0400","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2017 00:34:13 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby fmsmga001.fm.intel.com with ESMTP; 19 Sep 2017 00:34:12 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1duD7e-000Ri7-NI; Tue, 19 Sep 2017 15:39:10 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,417,1500966000\"; \n\td=\"gz'50?scan'50,208,50\";a=\"1196622862\"","Date":"Tue, 19 Sep 2017 15:44:47 +0800","From":"kbuild test robot ","To":"Tom Herbert ","Cc":"kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org,\n\tpablo@netfilter.org, laforge@gnumonks.org, rohit@quantonium.net,\n\tTom Herbert ","Subject":"Re: [PATCH net-next 04/14] gtp: udp recv clean up","Message-ID":"<201709191523.enXn3mfA%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"PEIAKu/WMn1b1Hv9\"","Content-Disposition":"inline","In-Reply-To":"<20170919003904.5124-5-tom@quantonium.net>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770928,"web_url":"http://patchwork.ozlabs.org/comment/1770928/","msgid":"<20170919113223.ve3qvfgr7pmduif7@nataraja>","list_archive_url":null,"date":"2017-09-19T11:32:23","subject":"Re: [PATCH net-next 04/14] gtp: udp recv clean up","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Tom,\n\nI think this patch does too many things at once:\n* introduce separate rx functions\n* convert from netif_rx to gro_cells_receive\n* cosmetic changes like \"return -1\" to \"goto drop\"\n\nIn the context of reviewability and the \"one patch per topic\", I would\nprefer to see those separated, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMGV3sYMz9s4q\n\tfor ;\n\tTue, 19 Sep 2017 22:13:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751778AbdISMNQ (ORCPT );\n\tTue, 19 Sep 2017 08:13:16 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45344 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751543AbdISMNN (ORCPT\n\t); Tue, 19 Sep 2017 08:13:13 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1duHOn-0001In-Pa; Tue, 19 Sep 2017 14:13:09 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duGlM-0005cF-0s; Tue, 19 Sep 2017 19:32:24 +0800"],"Date":"Tue, 19 Sep 2017 19:32:23 +0800","From":"Harald Welte ","To":"Tom Herbert ","Cc":"davem@davemloft.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 04/14] gtp: udp recv clean up","Message-ID":"<20170919113223.ve3qvfgr7pmduif7@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-5-tom@quantonium.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919003904.5124-5-tom@quantonium.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]