[{"id":1770637,"web_url":"http://patchwork.ozlabs.org/comment/1770637/","msgid":"<20170918.211751.1871429944584121281.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T04:17:51","subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get\n\ttunnel routes and add dst_cache","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tom Herbert \nDate: Mon, 18 Sep 2017 17:38:53 -0700\n\n> Call ip_tunnel_get_route and dst_cache to pdp context which should\n> improve performance by obviating the need to perform a route lookup\n> on every packet.\n> \n> Signed-off-by: Tom Herbert \n\nNot caused by your changes, but something to think about:\n\n> -static struct rtable *ip4_route_output_gtp(struct flowi4 *fl4,\n> -\t\t\t\t\t const struct sock *sk,\n> -\t\t\t\t\t __be32 daddr)\n> -{\n> -\tmemset(fl4, 0, sizeof(*fl4));\n> -\tfl4->flowi4_oif\t\t= sk->sk_bound_dev_if;\n> -\tfl4->daddr\t\t= daddr;\n> -\tfl4->saddr\t\t= inet_sk(sk)->inet_saddr;\n> -\tfl4->flowi4_tos\t\t= RT_CONN_FLAGS(sk);\n> -\tfl4->flowi4_proto\t= sk->sk_protocol;\n> -\n> -\treturn ip_route_output_key(sock_net(sk), fl4);\n> -}\n\nThis and the new dst caching code ignores any source address selection\ndone by ip_route_output_key() or the new tunnel route lookup helpers.\n\nEither source address selection should be respected, or if saddr will\nnever be modified by a route lookup for some specific reason here,\nthat should be documented.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx8jv5kzXz9ryr\n\tfor ;\n\tTue, 19 Sep 2017 14:17:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750910AbdISERx (ORCPT );\n\tTue, 19 Sep 2017 00:17:53 -0400","from shards.monkeyblade.net ([184.105.139.130]:38576 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750713AbdISERx (ORCPT\n\t); Tue, 19 Sep 2017 00:17:53 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 4AED8102ABA29;\n\tMon, 18 Sep 2017 21:17:52 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 21:17:51 -0700 (PDT)","Message-Id":"<20170918.211751.1871429944584121281.davem@davemloft.net>","To":"tom@quantonium.net","Cc":"netdev@vger.kernel.org, pablo@netfilter.org, laforge@gnumonks.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get\n\ttunnel routes and add dst_cache","From":"David Miller ","In-Reply-To":"<20170919003904.5124-4-tom@quantonium.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-4-tom@quantonium.net>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 21:17:52 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770927,"web_url":"http://patchwork.ozlabs.org/comment/1770927/","msgid":"<20170919120942.dpy5kmkhzws7pqd5@nataraja>","list_archive_url":null,"date":"2017-09-19T12:09:42","subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Dave,\n\nOn Mon, Sep 18, 2017 at 09:17:51PM -0700, David Miller wrote:\n> This and the new dst caching code ignores any source address selection\n> done by ip_route_output_key() or the new tunnel route lookup helpers.\n> \n> Either source address selection should be respected, or if saddr will\n> never be modified by a route lookup for some specific reason here,\n> that should be documented.\n\nThe IP source address is fixed by signaling on the GTP-C control plane\nand nothing that the kernel can unilaterally decide to change. Such a\nchange of address would have to be decided by and first be signaled on\nGTP-C to the peer by the userspace daemon, which would then update the\nPDP context in the kernel.\n\nSo I guess you're asking us to document that rationale as form of a\nsource code comment ?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMGQ47KXz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 22:13:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751803AbdISMNR (ORCPT );\n\tTue, 19 Sep 2017 08:13:17 -0400","from ganesha.gnumonks.org ([213.95.27.120]:45320 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751578AbdISMNN (ORCPT\n\t); Tue, 19 Sep 2017 08:13:13 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1duHOo-0001Iv-9m; Tue, 19 Sep 2017 14:13:10 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1duHLS-0007rj-AC; Tue, 19 Sep 2017 20:09:42 +0800"],"Date":"Tue, 19 Sep 2017 20:09:42 +0800","From":"Harald Welte ","To":"David Miller ","Cc":"tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","Message-ID":"<20170919120942.dpy5kmkhzws7pqd5@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-4-tom@quantonium.net>\n\t<20170918.211751.1871429944584121281.davem@davemloft.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918.211751.1871429944584121281.davem@davemloft.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771179,"web_url":"http://patchwork.ozlabs.org/comment/1771179/","msgid":"","list_archive_url":null,"date":"2017-09-19T16:05:18","subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","submitter":{"id":65986,"url":"http://patchwork.ozlabs.org/api/people/65986/","name":"Tom Herbert","email":"tom@herbertland.com"},"content":"On Mon, Sep 18, 2017 at 9:17 PM, David Miller wrote:\n> From: Tom Herbert \n> Date: Mon, 18 Sep 2017 17:38:53 -0700\n>\n>> Call ip_tunnel_get_route and dst_cache to pdp context which should\n>> improve performance by obviating the need to perform a route lookup\n>> on every packet.\n>>\n>> Signed-off-by: Tom Herbert \n>\n> Not caused by your changes, but something to think about:\n>\n>> -static struct rtable *ip4_route_output_gtp(struct flowi4 *fl4,\n>> - const struct sock *sk,\n>> - __be32 daddr)\n>> -{\n>> - memset(fl4, 0, sizeof(*fl4));\n>> - fl4->flowi4_oif = sk->sk_bound_dev_if;\n>> - fl4->daddr = daddr;\n>> - fl4->saddr = inet_sk(sk)->inet_saddr;\n>> - fl4->flowi4_tos = RT_CONN_FLAGS(sk);\n>> - fl4->flowi4_proto = sk->sk_protocol;\n>> -\n>> - return ip_route_output_key(sock_net(sk), fl4);\n>> -}\n>\n> This and the new dst caching code ignores any source address selection\n> done by ip_route_output_key() or the new tunnel route lookup helpers.\n>\n> Either source address selection should be respected, or if saddr will\n> never be modified by a route lookup for some specific reason here,\n> that should be documented.\n\nYes, I noticed that. In this case the source address is intended to be\ntaken bound on the socket which would imply we aren't interested in\nsource address selection.\n\nTom","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=herbertland-com.20150623.gappssmtp.com\n\theader.i=@herbertland-com.20150623.gappssmtp.com\n\theader.b=\"lp3P1l8Y\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxSQC2z1Zz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 02:05:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751457AbdISQFU (ORCPT );\n\tTue, 19 Sep 2017 12:05:20 -0400","from mail-qt0-f196.google.com ([209.85.216.196]:33181 \"EHLO\n\tmail-qt0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750733AbdISQFT (ORCPT\n\t); Tue, 19 Sep 2017 12:05:19 -0400","by mail-qt0-f196.google.com with SMTP id b1so59454qtc.0\n\tfor ; Tue, 19 Sep 2017 09:05:19 -0700 (PDT)","by 10.237.61.196 with HTTP; Tue, 19 Sep 2017 09:05:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=herbertland-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ccYFnAwNa9ruHx5ryM0du07nH/YYuvJyzTkunmkXBh8=;\n\tb=lp3P1l8YiDeNehwctpoVGkEoBZArosgitA7+nGX2aJX5Dmu6CIuPfs3tol1hSJPc5j\n\tuXf+/iLpM3DCVQS16S8z2A9lSG6LpVNi3DM6oc3jZ+rlnVcMbhLr0MXTUEHassI3Bnj6\n\tsvRQPn3UBez4+O2zVL2silyMHg0FlV/4VANoGMx3dj5QqT5tvDd29k1/NE7rO8AlGgrb\n\tb3cpC1mi78AyIxqJfc36U7eRbYUN3I2qBMUKQv8weLRJio0M+zEIfsRVAAk5JfsGs7ge\n\tMhooXx9/aUgZfCGwGdyZA9LoS8dUb528OchMkxwiEPPWyMwwVQ4dZA4UMDQukTQILIV5\n\tCyug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ccYFnAwNa9ruHx5ryM0du07nH/YYuvJyzTkunmkXBh8=;\n\tb=YOIGq9Avt9jA+Dxa49ZOdMu3ncRz7aFF9coyxf/wjTYIvU5Mua+p0/As+dE0wLi3Wq\n\tPCCk4M6DXQcFjGsdVe3AVJdvZDbEVbcxXpQTXJmvC1Hr2cLE/83w2X0Ug4JifCZe5Tdd\n\thaBMExU6acD7m0QPdx+ElvPJDf4uGrsA6gTHJM6d5GaXwUBPPYqrX8Zkna4zJVgMRoBh\n\tGGFKui06ZBhIa4IwSfJ5n9JimIJf0vKwJ9EJnS7vgMJhW2vapg0+DsF5OOFjDVdZWjs0\n\tLWNzO6p1dBmgfDIXO4hUpJG40OONBdJJ1YvqVP643bvAt2rPaUokucnlYm4Dm1KGLK79\n\tQMpQ==","X-Gm-Message-State":"AHPjjUiWPsmVf4TYvwFY4/Z6jOwCQeLUmznLsrzBXL3krUgSdNVTLwSP\n\tYj/jst8p8USM2qgwWwMoS7NfdAJQVy8GizuBdoTXrg==","X-Google-Smtp-Source":"AOwi7QDBQ022a4Nysv5VEVOUy3TMLf1+DUL2MHdfs7cye4zDcwBF/IN1a05maookL1svP51OjbIPFDBkUTx9Nk12tsE=","X-Received":"by 10.237.58.7 with SMTP id n7mr2912703qte.205.1505837118790;\n\tTue, 19 Sep 2017 09:05:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918.211751.1871429944584121281.davem@davemloft.net>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-4-tom@quantonium.net>\n\t<20170918.211751.1871429944584121281.davem@davemloft.net>","From":"Tom Herbert ","Date":"Tue, 19 Sep 2017 09:05:18 -0700","Message-ID":"","Subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","To":"David Miller ","Cc":"Tom Herbert ,\n\tLinux Kernel Network Developers ,\n\tPablo Neira Ayuso ,\n\tHarald Welte , Rohit Seth ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771236,"web_url":"http://patchwork.ozlabs.org/comment/1771236/","msgid":"<20170919.104446.1562100139136479510.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T17:44:46","subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get\n\ttunnel routes and add dst_cache","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Harald Welte \nDate: Tue, 19 Sep 2017 20:09:42 +0800\n\n> So I guess you're asking us to document that rationale as form of a\n> source code comment ?\n\nYes that would make ignoring the potential changing of the non-const\n'saddr' argument at least be documented.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVcy6SrFz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:44:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751394AbdISRot (ORCPT );\n\tTue, 19 Sep 2017 13:44:49 -0400","from shards.monkeyblade.net ([184.105.139.130]:37378 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750973AbdISRos (ORCPT\n\t); Tue, 19 Sep 2017 13:44:48 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 62AF1102C138E;\n\tTue, 19 Sep 2017 10:44:47 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 10:44:46 -0700 (PDT)","Message-Id":"<20170919.104446.1562100139136479510.davem@davemloft.net>","To":"laforge@gnumonks.org","Cc":"tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","Subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get\n\ttunnel routes and add dst_cache","From":"David Miller ","In-Reply-To":"<20170919120942.dpy5kmkhzws7pqd5@nataraja>","References":"<20170919003904.5124-4-tom@quantonium.net>\n\t<20170918.211751.1871429944584121281.davem@davemloft.net>\n\t<20170919120942.dpy5kmkhzws7pqd5@nataraja>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 10:44:47 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771993,"web_url":"http://patchwork.ozlabs.org/comment/1771993/","msgid":"<01c68c74-455c-9bff-e5bb-b1708d8f92f4@tpip.net>","list_archive_url":null,"date":"2017-09-20T15:37:52","subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","submitter":{"id":66668,"url":"http://patchwork.ozlabs.org/api/people/66668/","name":"Andreas Schultz","email":"aschultz@tpip.net"},"content":"On 19/09/17 14:09, Harald Welte wrote:\n> Hi Dave,\n> \n> On Mon, Sep 18, 2017 at 09:17:51PM -0700, David Miller wrote:\n>> This and the new dst caching code ignores any source address selection\n>> done by ip_route_output_key() or the new tunnel route lookup helpers.\n>>\n>> Either source address selection should be respected, or if saddr will\n>> never be modified by a route lookup for some specific reason here,\n>> that should be documented.\n> \n> The IP source address is fixed by signaling on the GTP-C control plane\n> and nothing that the kernel can unilaterally decide to change. Such a\n> change of address would have to be decided by and first be signaled on\n> GTP-C to the peer by the userspace daemon, which would then update the\n> PDP context in the kernel.\n\nI think we had this discussion before. The sending IP and port are not \npart of the identity of the PDP context. So IMHO the sender is permitted\nto change the source IP at random.\n\nRegards\nAndreas\n\n> \n> So I guess you're asking us to document that rationale as form of a\n> source code comment ?\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy3m654cgz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 01:37:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751635AbdITPh4 (ORCPT );\n\tWed, 20 Sep 2017 11:37:56 -0400","from mail.tpip.net ([92.43.49.48]:38721 \"EHLO mail.tpip.net\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751507AbdITPhz (ORCPT );\n\tWed, 20 Sep 2017 11:37:55 -0400","from office.tpip.net (unknown [153.92.65.89])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.tpip.net (Postfix) with ESMTPS id 0D7784F406;\n\tWed, 20 Sep 2017 15:37:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby office.tpip.net (Postfix) with ESMTP id D1D44A318D;\n\tWed, 20 Sep 2017 17:37:53 +0200 (CEST)","from office.tpip.net ([127.0.0.1])\n\tby localhost (office.tpip.net [127.0.0.1]) (amavisd-new, port 10032)\n\twith ESMTP id WQcrwto1CiUA; Wed, 20 Sep 2017 17:37:53 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby office.tpip.net (Postfix) with ESMTP id 7013BA318E;\n\tWed, 20 Sep 2017 17:37:53 +0200 (CEST)","from office.tpip.net ([127.0.0.1])\n\tby localhost (office.tpip.net [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id jrRbn3Yg1U5m; Wed, 20 Sep 2017 17:37:53 +0200 (CEST)","from [192.168.13.82] (pd95c9392.dip0.t-ipconnect.de\n\t[217.92.147.146])\n\tby office.tpip.net (Postfix) with ESMTPSA id 18A1FA318D;\n\tWed, 20 Sep 2017 17:37:53 +0200 (CEST)"],"X-Virus-Scanned":"amavisd-new at tpip.net","Subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","To":"Harald Welte , David Miller ","Cc":"tom@quantonium.net, netdev@vger.kernel.org, pablo@netfilter.org,\n\trohit@quantonium.net","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-4-tom@quantonium.net>\n\t<20170918.211751.1871429944584121281.davem@davemloft.net>\n\t<20170919120942.dpy5kmkhzws7pqd5@nataraja>","From":"Andreas Schultz ","Message-ID":"<01c68c74-455c-9bff-e5bb-b1708d8f92f4@tpip.net>","Date":"Wed, 20 Sep 2017 17:37:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919120942.dpy5kmkhzws7pqd5@nataraja>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1774097,"web_url":"http://patchwork.ozlabs.org/comment/1774097/","msgid":"<20170924013325.7ywkdfdlzeflsbl2@nataraja>","list_archive_url":null,"date":"2017-09-24T01:33:25","subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","submitter":{"id":931,"url":"http://patchwork.ozlabs.org/api/people/931/","name":"Harald Welte","email":"laforge@gnumonks.org"},"content":"Hi Andreas,\n\nOn Wed, Sep 20, 2017 at 05:37:52PM +0200, Andreas Schultz wrote:\n> I think we had this discussion before. The sending IP and port are not part\n> of the identity of the PDP context. So IMHO the sender is permitted\n> to change the source IP at random.\n\nThanks for the reminder: You are correct, at least in the uplink case\n(MS->GGSN) where there is mobility of the MS. In the downlink case\n(GGSN->MS), which is the \"sending\" part for the kernel GTP code used at\na GGSN, I'm not sure if that theory holds true in reality.\n\nDo you agree that the current behavior of not using automatic source\naddress selection for encapsulated GTP packets but rather using the\nsource address of the socket is intended?\n\nDo you further agree that the dst_cache support patch by Tom retains\nthat intended behavior and it should be merged?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y08zr3kYQz9t43\n\tfor ;\n\tSun, 24 Sep 2017 11:40:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751462AbdIXBkP (ORCPT );\n\tSat, 23 Sep 2017 21:40:15 -0400","from ganesha.gnumonks.org ([213.95.27.120]:60251 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750839AbdIXBkO (ORCPT\n\t); Sat, 23 Sep 2017 21:40:14 -0400","from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dvvtw-0007Cv-Lu; Sun, 24 Sep 2017 03:40:08 +0200","from laforge by localhost.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dvvnR-0000Rn-8z; Sun, 24 Sep 2017 09:33:25 +0800"],"Date":"Sun, 24 Sep 2017 09:33:25 +0800","From":"Harald Welte ","To":"Andreas Schultz ","Cc":"David Miller , tom@quantonium.net,\n\tnetdev@vger.kernel.org, pablo@netfilter.org, rohit@quantonium.net","Subject":"Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel\n\troutes and add dst_cache","Message-ID":"<20170924013325.7ywkdfdlzeflsbl2@nataraja>","References":"<20170919003904.5124-1-tom@quantonium.net>\n\t<20170919003904.5124-4-tom@quantonium.net>\n\t<20170918.211751.1871429944584121281.davem@davemloft.net>\n\t<20170919120942.dpy5kmkhzws7pqd5@nataraja>\n\t<01c68c74-455c-9bff-e5bb-b1708d8f92f4@tpip.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<01c68c74-455c-9bff-e5bb-b1708d8f92f4@tpip.net>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]