[{"id":1770556,"web_url":"http://patchwork.ozlabs.org/comment/1770556/","msgid":"<87mv5r1vzx.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-18T22:29:22","subject":"Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Hi Florian,\n\nFlorian Fainelli writes:\n\n> @@ -1000,6 +1005,9 @@ static void b53_adjust_link(struct dsa_switch *ds, int port,\n> \t\t\tb53_write8(dev, B53_CTRL_PAGE, po_reg, gmii_po);\n> \t\t}\n> \t}\n> +\n> +\t/* Re-negotiate EEE if it was enabled already */\n> +\tp->eee_enabled = b53_eee_init(ds, port, phydev);\n> }\n\nSame here, I think we can move this up to DSA core, maybe with a\neee_enabled mask in dsa_switch or a bool in dsa_port.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx13s0HKMz9s4s\n\tfor ;\n\tTue, 19 Sep 2017 08:32:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751034AbdIRWcy (ORCPT );\n\tMon, 18 Sep 2017 18:32:54 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:36188 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1750783AbdIRWcx (ORCPT\n\t); Mon, 18 Sep 2017 18:32:53 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id F149F9C1A61;\n\tMon, 18 Sep 2017 18:32:52 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id IoBfESLNlcyt; Mon, 18 Sep 2017 18:32:52 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id A931C9C242D;\n\tMon, 18 Sep 2017 18:32:52 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id wDG6nCXcQxwj; Mon, 18 Sep 2017 18:32:52 -0400 (EDT)","from localhost (unknown [192.168.49.104])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id 807C79C1A61;\n\tMon, 18 Sep 2017 18:32:52 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"Florian Fainelli , netdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch,\n\tFlorian Fainelli ","Subject":"Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE","In-Reply-To":"<20170918214128.27896-10-f.fainelli@gmail.com>","References":"<20170918214128.27896-1-f.fainelli@gmail.com>\n\t<20170918214128.27896-10-f.fainelli@gmail.com>","Date":"Mon, 18 Sep 2017 18:29:22 -0400","Message-ID":"<87mv5r1vzx.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770558,"web_url":"http://patchwork.ozlabs.org/comment/1770558/","msgid":"<77a80a64-7840-861d-a3ec-5e2efbfe0d8c@gmail.com>","list_archive_url":null,"date":"2017-09-18T22:34:16","subject":"Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/18/2017 03:29 PM, Vivien Didelot wrote:\n> Hi Florian,\n> \n> Florian Fainelli writes:\n> \n>> @@ -1000,6 +1005,9 @@ static void b53_adjust_link(struct dsa_switch *ds, int port,\n>> \t\t\tb53_write8(dev, B53_CTRL_PAGE, po_reg, gmii_po);\n>> \t\t}\n>> \t}\n>> +\n>> +\t/* Re-negotiate EEE if it was enabled already */\n>> +\tp->eee_enabled = b53_eee_init(ds, port, phydev);\n>> }\n> \n> Same here, I think we can move this up to DSA core, maybe with a\n> eee_enabled mask in dsa_switch or a bool in dsa_port.\n\nThis can be done as a subsequent patch, sure.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lsRvVjkW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx15X1W63z9s4s\n\tfor ;\n\tTue, 19 Sep 2017 08:34:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750982AbdIRWeW (ORCPT );\n\tMon, 18 Sep 2017 18:34:22 -0400","from mail-wr0-f196.google.com ([209.85.128.196]:35280 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750783AbdIRWeV (ORCPT\n\t); Mon, 18 Sep 2017 18:34:21 -0400","by mail-wr0-f196.google.com with SMTP id n64so1193338wrb.2\n\tfor ; Mon, 18 Sep 2017 15:34:20 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tr21sm285504wmd.26.2017.09.18.15.34.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 15:34:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=HX1fSxGcusRpyYFF9WoJNUYzwyaPlaPegDGp2GRLgTk=;\n\tb=lsRvVjkWGXJW0H02LTqIR/DeHg9FlRajNI8Y7h7jfAYMFSjTUM9jr1CBY64dJwBzYv\n\tw0evVJVvZj5AbjRrINVr2xVocojjbQl+L+KQj1+qSmgshEYxyvxVpEjj86znHDes6ajz\n\tKRQoDi1r5R34irgJSX7rW+MkXbXNALMzPFojjMa8MsuRnHXhTFtzTVnHdM9xxtq1wJ7n\n\tvRifupS8QXFWrfXjzP9jonJmOck8q9Ib7sFGajBRuVh0a8x2llaS2BMWuMTpfbeYaXxj\n\tK5zKGtN65cW+S5ndeJl8xz4a52vynXzsKXJc6vBIbzf8by0A139cqrPdjgG6jj1rTJil\n\tAJHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HX1fSxGcusRpyYFF9WoJNUYzwyaPlaPegDGp2GRLgTk=;\n\tb=tCNAbsy6oZq3naHbelODI50WfvC1wIusH9Ttu2Tf5OJQxR0gcHBhPzFs9iElzn/mCS\n\tSomliQ8iPqQv25NH3CMxbzcK86RlcL33djEJPhjWTUsoAfQ1LIPK6XFoscZbIShF/7WN\n\tSm9Ri7p4nfiAbgmejcLYllTsiqe4k7YhVg0R2wmnVT3/aspGieSf1WMlyRSI8ZsJV6Co\n\tkKhLaKYjpAu5vPBZ1Z6Z13BCmUJvWuouXHFDpEnhprKAOA91BVx1+LWip7oReqSqsQqL\n\tyfpZKYLbr8mgWUbsi2RnpfegVUw5YxL1Wx5Pc30e092TPig7WuzBaV1otOj4R1E+cAYP\n\tRRSw==","X-Gm-Message-State":"AHPjjUhUtzUg0iEVkKQRsxZJ85A6uQTIyuEZ+t1sxo9lsXgKctCEV3qL\n\t3aFFzbfGnGpqmMLa2l0=","X-Google-Smtp-Source":"ADKCNb7C3okroYY7RK+FG9lSObEHPiE4ay7guScj0A/OSDjf8Z43xjvKIhO0a6DK62LRhPg7V28zGg==","X-Received":"by 10.223.187.16 with SMTP id r16mr27515835wrg.88.1505774060151; \n\tMon, 18 Sep 2017 15:34:20 -0700 (PDT)","Subject":"Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch","References":"<20170918214128.27896-1-f.fainelli@gmail.com>\n\t<20170918214128.27896-10-f.fainelli@gmail.com>\n\t<87mv5r1vzx.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","From":"Florian Fainelli ","Message-ID":"<77a80a64-7840-861d-a3ec-5e2efbfe0d8c@gmail.com>","Date":"Mon, 18 Sep 2017 15:34:16 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<87mv5r1vzx.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]