[{"id":1770554,"web_url":"http://patchwork.ozlabs.org/comment/1770554/","msgid":"<87poan1w2q.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-18T22:27:41","subject":"Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Hi Florian,\n\nFlorian Fainelli writes:\n\n> @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch *ds, int port,\n> \tcore_writel(priv, reg, offset);\n> \n> \tif (!phydev->is_pseudo_fixed_link)\n> -\t\tp->eee_enabled = bcm_sf2_eee_init(ds, port, phydev);\n> +\t\tp->eee_enabled = b53_eee_init(ds, port, phydev);\n> }\n\nI know this is a bit out-of-scope of this patch, but I have to say I am\nnot confortable with having still phy device stuffs in switch drivers...\n\nCan this is_pseudo_fixed_link check + phy_eee_init + eee_enable be moved\nup to dsa_slave_adjust_link in a future patch maybe?\n\nThanks,\n\n Vivien","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx11w0Kqkz9s4s\n\tfor ;\n\tTue, 19 Sep 2017 08:31:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750828AbdIRWbO (ORCPT );\n\tMon, 18 Sep 2017 18:31:14 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:36080 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1750747AbdIRWbN (ORCPT\n\t); Mon, 18 Sep 2017 18:31:13 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 7D24E9C1A61;\n\tMon, 18 Sep 2017 18:31:12 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id WzWVCQBhx-pv; Mon, 18 Sep 2017 18:31:12 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 3354C9C2C5F;\n\tMon, 18 Sep 2017 18:31:12 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id evkvGEBsdLPB; Mon, 18 Sep 2017 18:31:12 -0400 (EDT)","from localhost (unknown [192.168.49.104])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id 0E8BB9C1A61;\n\tMon, 18 Sep 2017 18:31:12 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"Florian Fainelli , netdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch,\n\tFlorian Fainelli ","Subject":"Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53","In-Reply-To":"<20170918214128.27896-9-f.fainelli@gmail.com>","References":"<20170918214128.27896-1-f.fainelli@gmail.com>\n\t<20170918214128.27896-9-f.fainelli@gmail.com>","Date":"Mon, 18 Sep 2017 18:27:41 -0400","Message-ID":"<87poan1w2q.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770557,"web_url":"http://patchwork.ozlabs.org/comment/1770557/","msgid":"","list_archive_url":null,"date":"2017-09-18T22:33:52","subject":"Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/18/2017 03:27 PM, Vivien Didelot wrote:\n> Hi Florian,\n> \n> Florian Fainelli writes:\n> \n>> @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch *ds, int port,\n>> \tcore_writel(priv, reg, offset);\n>> \n>> \tif (!phydev->is_pseudo_fixed_link)\n>> -\t\tp->eee_enabled = bcm_sf2_eee_init(ds, port, phydev);\n>> +\t\tp->eee_enabled = b53_eee_init(ds, port, phydev);\n>> }\n> \n> I know this is a bit out-of-scope of this patch, but I have to say I am\n> not confortable with having still phy device stuffs in switch drivers...\n\nYes, this is out of scope :)\n\n> \n> Can this is_pseudo_fixed_link check + phy_eee_init + eee_enable be moved\n> up to dsa_slave_adjust_link in a future patch maybe?\n\nNot 100% positive this applies to all switches, which is why this is\nstill largely a switch driver decision.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TRVYKVh8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx15465hdz9s4s\n\tfor ;\n\tTue, 19 Sep 2017 08:34:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750886AbdIRWd6 (ORCPT );\n\tMon, 18 Sep 2017 18:33:58 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:35066 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750714AbdIRWd5 (ORCPT\n\t); Mon, 18 Sep 2017 18:33:57 -0400","by mail-wm0-f68.google.com with SMTP id e64so2223687wmi.2\n\tfor ; Mon, 18 Sep 2017 15:33:57 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tw73sm105555wmw.31.2017.09.18.15.33.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 15:33:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=8Ln7fosqMshoGEY4UHxirGoK2iVkT1Y1XcuvOV4iGWw=;\n\tb=TRVYKVh8aj5TgTzd41kmURYhnjZPYaHufpCpjROMb/i6zmuCUTEQBrHtsBK/KOBzCd\n\tvyze4al7IfoQi8Rzoy5pC0BWkrC9bZV08e5HJ1abEB97kiaXwrX3jDpdWQwKnlOU/d2t\n\tu+DMMWMr4H3vpIPXuC4ZdRj537h/oNmP9UPpmjmqriDH5TuLnW2Ajec2pxp2ESK6E9tx\n\tp2KjMa5zeQKfV+X9uwm99j0Tm6qNuPDlH5B4kBI0olGMiUBn5C8EVT3FQHoTEXA1WcUR\n\tgeztl7gUXRLvo01uqVFc7QpCFbnbt4Q4l9BPVPHhZCR2K7or+8eqVPIxA1CdB7kQIgwj\n\tlxdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=8Ln7fosqMshoGEY4UHxirGoK2iVkT1Y1XcuvOV4iGWw=;\n\tb=L+a6c1jOruUm189x015MF23IJVNhNWcBEZgpMA/0XvT3/VopFvygB0Wcj3B2LzmCPQ\n\t9/fU2ZcfRKfFd2aG25+jgzRZ16XFRqGNJ0Al7fc19FuwNCLGEUZQER+v7dlH2Eq5p84x\n\tqL+aHd5TIGZB7I9vL8uo6LNvhDo2ajstMQ4ktsTaydxuYrb48eeqlRPmZjufeClOth+B\n\tXyPhVMudt70Z8BsKMkHHo0W3OPUQHLFN/5US9egilfyTWp1dKt8wEroORKQWQLk8AxA3\n\tgE0Ts1zMrgwL1mtBN4CvTjtEYHE+2vxhTKcgS075cxDz5k5b6Yt4/YN4LTlhBeXxLciY\n\tHvZQ==","X-Gm-Message-State":"AHPjjUiGu0WQWf1fbv2s/gwgCwaul7dla6mjw/L7xv79vMM4B5MLE9Zv\n\tzjvgBHhM0ZjBQOpSpTdVvBWJqzBB","X-Google-Smtp-Source":"AOwi7QCQSrZOMAQKQwa7dken5BkLige2Rz9ww/P9wRW9jdZIaV8wIBAz1WaZP4nMhAmuHyziUQu2Pg==","X-Received":"by 10.28.113.28 with SMTP id m28mr1994627wmc.141.1505774036368; \n\tMon, 18 Sep 2017 15:33:56 -0700 (PDT)","Subject":"Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"davem@davemloft.net, andrew@lunn.ch","References":"<20170918214128.27896-1-f.fainelli@gmail.com>\n\t<20170918214128.27896-9-f.fainelli@gmail.com>\n\t<87poan1w2q.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","From":"Florian Fainelli ","Message-ID":"","Date":"Mon, 18 Sep 2017 15:33:52 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<87poan1w2q.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]